[{"id":26342,"web_url":"https://patchwork.libcamera.org/comment/26342/","msgid":"<20230124172817.7ojq4darhhk5kkst@uno.localdomain>","date":"2023-01-24T17:28:17","subject":"Re: [libcamera-devel] [PATCH v2 3/4] ipa: rkisp1: Add OV4689 tuning\n\tfile","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Mikhail\n\nOn Mon, Jan 23, 2023 at 05:06:18PM +0300, Mikhail Rudenko wrote:\n> Add a minimal tuning file for Omnivision OV4689, specifying black\n> level subtraction level.\n>\n> Signed-off-by: Mikhail Rudenko \n> ---\n> src/ipa/rkisp1/data/meson.build | 1 +\n> src/ipa/rkisp1/data/ov4689.yaml | 13 +++++++++++++\n> 2 files changed, 14 insertions(+)\n> create mode 100644 src/ipa/rkisp1/data/ov4689.yaml\n>\n> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> index c3b4e388..f5e9fa75 100644\n> --- a/src/ipa/rkisp1/data/meson.build\n> +++ b/src/ipa/rkisp1/data/meson.build\n> @@ -2,6 +2,7 @@\n>\n> conf_files = files([\n> 'imx219.yaml',\n> + 'ov4689.yaml',\n> 'ov5640.yaml',\n> 'uncalibrated.yaml',\n> ])\n> diff --git a/src/ipa/rkisp1/data/ov4689.yaml b/src/ipa/rkisp1/data/ov4689.yaml\n> new file mode 100644\n> index 00000000..2068684c\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/data/ov4689.yaml\n> @@ -0,0 +1,13 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +%YAML 1.1\n> +---\n> +version: 1\n> +algorithms:\n> + - Agc:\n> + - Awb:\n> + - BlackLevelCorrection:\n> + R: 66\n> + Gr: 66\n> + Gb: 66\n> + B: 66\n\nOh great, you've measured them!\nThanks!\n\nReviewed-by: Jacopo Mondi \n\n> +...\n> --\n> 2.39.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55D6BBEFBE\n\tfor ;\n\tTue, 24 Jan 2023 17:28:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AAD84625E4;\n\tTue, 24 Jan 2023 18:28:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B68F603D8\n\tfor ;\n\tTue, 24 Jan 2023 18:28:21 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B324A8A9;\n\tTue, 24 Jan 2023 18:28:20 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674581302;\n\tbh=PuWrRVAU38z0yYTHggqDK/31YkhiNKZPxhhsBKqSWnc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=fm65AProQLUMFIgkd2DsVpZTp8WYx0umvtB9D0QfdACdWDUDDja56ereFaS1W9kru\n\tElwRQ/ogoayo6Z7yb0aotrQ7nPCCP6/8UlBhI5ahp+pAb3qRPc6r0BZfKxeGBftUAf\n\tZAbq4G4ZwqYTaBfFKspOWNPwC3gFx824TviT8dxfyYpkFRDJm5vOyiuItAxoFZezmj\n\towh0acw5oKhrRX357Xerd2eyN/DWlqxZk0jQDngo1wHoM+ccbpFMPtdhvbE5lZsYwm\n\t4ykxo6JrA4d1nAAodqOT+n+9G8QpbwBF+1RdzkzDeMN1iI50dksUtAFANyty4kXOqr\n\tt2P1SJ22ANk4g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674581300;\n\tbh=PuWrRVAU38z0yYTHggqDK/31YkhiNKZPxhhsBKqSWnc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=txiLstLfyf+ehXt4BLU1/5csZ69ANgkDMq8gaMF/BN5Ba6faPvu7OPVbOXQdFUj5A\n\tQYPMgAlRfi1r2qFnBwlsQdL0VI2huDcQfS/s0lJPheBxhWDK4qEEVdL6T91ZR+vSD1\n\tdTGymwhMCnjO+ZJL2inmKUpGMJalxrEuIG6MXwmU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"txiLstLf\"; dkim-atps=neutral","Date":"Tue, 24 Jan 2023 18:28:17 +0100","To":"Mikhail Rudenko ","Message-ID":"<20230124172817.7ojq4darhhk5kkst@uno.localdomain>","References":"<20230123140619.177878-1-mike.rudenko@gmail.com>\n\t<20230123140619.177878-4-mike.rudenko@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230123140619.177878-4-mike.rudenko@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] ipa: rkisp1: Add OV4689 tuning\n\tfile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]