[{"id":26341,"web_url":"https://patchwork.libcamera.org/comment/26341/","msgid":"<20230124172553.mo7se3snwzkdrodm@uno.localdomain>","date":"2023-01-24T17:25:53","subject":"Re: [libcamera-devel] [PATCH v2 2/4] libcamera: camera_sensor: Add\n\tOV4689 sensor properties","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Mikhail\n\nOn Mon, Jan 23, 2023 at 05:06:17PM +0300, Mikhail Rudenko wrote:\n> Add an entry to the sensor properties for Omnivision OV4689.\n>\n> Kernel supports two more types of color bars patterns, which we do not\n> expose now.\n>\n> Signed-off-by: Mikhail Rudenko \n\nThanks\n\nReviewed-by: Jacopo Mondi \n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 13 +++++++++++++\n> 1 file changed, 13 insertions(+)\n>\n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index c3c2cace..a601e1ae 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -130,6 +130,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1},\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"ov4689\", {\n> +\t\t\t.unitCellSize = { 2000, 2000 },\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1},\n> +\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 2},\n> +\t\t\t\t/*\n> +\t\t\t\t * No corresponding test patterns in\n> +\t\t\t\t * MIPI CCS specification for sensor's\n> +\t\t\t\t * colorBarType2 and colorBarType3.\n> +\t\t\t\t */\n> +\t\t\t},\n> +\t\t} },\n> \t\t{ \"ov5640\", {\n> \t\t\t.unitCellSize = { 1400, 1400 },\n> \t\t\t.testPatternModes = {\n> --\n> 2.39.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 912A3BEFBE\n\tfor ;\n\tTue, 24 Jan 2023 17:25:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 19D776045E;\n\tTue, 24 Jan 2023 18:25:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7D8E603D8\n\tfor ;\n\tTue, 24 Jan 2023 18:25:57 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1026C8A9;\n\tTue, 24 Jan 2023 18:25:57 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674581159;\n\tbh=0i/SeDTgM4ww1dYdQ8nY+7YSdpmLvY8Pu2QZolfrlwY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=3z/EKIDSfYDncZ8YG6Kalvo4M/kqjF78u7+//zaxoSoFYL83IhRYR3Tb1noarESsD\n\tCbiUqZOeIRhvu4k1edKN80+AnLwFjRdE8WBQL3OuJjYgEhS3Bu5xqL7zSsPX5mKYZ7\n\txr9lGxPltTXX/mwTPxXMSAQTWVJNMoY43Xer3Nf5St6+rSdvj7st7ZCGDXTZ/YJMzz\n\tMrp2q6ntv90swwNmX/eoin3XxrQvf0nsuddIw6kFUMDE1VeZ90pHtUWz8l+q9tzwO2\n\tjWsWF7YwVxe8EGEEFxF6QB7F887nOgmvDvymFwdu2wsiDjCXRqMkx6DIkwdg94x0IZ\n\tkj2ie990NTTEA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674581157;\n\tbh=0i/SeDTgM4ww1dYdQ8nY+7YSdpmLvY8Pu2QZolfrlwY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mq4wsYbv0OXSKhxjEEOUMz+veg+KomDuQakMcxsEYhG9Nr/cgPfgQQ4118+qxiCwm\n\tOh20SASGwXS4NNrovuwCYBz/IIigpPeQz01n04tCZ6XMzF4gxTP/nMTsTt6H/opYr5\n\tPxAz4piQnj+/23CB+k+l3etx6RTQcsakl1iAIOEU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"mq4wsYbv\"; dkim-atps=neutral","Date":"Tue, 24 Jan 2023 18:25:53 +0100","To":"Mikhail Rudenko ","Message-ID":"<20230124172553.mo7se3snwzkdrodm@uno.localdomain>","References":"<20230123140619.177878-1-mike.rudenko@gmail.com>\n\t<20230123140619.177878-3-mike.rudenko@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230123140619.177878-3-mike.rudenko@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/4] libcamera: camera_sensor: Add\n\tOV4689 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]