[{"id":26265,"web_url":"https://patchwork.libcamera.org/comment/26265/","msgid":"<20230119171259.l6qvgb6utweb5wfn@uno.localdomain>","date":"2023-01-19T17:12:59","subject":"Re: [libcamera-devel] [PATCH 3/4] ipa: rkisp1: Add OV4689 tuning\n\tfile","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Mikhail\n\nOn Thu, Jan 19, 2023 at 06:59:04PM +0300, Mikhail Rudenko via libcamera-devel wrote:\n> Add a minimal tuning file for Omnivision OV4689, specifying black\n> level subtraction level.\n>\n> Signed-off-by: Mikhail Rudenko \n> ---\n> src/ipa/rkisp1/data/meson.build | 1 +\n> src/ipa/rkisp1/data/ov4689.yaml | 13 +++++++++++++\n> 2 files changed, 14 insertions(+)\n> create mode 100644 src/ipa/rkisp1/data/ov4689.yaml\n>\n> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> index c3b4e388..f5e9fa75 100644\n> --- a/src/ipa/rkisp1/data/meson.build\n> +++ b/src/ipa/rkisp1/data/meson.build\n> @@ -2,6 +2,7 @@\n>\n> conf_files = files([\n> 'imx219.yaml',\n> + 'ov4689.yaml',\n> 'ov5640.yaml',\n> 'uncalibrated.yaml',\n> ])\n> diff --git a/src/ipa/rkisp1/data/ov4689.yaml b/src/ipa/rkisp1/data/ov4689.yaml\n> new file mode 100644\n> index 00000000..750b369e\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/data/ov4689.yaml\n> @@ -0,0 +1,13 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +%YAML 1.1\n> +---\n> +version: 1\n> +algorithms:\n> + - Agc:\n> + - Awb:\n> + - BlackLevelCorrection:\n> + R: 64\n> + Gr: 64\n> + Gb: 64\n> + B: 64\n\nAre these values measured ?\n\nIn such case\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> +...\n> --\n> 2.39.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7095DC3240\n\tfor ;\n\tThu, 19 Jan 2023 17:13:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1CA3761EFE;\n\tThu, 19 Jan 2023 18:13:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E600361EFE\n\tfor ;\n\tThu, 19 Jan 2023 18:13:02 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8ABEF501;\n\tThu, 19 Jan 2023 18:13:02 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674148385;\n\tbh=u+599cVrW7OaEZ5kr7i4FWNJzy/KKtL748VvibsXm88=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=xbX5Ij0ucd8apyCrypQo9WyiWjQzVXboydodZc1H1ITA4yhuPZkMiRntBVFH9LvZw\n\tTsA/Q07hjf1O670w9ACFq6u4BK69q014jYZ89gJakLk044WRprUWRwV1VcUS2UK4FD\n\tgEEquY3oHuI3/pdHBaPgon/Y+IL3qOFiO4QNHbEFFm2iRMf7pa8Uoh8QVY+8brgvh1\n\tc4vx8YT6EKIRjpdhsVPhv3phlVIVNW+bdWkSeem4ks3Dj+ja6O0u3bKYUPsSOYpR7H\n\t08UZ3YA8OzgEsh8mllBmClyDK85fTB8uK+7+WNaTnbct+o1cMwgE/++dhC44IfM8Vx\n\t/D4EfJjGfCU3A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674148382;\n\tbh=u+599cVrW7OaEZ5kr7i4FWNJzy/KKtL748VvibsXm88=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Izjlh52KYHN9NilAXrK3s4lAyzg7FQ+xbfJ5NA6GRTi6Dr8UqGa+iJ05ayVEMkwUB\n\tm+aDyVmDna5HF5rqTTQG9ewlUO8njIGXzhQAUwrHiLay+1YYY36246hiDrk1v1yKTG\n\tcJWMdsfY+0/gxGHyFdQ89oW8NCDb94U+q48vxxUI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Izjlh52K\"; dkim-atps=neutral","Date":"Thu, 19 Jan 2023 18:12:59 +0100","To":"Mikhail Rudenko ","Message-ID":"<20230119171259.l6qvgb6utweb5wfn@uno.localdomain>","References":"<20230119155905.464995-1-mike.rudenko@gmail.com>\n\t<20230119155905.464995-4-mike.rudenko@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230119155905.464995-4-mike.rudenko@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH 3/4] ipa: rkisp1: Add OV4689 tuning\n\tfile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26269,"web_url":"https://patchwork.libcamera.org/comment/26269/","msgid":"<87edrqbcnn.fsf@gmail.com>","date":"2023-01-19T17:47:37","subject":"Re: [libcamera-devel] [PATCH 3/4] ipa: rkisp1: Add OV4689 tuning\n\tfile","submitter":{"id":146,"url":"https://patchwork.libcamera.org/api/people/146/","name":"Mikhail Rudenko","email":"mike.rudenko@gmail.com"},"content":"On 2023-01-19 at 18:12 +01, Jacopo Mondi wrote:\n\n> Hi Mikhail\n>\n> On Thu, Jan 19, 2023 at 06:59:04PM +0300, Mikhail Rudenko via libcamera-devel wrote:\n>> Add a minimal tuning file for Omnivision OV4689, specifying black\n>> level subtraction level.\n>>\n>> Signed-off-by: Mikhail Rudenko \n>> ---\n>> src/ipa/rkisp1/data/meson.build | 1 +\n>> src/ipa/rkisp1/data/ov4689.yaml | 13 +++++++++++++\n>> 2 files changed, 14 insertions(+)\n>> create mode 100644 src/ipa/rkisp1/data/ov4689.yaml\n>>\n>> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n>> index c3b4e388..f5e9fa75 100644\n>> --- a/src/ipa/rkisp1/data/meson.build\n>> +++ b/src/ipa/rkisp1/data/meson.build\n>> @@ -2,6 +2,7 @@\n>>\n>> conf_files = files([\n>> 'imx219.yaml',\n>> + 'ov4689.yaml',\n>> 'ov5640.yaml',\n>> 'uncalibrated.yaml',\n>> ])\n>> diff --git a/src/ipa/rkisp1/data/ov4689.yaml b/src/ipa/rkisp1/data/ov4689.yaml\n>> new file mode 100644\n>> index 00000000..750b369e\n>> --- /dev/null\n>> +++ b/src/ipa/rkisp1/data/ov4689.yaml\n>> @@ -0,0 +1,13 @@\n>> +# SPDX-License-Identifier: CC0-1.0\n>> +%YAML 1.1\n>> +---\n>> +version: 1\n>> +algorithms:\n>> + - Agc:\n>> + - Awb:\n>> + - BlackLevelCorrection:\n>> + R: 64\n>> + Gr: 64\n>> + Gb: 64\n>> + B: 64\n>\n> Are these values measured ?\n>\n> In such case\n> Reviewed-by: Jacopo Mondi \n\nThese values were taken from Rockchip's camera engine xml\nconfigs. Should I measure them instead?\n\n> Thanks\n> j\n>\n>> +...\n>> --\n>> 2.39.0\n>>\n\n\n--\nBest regards,\nMikhail Rudenko","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF15EC3240\n\tfor ;\n\tThu, 19 Jan 2023 18:30:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9887C625D8;\n\tThu, 19 Jan 2023 19:30:08 +0100 (CET)","from mail-lf1-x131.google.com (mail-lf1-x131.google.com\n\t[IPv6:2a00:1450:4864:20::131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 06AB761EFE\n\tfor ;\n\tThu, 19 Jan 2023 19:30:07 +0100 (CET)","by mail-lf1-x131.google.com with SMTP id y25so4458605lfa.9\n\tfor ;\n\tThu, 19 Jan 2023 10:30:06 -0800 (PST)","from razdolb (93-80-66-125.broadband.corbina.ru. [93.80.66.125])\n\tby smtp.gmail.com with ESMTPSA id\n\to7-20020ac24e87000000b004cb23904bd9sm5968637lfr.144.2023.01.19.10.30.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 19 Jan 2023 10:30:05 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674153008;\n\tbh=dz5epzSboFGvIdTMKFSFYi7oWR89DTGyWhjVCkSW38c=;\n\th=References:To:Date:In-reply-to:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=CnOLwY3QaMOl2B0dMYaKAR9AeMzOUmntiO+n/RS1T/wb3pLTluEJKT/JAET9CdQk7\n\tePZ5HxvDYwrEAWhxjQAgoHVQKxwK1+ZL9BkX2s2+LwSWmKQiXAdjq1iSY6NGX5kAfk\n\tKTKjp0MUdGnXaVRZRtjlZy9pFm7G6MiFBpK7GTnDKIxLK6bkOZdKVjbvBkBsSRwhQ7\n\tEaymnbLuUYUjfUT+wNzLLjjwYshRAdRINGtq85FH8epaEJQ4I9rKVkt0S0eiEkDPA6\n\tQ0hcliz/lGLni5ePXtON4PyDi24vaAhjjscHELo4IDhBjKkQW3G1a3tso0GBeZICie\n\thu0MVngPN53/w==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:from:to:cc:subject:date:message-id:reply-to;\n\tbh=umTjWd8LN9FoyVorE9eBEPavaIVuCtXUQx6TTrzCQmw=;\n\tb=bE6IRabZAj81kORSsq0XTBQjDMXcNEtKWrZ0vugKPPI23qUKopUuJlF2OQxOnlgc+P\n\tQ/JncFYH5BLh2Qg1HKy+H33jBbonipJ7v1TlOoD3RQT3LF6U3+rFZDurqsYU03d5ehBC\n\thiUd6cTTKq0IgGiucAIYKDfwtdpenRuWpVtUCSIJa3gZbOgmUXgN7nZ5URxu+uykCuYF\n\tLHWg+5p1ODX+h+ycnEta9GOOZSGyUcevMt+ohiTBhAgcRj4EaYRiIS85bOZNWGWioShi\n\tu1JDjdOt3gwQkyXYO4rEjOo2xlX6CX8BX7vtDVfFcorM0fKcN7FupLsOGiPVhaDcXlzC\n\tn4wA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"bE6IRabZ\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=umTjWd8LN9FoyVorE9eBEPavaIVuCtXUQx6TTrzCQmw=;\n\tb=2TyfTG09jAukm56YDsRLy7BSt7/wPXs4EbwM7eU7w1jVQwy1UTzGZcs3qVcRY1Lehz\n\tNRn7sKYw31w6wFHYyjLrR5VebSXTl3QrMmyTvLqMYQoXS5BUk3mpQJTRKQbUBB+MztmR\n\tSg6IANIZIQsukGEO2WYt+KvshYWo/oIKSx1ys5ZL2wRINrM/WsyfopIRwCr4SdZ07Ax8\n\tRe7X440ApRpr0eEd3Ii2Ye16JHvUchLOKC2HcvH7logDcDNZ/aLVtqYU2FUHgtqvHSle\n\t09wxSmJLw6wwje0wSlNpbqo5A7syTrjVTiSYZMPVu6Dfj1D/hQuNe2V9RHfb4LoCl4sQ\n\tw9Hw==","X-Gm-Message-State":"AFqh2kot12cEZqLpiCXaFuOD/1jdy6e7Kwcah5BWlLnHyVAwrbNoakDN\n\tQRbaEIf3Qn9alIH1LT63tIT6yx1Xz40=","X-Google-Smtp-Source":"AMrXdXsZnX62aOQcl3eYxX3Bv3+hsDNRC1jlGo3EZYavr+YtoO80hFuWyXpPrTk20VkakBXX+WVcrA==","X-Received":"by 2002:a05:6512:3f0c:b0:4ca:94cc:a288 with SMTP id\n\ty12-20020a0565123f0c00b004ca94cca288mr4200935lfa.27.1674153005969; \n\tThu, 19 Jan 2023 10:30:05 -0800 (PST)","References":"<20230119155905.464995-1-mike.rudenko@gmail.com>\n\t<20230119155905.464995-4-mike.rudenko@gmail.com>\n\t<20230119171259.l6qvgb6utweb5wfn@uno.localdomain>","User-agent":"mu4e 1.9.0; emacs 28.2","To":"Jacopo Mondi ","Date":"Thu, 19 Jan 2023 20:47:37 +0300","In-reply-to":"<20230119171259.l6qvgb6utweb5wfn@uno.localdomain>","Message-ID":"<87edrqbcnn.fsf@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH 3/4] ipa: rkisp1: Add OV4689 tuning\n\tfile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Mikhail Rudenko via libcamera-devel\n\t","Reply-To":"Mikhail Rudenko ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26272,"web_url":"https://patchwork.libcamera.org/comment/26272/","msgid":"<20230120083613.hox74j63vhead3hz@uno.localdomain>","date":"2023-01-20T08:36:13","subject":"Re: [libcamera-devel] [PATCH 3/4] ipa: rkisp1: Add OV4689 tuning\n\tfile","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Mikhail\n\nOn Thu, Jan 19, 2023 at 08:47:37PM +0300, Mikhail Rudenko via libcamera-devel wrote:\n>\n> On 2023-01-19 at 18:12 +01, Jacopo Mondi wrote:\n>\n> > Hi Mikhail\n> >\n> > On Thu, Jan 19, 2023 at 06:59:04PM +0300, Mikhail Rudenko via libcamera-devel wrote:\n> >> Add a minimal tuning file for Omnivision OV4689, specifying black\n> >> level subtraction level.\n> >>\n> >> Signed-off-by: Mikhail Rudenko \n> >> ---\n> >> src/ipa/rkisp1/data/meson.build | 1 +\n> >> src/ipa/rkisp1/data/ov4689.yaml | 13 +++++++++++++\n> >> 2 files changed, 14 insertions(+)\n> >> create mode 100644 src/ipa/rkisp1/data/ov4689.yaml\n> >>\n> >> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> >> index c3b4e388..f5e9fa75 100644\n> >> --- a/src/ipa/rkisp1/data/meson.build\n> >> +++ b/src/ipa/rkisp1/data/meson.build\n> >> @@ -2,6 +2,7 @@\n> >>\n> >> conf_files = files([\n> >> 'imx219.yaml',\n> >> + 'ov4689.yaml',\n> >> 'ov5640.yaml',\n> >> 'uncalibrated.yaml',\n> >> ])\n> >> diff --git a/src/ipa/rkisp1/data/ov4689.yaml b/src/ipa/rkisp1/data/ov4689.yaml\n> >> new file mode 100644\n> >> index 00000000..750b369e\n> >> --- /dev/null\n> >> +++ b/src/ipa/rkisp1/data/ov4689.yaml\n> >> @@ -0,0 +1,13 @@\n> >> +# SPDX-License-Identifier: CC0-1.0\n> >> +%YAML 1.1\n> >> +---\n> >> +version: 1\n> >> +algorithms:\n> >> + - Agc:\n> >> + - Awb:\n> >> + - BlackLevelCorrection:\n> >> + R: 64\n> >> + Gr: 64\n> >> + Gb: 64\n> >> + B: 64\n> >\n> > Are these values measured ?\n> >\n> > In such case\n> > Reviewed-by: Jacopo Mondi \n>\n> These values were taken from Rockchip's camera engine xml\n> configs. Should I measure them instead?\n>\n\nIt would be best, but it's not a huge deal. All it takes would be to\noptically cover the sensor, dump a raw frame and compute each color\nchannel average value (you should probably also set gains to their\nminimum and disable aegc and awb algorithms by deleting them from this\ntuning file).\n\nIf you don't want to do that, just please record with a comment\n\n /* Values extracted from Rockchip's camera engine tuning file. */\n\nOr something similar\n\n\n> > Thanks\n> > j\n> >\n> >> +...\n> >> --\n> >> 2.39.0\n> >>\n>\n>\n> --\n> Best regards,\n> Mikhail Rudenko","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5898BE175\n\tfor ;\n\tFri, 20 Jan 2023 08:36:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08FA7625E4;\n\tFri, 20 Jan 2023 09:36:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 516366045E\n\tfor ;\n\tFri, 20 Jan 2023 09:36:16 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AEF11514;\n\tFri, 20 Jan 2023 09:36:15 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674203778;\n\tbh=rZjoZpYItJSI91Q4HXnvwBRaOF27jWZ5PoYNdJc2dAQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=D+P4ZzvVMrltd+FYDGiaT2DKNNepQ0TvKh2NmVBYgW3QQylL/WZZObA2pSRz4xa7N\n\tJCZOLpDJIOdQvxLdGutOOXG0Z5N95HKhK/jzJFZjwJ71hc2NNl7yafw9BBHATzgMc8\n\tvCLRc8Nvh4yjayRFCEeJGiRVrDpkQwjvv5R1upFr9//t2TQTU30RVniWFr01CCqzne\n\tDRxWEITwpoj5Ogbx9axed3pdPAZHJGUZeeP6qUlbv0/wV4Jbey6xmsuqSMwPO38gF2\n\tZekuZ3+R1ozJ55q/R4fCePh7fOt5TJhFuBkW1WN+qHs/bntdOKDefh9zu2APdLWJsG\n\tcY3avArbUM5tg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674203775;\n\tbh=rZjoZpYItJSI91Q4HXnvwBRaOF27jWZ5PoYNdJc2dAQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vYNZfEdMA7tJjugXAZCchkqbZwgBhw5W/fODBAViIFKLyzkvpV+PAUUIGZXIaopyb\n\tDm0Qb1wuO311QJ8cveRRGfDuBb0auRsaalWyfM0tLucCAqNtRxmVxDSku9QHYmzzSi\n\tTHfZxvmkcPsbYvQ46Xh8BZ+Ite2D/vcSg2NGmfBI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vYNZfEdM\"; dkim-atps=neutral","Date":"Fri, 20 Jan 2023 09:36:13 +0100","To":"Mikhail Rudenko ","Message-ID":"<20230120083613.hox74j63vhead3hz@uno.localdomain>","References":"<20230119155905.464995-1-mike.rudenko@gmail.com>\n\t<20230119155905.464995-4-mike.rudenko@gmail.com>\n\t<20230119171259.l6qvgb6utweb5wfn@uno.localdomain>\n\t<87edrqbcnn.fsf@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<87edrqbcnn.fsf@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH 3/4] ipa: rkisp1: Add OV4689 tuning\n\tfile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26297,"web_url":"https://patchwork.libcamera.org/comment/26297/","msgid":"<87a62d1dto.fsf@gmail.com>","date":"2023-01-20T14:22:28","subject":"Re: [libcamera-devel] [PATCH 3/4] ipa: rkisp1: Add OV4689 tuning\n\tfile","submitter":{"id":146,"url":"https://patchwork.libcamera.org/api/people/146/","name":"Mikhail Rudenko","email":"mike.rudenko@gmail.com"},"content":"Hi Jacopo,\n\nOn 2023-01-20 at 09:36 +01, Jacopo Mondi wrote:\n\n> Hi Mikhail\n>\n> On Thu, Jan 19, 2023 at 08:47:37PM +0300, Mikhail Rudenko via libcamera-devel wrote:\n>>\n>> On 2023-01-19 at 18:12 +01, Jacopo Mondi wrote:\n>>\n>> > Hi Mikhail\n>> >\n>> > On Thu, Jan 19, 2023 at 06:59:04PM +0300, Mikhail Rudenko via libcamera-devel wrote:\n>> >> Add a minimal tuning file for Omnivision OV4689, specifying black\n>> >> level subtraction level.\n>> >>\n>> >> Signed-off-by: Mikhail Rudenko \n>> >> ---\n>> >> src/ipa/rkisp1/data/meson.build | 1 +\n>> >> src/ipa/rkisp1/data/ov4689.yaml | 13 +++++++++++++\n>> >> 2 files changed, 14 insertions(+)\n>> >> create mode 100644 src/ipa/rkisp1/data/ov4689.yaml\n>> >>\n>> >> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n>> >> index c3b4e388..f5e9fa75 100644\n>> >> --- a/src/ipa/rkisp1/data/meson.build\n>> >> +++ b/src/ipa/rkisp1/data/meson.build\n>> >> @@ -2,6 +2,7 @@\n>> >>\n>> >> conf_files = files([\n>> >> 'imx219.yaml',\n>> >> + 'ov4689.yaml',\n>> >> 'ov5640.yaml',\n>> >> 'uncalibrated.yaml',\n>> >> ])\n>> >> diff --git a/src/ipa/rkisp1/data/ov4689.yaml b/src/ipa/rkisp1/data/ov4689.yaml\n>> >> new file mode 100644\n>> >> index 00000000..750b369e\n>> >> --- /dev/null\n>> >> +++ b/src/ipa/rkisp1/data/ov4689.yaml\n>> >> @@ -0,0 +1,13 @@\n>> >> +# SPDX-License-Identifier: CC0-1.0\n>> >> +%YAML 1.1\n>> >> +---\n>> >> +version: 1\n>> >> +algorithms:\n>> >> + - Agc:\n>> >> + - Awb:\n>> >> + - BlackLevelCorrection:\n>> >> + R: 64\n>> >> + Gr: 64\n>> >> + Gb: 64\n>> >> + B: 64\n>> >\n>> > Are these values measured ?\n>> >\n>> > In such case\n>> > Reviewed-by: Jacopo Mondi \n>>\n>> These values were taken from Rockchip's camera engine xml\n>> configs. Should I measure them instead?\n>>\n>\n> It would be best, but it's not a huge deal. All it takes would be to\n> optically cover the sensor, dump a raw frame and compute each color\n> channel average value (you should probably also set gains to their\n> minimum and disable aegc and awb algorithms by deleting them from this\n> tuning file).\n\nI'll try to do this over the weekend (for educational purposes at least), and\npost the results as v2 of this patch.\n\nBest regards,\nMikhail\n\n> If you don't want to do that, just please record with a comment\n>\n> /* Values extracted from Rockchip's camera engine tuning file. */\n>\n> Or something similar\n>\n>\n>> > Thanks\n>> > j\n>> >\n>> >> +...\n>> >> --\n>> >> 2.39.0\n>> >>\n>>\n>>\n>> --\n>> Best regards,\n>> Mikhail Rudenko","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 894B0C3240\n\tfor ;\n\tFri, 20 Jan 2023 14:27:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E252B625E4;\n\tFri, 20 Jan 2023 15:27:18 +0100 (CET)","from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com\n\t[IPv6:2a00:1450:4864:20::22d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9270361EFD\n\tfor ;\n\tFri, 20 Jan 2023 15:27:17 +0100 (CET)","by mail-lj1-x22d.google.com with SMTP id e16so5688270ljn.3\n\tfor ;\n\tFri, 20 Jan 2023 06:27:17 -0800 (PST)","from razdolb (93-80-66-125.broadband.corbina.ru. [93.80.66.125])\n\tby smtp.gmail.com with ESMTPSA id\n\ts36-20020a2ea724000000b0028b74d7edebsm1923154lje.47.2023.01.20.06.27.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 20 Jan 2023 06:27:15 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674224838;\n\tbh=O3/qLwuD72+NbmBQTj1csC4g+3ItwINkAzpoFIbeqVM=;\n\th=References:To:Date:In-reply-to:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=V0N3XwGBi7MbyQKbvvcl97Cnoua3CQMlSyagRN0JzWhstr5GUmLOfqfepzB44mQno\n\tHnFsBwAdKCrmzvlYAWpFPc4783LRW3Ha0OHemZwREyEkoO4qoMweP6pFQa2rJ4QhkO\n\tTdCxsHxhPLYZqVXYsQVOx/rFQ9AnZX0IqHipwBbKoIciYqQiuDrBV55+eGWWX9F3Uz\n\t0HA7xZAn1QvStyrGyeobsn1UDzRZOkkMtaA38HnKR6aTSRyZOPEemFtHOB7Ps0SZLg\n\tDwPDvH9qEh14juRqaahajgzlpbHOlf0hJ4V1SnslyP9YaliwI+IaKg3Dlu2eKtSQ4F\n\tLDJQS5HhWqRXw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:from:to:cc:subject:date:message-id:reply-to;\n\tbh=SXHQM1XlIC4KlJW9p2B0hNDEWLEu/wuz4FHYW3mMvKI=;\n\tb=V/ttgQYZ+mq7kYzVJKAKfVhd6otQ6sBqfOzM03FG4mrQydcUKMhk6Rt9xqmsVDc5PO\n\tK4oGUsyCyT47XTGKQ3Y9aoBkMyFjSvwrqj29kCm2zniyNhnvrUvg55vUsOl2Q0Ipmnn9\n\tK/YiTh0jnU/5IpP1Dl9V/RtyBom5z2DKcaiH8ZviqdtN+GjBqMXD6L0P1Mtt86GEBJfl\n\tOFnIEyfBmrMona+Z1mrVrLwTv3fzX/o5Lq99tzhEJR11yd/12KaU5OptxsxsHv+x+R+0\n\tnD4GHv6G57qTkEatMrBI/SMP9PL98uu0L48e845lGILjKLFIXP85huC5N/2EKIDG32ta\n\tvT3Q=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"V/ttgQYZ\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=SXHQM1XlIC4KlJW9p2B0hNDEWLEu/wuz4FHYW3mMvKI=;\n\tb=WMUMakOvBoyjul1pixt51wVxq/EdOF7cR1r/boMBUHxUJTYvfrUEi7X9HnW0Jrwbzq\n\tgstRB7Y3iHxUo2UueFsQmdMtOSPWzNnzvg44jt/XHBh6B8JV+VpDP1rk5/4h42f3dpw1\n\tQO+pzbG8G4xWUh5XAxu9Fe3NWcE9uk+otYZl0Ks5Bb65fR6ESNKlmhpqvyCiX6g5Ps0k\n\tD9EE/atdTAbYVd/bhZ4CIPrkg7BHWFlc8Sx4fDF9QuHc53ZafxyZ3VmB3L+zZtnvtang\n\t2tbsGQFgfohGucrY1FkyhdayG7o+sp9qG6bI/OGL2bb7OwVLxxsnklh8bITxjkqG39U5\n\tSElg==","X-Gm-Message-State":"AFqh2kpvGTqgTlrx1rVxU367nMbjhWX63UwRdqq3pO83Pq2zLZ6lqBEf\n\tf+lbfmGqFa9yJlZ7jn/f6Lq21hxpJKk=","X-Google-Smtp-Source":"AMrXdXsPrjmgnwRcDDfIYnzV96a+93Px/1I72TN+UsLX7sYh1N0YCWU/F1TzkDOELR0vEr5gFvfmPQ==","X-Received":"by 2002:a2e:9bce:0:b0:289:82f6:a561 with SMTP id\n\tw14-20020a2e9bce000000b0028982f6a561mr4216496ljj.39.1674224836376; \n\tFri, 20 Jan 2023 06:27:16 -0800 (PST)","References":"<20230119155905.464995-1-mike.rudenko@gmail.com>\n\t<20230119155905.464995-4-mike.rudenko@gmail.com>\n\t<20230119171259.l6qvgb6utweb5wfn@uno.localdomain>\n\t<87edrqbcnn.fsf@gmail.com>\n\t<20230120083613.hox74j63vhead3hz@uno.localdomain>","User-agent":"mu4e 1.9.0; emacs 28.2","To":"Jacopo Mondi ","Date":"Fri, 20 Jan 2023 17:22:28 +0300","In-reply-to":"<20230120083613.hox74j63vhead3hz@uno.localdomain>","Message-ID":"<87a62d1dto.fsf@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH 3/4] ipa: rkisp1: Add OV4689 tuning\n\tfile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Mikhail Rudenko via libcamera-devel\n\t","Reply-To":"Mikhail Rudenko ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]