[{"id":26264,"web_url":"https://patchwork.libcamera.org/comment/26264/","msgid":"<20230119171120.fk3vqxpmweh4qymm@uno.localdomain>","date":"2023-01-19T17:11:20","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: camera_sensor: Add\n\tOV4689 sensor properties","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Mikhail\n\nOn Thu, Jan 19, 2023 at 06:59:03PM +0300, Mikhail Rudenko via libcamera-devel wrote:\n> Add an entry to the sensor properties for Omnivision OV4689.\n>\n> Kernel supports three more types of color bars patterns, which we do\n> not expose now.\n>\n> Signed-off-by: Mikhail Rudenko \n> ---\n> src/libcamera/camera_sensor_properties.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index c3c2cace..ca8ef962 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -130,6 +130,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1},\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"ov4689\", {\n> +\t\t\t.unitCellSize = { 2000, 2000 },\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1}, // TODO: more patterns\n\nThere's are 3 more patters and they seems easy to add here.\nAny reason to skip them ?\n\nThanks\n j\n\n> +\t\t\t},\n> +\t\t} },\n> \t\t{ \"ov5640\", {\n> \t\t\t.unitCellSize = { 1400, 1400 },\n> \t\t\t.testPatternModes = {\n> --\n> 2.39.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9BAFBBD87C\n\tfor ;\n\tThu, 19 Jan 2023 17:11:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42D1E625E4;\n\tThu, 19 Jan 2023 18:11:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98F8B61EFE\n\tfor ;\n\tThu, 19 Jan 2023 18:11:23 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 39A26501;\n\tThu, 19 Jan 2023 18:11:23 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674148285;\n\tbh=Svh3fUmdsfYpJvPdog9/Z1gHHTfAzF0qQIlTocP1OMA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=k47QwR6CLoLPGZfR6S4qrL3kW8buvL947rKPKfGpwZhrGU9dQpknj/qtcYlBeDJ/n\n\tkuyoK+UD8TxxC2KxGWMA/NSmyTv3/M9G4XdI45cBBJE1hzF4zcyjl0P6uWfBZICIy+\n\tD895xa4m3HrLxaG+ANxw0KkwXqQwSB4qt/Zzvd+9FvW52yZEj20sgvlYRTwSOEaqoO\n\tb7c4WVuLVWwjZCFQAQf+QyNbz5A8eGWOmKbg2eFI5nZoxSq/Y+V7cXj1ey5Bzha9eE\n\tei0wVpibvPUM/JWydnyNi6npxzNjz4G83hO+yXC4fLgXpFLuSE1JiSO/k/IWcMJPkL\n\t/QQvjaqgnUCBw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674148283;\n\tbh=Svh3fUmdsfYpJvPdog9/Z1gHHTfAzF0qQIlTocP1OMA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UyWovYQ2TrGpW9oRDY6mjPpHyGMjRAkNa4a9JHScYabELG9xWGr3QkcpdJDTfFTtg\n\tcEnMa9yTKue5dzvkpmRL9b8wtGh0Pbc6L+LAGSvqGAPKJg9Jtvoa2vC9CNzWz/ZzA4\n\tXB1RqayUaA3E1oViTrowAtgXV6np8dJHN49erm74="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UyWovYQ2\"; dkim-atps=neutral","Date":"Thu, 19 Jan 2023 18:11:20 +0100","To":"Mikhail Rudenko ","Message-ID":"<20230119171120.fk3vqxpmweh4qymm@uno.localdomain>","References":"<20230119155905.464995-1-mike.rudenko@gmail.com>\n\t<20230119155905.464995-3-mike.rudenko@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230119155905.464995-3-mike.rudenko@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: camera_sensor: Add\n\tOV4689 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26268,"web_url":"https://patchwork.libcamera.org/comment/26268/","msgid":"<87ilh2bco7.fsf@gmail.com>","date":"2023-01-19T17:43:46","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: camera_sensor: Add\n\tOV4689 sensor properties","submitter":{"id":146,"url":"https://patchwork.libcamera.org/api/people/146/","name":"Mikhail Rudenko","email":"mike.rudenko@gmail.com"},"content":"On 2023-01-19 at 18:11 +01, Jacopo Mondi wrote:\n\n> Hi Mikhail\n>\n> On Thu, Jan 19, 2023 at 06:59:03PM +0300, Mikhail Rudenko via libcamera-devel wrote:\n>> Add an entry to the sensor properties for Omnivision OV4689.\n>>\n>> Kernel supports three more types of color bars patterns, which we do\n>> not expose now.\n>>\n>> Signed-off-by: Mikhail Rudenko \n>> ---\n>> src/libcamera/camera_sensor_properties.cpp | 7 +++++++\n>> 1 file changed, 7 insertions(+)\n>>\n>> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n>> index c3c2cace..ca8ef962 100644\n>> --- a/src/libcamera/camera_sensor_properties.cpp\n>> +++ b/src/libcamera/camera_sensor_properties.cpp\n>> @@ -130,6 +130,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n>> \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1},\n>> \t\t\t},\n>> \t\t} },\n>> +\t\t{ \"ov4689\", {\n>> +\t\t\t.unitCellSize = { 2000, 2000 },\n>> +\t\t\t.testPatternModes = {\n>> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n>> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1}, // TODO: more patterns\n>\n> There's are 3 more patters and they seems easy to add here.\n> Any reason to skip them ?\n\nAll the patterns supported by the kernel driver are color bars\nvariations. If the following is OK, I'll do it in v2:\n\n { controls::draft::TestPatternModeOff, 0 },\n { controls::draft::TestPatternModeColorBars, 1},\n { controls::draft::TestPatternModeColorBars, 2},\n { controls::draft::TestPatternModeColorBars, 3},\n { controls::draft::TestPatternModeColorBars, 4},\n\n> Thanks\n> j\n>\n>> +\t\t\t},\n>> +\t\t} },\n>> \t\t{ \"ov5640\", {\n>> \t\t\t.unitCellSize = { 1400, 1400 },\n>> \t\t\t.testPatternModes = {\n>> --\n>> 2.39.0\n>>\n\n--\nBest regards,\nMikhail Rudenko","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C13D1C3240\n\tfor ;\n\tThu, 19 Jan 2023 18:29:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 213B7625E4;\n\tThu, 19 Jan 2023 19:29:49 +0100 (CET)","from mail-lf1-x129.google.com (mail-lf1-x129.google.com\n\t[IPv6:2a00:1450:4864:20::129])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8824461EFE\n\tfor ;\n\tThu, 19 Jan 2023 19:29:47 +0100 (CET)","by mail-lf1-x129.google.com with SMTP id b3so4519189lfv.2\n\tfor ;\n\tThu, 19 Jan 2023 10:29:47 -0800 (PST)","from razdolb (93-80-66-125.broadband.corbina.ru. [93.80.66.125])\n\tby smtp.gmail.com with ESMTPSA id\n\to20-20020a05651205d400b004cb34b81150sm5950784lfo.282.2023.01.19.10.29.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 19 Jan 2023 10:29:45 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674152989;\n\tbh=+82vhwWTF5HSbaQkD+gyhr95iinxcJ9L/Gd//N4VttU=;\n\th=References:To:Date:In-reply-to:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zBVmCsffQR0P9NrT6Dk2HQwo0WnVPnWm2oc7r61BD+SELqjllReIhdIS9TtQ92F/W\n\t1n8+qVEvZbnPiZEmASUOMZ0GghGx/sMS6H8QtO9lDzG44IE9L55bGOzOLcVi9mf3bC\n\trkMzD0c5FEUMh4Ja7d8zye+sfDfSJQBgemXQipea0VQoOlbXOUMyMv/SvroXgSZboE\n\t5M/JadwokDxVjNrZF4U1MwfPPhClhY7ULv8Iy6gbSzlLiTEa/h8WsclvqAVMmv8p5C\n\tndP8uO3GjpXdVRfmkJMbGkLuWhmjDehkt/cGW/XVnr1Ib1SsR6RA8H91fujC2XBPdX\n\tKlscxO7E3cv2g==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:from:to:cc:subject:date:message-id:reply-to;\n\tbh=VXqeR1exgkmqWC840E26acYXTJn9yjwtgtwuOaZV+2Y=;\n\tb=lXx9WX/sOzZjpz6rzP5xI4n/udMnuINlIYyu4Zvv+uRx8xV+uCaU+dYBf0vfLaABUC\n\tpcwkofyTBSJhnTigKmvPfb7tTG1OHzCH3cYIrbUUa5FX2ttBgE2oK4x5USnHbB9Oqj0B\n\tLsv48Xg/MZl9M8B8pRqVpNz6NrAeH1F+b8isixG6VvwMrh8My5CZNz/8QkMCybzZP5vt\n\thEX+ajTKIOg3tllMT33fruHhEjFCzlZAcLff+gkMUFCy3nO1dNL05UDnm261CZh2NyOj\n\to/XpzjUylnrEvXY3UjgnmR35g1v49Xwksqp1yQTCW/2htryATgZRxTRTtVuFb7MJlnCQ\n\t4Jsg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lXx9WX/s\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=VXqeR1exgkmqWC840E26acYXTJn9yjwtgtwuOaZV+2Y=;\n\tb=M1YSTlwC1YITyK/PS7PIFgcx2OFHxXahYoRWbC1H7umnK/nWa0xFW1TyVUthm/tzh8\n\tyVdnuLjnvauCUQIIqaEe+CA3CaamvmIMQj5lP8sw8mKXPyRi0FBadBVsUkrX0/C0D7pZ\n\tI+cl5M5CUoeK6P88FIa7LCIivhxNmku6vytobpAeE42jJIWF4FEMD+tkcKty+p51UY/M\n\tMvJHWSzdS0pca2yeAJaR0DKAFi0QVgJUuOqKmXWLYytsbgsihaILkTOMikGEkZcIYVl6\n\tab0ZBg+92QVe8ey6iCCDe2tCYNHFeTyFl9epZ05qPZuMn0A1ehgoniwR/6QKKH2RUe/4\n\th6iQ==","X-Gm-Message-State":"AFqh2kqgW16hAbKDqLr3K1cIxDN82n/yyKNgbZI5BgYYfX38y6Q2+IbX\n\tiNPH0N6ltwJvAsyjVb69d6fkppde7kM=","X-Google-Smtp-Source":"AMrXdXuZn3G5yzO+J8TANurM78vsEJgE14eeaXxdK3oeSpeFxyTirAR0K9qbSJ4zK7dr/Z7N/1v2SA==","X-Received":"by 2002:a05:6512:d1:b0:4a4:68b7:dec0 with SMTP id\n\tc17-20020a05651200d100b004a468b7dec0mr5448884lfp.28.1674152986362; \n\tThu, 19 Jan 2023 10:29:46 -0800 (PST)","References":"<20230119155905.464995-1-mike.rudenko@gmail.com>\n\t<20230119155905.464995-3-mike.rudenko@gmail.com>\n\t<20230119171120.fk3vqxpmweh4qymm@uno.localdomain>","User-agent":"mu4e 1.9.0; emacs 28.2","To":"Jacopo Mondi ","Date":"Thu, 19 Jan 2023 20:43:46 +0300","In-reply-to":"<20230119171120.fk3vqxpmweh4qymm@uno.localdomain>","Message-ID":"<87ilh2bco7.fsf@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: camera_sensor: Add\n\tOV4689 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Mikhail Rudenko via libcamera-devel\n\t","Reply-To":"Mikhail Rudenko ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26271,"web_url":"https://patchwork.libcamera.org/comment/26271/","msgid":"<20230120081739.ao6sriztn4qomcne@uno.localdomain>","date":"2023-01-20T08:17:39","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: camera_sensor: Add\n\tOV4689 sensor properties","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Mikhail\n\nOn Thu, Jan 19, 2023 at 08:43:46PM +0300, Mikhail Rudenko via libcamera-devel wrote:\n>\n> On 2023-01-19 at 18:11 +01, Jacopo Mondi wrote:\n>\n> > Hi Mikhail\n> >\n> > On Thu, Jan 19, 2023 at 06:59:03PM +0300, Mikhail Rudenko via libcamera-devel wrote:\n> >> Add an entry to the sensor properties for Omnivision OV4689.\n> >>\n> >> Kernel supports three more types of color bars patterns, which we do\n> >> not expose now.\n> >>\n> >> Signed-off-by: Mikhail Rudenko \n> >> ---\n> >> src/libcamera/camera_sensor_properties.cpp | 7 +++++++\n> >> 1 file changed, 7 insertions(+)\n> >>\n> >> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> >> index c3c2cace..ca8ef962 100644\n> >> --- a/src/libcamera/camera_sensor_properties.cpp\n> >> +++ b/src/libcamera/camera_sensor_properties.cpp\n> >> @@ -130,6 +130,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> >> \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1},\n> >> \t\t\t},\n> >> \t\t} },\n> >> +\t\t{ \"ov4689\", {\n> >> +\t\t\t.unitCellSize = { 2000, 2000 },\n> >> +\t\t\t.testPatternModes = {\n> >> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> >> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1}, // TODO: more patterns\n> >\n> > There's are 3 more patters and they seems easy to add here.\n> > Any reason to skip them ?\n>\n> All the patterns supported by the kernel driver are color bars\n> variations. If the following is OK, I'll do it in v2:\n>\n> { controls::draft::TestPatternModeOff, 0 },\n> { controls::draft::TestPatternModeColorBars, 1},\n> { controls::draft::TestPatternModeColorBars, 2},\n> { controls::draft::TestPatternModeColorBars, 3},\n> { controls::draft::TestPatternModeColorBars, 4},\n>\n\nWe're here trying to index test patterns using the modes defined by MIPI CCS\nspecifications from section 10.1. Looking at the sensor's test pattern\nit seems to me the additional \"Color bar type 2\" corresponds to the\nFadeToGray CCS test pattern mode.\n\n\nOV4689 CCS libcamera\nColorBarType1 = 100% Color bars = TestPatternModeColorBars\nColorBarType2 = Fade to gray bars = TestPatternModeColorBarsFadeToGray\n\nI cannot find any other CCS pattern corresponding to ColorBarType2 or\n3.\n\nI would then change this to\n\n\t\t{ \"ov4689\", {\n\t\t\t.unitCellSize = { 2000, 2000 },\n\t\t\t.testPatternModes = {\n\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1},\n\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 2},\n /*\n * No corresponding test patterns in\n * MIPI CCS specification for sensor's\n * colorBarType2 and colorBarType3.\n */\n },\n } },\n\nI can change it when applying with your ack, if no other comments.\n\n\n> > Thanks\n> > j\n> >\n> >> +\t\t\t},\n> >> +\t\t} },\n> >> \t\t{ \"ov5640\", {\n> >> \t\t\t.unitCellSize = { 1400, 1400 },\n> >> \t\t\t.testPatternModes = {\n> >> --\n> >> 2.39.0\n> >>\n>\n> --\n> Best regards,\n> Mikhail Rudenko","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9E30C3240\n\tfor ;\n\tFri, 20 Jan 2023 08:17:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32719625E6;\n\tFri, 20 Jan 2023 09:17:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 713986045E\n\tfor ;\n\tFri, 20 Jan 2023 09:17:42 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C2CBA501;\n\tFri, 20 Jan 2023 09:17:41 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674202664;\n\tbh=NFIlgAmOdo3Q28p7yAEZippIZDvECDZismWPlSiPnGs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ol1QcKkDXenoPb5i252mPAQIAhoau9eF1b9NfvCsz6J7arWxQiq5WdbeIaO6Zh4vm\n\tuBVVQB515cB2O8HsVgMPEPCJ3hdZh0QUcHW5V3dIHFDHhnIsI290Ted0hCRPt/ak8p\n\tzIKZ2T/wbMDxm2CXvGNqgYFbfCZHqS//NRwtIRIb/UVwdpVFlO0cW3uiptWRW4FXqV\n\tIEd+QF0pYHhwi6ksJjQvidOuBK0p5LkvhSLU7A4vaar/zAcWWOlTsY8JCH3A6LUH7G\n\twS4PsuRlUeMQtfw62eiKSxDV+x6V6/3uHp8AtTbG9tMCGDWaQuluBA2h8WknksdAHh\n\tX8f6Ff7YwHiQQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674202661;\n\tbh=NFIlgAmOdo3Q28p7yAEZippIZDvECDZismWPlSiPnGs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Kv37A8hqy5wEVifCunRX/0BPjkdOCrM7EgPFpAy8dl7PdB7MWhyHwEkutp02IxQAG\n\tFy3nYg4vC8I+XFm59jR90Kmj568PMMtZa0SNBAPWJsxYrAnX8Q0o45I3oTKA3jVKSj\n\tSZuYnBZGhkdnuFOIsaQj06TyCBHnXppyd1k/4bAo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Kv37A8hq\"; dkim-atps=neutral","Date":"Fri, 20 Jan 2023 09:17:39 +0100","To":"Mikhail Rudenko ","Message-ID":"<20230120081739.ao6sriztn4qomcne@uno.localdomain>","References":"<20230119155905.464995-1-mike.rudenko@gmail.com>\n\t<20230119155905.464995-3-mike.rudenko@gmail.com>\n\t<20230119171120.fk3vqxpmweh4qymm@uno.localdomain>\n\t<87ilh2bco7.fsf@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<87ilh2bco7.fsf@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: camera_sensor: Add\n\tOV4689 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26296,"web_url":"https://patchwork.libcamera.org/comment/26296/","msgid":"<87h6wl1e27.fsf@gmail.com>","date":"2023-01-20T14:19:43","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: camera_sensor: Add\n\tOV4689 sensor properties","submitter":{"id":146,"url":"https://patchwork.libcamera.org/api/people/146/","name":"Mikhail Rudenko","email":"mike.rudenko@gmail.com"},"content":"Hi Jacopo,\n\nOn 2023-01-20 at 09:17 +01, Jacopo Mondi wrote:\n\n> Hi Mikhail\n>\n> On Thu, Jan 19, 2023 at 08:43:46PM +0300, Mikhail Rudenko via libcamera-devel wrote:\n>>\n>> On 2023-01-19 at 18:11 +01, Jacopo Mondi wrote:\n>>\n>> > Hi Mikhail\n>> >\n>> > On Thu, Jan 19, 2023 at 06:59:03PM +0300, Mikhail Rudenko via libcamera-devel wrote:\n>> >> Add an entry to the sensor properties for Omnivision OV4689.\n>> >>\n>> >> Kernel supports three more types of color bars patterns, which we do\n>> >> not expose now.\n>> >>\n>> >> Signed-off-by: Mikhail Rudenko \n>> >> ---\n>> >> src/libcamera/camera_sensor_properties.cpp | 7 +++++++\n>> >> 1 file changed, 7 insertions(+)\n>> >>\n>> >> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n>> >> index c3c2cace..ca8ef962 100644\n>> >> --- a/src/libcamera/camera_sensor_properties.cpp\n>> >> +++ b/src/libcamera/camera_sensor_properties.cpp\n>> >> @@ -130,6 +130,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n>> >> \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1},\n>> >> \t\t\t},\n>> >> \t\t} },\n>> >> +\t\t{ \"ov4689\", {\n>> >> +\t\t\t.unitCellSize = { 2000, 2000 },\n>> >> +\t\t\t.testPatternModes = {\n>> >> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n>> >> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1}, // TODO: more patterns\n>> >\n>> > There's are 3 more patters and they seems easy to add here.\n>> > Any reason to skip them ?\n>>\n>> All the patterns supported by the kernel driver are color bars\n>> variations. If the following is OK, I'll do it in v2:\n>>\n>> { controls::draft::TestPatternModeOff, 0 },\n>> { controls::draft::TestPatternModeColorBars, 1},\n>> { controls::draft::TestPatternModeColorBars, 2},\n>> { controls::draft::TestPatternModeColorBars, 3},\n>> { controls::draft::TestPatternModeColorBars, 4},\n>>\n>\n> We're here trying to index test patterns using the modes defined by MIPI CCS\n> specifications from section 10.1. Looking at the sensor's test pattern\n> it seems to me the additional \"Color bar type 2\" corresponds to the\n> FadeToGray CCS test pattern mode.\n>\n>\n> OV4689 CCS libcamera\n> ColorBarType1 = 100% Color bars = TestPatternModeColorBars\n> ColorBarType2 = Fade to gray bars = TestPatternModeColorBarsFadeToGray\n>\n> I cannot find any other CCS pattern corresponding to ColorBarType2 or\n> 3.\n>\n> I would then change this to\n>\n> \t\t{ \"ov4689\", {\n> \t\t\t.unitCellSize = { 2000, 2000 },\n> \t\t\t.testPatternModes = {\n> \t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1},\n> \t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 2},\n> /*\n> * No corresponding test patterns in\n> * MIPI CCS specification for sensor's\n> * colorBarType2 and colorBarType3.\n> */\n> },\n> } },\n\nThis looks reasonable, thanks! I'll do so in v2 alongside a few other\nchanges.\n\nBest regards,\nMikhail\n\n> I can change it when applying with your ack, if no other comments.\n>\n>\n>> > Thanks\n>> > j\n>> >\n>> >> +\t\t\t},\n>> >> +\t\t} },\n>> >> \t\t{ \"ov5640\", {\n>> >> \t\t\t.unitCellSize = { 1400, 1400 },\n>> >> \t\t\t.testPatternModes = {\n>> >> --\n>> >> 2.39.0\n>> >>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 895F0BE175\n\tfor ;\n\tFri, 20 Jan 2023 14:22:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E8885625D8;\n\tFri, 20 Jan 2023 15:22:13 +0100 (CET)","from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com\n\t[IPv6:2a00:1450:4864:20::12b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 26F6D61EFD\n\tfor ;\n\tFri, 20 Jan 2023 15:22:12 +0100 (CET)","by mail-lf1-x12b.google.com with SMTP id h24so4085877lfv.6\n\tfor ;\n\tFri, 20 Jan 2023 06:22:12 -0800 (PST)","from razdolb (93-80-66-125.broadband.corbina.ru. [93.80.66.125])\n\tby smtp.gmail.com with ESMTPSA id\n\tu3-20020a056512040300b004d1454463basm2546318lfk.94.2023.01.20.06.22.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 20 Jan 2023 06:22:09 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674224533;\n\tbh=BLdGEkfx4FaPgADMAcO4S1ZpDZrqvsMd/eqCNpI0a1A=;\n\th=References:To:Date:In-reply-to:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=IQ5jYnLmpBuRjVS2l9M2YKc7C0C/udJCCZXBhrDYdAxRJt2gzJo+YR4e8iJVe/FwK\n\t4wg0baJGhamTae+NlIjjBdCorT/YBUSEs+9yNuDZrY1WdSO5C/wxsHXPI29lfi6pOm\n\t/lU8YQ7LNJxaUDz/4ZKlu0hdsxYJDz+C0HYkQEcH+zlZhxHp9qmrragpxocAijWa4A\n\tG2EGiV4WPzghi/txMlrKVilvOOUnN1OL/KCynYGAWCQ6Ozpt/zSCxHUwrGBB74xccT\n\t7tK34Mn2dkl0g0iTwKvZWRQEZwJn4aZimWFV1CN/vawYV+4FJ/j1p+RlZlUp23NBlm\n\tUUtIfrhMJzGPA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:from:to:cc:subject:date:message-id:reply-to;\n\tbh=jSA+Yi3TEd9wi4LXLXZg4kdMEuwZtUvLrFtRwxxM/vk=;\n\tb=OIB3zLYg78rLoETH6nrslE5L9oX0RI63V8wX5ughPC9P0YCwTKDmXOUhOudfiotzv1\n\tGlJcba9kWrDtrLrh9ngh2qKRpIxooxqHrep3M9L/FazPODw6ifDuMzQpkwhyqPjfHDT/\n\t3Vi1isqqwa5NYGIDIR5y2KaIbAaDUDy3IOEokdBSr+5CYE2i+SUxCjuypU63LYFYfF6o\n\tkx8UzvzIl2gSNIQ1txAsA4nqZdrZRUhNMJV6fU2jCsOOUuN3F1+8s9X2dGxP0vna0BvS\n\tLl80aqjz8tR3oVLJpyBxAa9B9GyrAKw5dairLU4BI91vyEos14qMVKN4sh206GIP2ysD\n\t5XVQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"OIB3zLYg\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=jSA+Yi3TEd9wi4LXLXZg4kdMEuwZtUvLrFtRwxxM/vk=;\n\tb=fxtJKpquGBrfnplbeR1odFXH9bw/dTtZErMps2NsBurwGK5ZIzu3WZPPtnvXUanfJr\n\tv7QHAiiLgAlQyD4e6Lm88o7m5og63Xf9aXHm0jLhk/XP+F++qAC1TcmkrpcEEvER6qTR\n\t6HN6J+IA7nnPVOFyRC+gKzJ4Jr6VBvxR3FxjT95/6CzjQE0Tsv5kKOgnnH3aDoKeJe/u\n\tM5luk3ZpS5gZ6lOkN74/Msr6ZfE93sE6/L+1Wq8uNVRPbolrh4/CQCp9iMalvwkn3XyA\n\tcbUlE8vwgV4UUgn7odjwC9QKrudtQm5rNcN29c03nXajVzYo5EISdDzVsQ4jmGWqbig2\n\tmt4A==","X-Gm-Message-State":"AFqh2kpVtu2Xb5/Ib1ScvQrlt4mL4JN+UZPOgVkv97XALlc2ekzvISwg\n\tCDXTqIxn+XfYDXW1/uf3dxYgUDU5JAY=","X-Google-Smtp-Source":"AMrXdXv1f19ocUZmwKoUHFfZR8aedjlZCAnuyx183UP8upKzyc8CxCTV4GXovTp1krL7TC7tgWYSeg==","X-Received":"by 2002:ac2:57cc:0:b0:4b5:32e6:12e with SMTP id\n\tk12-20020ac257cc000000b004b532e6012emr3652571lfo.65.1674224530273; \n\tFri, 20 Jan 2023 06:22:10 -0800 (PST)","References":"<20230119155905.464995-1-mike.rudenko@gmail.com>\n\t<20230119155905.464995-3-mike.rudenko@gmail.com>\n\t<20230119171120.fk3vqxpmweh4qymm@uno.localdomain>\n\t<87ilh2bco7.fsf@gmail.com>\n\t<20230120081739.ao6sriztn4qomcne@uno.localdomain>","User-agent":"mu4e 1.9.0; emacs 28.2","To":"Jacopo Mondi ","Date":"Fri, 20 Jan 2023 17:19:43 +0300","In-reply-to":"<20230120081739.ao6sriztn4qomcne@uno.localdomain>","Message-ID":"<87h6wl1e27.fsf@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: camera_sensor: Add\n\tOV4689 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Mikhail Rudenko via libcamera-devel\n\t","Reply-To":"Mikhail Rudenko ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]