[{"id":26263,"web_url":"https://patchwork.libcamera.org/comment/26263/","msgid":"<20230119171007.pbghbg3s3mj3hqa5@uno.localdomain>","date":"2023-01-19T17:10:07","subject":"Re: [libcamera-devel] [PATCH 1/4] ipa: camera_sensor_helper: Add\n\tOV4689 support","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Mikhail\n\nOn Thu, Jan 19, 2023 at 06:59:02PM +0300, Mikhail Rudenko via libcamera-devel wrote:\n> Add support for Omnivision OV4689 image sensor to libipa.\n>\n> The sensor implements a linear gain equation with analogue gain\n> control values 0-2047 corresponding to 0x-16x physical gain range.\n>\n> Signed-off-by: Mikhail Rudenko \n\nThanks for abstracting it nicely in the driver\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 3d8a2835..075c568e 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -461,6 +461,17 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov2740\", CameraSensorHelperOv2740)\n>\n> +class CameraSensorHelperOv4689 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperOv4689()\n> +\t{\n> +\t\tgainType_ = AnalogueGainLinear;\n> +\t\tgainConstants_.linear = { 1, 0, 0, 128 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov4689\", CameraSensorHelperOv4689)\n> +\n> class CameraSensorHelperOv5640 : public CameraSensorHelper\n> {\n> public:\n> --\n> 2.39.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 642D7BD87C\n\tfor ;\n\tThu, 19 Jan 2023 17:10:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2097625D8;\n\tThu, 19 Jan 2023 18:10:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B6CB61EFE\n\tfor ;\n\tThu, 19 Jan 2023 18:10:11 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B96EA501;\n\tThu, 19 Jan 2023 18:10:10 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674148212;\n\tbh=n11fOxA2rKBZG2AN7/OLFfbenaZE4EWYDM4JmF95OfA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=sUlr47DM095sq9RcuDpKukOyTukcaWIkVx1YylLTDeZ5HWrAwXjOqHSeO6hJAOSd4\n\tSL2kzj+Y3FGeSfunV4RFzR2+NZmLgRtuEBdrtJivqvB2Vsv0TOAjyq7a4++yEnEPSN\n\tRKg/+RkSJnaqdgp1aJZ29cquOYa6L+Iabol11nBCeNE/HfjqrSqlHD1TRWT0uIKd7M\n\tMvw8of3PaK4cXBI/alLnNJx72y/Mv4YsnmXZCKhOXRI6gklD/5oWrh7FmTZEftwWMV\n\tjhz5UmDzF07dUus0Kk1enLotWiMK7SsKmmS9fqrkis0e0a4WNtj+/UJJQ2reglpee2\n\tpPGTEThvwfYpg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674148210;\n\tbh=n11fOxA2rKBZG2AN7/OLFfbenaZE4EWYDM4JmF95OfA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RvzOUy1AokWB6Ogc7xv5JGXZLjGLll30N/kCj6kPpTxR816hjue0kMpa4rQ/U6R2j\n\tAkEds5v0nlGqLrD3S+eKDnj5YuAyJYQJ3IJDkYSY4Tos+uuOoWCREJ3Ku9Xqj3bSUo\n\t0pktQphwSPRhQRhyYg2c6Fow21tnm1Xu8yIEjtMU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"RvzOUy1A\"; dkim-atps=neutral","Date":"Thu, 19 Jan 2023 18:10:07 +0100","To":"Mikhail Rudenko ","Message-ID":"<20230119171007.pbghbg3s3mj3hqa5@uno.localdomain>","References":"<20230119155905.464995-1-mike.rudenko@gmail.com>\n\t<20230119155905.464995-2-mike.rudenko@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230119155905.464995-2-mike.rudenko@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH 1/4] ipa: camera_sensor_helper: Add\n\tOV4689 support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]