[{"id":26399,"web_url":"https://patchwork.libcamera.org/comment/26399/","msgid":"<20230206091212.elpzeagurxg4wmob@uno.localdomain>","date":"2023-02-06T09:12:12","subject":"Re: [libcamera-devel] [PATCH v3 8/8] ipa: rkisp1: Add OV5675 tuning\n\tfile","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Daniel,\n thank you for this big chunk of work. I still haven't got to\nrun-time test it, let me point out a few things I've noticed here\nfirst\n\nOn Thu, Jan 19, 2023 at 09:41:12AM +0100, Daniel Semkowicz via libcamera-devel wrote:\n> Add the OV5675 tuning file with default values and enabled AF algorithm.\n>\n> Signed-off-by: Daniel Semkowicz \n> ---\n> src/ipa/rkisp1/data/meson.build | 1 +\n> src/ipa/rkisp1/data/ov5675.yaml | 20 ++++++++++++++++++++\n> 2 files changed, 21 insertions(+)\n> create mode 100644 src/ipa/rkisp1/data/ov5675.yaml\n>\n> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> index c3b4e388..03d71cbf 100644\n> --- a/src/ipa/rkisp1/data/meson.build\n> +++ b/src/ipa/rkisp1/data/meson.build\n> @@ -3,6 +3,7 @@\n> conf_files = files([\n> 'imx219.yaml',\n> 'ov5640.yaml',\n> + 'ov5675.yaml',\n> 'uncalibrated.yaml',\n> ])\n>\n> diff --git a/src/ipa/rkisp1/data/ov5675.yaml b/src/ipa/rkisp1/data/ov5675.yaml\n> new file mode 100644\n> index 00000000..2c088d18\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/data/ov5675.yaml\n> @@ -0,0 +1,20 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +%YAML 1.1\n> +---\n> +version: 1\n> +algorithms:\n> + - Af:\n> + min-vcm-position: 0\n> + max-vcm-position: 1023\n> + coarse-search-step: 30\n> + fine-search-step: 1\n> + fine-scan-range: 0.05\n> + max-variance-change: 0.5\n> + wait-frames-lens: 2 # tuned for 30fps stream\n> + isp-threshold: 128\n> + isp-var-shift: 4\n\nDo these information belong to the -camera sensor- tuning file ?\nThe same sensor, depending on how the camera module is assembled,\nmight be paired with different lenses/VCM combo.\n\nMy gut feeling is that would be better expressed with something like a\nlens helper, similar to what we have in libipa's CameraSensorHelper ?\n\nWhat do you think ?\n\n> + - Agc:\n> + - Awb:\n> + - BlackLevelCorrection:\n> + - ColorProcessing:\n\nTo be honest, I wonder if it was a good idea to list what algorithms\nto enable in the sensor tuning file.\n\nThe decision of what algorithms to use, and possibly any tuning data\nassociated with them, are maybe properties that need to be associated to\na global device tuning file. But that's not a discussion that should\nblock this series.\n\nThanks\n j\n\n> +...\n> --\n> 2.39.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2FDABDB1C\n\tfor ;\n\tMon, 6 Feb 2023 09:12:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 33E7561EF3;\n\tMon, 6 Feb 2023 10:12:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3AB1161EF3\n\tfor ;\n\tMon, 6 Feb 2023 10:12:16 +0100 (CET)","from ideasonboard.com (host-79-55-56-167.retail.telecomitalia.it\n\t[79.55.56.167])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7BBF24DA;\n\tMon, 6 Feb 2023 10:12:15 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675674738;\n\tbh=nRFP/4tt76h0Z7yTUhSFDTeYCHYKRvFMLPrdE8yUfDQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=xvu6q1i7n2v74m0Oa6RwxLZfJRns/Z+i4zTYrOdljVQbvoXJDMM8NyDkIh+36oomo\n\tO0EngEfYI6f/fWCN+eLs6KZKBy2jSRAWgIjLlQqOJ5w4z3HYhLMalOQQZoY1eksV16\n\tmmeZHM6cJMvU+wYoFEMa18U1OaTWL+6ajVWQ6QTXoPaH3y7Zk8hCTZz149llmVxOTt\n\tb/VbT3fMpaELDkIPSX73eV6kIoCV12nTibB6cv59FcmGUEK+az1OZHtBUOGpBRLN94\n\tkPgHmpj8qmxwlI9vg4Cfh5PLqjGyNhjKIk+DQhOARzj13fGMtlrbETQcnX+i8RJG13\n\tg8rVSFgAQFIbg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675674735;\n\tbh=nRFP/4tt76h0Z7yTUhSFDTeYCHYKRvFMLPrdE8yUfDQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jAWcGggftnG1kcVI9jsTJvuwzeYNFZpwNCFlhFAC/J5hW+mDzf4wirTFjddcGUSv3\n\tcZZeH+XiCeOKBeF3Q61yzXJZB2ShDxKC8jEWt15xsnFWEGWIUhddYwLHM6rlNOhmR0\n\tdY/hVY7YQANd439W06S0yao0CiO/IJ5B7rA8JRTg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jAWcGggf\"; dkim-atps=neutral","Date":"Mon, 6 Feb 2023 10:12:12 +0100","To":"Daniel Semkowicz ","Message-ID":"<20230206091212.elpzeagurxg4wmob@uno.localdomain>","References":"<20230119084112.20564-1-dse@thaumatec.com>\n\t<20230119084112.20564-9-dse@thaumatec.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230119084112.20564-9-dse@thaumatec.com>","Subject":"Re: [libcamera-devel] [PATCH v3 8/8] ipa: rkisp1: Add OV5675 tuning\n\tfile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26402,"web_url":"https://patchwork.libcamera.org/comment/26402/","msgid":"","date":"2023-02-06T09:59:04","subject":"Re: [libcamera-devel] [PATCH v3 8/8] ipa: rkisp1: Add OV5675 tuning\n\tfile","submitter":{"id":126,"url":"https://patchwork.libcamera.org/api/people/126/","name":"Daniel Semkowicz","email":"dse@thaumatec.com"},"content":"Hi Jacopo,\n\nOn Mon, Feb 6, 2023 at 10:12 AM Jacopo Mondi\n wrote:\n>\n> Hi Daniel,\n> thank you for this big chunk of work. I still haven't got to\n> run-time test it, let me point out a few things I've noticed here\n> first\n>\n> On Thu, Jan 19, 2023 at 09:41:12AM +0100, Daniel Semkowicz via libcamera-devel wrote:\n> > Add the OV5675 tuning file with default values and enabled AF algorithm.\n> >\n> > Signed-off-by: Daniel Semkowicz \n> > ---\n> > src/ipa/rkisp1/data/meson.build | 1 +\n> > src/ipa/rkisp1/data/ov5675.yaml | 20 ++++++++++++++++++++\n> > 2 files changed, 21 insertions(+)\n> > create mode 100644 src/ipa/rkisp1/data/ov5675.yaml\n> >\n> > diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> > index c3b4e388..03d71cbf 100644\n> > --- a/src/ipa/rkisp1/data/meson.build\n> > +++ b/src/ipa/rkisp1/data/meson.build\n> > @@ -3,6 +3,7 @@\n> > conf_files = files([\n> > 'imx219.yaml',\n> > 'ov5640.yaml',\n> > + 'ov5675.yaml',\n> > 'uncalibrated.yaml',\n> > ])\n> >\n> > diff --git a/src/ipa/rkisp1/data/ov5675.yaml b/src/ipa/rkisp1/data/ov5675.yaml\n> > new file mode 100644\n> > index 00000000..2c088d18\n> > --- /dev/null\n> > +++ b/src/ipa/rkisp1/data/ov5675.yaml\n> > @@ -0,0 +1,20 @@\n> > +# SPDX-License-Identifier: CC0-1.0\n> > +%YAML 1.1\n> > +---\n> > +version: 1\n> > +algorithms:\n> > + - Af:\n> > + min-vcm-position: 0\n> > + max-vcm-position: 1023\n> > + coarse-search-step: 30\n> > + fine-search-step: 1\n> > + fine-scan-range: 0.05\n> > + max-variance-change: 0.5\n> > + wait-frames-lens: 2 # tuned for 30fps stream\n> > + isp-threshold: 128\n> > + isp-var-shift: 4\n>\n> Do these information belong to the -camera sensor- tuning file ?\n> The same sensor, depending on how the camera module is assembled,\n> might be paired with different lenses/VCM combo.\n>\n> My gut feeling is that would be better expressed with something like a\n> lens helper, similar to what we have in libipa's CameraSensorHelper ?\n>\n> What do you think ?\n>\n\nThe first two, \"min-vcm-position\" and \"max-vcm-position\", indeed are\nnot a part of the sensor, but describe the lens range limits.\nThis is a quick workaround for the missing possibility to pass lens\nconfiguration to the algorithm during algorithm init.\nIt would be good to solve this problem, get rid of the manual config\nand read the limits from the v4l subdevice. But we are back to the old\nquestion about the interface. As a simple solution, I can just add the\nlens range limits to the IPAContext and read it in the AF algorithm\nduring initialization. Or do we want to have some common parameter for\nthat and hide the hardware values [1, 1023] behind some abstract range,\nfor example [0, 1]?\n\nThe rest of the parameters are more user-specific and allow to\nconfigure AF for specific usage (We can have a very fast, but less\nprecise auto-focus or the other way). This is probably more connected\nto your second question, whether we should include algorithms\nconfiguration in the sensor tuning file at all.\n\n> > + - Agc:\n> > + - Awb:\n> > + - BlackLevelCorrection:\n> > + - ColorProcessing:\n>\n> To be honest, I wonder if it was a good idea to list what algorithms\n> to enable in the sensor tuning file.\n>\n> The decision of what algorithms to use, and possibly any tuning data\n> associated with them, are maybe properties that need to be associated to\n> a global device tuning file. But that's not a discussion that should\n> block this series.\n\nCurrently, all the tuning is done in the IPA algorithms, so it\nwould be difficult to distinguish which paramters should go to which\nfile.\n\nBest regards\nDaniel\n\n>\n> Thanks\n> j\n>\n> > +...\n> > --\n> > 2.39.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 157EFBDB1C\n\tfor ;\n\tMon, 6 Feb 2023 09:59:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B392625E6;\n\tMon, 6 Feb 2023 10:59:17 +0100 (CET)","from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com\n\t[IPv6:2a00:1450:4864:20::62f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37D5B61EF0\n\tfor ;\n\tMon, 6 Feb 2023 10:59:16 +0100 (CET)","by mail-ej1-x62f.google.com with SMTP id e22so3244480ejb.1\n\tfor ;\n\tMon, 06 Feb 2023 01:59:16 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675677557;\n\tbh=OAeXfZ4C1ERfARHbLrgCVB2UR4C+iOpU2qamgYHh61o=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=t+Fg539wSA9EhfGIV6us0Nzmmq+vKPBHu5fqM3ZesySrM8zkWjxkFwXkCPDoju5X1\n\t2fZmS/yTz3RoAWzcpPPOj8QIVYq8Drck00hkvimS7vRELVP6Q1+JGf6f1O5lOe4x5V\n\tR+Ri0f8Wl/6TDT8XUB93dSkx7IePT8/PI1j59ctDfEEZa8uTOZRw3kny8p3JutFhBO\n\t4fichTujX+WXS4mLp++24DiUoBLEoQAchbEpZzCZj+DGdsm6cjaX6P4IR+QjTrMF4k\n\tYIOgFjXCszSOh8CJAOkO/s/i00Tt1WH10waABeLnM3FbdlTSoKhZrjzvnxInFfpnzP\n\tQ+2VWaByze2/w==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=4iLpKeWb7iHxPTQGUQbC6rGVpYoYClpLuBYq7N8G2OI=;\n\tb=IkBu0n27d6nqW/STtUWYJ8w4X7bzqMHdN9wiqiCRZT7cxBTm0XssGquXvPkQc8XPNS\n\ta6GrCu4IuLMU6AgAfNhc36uAgiW0MXt4j+v5lsSwH7E1Hf6jqY3+PRuwXdXPtJRJ7S32\n\tRzplDQTz6Gx2jyjdW1/EzlUJ11CVD5k0gbtlVL0ukjpm3uymwP6aeeYqgK2L/K2dKkWw\n\tf9c8LoZOTt3+sh7ESqBuUjTF8HVJB8+UQ2Y6FrjEC66XfazA1QNAJOQHXj9kXTv2Lwbr\n\tf4gaFFZdgAOi4mztSRmSBsMjNari0cvNUVe8E9ktlUR9pBegyGyPm48//syj5bnpZKAU\n\teJgA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"IkBu0n27\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=4iLpKeWb7iHxPTQGUQbC6rGVpYoYClpLuBYq7N8G2OI=;\n\tb=reWnvOw9noDPFt74U6SX/3Q1MVpsWslYf0smicxucVTPEwrGenZrLLHx2BExSJfAk8\n\teOHtOJZ7Z2F/tjDsHyM8lLhFDUp4/OBspAjj3yzsqXw6KvfSuC1HAFE1xPnSbH1czIGX\n\t7aGwQCL8iwRuRnMUGh9ESTr4FOVoqOl78xAISTN9GGqvmnwRpI8UMDqz6ye9ei8vtNd5\n\tnH7lrNMX2F0UEJeXisHVprE4Y3OGORthQDANm4j/CBqWhkf/xeAX21NJ1hEnSl1h+HmN\n\t2bMdfzcvACHBKbaw7pORcMp6xePWzBQWbPfZAOtQCDsycWGU5/imDTy9mfX2nEZlFa5D\n\tf6/g==","X-Gm-Message-State":"AO0yUKV2Wakn85qwDXJmuf100ElCAdWAuRunxSGQswA7x4R1fza411ww\n\tccPxUZs9VeEZ+XTB9shZYbHa+RUEm4RnhrtqNh3pTSaRkqU8aqjK","X-Google-Smtp-Source":"AK7set9skw6bgY3CeSWD1cwRo7+0RtHQy2spioC2+tAtKNpcHC8V2Xy2WyNb0aDalBsIXsKGsp/J3EMZfKA18SyDcBc=","X-Received":"by 2002:a17:906:6c3:b0:7c1:98e:b910 with SMTP id\n\tv3-20020a17090606c300b007c1098eb910mr5183620ejb.81.1675677555789;\n\tMon, 06 Feb 2023 01:59:15 -0800 (PST)","MIME-Version":"1.0","References":"<20230119084112.20564-1-dse@thaumatec.com>\n\t<20230119084112.20564-9-dse@thaumatec.com>\n\t<20230206091212.elpzeagurxg4wmob@uno.localdomain>","In-Reply-To":"<20230206091212.elpzeagurxg4wmob@uno.localdomain>","Date":"Mon, 6 Feb 2023 10:59:04 +0100","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v3 8/8] ipa: rkisp1: Add OV5675 tuning\n\tfile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Daniel Semkowicz via libcamera-devel\n\t","Reply-To":"Daniel Semkowicz ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26421,"web_url":"https://patchwork.libcamera.org/comment/26421/","msgid":"<20230207153332.ygecswfnlavndppo@uno.localdomain>","date":"2023-02-07T15:33:32","subject":"Re: [libcamera-devel] [PATCH v3 8/8] ipa: rkisp1: Add OV5675 tuning\n\tfile","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Daniel\n\nOn Mon, Feb 06, 2023 at 10:59:04AM +0100, Daniel Semkowicz via libcamera-devel wrote:\n> Hi Jacopo,\n>\n> On Mon, Feb 6, 2023 at 10:12 AM Jacopo Mondi\n> wrote:\n> >\n> > Hi Daniel,\n> > thank you for this big chunk of work. I still haven't got to\n> > run-time test it, let me point out a few things I've noticed here\n> > first\n> >\n> > On Thu, Jan 19, 2023 at 09:41:12AM +0100, Daniel Semkowicz via libcamera-devel wrote:\n> > > Add the OV5675 tuning file with default values and enabled AF algorithm.\n> > >\n> > > Signed-off-by: Daniel Semkowicz \n> > > ---\n> > > src/ipa/rkisp1/data/meson.build | 1 +\n> > > src/ipa/rkisp1/data/ov5675.yaml | 20 ++++++++++++++++++++\n> > > 2 files changed, 21 insertions(+)\n> > > create mode 100644 src/ipa/rkisp1/data/ov5675.yaml\n> > >\n> > > diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> > > index c3b4e388..03d71cbf 100644\n> > > --- a/src/ipa/rkisp1/data/meson.build\n> > > +++ b/src/ipa/rkisp1/data/meson.build\n> > > @@ -3,6 +3,7 @@\n> > > conf_files = files([\n> > > 'imx219.yaml',\n> > > 'ov5640.yaml',\n> > > + 'ov5675.yaml',\n> > > 'uncalibrated.yaml',\n> > > ])\n> > >\n> > > diff --git a/src/ipa/rkisp1/data/ov5675.yaml b/src/ipa/rkisp1/data/ov5675.yaml\n> > > new file mode 100644\n> > > index 00000000..2c088d18\n> > > --- /dev/null\n> > > +++ b/src/ipa/rkisp1/data/ov5675.yaml\n> > > @@ -0,0 +1,20 @@\n> > > +# SPDX-License-Identifier: CC0-1.0\n> > > +%YAML 1.1\n> > > +---\n> > > +version: 1\n> > > +algorithms:\n> > > + - Af:\n> > > + min-vcm-position: 0\n> > > + max-vcm-position: 1023\n> > > + coarse-search-step: 30\n> > > + fine-search-step: 1\n> > > + fine-scan-range: 0.05\n> > > + max-variance-change: 0.5\n> > > + wait-frames-lens: 2 # tuned for 30fps stream\n> > > + isp-threshold: 128\n> > > + isp-var-shift: 4\n> >\n> > Do these information belong to the -camera sensor- tuning file ?\n> > The same sensor, depending on how the camera module is assembled,\n> > might be paired with different lenses/VCM combo.\n> >\n> > My gut feeling is that would be better expressed with something like a\n> > lens helper, similar to what we have in libipa's CameraSensorHelper ?\n> >\n> > What do you think ?\n> >\n>\n> The first two, \"min-vcm-position\" and \"max-vcm-position\", indeed are\n> not a part of the sensor, but describe the lens range limits.\n> This is a quick workaround for the missing possibility to pass lens\n> configuration to the algorithm during algorithm init.\n> It would be good to solve this problem, get rid of the manual config\n> and read the limits from the v4l subdevice. But we are back to the old\n> question about the interface. As a simple solution, I can just add the\n> lens range limits to the IPAContext and read it in the AF algorithm\n> during initialization. Or do we want to have some common parameter for\n> that and hide the hardware values [1, 1023] behind some abstract range,\n> for example [0, 1]?\n>\n> The rest of the parameters are more user-specific and allow to\n> configure AF for specific usage (We can have a very fast, but less\n> precise auto-focus or the other way). This is probably more connected\n> to your second question, whether we should include algorithms\n> configuration in the sensor tuning file at all.\n>\n\nI had a chat with the rest of the group about this and I was pointed\nto two things:\n- we already have lens-specific data in the LSC tables\n- we'll have to move to a \"camera module\" configuration file sooner\n than later, so it is acceptable to have these information here\n\nSo, for the time being, I think it's fine to have the settings here!\n\nI guess this mean\nReviewed-by: Jacopo Mondi \n\nThanks!\n\n> > > + - Agc:\n> > > + - Awb:\n> > > + - BlackLevelCorrection:\n> > > + - ColorProcessing:\n> >\n> > To be honest, I wonder if it was a good idea to list what algorithms\n> > to enable in the sensor tuning file.\n> >\n> > The decision of what algorithms to use, and possibly any tuning data\n> > associated with them, are maybe properties that need to be associated to\n> > a global device tuning file. But that's not a discussion that should\n> > block this series.\n>\n> Currently, all the tuning is done in the IPA algorithms, so it\n> would be difficult to distinguish which paramters should go to which\n> file.\n>\n> Best regards\n> Daniel\n>\n> >\n> > Thanks\n> > j\n> >\n> > > +...\n> > > --\n> > > 2.39.0\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FFAEBEFBE\n\tfor ;\n\tTue, 7 Feb 2023 15:33:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42BC8625E3;\n\tTue, 7 Feb 2023 16:33:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52E29625DF\n\tfor ;\n\tTue, 7 Feb 2023 16:33:36 +0100 (CET)","from ideasonboard.com (host-79-35-57-126.retail.telecomitalia.it\n\t[79.35.57.126])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9828E4AF;\n\tTue, 7 Feb 2023 16:33:35 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675784018;\n\tbh=eV2U+pjzLKBh2XFOJg6KGOMfa1G/SelUuaCljQdpUEk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0iPvtqMmrJQI5yKNm00DMXygttznqmPA9cTdRoJyRV8dC8Xl9yazXgk7b7w+owTuv\n\tGnYcf0CEXbAX3MnGjG8PK412zf/Y6gKv/sIurmWT0N6wxj3uZo/LnmoSrf555jScUk\n\tCAwUUbSGcFXNv2RK9ZHfffYgAzC2PncLbHv2daDPO/HfTM01ao/QD0xmOvH2JUs/BS\n\teC/3CiWyGpeMVaC5DmDB4edzaDjl7aoThj9/Uh3bpoq5x7XjsRRqL4BVCV1TXLU48Y\n\tGArchChIyLEYXlj9loJzorlug5+AIeGRn2/eovLRhhxhA9mMaqs5iBfoa4mJ9K8ep5\n\trjk0/gr4UqNSA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675784015;\n\tbh=eV2U+pjzLKBh2XFOJg6KGOMfa1G/SelUuaCljQdpUEk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Pccqe5kqItuCHAH1hBz+SiPj173QyNeofrxWlqG0IgIyvZ0SAKUt4UaL/83ln56XW\n\tWbTYphb+4YBeq/pV3bieMfBCSbuYC9mdOfgtBMyQZNOAC1HEero9IwSYqdQFtBV6CR\n\tBkjk4RJONRSaaNWM3TGP+6mI5HmsIID89f1j8VGc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Pccqe5kq\"; dkim-atps=neutral","Date":"Tue, 7 Feb 2023 16:33:32 +0100","To":"Daniel Semkowicz ","Message-ID":"<20230207153332.ygecswfnlavndppo@uno.localdomain>","References":"<20230119084112.20564-1-dse@thaumatec.com>\n\t<20230119084112.20564-9-dse@thaumatec.com>\n\t<20230206091212.elpzeagurxg4wmob@uno.localdomain>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v3 8/8] ipa: rkisp1: Add OV5675 tuning\n\tfile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]