[{"id":2453,"web_url":"https://patchwork.libcamera.org/comment/2453/","msgid":"<20190817155424.GC22846@wyvern>","date":"2019-08-17T15:54:24","subject":"Re: [libcamera-devel] [PATCH 2/5] libcamera: controls: Add camera\n\tlocation control","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2019-08-17 12:59:34 +0200, Jacopo Mondi wrote:\n> Define a new libcamera control used to specify the camera location.\n> Provide an enumeration of possible values to describe the \"front\",\n> \"back\" and \"external\" camera locations.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/control_ids.h | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h\n> index 75b6a2d5cafe..97ba11ec5f7b 100644\n> --- a/include/libcamera/control_ids.h\n> +++ b/include/libcamera/control_ids.h\n> @@ -12,6 +12,12 @@\n> \n> namespace libcamera {\n> \n> +enum CameraLocation {\n\nDo we need a CAMERA_LOCATION_UNKNOWN to handle cases where this \ninformation is not available?\n\n> +\tCAMERA_LOCATION_FRONT,\n> +\tCAMERA_LOCATION_BACK,\n> +\tCAMERA_LOCATION_EXTERNAL,\n> +};\n> +\n> enum ControlId {\n> \tAwbEnable,\n> \tBrightness,\n> @@ -19,6 +25,7 @@ enum ControlId {\n> \tSaturation,\n> \tManualExposure,\n> \tManualGain,\n> +\tLocation,\n> };\n> \n> } /* namespace libcamera */\n> -- \n> 2.22.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-ed1-x543.google.com (mail-ed1-x543.google.com\n\t[IPv6:2a00:1450:4864:20::543])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2FC5B600F9\n\tfor ;\n\tSat, 17 Aug 2019 17:54:27 +0200 (CEST)","by mail-ed1-x543.google.com with SMTP id s15so7638376edx.0\n\tfor ;\n\tSat, 17 Aug 2019 08:54:27 -0700 (PDT)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\th13sm626241edw.78.2019.08.17.08.54.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 17 Aug 2019 08:54:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=+BwXN8Mh3WGRAEhbWOwUk1vsqTkSBgesKTYsVz/8x2w=;\n\tb=zgEeA5xQYGjsjLNrIUXpAx31MpyxExitYiK4pEHvdU7zKwMJMmbGtYYalxxnNORKCa\n\tNFwNe6evlZ+1bayYl109OX8Q8SRgUtMEq0r7WPdbkKCFy89vSoeTopnPTpAtsjogkuja\n\tXryclsSQODBQzthumSncw4zHtu3houKLA+gk5xS1It1dWpvb1g6cof7lhLm2p9bitKlK\n\tXh3QQJE9xebqhIdwsTf7D7L5FdrKhkl2LTwE3bGmNWBZ1MW1t3NZyzM/hFUuWLktcDuZ\n\twv1MpWktxwb9x/QbdcXlDTvYWtN4RyJk4GiN3xYCfTTrFxS5lOinjqTTNVyD0POVFlJV\n\tcJZg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=+BwXN8Mh3WGRAEhbWOwUk1vsqTkSBgesKTYsVz/8x2w=;\n\tb=D7Qv6cCuUm0tj5Ag6MoCvqwDE883gpY5VHNpZDSg87WB0I+g+68/Yj06l4VJq1qKUi\n\tE7CenMEMsk2LamJnLt/5xdVE6mO9jD635S+L9uiloKzsOcwn2bLcQ3COP/8wNsC4RpDy\n\tLZ/gDv7NGmnKKvwROxuRBEhd53wkLaM7vCE97rX/1dSYbxeUZKviyLlwKF1ht+BMBUIg\n\tmJxBlJKiKzrQHtJQpWZKck9v/WAgD9mUlw7jdWy55wthtl4gdEEsmaaeg+0UujuTVX0K\n\tJzPcW2atzfrgcLkrTgIW/0aLzpMPjLN6RpKsYnDAnwuHu55eEuhsnW6fdBq0KaRZUDPE\n\tTpsA==","X-Gm-Message-State":"APjAAAXa0COMrOP6CQhXJA+5DqZTaCOOD5rXYKj/bdKs2YJJp0RNcL+C\n\tQw5lIRNeW7HaPVe6Eqi7N2aaNw==","X-Google-Smtp-Source":"APXvYqxooyZstefAZRrcx/E6nfi746+SkbpaaJ9z2wGClc8fyTNkAcPWLmTifbNKUIuybaKzeZGvwA==","X-Received":"by 2002:a17:906:8297:: with SMTP id\n\th23mr14217061ejx.1.1566057266825; \n\tSat, 17 Aug 2019 08:54:26 -0700 (PDT)","Date":"Sat, 17 Aug 2019 17:54:24 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190817155424.GC22846@wyvern>","References":"<20190817105937.29353-1-jacopo@jmondi.org>\n\t<20190817105937.29353-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190817105937.29353-3-jacopo@jmondi.org>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 2/5] libcamera: controls: Add camera\n\tlocation control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 17 Aug 2019 15:54:27 -0000"}},{"id":2454,"web_url":"https://patchwork.libcamera.org/comment/2454/","msgid":"<20190817155658.GD15630@pendragon.ideasonboard.com>","date":"2019-08-17T15:56:58","subject":"Re: [libcamera-devel] [PATCH 2/5] libcamera: controls: Add camera\n\tlocation control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Sat, Aug 17, 2019 at 05:54:24PM +0200, Niklas Söderlund wrote:\n> On 2019-08-17 12:59:34 +0200, Jacopo Mondi wrote:\n> > Define a new libcamera control used to specify the camera location.\n> > Provide an enumeration of possible values to describe the \"front\",\n> > \"back\" and \"external\" camera locations.\n> > \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > include/libcamera/control_ids.h | 7 +++++++\n> > 1 file changed, 7 insertions(+)\n> > \n> > diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h\n> > index 75b6a2d5cafe..97ba11ec5f7b 100644\n> > --- a/include/libcamera/control_ids.h\n> > +++ b/include/libcamera/control_ids.h\n> > @@ -12,6 +12,12 @@\n> > \n> > namespace libcamera {\n> > \n> > +enum CameraLocation {\n> \n> Do we need a CAMERA_LOCATION_UNKNOWN to handle cases where this \n> information is not available?\n\nThat, or move CAMERA_LOCATION_EXTERNAL as the first entry and use it as\na default.\n\nI don't like UNKNOWN much as it gives a way for pipeline handler authors\nto be lazy and \"fix this later\".\n\n> > +\tCAMERA_LOCATION_FRONT,\n> > +\tCAMERA_LOCATION_BACK,\n> > +\tCAMERA_LOCATION_EXTERNAL,\n> > +};\n\nI'm afraid I'll ask you to document CameraLocation and the new Location\nproperty :-)\n\n> > +\n> > enum ControlId {\n> > \tAwbEnable,\n> > \tBrightness,\n> > @@ -19,6 +25,7 @@ enum ControlId {\n> > \tSaturation,\n> > \tManualExposure,\n> > \tManualGain,\n> > +\tLocation,\n\nShould we move this to a new PropertyId enum ?\n\n> > };\n> > \n> > } /* namespace libcamera */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B85F8600F9\n\tfor ;\n\tSat, 17 Aug 2019 17:57:03 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 241A4556;\n\tSat, 17 Aug 2019 17:57:03 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566057423;\n\tbh=buVr1NWiABaKGAU8T70yuFYOnk2gSVdSjC+k3sgB22k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dmTPBchETMI9Ivs4oSpRxE/LDiBahitoDIKqlJiXPQYGS46aYxCsymBJ7YF0TmLK4\n\tsXx7FzjO6nYgR+lpTqBTPgttImdR8nbhDAGj75Sh1ZR7BvIm8kAEtrs7ICrPIQaCwl\n\t6xLHzwn/JMOE1bUDrvqqYQINyZYzGyZKLZNu7w+k=","Date":"Sat, 17 Aug 2019 18:56:58 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"Niklas =?utf-8?q?S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20190817155658.GD15630@pendragon.ideasonboard.com>","References":"<20190817105937.29353-1-jacopo@jmondi.org>\n\t<20190817105937.29353-3-jacopo@jmondi.org>\n\t<20190817155424.GC22846@wyvern>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190817155424.GC22846@wyvern>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/5] libcamera: controls: Add camera\n\tlocation control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 17 Aug 2019 15:57:03 -0000"}},{"id":2464,"web_url":"https://patchwork.libcamera.org/comment/2464/","msgid":"<20190819072943.qlmztlcdzuamub4u@uno.localdomain>","date":"2019-08-19T07:29:43","subject":"Re: [libcamera-devel] [PATCH 2/5] libcamera: controls: Add camera\n\tlocation control","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent, Niklas,\n\nOn Sat, Aug 17, 2019 at 06:56:58PM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Sat, Aug 17, 2019 at 05:54:24PM +0200, Niklas Söderlund wrote:\n> > On 2019-08-17 12:59:34 +0200, Jacopo Mondi wrote:\n> > > Define a new libcamera control used to specify the camera location.\n> > > Provide an enumeration of possible values to describe the \"front\",\n> > > \"back\" and \"external\" camera locations.\n> > >\n> > > Signed-off-by: Jacopo Mondi \n> > > ---\n> > > include/libcamera/control_ids.h | 7 +++++++\n> > > 1 file changed, 7 insertions(+)\n> > >\n> > > diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h\n> > > index 75b6a2d5cafe..97ba11ec5f7b 100644\n> > > --- a/include/libcamera/control_ids.h\n> > > +++ b/include/libcamera/control_ids.h\n> > > @@ -12,6 +12,12 @@\n> > >\n> > > namespace libcamera {\n> > >\n> > > +enum CameraLocation {\n> >\n> > Do we need a CAMERA_LOCATION_UNKNOWN to handle cases where this\n> > information is not available?\n>\n> That, or move CAMERA_LOCATION_EXTERNAL as the first entry and use it as\n> a default.\n>\n> I don't like UNKNOWN much as it gives a way for pipeline handler authors\n> to be lazy and \"fix this later\".\n\nI agree, I would not provide a way to skip providing the camera\nlocation by setting it to unknown.\n\n>\n> > > +\tCAMERA_LOCATION_FRONT,\n> > > +\tCAMERA_LOCATION_BACK,\n> > > +\tCAMERA_LOCATION_EXTERNAL,\n> > > +};\n>\n> I'm afraid I'll ask you to document CameraLocation and the new Location\n> property :-)\n\nAh yes indeed. I'll add documentation in controls.cpp\n\n>\n> > > +\n> > > enum ControlId {\n> > > \tAwbEnable,\n> > > \tBrightness,\n> > > @@ -19,6 +25,7 @@ enum ControlId {\n> > > \tSaturation,\n> > > \tManualExposure,\n> > > \tManualGain,\n> > > +\tLocation,\n>\n> Should we move this to a new PropertyId enum ?\n>\n\nWould you keep controls and property separated? I'm debated... Looking\nat android metadata tags, most of the controls have an associated\n'controlAvailble' static property assigned and I wonder if that's a\ngood idea or we can re-use the same id but in different context...\n\nFor sure Location would not be something that application could change with\na control.\n\n> > > };\n> > >\n> > > } /* namespace libcamera */\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB49260E38\n\tfor ;\n\tMon, 19 Aug 2019 09:28:21 +0200 (CEST)","from uno.localdomain (unknown [87.18.63.98])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 9F04C1C0007;\n\tMon, 19 Aug 2019 07:28:19 +0000 (UTC)"],"X-Originating-IP":"87.18.63.98","Date":"Mon, 19 Aug 2019 09:29:43 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"Niklas =?utf-8?q?S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20190819072943.qlmztlcdzuamub4u@uno.localdomain>","References":"<20190817105937.29353-1-jacopo@jmondi.org>\n\t<20190817105937.29353-3-jacopo@jmondi.org>\n\t<20190817155424.GC22846@wyvern>\n\t<20190817155658.GD15630@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"czpzmeudsesqd2wt\"","Content-Disposition":"inline","In-Reply-To":"<20190817155658.GD15630@pendragon.ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 2/5] libcamera: controls: Add camera\n\tlocation control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 19 Aug 2019 07:28:22 -0000"}},{"id":2482,"web_url":"https://patchwork.libcamera.org/comment/2482/","msgid":"<20190819132525.GC5011@pendragon.ideasonboard.com>","date":"2019-08-19T13:25:25","subject":"Re: [libcamera-devel] [PATCH 2/5] libcamera: controls: Add camera\n\tlocation control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Aug 19, 2019 at 09:29:43AM +0200, Jacopo Mondi wrote:\n> On Sat, Aug 17, 2019 at 06:56:58PM +0300, Laurent Pinchart wrote:\n> > On Sat, Aug 17, 2019 at 05:54:24PM +0200, Niklas Söderlund wrote:\n> > > On 2019-08-17 12:59:34 +0200, Jacopo Mondi wrote:\n> > > > Define a new libcamera control used to specify the camera location.\n> > > > Provide an enumeration of possible values to describe the \"front\",\n> > > > \"back\" and \"external\" camera locations.\n> > > >\n> > > > Signed-off-by: Jacopo Mondi \n> > > > ---\n> > > > include/libcamera/control_ids.h | 7 +++++++\n> > > > 1 file changed, 7 insertions(+)\n> > > >\n> > > > diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h\n> > > > index 75b6a2d5cafe..97ba11ec5f7b 100644\n> > > > --- a/include/libcamera/control_ids.h\n> > > > +++ b/include/libcamera/control_ids.h\n> > > > @@ -12,6 +12,12 @@\n> > > >\n> > > > namespace libcamera {\n> > > >\n> > > > +enum CameraLocation {\n> > >\n> > > Do we need a CAMERA_LOCATION_UNKNOWN to handle cases where this\n> > > information is not available?\n> >\n> > That, or move CAMERA_LOCATION_EXTERNAL as the first entry and use it as\n> > a default.\n> >\n> > I don't like UNKNOWN much as it gives a way for pipeline handler authors\n> > to be lazy and \"fix this later\".\n> \n> I agree, I would not provide a way to skip providing the camera\n> location by setting it to unknown.\n> \n> > > > +\tCAMERA_LOCATION_FRONT,\n> > > > +\tCAMERA_LOCATION_BACK,\n> > > > +\tCAMERA_LOCATION_EXTERNAL,\n> > > > +};\n> >\n> > I'm afraid I'll ask you to document CameraLocation and the new Location\n> > property :-)\n> \n> Ah yes indeed. I'll add documentation in controls.cpp\n> \n> > > > +\n> > > > enum ControlId {\n> > > > \tAwbEnable,\n> > > > \tBrightness,\n> > > > @@ -19,6 +25,7 @@ enum ControlId {\n> > > > \tSaturation,\n> > > > \tManualExposure,\n> > > > \tManualGain,\n> > > > +\tLocation,\n> >\n> > Should we move this to a new PropertyId enum ?\n> \n> Would you keep controls and property separated? I'm debated... Looking\n> at android metadata tags, most of the controls have an associated\n> 'controlAvailble' static property assigned and I wonder if that's a\n> good idea or we can re-use the same id but in different context...\n\nAndroid has decided to build everything around a single metadata\nconcept, I assume to give easy serialisation. I don't think we have to\ndo the same. The data structures underlying controls and properties\nshould be the same, with the same serialisation format, but I think it\nwould make sense to keep the definition of controls and properties\nseparate, as they're not the same.\n\n> For sure Location would not be something that application could change with\n> a control.\n> \n> > > > };\n> > > >\n> > > > } /* namespace libcamera */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8DD660C1E\n\tfor ;\n\tMon, 19 Aug 2019 15:25:31 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 53D5C510;\n\tMon, 19 Aug 2019 15:25:31 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1566221131;\n\tbh=T063tDgW518SxCsbV88EzxxYKaRrehLJ8RhWyWsb3bY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Sptr0QfW8blyW9b8YIwGP+rxNNNkqVeyWg+DHdEoJoCC9wp15/8Wr/yfzSyA4XIb1\n\tXGg62mLG6sWEi957UcSvmxu7PZV7T2B6X4KgSTX1rkRqlfPVC2iC05UIU+J0NhZ6bY\n\tFfyjZDrvPimRlJxadUUQIMHAR0fzSoF8WDP64P38=","Date":"Mon, 19 Aug 2019 16:25:25 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"Niklas =?utf-8?q?S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20190819132525.GC5011@pendragon.ideasonboard.com>","References":"<20190817105937.29353-1-jacopo@jmondi.org>\n\t<20190817105937.29353-3-jacopo@jmondi.org>\n\t<20190817155424.GC22846@wyvern>\n\t<20190817155658.GD15630@pendragon.ideasonboard.com>\n\t<20190819072943.qlmztlcdzuamub4u@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190819072943.qlmztlcdzuamub4u@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/5] libcamera: controls: Add camera\n\tlocation control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 19 Aug 2019 13:25:32 -0000"}}]