[{"id":26283,"web_url":"https://patchwork.libcamera.org/comment/26283/","msgid":"<167421309247.42371.16142422438945998894@Monstersaurus>","date":"2023-01-20T11:11:32","subject":"Re: [libcamera-devel] [PATCH v5 09/12] pipeline: raspberrypi:\n\tValidate OptionalStream in queueRequestDevice()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2023-01-18 08:59:50)\n> Add some validation in queueRequestDevice() to ensure that a frame buffer is\n> provided in a Request if the MandatoryRequestBuffer flag has not been set in\n> the StreamConfiguration for every configured stream.\n\nI think this should be handled in the core. This shouldn't be pipeline\nspecific. We mustn't have different behaviours in different pipelines.\n\n(That's why it's important we get this right globally)\n\n--\nKieran\n\n \n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 13d0ab4c4968..39f48e0a57fb 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1153,6 +1153,13 @@ int PipelineHandlerRPi::queueRequestDevice(Camera *camera, Request *request)\n> stream->setExternalBuffer(buffer);\n> }\n> \n> + if (!(stream->configuration().hints & StreamConfiguration::Hint::OptionalStream) &&\n> + !buffer) {\n> + LOG(RPI, Error) << \"No buffer provided for mandatory stream \"\n> + << stream->name();\n> + return -EINVAL;\n> + }\n> +\n> /*\n> * If no buffer is provided by the request for this stream, we\n> * queue a nullptr to the stream to signify that it must use an\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDBD5BE175\n\tfor ;\n\tFri, 20 Jan 2023 11:11:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97689625E4;\n\tFri, 20 Jan 2023 12:11:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AE6061EFD\n\tfor ;\n\tFri, 20 Jan 2023 12:11:35 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 069BD514;\n\tFri, 20 Jan 2023 12:11:34 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674213096;\n\tbh=BrVCH+rjHbu/obnjgcL4tVad88eZzIqdXKHqoVQ/20Q=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=fox+PTvefPNHH641HtvihpZ2RCMSBpV8xKehUkjXEMxoZzp/uxUB68aE9XLBXwh2Q\n\t/1cB2V6GohCn7FDBjpFIJ+UsNGrHG0J7NHwld21DKYJro0WXO4f9d240wjuT31w+tw\n\tWWP/k1VotJobu1uwRvVEL6f0aklU6FLsj4vhwzWSjwWlHjJAmJv1xe3Td75WccZp2A\n\t3kxzHkW4J58ZxXJihDVswvpxi6nHWc15qgTxIMiCXs1PYldj7G1kRDux7XzgE8iz7r\n\tDhhE+Tqdhf+/M3/cPzKjnlX29iHZcOUO1lrubrvDrLEWanXtZFz1DWmlGQrmineo8N\n\tcMen4GV/I4JEw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674213095;\n\tbh=BrVCH+rjHbu/obnjgcL4tVad88eZzIqdXKHqoVQ/20Q=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=sc3NqMSBUSeELXP4PHPnXBCeRdSA99myxFEtF8c3+iSa4k+HltLbZcvG0+u+Gh1Dg\n\tiK6c66orNVS16eVZYSnhrn6bvnd6QWunfbKj3k8qSjry6ruvDz2jVvhL5ZjD7fuomr\n\tWWfWzjTxDN1ILVo7jBYIw5WCUO6FECyUySDLTdxY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"sc3NqMSB\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230118085953.7027-10-naush@raspberrypi.com>","References":"<20230118085953.7027-1-naush@raspberrypi.com>\n\t<20230118085953.7027-10-naush@raspberrypi.com>","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 20 Jan 2023 11:11:32 +0000","Message-ID":"<167421309247.42371.16142422438945998894@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v5 09/12] pipeline: raspberrypi:\n\tValidate OptionalStream in queueRequestDevice()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26312,"web_url":"https://patchwork.libcamera.org/comment/26312/","msgid":"","date":"2023-01-22T21:35:41","subject":"Re: [libcamera-devel] [PATCH v5 09/12] pipeline: raspberrypi:\n\tValidate OptionalStream in queueRequestDevice()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jan 20, 2023 at 11:11:32AM +0000, Kieran Bingham via libcamera-devel wrote:\n> Quoting Naushir Patuck via libcamera-devel (2023-01-18 08:59:50)\n> > Add some validation in queueRequestDevice() to ensure that a frame buffer is\n> > provided in a Request if the MandatoryRequestBuffer flag has not been set in\n> > the StreamConfiguration for every configured stream.\n> \n> I think this should be handled in the core. This shouldn't be pipeline\n> specific. We mustn't have different behaviours in different pipelines.\n\nAgreed. A test in lc-compliance would also be good.\n\n> (That's why it's important we get this right globally)\n> \n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 +++++++\n> > 1 file changed, 7 insertions(+)\n> > \n> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > index 13d0ab4c4968..39f48e0a57fb 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > @@ -1153,6 +1153,13 @@ int PipelineHandlerRPi::queueRequestDevice(Camera *camera, Request *request)\n> > stream->setExternalBuffer(buffer);\n> > }\n> > \n> > + if (!(stream->configuration().hints & StreamConfiguration::Hint::OptionalStream) &&\n> > + !buffer) {\n> > + LOG(RPI, Error) << \"No buffer provided for mandatory stream \"\n> > + << stream->name();\n> > + return -EINVAL;\n> > + }\n> > +\n> > /*\n> > * If no buffer is provided by the request for this stream, we\n> > * queue a nullptr to the stream to signify that it must use an","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55D0BBDB1D\n\tfor ;\n\tSun, 22 Jan 2023 21:35:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5FD5625E4;\n\tSun, 22 Jan 2023 22:35:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAB8A625DD\n\tfor ;\n\tSun, 22 Jan 2023 22:35:44 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 19ACA471;\n\tSun, 22 Jan 2023 22:35:43 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674423345;\n\tbh=rfV5nqxyKY12OLuE8PZPZi4t/HSZpMDksW5R+PnQy48=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ypetpZYyc070Ph/8Z3XzfhRkpGyTOp5SRe7buuPtYK90TnqhlTPLssJjA94ex0kMO\n\tre2ZR8BzVrvAd9AS5F/4VBWpFm3I55V0GQuDGfVh2zXsvKp49/ZqpOakqFOnBOBJ4m\n\tvZBVHPs1uP4m4qb+p9WPa7A0NBkQQJxiogTEjQ50MKsnmikDiHw7Vs5jOjyudFcLFf\n\tUQ45SmuFQXDxp527+9iJ/+mfwrRsEHBEXMfAocf6Em7aWTijMZFNq3yTLOyTl0CclD\n\tW6W5GqkpxCOrh5ULl7ReSBle5vMxd7lO+0cg3YtjRRrUNEK1IERsxLWWzSKCHxgxAn\n\tQ2hG+lxoL6GIA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674423344;\n\tbh=rfV5nqxyKY12OLuE8PZPZi4t/HSZpMDksW5R+PnQy48=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nwO6CPsT5RUUeZJ3LxDbRWp4toOwcnROoGPvlfVtrWcWVbKDT0v6DvI4H+4YG66Rf\n\tfu3LVvCd4vt2W4cER0y0zOerRtiOaRHCueqtrcTyMQoe6gd4hOxneuZnKm8ZvzgMIn\n\tlmlqQtD4bomlXsLctMEK+cYWBPB+YgP4b9Mkj3vI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nwO6CPsT\"; dkim-atps=neutral","Date":"Sun, 22 Jan 2023 23:35:41 +0200","To":"Kieran Bingham ","Message-ID":"","References":"<20230118085953.7027-1-naush@raspberrypi.com>\n\t<20230118085953.7027-10-naush@raspberrypi.com>\n\t<167421309247.42371.16142422438945998894@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<167421309247.42371.16142422438945998894@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v5 09/12] pipeline: raspberrypi:\n\tValidate OptionalStream in queueRequestDevice()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26352,"web_url":"https://patchwork.libcamera.org/comment/26352/","msgid":"","date":"2023-01-25T14:11:31","subject":"Re: [libcamera-devel] [PATCH v5 09/12] pipeline: raspberrypi:\n\tValidate OptionalStream in queueRequestDevice()","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent and Kieran,\n\nOn Sun, 22 Jan 2023 at 21:35, Laurent Pinchart\n wrote:\n>\n> On Fri, Jan 20, 2023 at 11:11:32AM +0000, Kieran Bingham via libcamera-devel wrote:\n> > Quoting Naushir Patuck via libcamera-devel (2023-01-18 08:59:50)\n> > > Add some validation in queueRequestDevice() to ensure that a frame buffer is\n> > > provided in a Request if the MandatoryRequestBuffer flag has not been set in\n> > > the StreamConfiguration for every configured stream.\n> >\n> > I think this should be handled in the core. This shouldn't be pipeline\n> > specific. We mustn't have different behaviours in different pipelines.\n>\n> Agreed. A test in lc-compliance would also be good.\n\nWill add this test to lc-compliance. As noted earlier, this may take some time\nas I need to work my way round this app and first add multi-stream support.\n\nNaush\n\n>\n> > (That's why it's important we get this right globally)\n> >\n> > > Signed-off-by: Naushir Patuck \n> > > ---\n> > > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 +++++++\n> > > 1 file changed, 7 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > > index 13d0ab4c4968..39f48e0a57fb 100644\n> > > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > > @@ -1153,6 +1153,13 @@ int PipelineHandlerRPi::queueRequestDevice(Camera *camera, Request *request)\n> > > stream->setExternalBuffer(buffer);\n> > > }\n> > >\n> > > + if (!(stream->configuration().hints & StreamConfiguration::Hint::OptionalStream) &&\n> > > + !buffer) {\n> > > + LOG(RPI, Error) << \"No buffer provided for mandatory stream \"\n> > > + << stream->name();\n> > > + return -EINVAL;\n> > > + }\n> > > +\n> > > /*\n> > > * If no buffer is provided by the request for this stream, we\n> > > * queue a nullptr to the stream to signify that it must use an\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF611BDB1D\n\tfor ;\n\tWed, 25 Jan 2023 14:11:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECA85625E4;\n\tWed, 25 Jan 2023 15:11:49 +0100 (CET)","from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com\n\t[IPv6:2607:f8b0:4864:20::b35])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7014B603C0\n\tfor ;\n\tWed, 25 Jan 2023 15:11:48 +0100 (CET)","by mail-yb1-xb35.google.com with SMTP id d132so1584197ybb.5\n\tfor ;\n\tWed, 25 Jan 2023 06:11:48 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674655909;\n\tbh=LO2MIVMmh2kVDfOsfOzuPPAv2SojGdNUFcY2zqK7ams=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=HNVXX3V507F9O7hvlBvf8P2FOQn3ecTJHe1ASYpa/KdBm8u/NsCQsId6HaC7aZbuJ\n\tqjjQbMEROTi1HZpwrd11MQBpJi5flOdhmrH0CYfHS7nV+DMzgWzT6wKdrKifFx3LLW\n\tOppoR2oLJSY74cltWftf1URCRs+I34w4kMU2kFOCzcREPv295dgbJGpdEp8ulsCkRT\n\tbjzVbzowdTWUWFmYQR0nfFnR8MBPWEf1+L+dKYKGbIFbI9L17Gqjdvk4ww2TLFuRBe\n\tsPVvZ2Sj+p4z5aPAiYq9MeoHJ80Q58S6fShKQ3o+uQsFPomraBSmbqgUTCaMmj27Gt\n\t6JqUX0We/V8mA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=AEfznftElgGmCYZfY1xgR6GIl07e01HhtWpsGFnX6dk=;\n\tb=R1AhD+vtmEueyynyI9/YrQ3BApMVh21eK4wI8r05+hzIeTVqvou+gMMql38D1kcqGV\n\tw6JkuZfBHxjuqZGsXo8Tm+UwzQkufnNCoaV4OB383oX1vSyoWTeTLM+oLrzvB2YhcaHg\n\txeWibvcnbQTKRacv9+b7ckGAqwKOXWrF7NZP6oW1bm2fC7YZmCD4OCUQPOJGr1jYmgSN\n\theEL0ZfZEMCsV+6i78sfxeZlex+N6p+uPakg7mpEpD86PoItyH7xiATPx3bNE91JNyvA\n\tVti0OZNNkW9hTmV+q9EcJPv+I0sSaFoVhKiOjnTohnpbqaDbwKSE32ZNNVcksQ5rDVR2\n\tWyPA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"R1AhD+vt\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=AEfznftElgGmCYZfY1xgR6GIl07e01HhtWpsGFnX6dk=;\n\tb=x0LxQwa9v9hw+YlgFqbObGZcmUNVovCLSqdl1EMleygvbm/4rv6KLpcpS9I6RkYpec\n\t5HrRjgjHPxsOHwgojALUe5IODImYIYM2oQxoNzPO6WfZ9xpXKuJ+8PLZO/lShEPguCPl\n\tvtefch5kbyiUnpqk+K1VnH2xITMiqFRIT3Qv4wOm5ODBbbuSNr38GEQSOPUA822cdvKD\n\trVWA97cha2vnLOW343hBOK8aIJ82Qdou2U9vCmxt2zHpFiIkpPqCViKB5zvmZQUE8YyA\n\t4SmQugpVcA7rLaHgs31pf9AUczWLm4xNYHRREguoF6D2S2VQB+/wt/iYGEEIntYOXUbe\n\t6JlQ==","X-Gm-Message-State":"AFqh2kqEgtnYAl0w3oj+sy5yAISRJncnctEQkN4XXvOyxBiFTD3rUU0w\n\tL2aGIpw+yDPbz2m19lQSlJkoOXygicwqsMYlmNAFGFPRuh9gqYnRX00=","X-Google-Smtp-Source":"AMrXdXsHS7+RM/8LgipXf2UcvWbCyBfZwoM7XNwvl/7ZzrUAxHvqEuF2Vbo5yvoBhY+GlrvEXeImqbCL7sMsRoqkYNg=","X-Received":"by 2002:a25:7583:0:b0:783:bc5e:3d67 with SMTP id\n\tq125-20020a257583000000b00783bc5e3d67mr2501206ybc.524.1674655907109;\n\tWed, 25 Jan 2023 06:11:47 -0800 (PST)","MIME-Version":"1.0","References":"<20230118085953.7027-1-naush@raspberrypi.com>\n\t<20230118085953.7027-10-naush@raspberrypi.com>\n\t<167421309247.42371.16142422438945998894@Monstersaurus>\n\t","In-Reply-To":"","Date":"Wed, 25 Jan 2023 14:11:31 +0000","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v5 09/12] pipeline: raspberrypi:\n\tValidate OptionalStream in queueRequestDevice()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]