[{"id":26282,"web_url":"https://patchwork.libcamera.org/comment/26282/","msgid":"<167421299642.42371.14763888065145378951@Monstersaurus>","date":"2023-01-20T11:09:56","subject":"Re: [libcamera-devel] [PATCH v5 08/12] pipeline: raspberrypi:\n\tHandle OptionalStream hints for ISP Output0","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2023-01-18 08:59:49)\n> Look for OptionalStream flag in the hints field of the ISP Output0\n> StreamConfiguration structure. If this flag is not set, it guarantees that the\n> application will provide buffers for the ISP, do not allocate any internal\n> buffers for the device.\n> \n> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n\nIf this is the chosen orientation of the hint, then:\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  .../pipeline/raspberrypi/raspberrypi.cpp      | 29 ++++++++++++++-----\n>  1 file changed, 22 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 2b396f1db9b6..13d0ab4c4968 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1453,7 +1453,7 @@ int PipelineHandlerRPi::prepareBuffers(Camera *camera)\n>         RPiCameraData *data = cameraData(camera);\n>         unsigned int minUnicamBuffers = data->config_.minUnicamBuffers,\n>                      minTotalUnicamBuffers = data->config_.minTotalUnicamBuffers,\n> -                    numRawBuffers = 0;\n> +                    numRawBuffers = 0, minIspBuffers = 1;\n>         int ret;\n>  \n>         for (Stream *s : camera->streams()) {\n> @@ -1477,8 +1477,21 @@ int PipelineHandlerRPi::prepareBuffers(Camera *camera)\n>                                         minTotalUnicamBuffers = 0;\n>                                 }\n>                         }\n> -\n> -                       break;\n> +               } else if (s == &data->isp_[Isp::Output0]) {\n> +                       /*\n> +                        * Since the ISP runs synchronous with the IPA and requests,\n> +                        * we only ever need a maximum of one internal buffer. Any\n> +                        * buffers the application wants to hold onto will already\n> +                        * be exported through PipelineHandlerRPi::exportFrameBuffers().\n> +                        *\n> +                        * However, as above, if the application provides a guarantee\n> +                        * that the buffer will always be provided for the ISP Output0\n> +                        * stream in a Request, we don't need any internal buffers\n> +                        * allocated.\n> +                        */\n> +                       if (!(s->configuration().hints & StreamConfiguration::Hint::OptionalStream) &&\n> +                           !data->dropFrameCount_)\n> +                               minIspBuffers = 0;\n>                 }\n>         }\n>  \n> @@ -1514,12 +1527,14 @@ int PipelineHandlerRPi::prepareBuffers(Camera *camera)\n>                          * so allocate the minimum required to avoid frame drops.\n>                          */\n>                         numBuffers = data->config_.minTotalUnicamBuffers;\n> +               } else if (stream == &data->isp_[Isp::Output0]) {\n> +                       /* Buffer count for this is handled in the earlier loop above. */\n> +                       numBuffers = minIspBuffers;\n>                 } else {\n>                         /*\n> -                        * Since the ISP runs synchronous with the IPA and requests,\n> -                        * we only ever need one set of internal buffers. Any buffers\n> -                        * the application wants to hold onto will already be exported\n> -                        * through PipelineHandlerRPi::exportFrameBuffers().\n> +                        * Same reasoning as for ISP Output 0, we only ever need\n> +                        * a maximum of one internal buffer for Output1 (required\n> +                        * for colour denoise) and ISP statistics.\n>                          */\n>                         numBuffers = 1;\n>                 }\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94DB2BE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 20 Jan 2023 11:10:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3E2D625E4;\n\tFri, 20 Jan 2023 12:10:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4DBCA61EFD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 Jan 2023 12:09:59 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9CF1514;\n\tFri, 20 Jan 2023 12:09:58 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674213000;\n\tbh=rilB87GHOPNv0mYlBIhe4VrIiFHUqJsqC7fZiE9Exxk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=SGrVsmpjCFbay6TfZshfJ3ty6TgmPws04IfIPhYEqNffBjSO8Cs3FUEu9HjC9rVhA\n\tzAdUfv7HUFjpde284lyzsAcHoEr1KrVG2sLHhrdbT3wATzGe5yowe6Z2YxJEYL2a2H\n\tKSZnbcxEAC+BU39tH7LSeAu75ZsE+1Ah3ictN/vIoUbRt/8Dje288TKS9urLAPUuf8\n\tL/FyUXNy1GrHUqZRtvhuJnGZhRjpuC8eyAbud57V9XlwEeR9LxfDP2/5gOL4PyNvul\n\tcYvuLvr4ejZ8BKdSYPft3Ya66dBUp6MXNBulRxAxMAgsAJKBQ0JNO5OEcw3uzuD6Lh\n\tjCakNZmm1otfw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674212998;\n\tbh=rilB87GHOPNv0mYlBIhe4VrIiFHUqJsqC7fZiE9Exxk=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=VZ2h6106PSd19Lg9tBUIH/0m4itUz65NDSfT34YmIiEzFdtF2PzpltEAuDQt39q4e\n\tniZl82R5+sSQEW91qacIJqNXy3BsVEazK+SNxzGSOWWv5k8KDSBi/XN/Y4haXCd2Tz\n\t6CKrzpCVFXCstCHOzsh3Ttr6eqc63rb31t5m+7P8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VZ2h6106\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230118085953.7027-9-naush@raspberrypi.com>","References":"<20230118085953.7027-1-naush@raspberrypi.com>\n\t<20230118085953.7027-9-naush@raspberrypi.com>","To":"Naushir Patuck <naush@raspberrypi.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 20 Jan 2023 11:09:56 +0000","Message-ID":"<167421299642.42371.14763888065145378951@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v5 08/12] pipeline: raspberrypi:\n\tHandle OptionalStream hints for ISP Output0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":26315,"web_url":"https://patchwork.libcamera.org/comment/26315/","msgid":"<Y828nS+5NkMMGPMd@pendragon.ideasonboard.com>","date":"2023-01-22T22:45:49","subject":"Re: [libcamera-devel] [PATCH v5 08/12] pipeline: raspberrypi:\n\tHandle OptionalStream hints for ISP Output0","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Wed, Jan 18, 2023 at 08:59:49AM +0000, Naushir Patuck via libcamera-devel wrote:\n> Look for OptionalStream flag in the hints field of the ISP Output0\n> StreamConfiguration structure. If this flag is not set, it guarantees that the\n> application will provide buffers for the ISP, do not allocate any internal\n> buffers for the device.\n> \n> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> ---\n>  .../pipeline/raspberrypi/raspberrypi.cpp      | 29 ++++++++++++++-----\n>  1 file changed, 22 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 2b396f1db9b6..13d0ab4c4968 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1453,7 +1453,7 @@ int PipelineHandlerRPi::prepareBuffers(Camera *camera)\n>  \tRPiCameraData *data = cameraData(camera);\n>  \tunsigned int minUnicamBuffers = data->config_.minUnicamBuffers,\n>  \t\t     minTotalUnicamBuffers = data->config_.minTotalUnicamBuffers,\n> -\t\t     numRawBuffers = 0;\n> +\t\t     numRawBuffers = 0, minIspBuffers = 1;\n\nOne variable per line.\n\n>  \tint ret;\n>  \n>  \tfor (Stream *s : camera->streams()) {\n> @@ -1477,8 +1477,21 @@ int PipelineHandlerRPi::prepareBuffers(Camera *camera)\n>  \t\t\t\t\tminTotalUnicamBuffers = 0;\n>  \t\t\t\t}\n>  \t\t\t}\n> -\n> -\t\t\tbreak;\n> +\t\t} else if (s == &data->isp_[Isp::Output0]) {\n> +\t\t\t/*\n> +\t\t\t * Since the ISP runs synchronous with the IPA and requests,\n> +\t\t\t * we only ever need a maximum of one internal buffer. Any\n> +\t\t\t * buffers the application wants to hold onto will already\n> +\t\t\t * be exported through PipelineHandlerRPi::exportFrameBuffers().\n> +\t\t\t *\n> +\t\t\t * However, as above, if the application provides a guarantee\n> +\t\t\t * that the buffer will always be provided for the ISP Output0\n> +\t\t\t * stream in a Request, we don't need any internal buffers\n> +\t\t\t * allocated.\n> +\t\t\t */\n> +\t\t\tif (!(s->configuration().hints & StreamConfiguration::Hint::OptionalStream) &&\n> +\t\t\t    !data->dropFrameCount_)\n> +\t\t\t\tminIspBuffers = 0;\n>  \t\t}\n>  \t}\n>  \n> @@ -1514,12 +1527,14 @@ int PipelineHandlerRPi::prepareBuffers(Camera *camera)\n>  \t\t\t * so allocate the minimum required to avoid frame drops.\n>  \t\t\t */\n>  \t\t\tnumBuffers = data->config_.minTotalUnicamBuffers;\n> +\t\t} else if (stream == &data->isp_[Isp::Output0]) {\n> +\t\t\t/* Buffer count for this is handled in the earlier loop above. */\n> +\t\t\tnumBuffers = minIspBuffers;\n>  \t\t} else {\n>  \t\t\t/*\n> -\t\t\t * Since the ISP runs synchronous with the IPA and requests,\n> -\t\t\t * we only ever need one set of internal buffers. Any buffers\n> -\t\t\t * the application wants to hold onto will already be exported\n> -\t\t\t * through PipelineHandlerRPi::exportFrameBuffers().\n> +\t\t\t * Same reasoning as for ISP Output 0, we only ever need\n> +\t\t\t * a maximum of one internal buffer for Output1 (required\n> +\t\t\t * for colour denoise) and ISP statistics.\n>  \t\t\t */\n>  \t\t\tnumBuffers = 1;\n\nDo you plan to also optimize the buffer allocation based on hints for\nOutput1 ?\n\n>  \t\t}","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2682BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 22 Jan 2023 22:45:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39CA0625E4;\n\tSun, 22 Jan 2023 23:45:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA87C625DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 22 Jan 2023 23:45:51 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 47F40471;\n\tSun, 22 Jan 2023 23:45:51 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674427553;\n\tbh=pLzac2oHFIMut99spjYHyEgWSE9ZCamY/XcPTujDuag=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZZHT1RJw77apQcCaz2CeXgPB5NSxes3tBMjoxAPNW2zxkh6CVE15Eq9GB+G/pvoHx\n\tuGnT/6FhuksPUaK4CIiVTCNA+VbaFxT2ApWth7jd7DiN1AdpHAGhLOBJUsts/M5FLy\n\tXT3atL74gb1deAeQ7CFxpy64TKqkQjwdZgTUTsh0YvnyP40FdSCEHqsqd1N0uchFE6\n\t2QlCnXfQJEqGgfJnMCKWSRguL8dHDty/dF89VisAQPZiH6QpwL24rKh5o3Rl4B2vqM\n\tOTF32nvGt4HKmqIhs5khMCrzGyHwNDuNCacRTMjqIMLK4eyI2wICUVWxedt1GBJF8z\n\t6J7Uf2FRqRTvA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674427551;\n\tbh=pLzac2oHFIMut99spjYHyEgWSE9ZCamY/XcPTujDuag=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UqbX5woxgyBJ/XrzICRChCvBtELIbSvXYfcc363l5jvNB+2at/NR3iUAu9MVlrBo8\n\tYsQEjyXezdlZN5j8CZ0Iz2DhnBZupm4mKMDldgKiKbmFkSpNENrWUOFRgI91SpBlhM\n\tcoNkylLzqGCRMAqIY6x70WwqGlhkqIjCLsgNXD6k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UqbX5wox\"; dkim-atps=neutral","Date":"Mon, 23 Jan 2023 00:45:49 +0200","To":"Naushir Patuck <naush@raspberrypi.com>","Message-ID":"<Y828nS+5NkMMGPMd@pendragon.ideasonboard.com>","References":"<20230118085953.7027-1-naush@raspberrypi.com>\n\t<20230118085953.7027-9-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230118085953.7027-9-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v5 08/12] pipeline: raspberrypi:\n\tHandle OptionalStream hints for ISP Output0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":26351,"web_url":"https://patchwork.libcamera.org/comment/26351/","msgid":"<CAEmqJPqE8XktOTvkCfruNcU3FVv+N-pkD92N-aFi2=eJgy2Egw@mail.gmail.com>","date":"2023-01-25T13:07:51","subject":"Re: [libcamera-devel] [PATCH v5 08/12] pipeline: raspberrypi:\n\tHandle OptionalStream hints for ISP Output0","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nThank you for your feedback.\n\nOn Sun, 22 Jan 2023 at 22:45, Laurent Pinchart\n<laurent.pinchart@ideasonboard.com> wrote:\n>\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Wed, Jan 18, 2023 at 08:59:49AM +0000, Naushir Patuck via libcamera-devel wrote:\n> > Look for OptionalStream flag in the hints field of the ISP Output0\n> > StreamConfiguration structure. If this flag is not set, it guarantees that the\n> > application will provide buffers for the ISP, do not allocate any internal\n> > buffers for the device.\n> >\n> > Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> > ---\n> >  .../pipeline/raspberrypi/raspberrypi.cpp      | 29 ++++++++++++++-----\n> >  1 file changed, 22 insertions(+), 7 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > index 2b396f1db9b6..13d0ab4c4968 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > @@ -1453,7 +1453,7 @@ int PipelineHandlerRPi::prepareBuffers(Camera *camera)\n> >       RPiCameraData *data = cameraData(camera);\n> >       unsigned int minUnicamBuffers = data->config_.minUnicamBuffers,\n> >                    minTotalUnicamBuffers = data->config_.minTotalUnicamBuffers,\n> > -                  numRawBuffers = 0;\n> > +                  numRawBuffers = 0, minIspBuffers = 1;\n>\n> One variable per line.\n\nAck.\n\n>\n> >       int ret;\n> >\n> >       for (Stream *s : camera->streams()) {\n> > @@ -1477,8 +1477,21 @@ int PipelineHandlerRPi::prepareBuffers(Camera *camera)\n> >                                       minTotalUnicamBuffers = 0;\n> >                               }\n> >                       }\n> > -\n> > -                     break;\n> > +             } else if (s == &data->isp_[Isp::Output0]) {\n> > +                     /*\n> > +                      * Since the ISP runs synchronous with the IPA and requests,\n> > +                      * we only ever need a maximum of one internal buffer. Any\n> > +                      * buffers the application wants to hold onto will already\n> > +                      * be exported through PipelineHandlerRPi::exportFrameBuffers().\n> > +                      *\n> > +                      * However, as above, if the application provides a guarantee\n> > +                      * that the buffer will always be provided for the ISP Output0\n> > +                      * stream in a Request, we don't need any internal buffers\n> > +                      * allocated.\n> > +                      */\n> > +                     if (!(s->configuration().hints & StreamConfiguration::Hint::OptionalStream) &&\n> > +                         !data->dropFrameCount_)\n> > +                             minIspBuffers = 0;\n> >               }\n> >       }\n> >\n> > @@ -1514,12 +1527,14 @@ int PipelineHandlerRPi::prepareBuffers(Camera *camera)\n> >                        * so allocate the minimum required to avoid frame drops.\n> >                        */\n> >                       numBuffers = data->config_.minTotalUnicamBuffers;\n> > +             } else if (stream == &data->isp_[Isp::Output0]) {\n> > +                     /* Buffer count for this is handled in the earlier loop above. */\n> > +                     numBuffers = minIspBuffers;\n> >               } else {\n> >                       /*\n> > -                      * Since the ISP runs synchronous with the IPA and requests,\n> > -                      * we only ever need one set of internal buffers. Any buffers\n> > -                      * the application wants to hold onto will already be exported\n> > -                      * through PipelineHandlerRPi::exportFrameBuffers().\n> > +                      * Same reasoning as for ISP Output 0, we only ever need\n> > +                      * a maximum of one internal buffer for Output1 (required\n> > +                      * for colour denoise) and ISP statistics.\n> >                        */\n> >                       numBuffers = 1;\n>\n> Do you plan to also optimize the buffer allocation based on hints for\n> Output1 ?\n\nNo, I'll leave Output1 as-is.  It's only ever one extra (much lower resolution)\nframe buffer.  It is also best to keep it around as we use it for colour denoise\nanalysis internally.\n\nRegards,\nNaush\n\n>\n> >               }\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F213EBDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 25 Jan 2023 13:08:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 51164625E4;\n\tWed, 25 Jan 2023 14:08:09 +0100 (CET)","from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com\n\t[IPv6:2607:f8b0:4864:20::b2c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CC9B603C0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Jan 2023 14:08:08 +0100 (CET)","by mail-yb1-xb2c.google.com with SMTP id u72so2215387ybi.7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Jan 2023 05:08:08 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674652089;\n\tbh=dKnA89xVdZ3z4Bp5hLBlA0MtbMDgkcSeTlgNMtCLKyY=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=dN9X0v49se1YUcRLgvfvDEKh816fXECwyF3WN2a4ULzYrt5Y+EpcoccUOBY+ZJNkO\n\taWdIU/N3J/w0bwzSKQWIuHPsgpTIvf/tRa2OI4O0B+4U3OcrAtRMJihv46pknkiuVp\n\tKHdx0Nmo0H30u1s4kFPnLitW1eotNFOOwYDTFW/hHeKfYaPUxPJUduR+TcXJ7TxUa0\n\t3sckUyETJgwSfw/EQWIQcK+yH1wfO4jA+NvZ8b51P9TdBHj7Hw4ywHCbYmAeWvE+3X\n\tmVPl7B2NmUXB36jqboxhCS9Ivmu/SNjI8mHm411ZYVpPu6AuWIbniHcgVb7lyBAThJ\n\tOzOqSdb1dWuOw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=EnkOkvXDoFXtBN6vRs2ULoj+/UHfF9l/kX831HPPS34=;\n\tb=DfU5/f+oZswtXaRfay2gLQ/AUCkpKc4nU4aMxzPNPX+BAFW9nLHGMcdzmjT40r9Jn3\n\t5E/FeVN9XISaibcC/x/jVAwm3GcV9zOaEHjJJ4Gn+wU75C6SSgUkGUePk6JA57YZo6Xb\n\tCnd4/r8kiZsR3pZxEHU9MQDLpLsxDLtSJZXGio3qJUNPlYvoXwQCqskPh2v+vnU40Otm\n\tiA9JcuwQB6ICG2ayH2atbZk2tgnkbwLt7LZfG4iclUEL6U5O/fASnEl5b4X6Z3bCUMiC\n\tRsR3UMNjbA1nIH322b0OLb5CX5DJWL7Kn8QVzwHHMTx6SHOWlP3zhXfLo7bxG8uFupGv\n\taidQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"DfU5/f+o\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=EnkOkvXDoFXtBN6vRs2ULoj+/UHfF9l/kX831HPPS34=;\n\tb=ZBduUdZWjkeqfZnEqRIy+Cy9ug3FdYJUTWUPBe/J1fli20a9W5v4rQ8Cc9gCrr+5bT\n\tloDO1XH8y4QMYRk5v2LhxA4Z8yT1zZ4YvHLMNfX8Gv6LNPbVyse+yAG3XNDNTxdc23gh\n\tWuionTQZvOE/gBH6DVJyl0vTM9tQuub5h1WNW2rmqlX1a0WQBrLiwd3MXEG1FMzDgXrW\n\tDzz6n1SJC8+oPUEplUB8L5Ek6e2xMKJeEZNoA0+T1Kd0KG5vs23P/punOyNhfBHiTpXq\n\tIhXD4Er3428ABcP/+qsfFjxr6kONojuhRgYO20rHFiPM6mBPiYNQPl7pQlNG6I/QovNw\n\tRB4w==","X-Gm-Message-State":"AO0yUKWHq79DjHhy4qzKI8jCPgUYqG4IJCFlSydTmL916pdM+NQja7zs\n\t1o1u4r0yn97u4cmgntYe2T+uEObxekQQO0NPXjTny6ehve7Zdsh3N0k=","X-Google-Smtp-Source":"AK7set+rWQv+tYBEECkscYQDNRyHWFEDi/dTCOlsj1R99YeiaNK9IWV8wir5IJ20s7hzkRYPudJf1sz0oZHnVdU5AMA=","X-Received":"by 2002:a25:a28e:0:b0:80b:72cc:ba35 with SMTP id\n\tc14-20020a25a28e000000b0080b72ccba35mr527194ybi.330.1674652086984;\n\tWed, 25 Jan 2023 05:08:06 -0800 (PST)","MIME-Version":"1.0","References":"<20230118085953.7027-1-naush@raspberrypi.com>\n\t<20230118085953.7027-9-naush@raspberrypi.com>\n\t<Y828nS+5NkMMGPMd@pendragon.ideasonboard.com>","In-Reply-To":"<Y828nS+5NkMMGPMd@pendragon.ideasonboard.com>","Date":"Wed, 25 Jan 2023 13:07:51 +0000","Message-ID":"<CAEmqJPqE8XktOTvkCfruNcU3FVv+N-pkD92N-aFi2=eJgy2Egw@mail.gmail.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v5 08/12] pipeline: raspberrypi:\n\tHandle OptionalStream hints for ISP Output0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]