[{"id":26279,"web_url":"https://patchwork.libcamera.org/comment/26279/","msgid":"<167421205862.42371.1980928024973459190@Monstersaurus>","date":"2023-01-20T10:54:18","subject":"Re: [libcamera-devel] [PATCH v5 06/12] libcamera: pipeline: build:\n\tAdd pipeline_data_dir variable","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2023-01-18 08:59:47)\n> Add a pipeline_data_dir variable to the meson build files. This variable\n> points to the location of pipeline handler specific configuration files on\n> the filesystem.\n> \n\nSounds reasonable.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/pipeline/meson.build | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/meson.build b/src/libcamera/pipeline/meson.build\n> index 30dc5b97f1dc..f14869f3a3c0 100644\n> --- a/src/libcamera/pipeline/meson.build\n> +++ b/src/libcamera/pipeline/meson.build\n> @@ -1,5 +1,8 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> +# Location of pipeline specific configuration files\n> +pipeline_data_dir = libcamera_datadir / 'pipeline'\n> +\n> foreach pipeline : pipelines\n> subdir(pipeline)\n> endforeach\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 543C1BE175\n\tfor ;\n\tFri, 20 Jan 2023 10:54:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 04E22625E4;\n\tFri, 20 Jan 2023 11:54:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 617686045E\n\tfor ;\n\tFri, 20 Jan 2023 11:54:21 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 098AB514;\n\tFri, 20 Jan 2023 11:54:20 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674212063;\n\tbh=RN9uu6uPmELyve5l9ueJ1jh9VmJP6fLrywsvKedWyng=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Hh7xUhPV2Un+9zQJDDCzhIjk/7F5/xmwL85GvWXR+UJCL4qerLPL4ugq7rMG94efq\n\tW4gTLV19YMzS6of88gY5GQLgp6lgSC0Izm2CqBHyT1KYIzb6BWV3n1TEeYDeqwMRAJ\n\to4iYH0Rv7CsPzBpdDxFFZnSZih9trZxDx0uKU2Y/CUDqLQZb3mJEyNcj/Stqh3MoQI\n\tu3CFJWL8YiRBQFnhuXsdbeX0jrzhWF4HycO9ciMcd+07SSrWcIYQB14pEA5c+GgpKx\n\teHvmNRa0quxF/hJNg/8x7ftSIRw37HAxiwu8HWzts5VYZqEGK2u2NUApQTcKH3wJSr\n\tn+vAwoiDxfI4Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674212061;\n\tbh=RN9uu6uPmELyve5l9ueJ1jh9VmJP6fLrywsvKedWyng=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=YD1LKf6V/2wBfwzx4VMl7WlQW28bWXET17bhAsQX+iKB2YpvNbLk04wpHmNh+/oh8\n\t0Nmj805rfIySJelweoIVM003gXiKfuxBmKoRCUDaxOCkBJrvdZfOimkFfpK09Pyw3c\n\ta55jI1tt7YLSABS1LNY/O6UeGCF2XXziKA5aBLbQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YD1LKf6V\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230118085953.7027-7-naush@raspberrypi.com>","References":"<20230118085953.7027-1-naush@raspberrypi.com>\n\t<20230118085953.7027-7-naush@raspberrypi.com>","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 20 Jan 2023 10:54:18 +0000","Message-ID":"<167421205862.42371.1980928024973459190@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v5 06/12] libcamera: pipeline: build:\n\tAdd pipeline_data_dir variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26310,"web_url":"https://patchwork.libcamera.org/comment/26310/","msgid":"","date":"2023-01-22T21:03:17","subject":"Re: [libcamera-devel] [PATCH v5 06/12] libcamera: pipeline: build:\n\tAdd pipeline_data_dir variable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Wed, Jan 18, 2023 at 08:59:47AM +0000, Naushir Patuck via libcamera-devel wrote:\n> Add a pipeline_data_dir variable to the meson build files. This variable\n> points to the location of pipeline handler specific configuration files on\n> the filesystem.\n\nI'm curious to know which text editor you use to write commit messages,\nas I thought the most common ones wrap lines to 72 characters by default\n:-)\n\n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/pipeline/meson.build | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/meson.build b/src/libcamera/pipeline/meson.build\n> index 30dc5b97f1dc..f14869f3a3c0 100644\n> --- a/src/libcamera/pipeline/meson.build\n> +++ b/src/libcamera/pipeline/meson.build\n> @@ -1,5 +1,8 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> +# Location of pipeline specific configuration files\n> +pipeline_data_dir = libcamera_datadir / 'pipeline'\n> +\n\nI wonder if we should later move this variable within the loop, and\nappend the pipeline handler name automatically. It will help ensuring\nconsistency, but I'm pretty sure that, as soon as we would merge a\npatch, someone would have a valid use case for an exception :-)\n\nReviewed-by: Laurent Pinchart \n\n> foreach pipeline : pipelines\n> subdir(pipeline)\n> endforeach","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 215E9BDB1D\n\tfor ;\n\tSun, 22 Jan 2023 21:03:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E647625E4;\n\tSun, 22 Jan 2023 22:03:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B330E625DD\n\tfor ;\n\tSun, 22 Jan 2023 22:03:20 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D508471;\n\tSun, 22 Jan 2023 22:03:20 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674421402;\n\tbh=g9UKbgt2X2GCtMcXOJoy33gfohu0/gd0B46PrKirqQQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JYuQrSt296+G6gVvR1JOQ6FdxkQUcrfzsOI7tcr60NUkkhu4R+rxB8q9bTjRN/4Uo\n\taRJSzOKWvmnc/6t5Ti+RwRrdH40+q1lcD79Xkqr0ZpUtLwskM1R33ZSLTKFdbdIqRT\n\tTxZs8TLYI9Kur72T5t/OgZkeW/JQs8NaCkMfq2Q5tMie76XbuCC/C2olQcgiiXiwR9\n\t+4IMZfJYXYEPznR068/ned5/vI8VtagsH3Z9YicI/Q3RZa/0A1ejRO2f5ZIXR2vkDn\n\tSUSpXK4ZczYEM9UUju/WUPhwI60cknYGiQubFdvyhXZypgw/nKJnD/dMg7ioxId2LW\n\tC4u7eMKn08jNw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1674421400;\n\tbh=g9UKbgt2X2GCtMcXOJoy33gfohu0/gd0B46PrKirqQQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=R2JnuSP4aPc1tNxtp7zKCeHre3rQERPN3VuPpwYBJm5ovOHc4IdwK40KVRnngPQE0\n\tdg3eHMoizaPw+h9DRvqay8HWaNTZFxY1kAZO9nCcyuo14XUlqb9CsrYVmPB2Ny2ZWK\n\tP5t56pGg/mGJNqupqNxpS4b11Omhzqu5zfIajut0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"R2JnuSP4\"; dkim-atps=neutral","Date":"Sun, 22 Jan 2023 23:03:17 +0200","To":"Naushir Patuck ","Message-ID":"","References":"<20230118085953.7027-1-naush@raspberrypi.com>\n\t<20230118085953.7027-7-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230118085953.7027-7-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v5 06/12] libcamera: pipeline: build:\n\tAdd pipeline_data_dir variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]