[{"id":26224,"web_url":"https://patchwork.libcamera.org/comment/26224/","msgid":"","date":"2023-01-16T00:36:02","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: rkisp1: Re-sort\n\tincludes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Sat, Jan 14, 2023 at 08:01:35PM +0100, Jacopo Mondi via libcamera-devel wrote:\n> Comply with a checkstyle suggestion and separate inclusion directives.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index c27b3ef9bd8e..5bdb4d255f6a 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -23,11 +23,12 @@\n> #include \n> #include \n> #include \n> +#include \n> +#include \n> +\n> #include \n> #include \n> #include \n> -#include \n> -#include \n> \n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_sensor.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3530EC3240\n\tfor ;\n\tMon, 16 Jan 2023 00:36:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 823CB625D8;\n\tMon, 16 Jan 2023 01:36:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7B1E625D0\n\tfor ;\n\tMon, 16 Jan 2023 01:36:02 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 48716997;\n\tMon, 16 Jan 2023 01:36:02 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1673829364;\n\tbh=QZkqAefX10AT5baXK9zZ8ffq4lJm1PvsBNShBvJvsjE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MNxHYaA1WQ5H9yKb5h9rZi++VZMBPnTRE7J7m+0ake3nrfV0EUV/JTgkMqNUEFrMy\n\ttRx8yJFleBCAGGpTltjGwLibnRPSlepoXjkeK1o7mWwOon4WQ161F7ynqWpi5rxf6t\n\t+4yiRnGRKIqFBZPaWt8xnyClojFnmABYrBbPdmgwlQBBKkDkEtEEM8fJnaGut6b6/V\n\t1m4naKWC2dFTfBXQiVtpAfAZfzhCqtqQQQ/u4SUaWS7gizjAhhLY4MRXZY9uKxaL3+\n\trigbwWlthePUGpC7DWVBqiqZxPwexFgj+noRHYhm0LkSkLlYe7ZS0msLXM8aVVFoIf\n\tSrgY0v79ZYdFQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1673829362;\n\tbh=QZkqAefX10AT5baXK9zZ8ffq4lJm1PvsBNShBvJvsjE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wYJDf+fEgRj/r1SCRINAcshMWz1ypKnIqJps1AP+hk//PuEhBhiz2aFuRIMvITSkn\n\tAm7sIcOGEI22RX0SAABIFUBOS120968OUOyRdUWljYfCHAKVus5vp1sFEAR/P9LECD\n\tLzuDg5Kl/S8DQSfbxSZEkDJaOXBM4NL5izItYEAo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"wYJDf+fE\"; dkim-atps=neutral","Date":"Mon, 16 Jan 2023 02:36:02 +0200","To":"Jacopo Mondi ","Message-ID":"","References":"<20230114190135.19703-1-jacopo.mondi@ideasonboard.com>\n\t<20230114190135.19703-2-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230114190135.19703-2-jacopo.mondi@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: rkisp1: Re-sort\n\tincludes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]