[{"id":2421,"web_url":"https://patchwork.libcamera.org/comment/2421/","msgid":"<20190816093759.GA5020@pendragon.ideasonboard.com>","date":"2019-08-16T09:37:59","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Support\n\tMPLANE M2M devices","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Aug 16, 2019 at 10:21:57AM +0100, Kieran Bingham wrote:\n> M2M devices using MPLANE API will set the V4L2_CAP_VIDEO_M2M_MPLANE\n> capability flag.\n> \n> Ensure that this is matched when checking for Multiplanar capabilities.\n> \n> Fixes: 4f7625cca7ec (\"libcamera: v4l2_videodevice: Support M2M devices\")\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/include/v4l2_videodevice.h | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/include/v4l2_videodevice.h b/src/libcamera/include/v4l2_videodevice.h\n> index 0fc2dcd81d2b..4b8cf9394eb9 100644\n> --- a/src/libcamera/include/v4l2_videodevice.h\n> +++ b/src/libcamera/include/v4l2_videodevice.h\n> @@ -50,7 +50,8 @@ struct V4L2Capability final : v4l2_capability {\n> \tbool isMultiplanar() const\n> \t{\n> \t\treturn device_caps() & (V4L2_CAP_VIDEO_CAPTURE_MPLANE |\n> -\t\t\t\t\tV4L2_CAP_VIDEO_OUTPUT_MPLANE);\n> +\t\t\t\t\tV4L2_CAP_VIDEO_OUTPUT_MPLANE |\n> +\t\t\t\t\tV4L2_CAP_VIDEO_M2M_MPLANE);\n> \t}\n> \tbool isCapture() const\n> \t{","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 12F9B600F9\n\tfor ;\n\tFri, 16 Aug 2019 11:38:04 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A2F72AF;\n\tFri, 16 Aug 2019 11:38:03 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565948283;\n\tbh=vU4Dy54vEbtQ3cVx3dpB4fLQF6A+ybUs0VxrtRt/Yx8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=amwFI6mYl2f3beG6/h+mIuzhXP3Jt5NmnIt7Nf6JcHEx84ZOHZ9laYjwiq4kz3of3\n\tU2ST+RitI1xXKFhWtZ/CP41pntesQ3YkzuXqhXroltLYC6i8s2phHNfIxoLAujk3qo\n\tPiVj5bkX4UgimbixxINmQjCqxkoRLuB0dICnPT8I=","Date":"Fri, 16 Aug 2019 12:37:59 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190816093759.GA5020@pendragon.ideasonboard.com>","References":"<20190816092157.30852-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190816092157.30852-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Support\n\tMPLANE M2M devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 16 Aug 2019 09:38:04 -0000"}},{"id":2451,"web_url":"https://patchwork.libcamera.org/comment/2451/","msgid":"<20190817154618.GB22846@wyvern>","date":"2019-08-17T15:46:18","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Support\n\tMPLANE M2M devices","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2019-08-16 10:21:57 +0100, Kieran Bingham wrote:\n> M2M devices using MPLANE API will set the V4L2_CAP_VIDEO_M2M_MPLANE\n> capability flag.\n> \n> Ensure that this is matched when checking for Multiplanar capabilities.\n> \n> Fixes: 4f7625cca7ec (\"libcamera: v4l2_videodevice: Support M2M devices\")\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/include/v4l2_videodevice.h | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/include/v4l2_videodevice.h b/src/libcamera/include/v4l2_videodevice.h\n> index 0fc2dcd81d2b..4b8cf9394eb9 100644\n> --- a/src/libcamera/include/v4l2_videodevice.h\n> +++ b/src/libcamera/include/v4l2_videodevice.h\n> @@ -50,7 +50,8 @@ struct V4L2Capability final : v4l2_capability {\n> \tbool isMultiplanar() const\n> \t{\n> \t\treturn device_caps() & (V4L2_CAP_VIDEO_CAPTURE_MPLANE |\n> -\t\t\t\t\tV4L2_CAP_VIDEO_OUTPUT_MPLANE);\n> +\t\t\t\t\tV4L2_CAP_VIDEO_OUTPUT_MPLANE |\n> +\t\t\t\t\tV4L2_CAP_VIDEO_M2M_MPLANE);\n> \t}\n> \tbool isCapture() const\n> \t{\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-ed1-x541.google.com (mail-ed1-x541.google.com\n\t[IPv6:2a00:1450:4864:20::541])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 47761600F9\n\tfor ;\n\tSat, 17 Aug 2019 17:46:20 +0200 (CEST)","by mail-ed1-x541.google.com with SMTP id f22so7608678edt.4\n\tfor ;\n\tSat, 17 Aug 2019 08:46:20 -0700 (PDT)","from localhost ([185.224.57.161]) by smtp.gmail.com with ESMTPSA id\n\toh24sm1254086ejb.35.2019.08.17.08.46.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 17 Aug 2019 08:46:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=QEOBbpEtVwRWailpPcj2VUtQu9h/Mvd+aMSLB2H9YlU=;\n\tb=mml1caay6OWm+BR9+s2QZQpmNMQntS7/AIiBtkyRjriIJv5wpX1EbbCZEC9L8rfrdp\n\twtRgUV6bvzuPjC77Fm7kHbiDGxKQJrajqECGlCF/z46RHw2FGii2G9+k+gmUNeniR0Vw\n\tWLF+GVWXbQ4VgzyBxj43qLGW+P2Vdzoq1m/1+OMLTEAt8BSk0/gUlgMw8+R5KqMJOogH\n\tcnNCDh3kv06n+fpyM1eOlOWhrtTJc1GezELc37o84SvJmCfWIDJyWU5tjfMHYBlPwO49\n\twlTq3et2EjA1T5VPZsxp9DJzMv3oOY02ImjO76u3woBUXsMt7b4i8eQvLInXMBlWMBL5\n\tSmGA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=QEOBbpEtVwRWailpPcj2VUtQu9h/Mvd+aMSLB2H9YlU=;\n\tb=H7vMM4YR87IdqJvzrqmFBNMWqfgjl3qf/EdTLy8M4Ckki7gemsnN+xSEab61dRE6U7\n\tkh4ZpqmefWqpi/sLJp4PgUAL2BkXhl5toSV6b4ZDtMHLa+ihmvyb5uYljmj3wXmEgjHI\n\tTdav4HIW1y5HWCmD9lCFI7y5AaSbrvckGyNZdvoJ2/grzq7SPX3urSSddqD8yqoc8jsV\n\tudWQnRoEEWAcD4nytZBiYdRSrntuGVly8mWeKbAdUbf9k4CY5Bdjgdatt/26uQ6UyiAW\n\tgTYrV2EUD/2P3VFUHabwCHb3FvHM6yreOfv9eMoY+1lR+UEnJvdTJyyKTs8lrGx6sGJx\n\tBSXw==","X-Gm-Message-State":"APjAAAUMbegBneRPu68U0M7JLM6dOZckt+nZb5LRTh/0XzaEiyhjcrsq\n\tLY7zSTNDknp77mVn+Z5q4+HgVA==","X-Google-Smtp-Source":"APXvYqxLWLOFU3QOA8fJoY9mTOKkCSj48JAwjq632w+IPuHVy/MQ2EO3lUqxR7F7m20pR5vDyfgdyg==","X-Received":"by 2002:a17:906:f198:: with SMTP id\n\tgs24mr13648825ejb.6.1566056779984; \n\tSat, 17 Aug 2019 08:46:19 -0700 (PDT)","Date":"Sat, 17 Aug 2019 17:46:18 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190817154618.GB22846@wyvern>","References":"<20190816092157.30852-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190816092157.30852-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Support\n\tMPLANE M2M devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 17 Aug 2019 15:46:20 -0000"}}]