[{"id":2420,"web_url":"https://patchwork.libcamera.org/comment/2420/","msgid":"<20190815123513.5zqtfwau5y2fkhvp@uno.localdomain>","date":"2019-08-15T12:35:13","subject":"Re: [libcamera-devel] [PATCH] hal: Fix comparison of unsigned\n\tinteger < 0","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n thanks for the fix\n\nOn Thu, Aug 15, 2019 at 03:23:32PM +0300, Laurent Pinchart wrote:\n> The CameraHalManager::getCameraInfo() validates the camera id it\n> receives from the camera service, and in doing so generates a compiler\n> error as the id is an unsigned integer and can never be negative:\n>\n> ../src/android/camera_hal_manager.cpp: In member function ‘CameraProxy* CameraHalManager::open(unsigned int, const hw_module_t*)’:\n> ../src/android/camera_hal_manager.cpp:89:9: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]\n> if (id < 0 || id >= numCameras()) {\n>\n> Fix it by removing the unneeded comparison.\n>\n\nIf relevant please add which compiler reports the error, as on clang-8 it\nis not reported. FYI with gcc-9.1 I see it as well.\n\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_hal_manager.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> index 1e66f63240da..37ba01355258 100644\n> --- a/src/android/camera_hal_manager.cpp\n> +++ b/src/android/camera_hal_manager.cpp\n> @@ -86,7 +86,7 @@ void CameraHalManager::run()\n> CameraProxy *CameraHalManager::open(unsigned int id,\n> \t\t\t\t const hw_module_t *hardwareModule)\n> {\n> -\tif (id < 0 || id >= numCameras()) {\n> +\tif (id >= numCameras()) {\n> \t\tLOG(HAL, Error) << \"Invalid camera id '\" << id << \"'\";\n> \t\treturn nullptr;\n> \t}\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C923960E2D\n\tfor ;\n\tThu, 15 Aug 2019 14:33:47 +0200 (CEST)","from uno.localdomain\n\t(host64-130-dynamic.5-87-r.retail.telecomitalia.it [87.5.130.64])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 3D0EE200006;\n\tThu, 15 Aug 2019 12:33:47 +0000 (UTC)"],"Date":"Thu, 15 Aug 2019 14:35:13 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190815123513.5zqtfwau5y2fkhvp@uno.localdomain>","References":"<20190815122332.13717-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"jnxjfdx427yse5wz\"","Content-Disposition":"inline","In-Reply-To":"<20190815122332.13717-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH] hal: Fix comparison of unsigned\n\tinteger < 0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 15 Aug 2019 12:33:47 -0000"}},{"id":2422,"web_url":"https://patchwork.libcamera.org/comment/2422/","msgid":"<20190817131929.GI2008@bigcity.dyn.berto.se>","date":"2019-08-17T13:19:29","subject":"Re: [libcamera-devel] [PATCH] hal: Fix comparison of unsigned\n\tinteger < 0","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-08-15 15:23:32 +0300, Laurent Pinchart wrote:\n> The CameraHalManager::getCameraInfo() validates the camera id it\n> receives from the camera service, and in doing so generates a compiler\n> error as the id is an unsigned integer and can never be negative:\n> \n> ../src/android/camera_hal_manager.cpp: In member function ‘CameraProxy* CameraHalManager::open(unsigned int, const hw_module_t*)’:\n> ../src/android/camera_hal_manager.cpp:89:9: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]\n> if (id < 0 || id >= numCameras()) {\n> \n> Fix it by removing the unneeded comparison.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_hal_manager.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> index 1e66f63240da..37ba01355258 100644\n> --- a/src/android/camera_hal_manager.cpp\n> +++ b/src/android/camera_hal_manager.cpp\n> @@ -86,7 +86,7 @@ void CameraHalManager::run()\n> CameraProxy *CameraHalManager::open(unsigned int id,\n> \t\t\t\t const hw_module_t *hardwareModule)\n> {\n> -\tif (id < 0 || id >= numCameras()) {\n> +\tif (id >= numCameras()) {\n> \t\tLOG(HAL, Error) << \"Invalid camera id '\" << id << \"'\";\n> \t\treturn nullptr;\n> \t}\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62B56600F9\n\tfor ;\n\tSat, 17 Aug 2019 15:19:31 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id n19so5892952lfe.13\n\tfor ;\n\tSat, 17 Aug 2019 06:19:31 -0700 (PDT)","from localhost (h-177-236.A463.priv.bahnhof.se. [217.31.177.236])\n\tby smtp.gmail.com with ESMTPSA id\n\tj22sm1439630ljg.17.2019.08.17.06.19.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 17 Aug 2019 06:19:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=eTDKLpL98X8S6BPNfFzJd9hBoxfoGamAlWF+L+opxYk=;\n\tb=xEyrjiujeZN5jxtqV5LwPdrc8eQ6hEZ5ugeuRIBVMRSisA90IyFMV8JmU66S2ZdMxv\n\tfbKw5Tt8wJHNmKcggn8Q8g/Z4XFANKnOhwGjov3Fzaj3Y+m5FWjjSKEx+hW8OF5JSNPl\n\t754/30zJxWT4oBbPWbi1VtFY36Y9cnVPt8Q5GFWFTaFLaQq0dCouUxzT/QMLvb/hdidB\n\t11ttqwyOBJ/UZ0cGzFmnyTSoHP45gt0C962TMp72h29m7FF5u0SSkkoQHBoyTI+PCPMn\n\tMbmwmOq3189riwf+ZUtrofHcBeE3r/YdM82utrzLcGXloiNsxENrFU8KxHmWH+BczpzR\n\ti3Gw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=eTDKLpL98X8S6BPNfFzJd9hBoxfoGamAlWF+L+opxYk=;\n\tb=F7+8cYNkhV4uSV5pHq84b0+edgGcDlY2B/1EiPVM1ks0tQk3wpwFJpO0kyN/lwyJMx\n\tgyyYn2N1JVQzytg/sUUkdqWE09fX+D1594LvbssfIiRAq5yqdIaCuDUpm4B4a9rpRm9K\n\tlMKVRGFbAuL/MQyg1eW1jO20P1GYiQ59j5WX9vwufYiY0hg9YKUPPn3nNVVGBZUHaZjf\n\t+BINVk1E68DEAsTbdWctZb1I9bhhenufVSwOATPV+qL9keMymtDh4esFBHC3vlUDdu1F\n\tPwlA4QP+UDFEaHwYqrpbf+DWmoxfPRhdM+1gwhs+T/yXM4ekJA0+jlAQPsVGznzmU2HB\n\tJq1w==","X-Gm-Message-State":"APjAAAVP31fN2xfJPs9ezfQKCO9XQSzNnZwodQ6m8UZiSmOLfRYDuPKy\n\tvoPIub0Nkfr0l9shqrW4avRQKlofQ/I=","X-Google-Smtp-Source":"APXvYqzM5A/Ztu7N61q38aFpUD1Mh6E2F+VCc7uIPIzM+olj4tU+NjIVx30UV/J/BNf2Qx97YXHuTw==","X-Received":"by 2002:ac2:568e:: with SMTP id 14mr8061685lfr.189.1566047970469;\n\tSat, 17 Aug 2019 06:19:30 -0700 (PDT)","Date":"Sat, 17 Aug 2019 15:19:29 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190817131929.GI2008@bigcity.dyn.berto.se>","References":"<20190815122332.13717-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190815122332.13717-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH] hal: Fix comparison of unsigned\n\tinteger < 0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 17 Aug 2019 13:19:31 -0000"}}]