[{"id":26186,"web_url":"https://patchwork.libcamera.org/comment/26186/","msgid":"<167292809347.2799906.13660835585057835497@Monstersaurus>","date":"2023-01-05T14:14:53","subject":"Re: [libcamera-devel] [PATCH] Replace deprecated 'meson' with\n\t'meson setup'","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-01-05 10:05:48)\n> Meson has deprecated implicit usage of the setup command. Update the\n> build instructions to use 'meson setup' explicitly.\n\nIs there a reference somewhere that states this is deprecated? I haven't\nseen one and can't (quickly) find it.\n\nBut it's fine either way, this is still the 'correct' way to do it\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> README.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/README.rst b/README.rst\n> index e9dd4207ae55..34b6b49f3575 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -34,7 +34,7 @@ To fetch the sources, build and install:\n> \n> git clone https://git.libcamera.org/libcamera/libcamera.git\n> cd libcamera\n> - meson build\n> + meson setup build\n> ninja -C build install\n> \n> Dependencies\n> \n> base-commit: e1b81401cafa2e071b0903c0afe8363e84c11ede\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC14FBD78E\n\tfor ;\n\tThu, 5 Jan 2023 14:14:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E970625CF;\n\tThu, 5 Jan 2023 15:14:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 208D2604D5\n\tfor ;\n\tThu, 5 Jan 2023 15:14:56 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91B4249C;\n\tThu, 5 Jan 2023 15:14:55 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672928098;\n\tbh=hZi936hBwdFJca+nLgB2/GeUH3He1y0/Ev3J4Y4nkYM=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=soSWWIE+k4AnBXJ/l1sHqhey8ZnbG2blJ9B/bR8YenqMzhRig792HRaBng7yLgJID\n\tU9tshiW6pZEN6GZQAtZadjcuKRtlOg7zq1oSUgreqWmGk6+XFJWgvQzt7zB6EgWmlC\n\tdkU+2Zey7+W1EJT2o5A9ujuhl7wZ4aBtzuJ66Alj6N9zG7PsQPSMx5o61A3qP8M8qp\n\t0NqtpJhbkdzlkTjhr5ED7DvwuF96qaAVBDVDZx3jCkiSDq/nob9Yunl1XSod4nH2bn\n\tzRvi/RUcGrYwGU8/+OBCfro7BY9wu7c88PCCj/Qg/SZQezLkdBAw4MY3CvGQwMhZJW\n\tlsy8VOf/KSPYA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1672928095;\n\tbh=hZi936hBwdFJca+nLgB2/GeUH3He1y0/Ev3J4Y4nkYM=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=gR308+9Ux/RoJ6BvlPFp4+uWp4OrU/yw+Gm3Q3UdDqvN9SCog0GpZG4RY9/dmCIzt\n\toyQRoK8t9dHBbHuJZc8gUc2jyzwONrbqlovbh+eHydbummOCEmzEC8fhLx0eB/RsZB\n\tSZLNRsvnZ066xXeplgs/IxlcN5lQ5JVhRDLgZdSU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gR308+9U\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230105100548.18155-1-laurent.pinchart@ideasonboard.com>","References":"<20230105100548.18155-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 05 Jan 2023 14:14:53 +0000","Message-ID":"<167292809347.2799906.13660835585057835497@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] Replace deprecated 'meson' with\n\t'meson setup'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26187,"web_url":"https://patchwork.libcamera.org/comment/26187/","msgid":"","date":"2023-01-05T14:42:40","subject":"Re: [libcamera-devel] [PATCH] Replace deprecated 'meson' with\n\t'meson setup'","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jan 05, 2023 at 02:14:53PM +0000, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2023-01-05 10:05:48)\n> > Meson has deprecated implicit usage of the setup command. Update the\n> > build instructions to use 'meson setup' explicitly.\n> \n> Is there a reference somewhere that states this is deprecated? I haven't\n> seen one and can't (quickly) find it.\n\nIt's printed by meson:\n\nWARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.\n\nI'll add that to the commit message.\n\n> But it's fine either way, this is still the 'correct' way to do it\n> \n> \n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > README.rst | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/README.rst b/README.rst\n> > index e9dd4207ae55..34b6b49f3575 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -34,7 +34,7 @@ To fetch the sources, build and install:\n> > \n> > git clone https://git.libcamera.org/libcamera/libcamera.git\n> > cd libcamera\n> > - meson build\n> > + meson setup build\n> > ninja -C build install\n> > \n> > Dependencies\n> > \n> > base-commit: e1b81401cafa2e071b0903c0afe8363e84c11ede","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D3BAC322E\n\tfor ;\n\tThu, 5 Jan 2023 14:42:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3FF8625CF;\n\tThu, 5 Jan 2023 15:42:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1382F604D5\n\tfor ;\n\tThu, 5 Jan 2023 15:42:45 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6622C49C;\n\tThu, 5 Jan 2023 15:42:44 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672929766;\n\tbh=/Yay9yq8E6zp3hobVhdNWrxwQOCkW+y73QV/VBzZxPg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=BIlCcmjrt4rAYywwtIulzDB7SCMIHYCrR7z+SZUKHQ/VaItcwxIW9AuGiIYd0Lqaz\n\tsFdoesyp4hnlEEgM3KsGkpX89McuTJGn8MLzYmYpVrmpllcs/ByY987jQaQSq9uT5I\n\tCs8G4lEdpI/EwyjV17uxhq3eThLK6QUW4AbDuPanC7zTQTOrb0n7oFMtdcaxDtsjaQ\n\tBcTC7hU54OhyNkdu1NNTacUjeZ2i4MPeeUzFrpB7v2k4yw81vbj4AWoOdaaZfSfj6v\n\toyg7Q9ux/u/8GUU8pNQCjzn5kYHVDwFiQ9MWxwefBoTuYamsT0r5apQYb3C+2W29gF\n\tS1UZGNbKdQNGA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1672929764;\n\tbh=/Yay9yq8E6zp3hobVhdNWrxwQOCkW+y73QV/VBzZxPg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cXouW5KeESTsBkppe/0zXC8CoLlWkphB8jKJMhmBySgsbnCmiSNygzry/ki+y/ezR\n\tQKljx5/SIltKr7J8SlcD/2lRMrx0FkpQZLgI78GtRH1WbVNRBxQaB93e5RH7EgypEU\n\tjrgYHC2dqXl9nzFWDcG4XJP3gD5hvpaeMhUNoI40="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cXouW5Ke\"; dkim-atps=neutral","Date":"Thu, 5 Jan 2023 16:42:40 +0200","To":"Kieran Bingham ","Message-ID":"","References":"<20230105100548.18155-1-laurent.pinchart@ideasonboard.com>\n\t<167292809347.2799906.13660835585057835497@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<167292809347.2799906.13660835585057835497@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] Replace deprecated 'meson' with\n\t'meson setup'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]