[{"id":26181,"web_url":"https://patchwork.libcamera.org/comment/26181/","msgid":"","date":"2023-01-05T07:11:19","subject":"Re: [libcamera-devel] [PATCH] libcamera: Use C++17 [[fallthrough]]\n\teverywhere","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Matti,\n\nOn Wed, Jan 04, 2023 at 06:15:01PM +0200, Matti Lehtimäki via libcamera-devel wrote:\n> Fixes build failure on some build environments.\n\nWould you be able to tell us what those build environments are ? We try\nhave a wide coverage of build targets and environments in our tests, and\nthe fact that we didn't catch this issue shows that an additional\nenvironment should be added.\n\n> Signed-off-by: Matti Lehtimäki \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n> src/libcamera/camera_sensor.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index 16aac441..750ec351 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -154,7 +154,7 @@ colorspace_from_colorimetry(const GstVideoColorimetry &colorimetry)\n> \tcase GST_VIDEO_TRANSFER_GAMMA22:\n> \tcase GST_VIDEO_TRANSFER_GAMMA28:\n> \t\tGST_WARNING(\"GAMMA 18, 20, 22, 28 transfer functions not supported\");\n> -\t/* fallthrough */\n> +\t\t[[fallthrough]];\n> \tcase GST_VIDEO_TRANSFER_GAMMA10:\n> \t\tcolorspace->transferFunction = ColorSpace::TransferFunction::Linear;\n> \t\tbreak;\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index ae3127d6..a210aa4f 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -427,7 +427,7 @@ int CameraSensor::initProperties()\n> \t\t\tLOG(CameraSensor, Warning)\n> \t\t\t\t<< \"Unsupported camera location \"\n> \t\t\t\t<< v4l2Orientation << \", setting to External\";\n> -\t\t\t/* Fall-through */\n> +\t\t\t[[fallthrough]];\n> \t\tcase V4L2_CAMERA_ORIENTATION_EXTERNAL:\n> \t\t\tpropertyValue = properties::CameraLocationExternal;\n> \t\t\tbreak;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D41DCBD78E\n\tfor ;\n\tThu, 5 Jan 2023 07:11:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 27FF4625CF;\n\tThu, 5 Jan 2023 08:11:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F22A61F06\n\tfor ;\n\tThu, 5 Jan 2023 08:11:24 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCEF749C;\n\tThu, 5 Jan 2023 08:11:23 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672902686;\n\tbh=30EF2zJZ975e8hNQjxeAghRVJl7ga8221OBSoqUa770=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=PHv7XRszC7Ho+kTwHfqgFgCfzy1QO7lRigVwPzBmFfm5KchEg8Hka98KUYUh7xRz0\n\tNqg+IREGUEQ40OYVehMiczbGN0HynP8kSp4EhB/ZS+0/wMtdzGtChdutfvUID9Kt4u\n\t3rSls5yKpGiCbF2q3KGoq9IWDKmpfzLtgzctBs4DdVZR/oOigqTzoribveHWFLVvR0\n\tx5S8qiQJL1vbOvTCPGqw17VhbjO5YWHvYAl1Ww4bxgSFmjwBtoCntNdKW+Ziv/Q/8n\n\tM8Glf0Oe0ULAl5CE3VH9o/GEk1ld1Knh66kxoMkxlKuwUFmlKV8QHK3nSjR4sdYscc\n\tCgHL6SCJKu+Eg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1672902684;\n\tbh=30EF2zJZ975e8hNQjxeAghRVJl7ga8221OBSoqUa770=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QFhmT8plM28N55Jhe1QXkg9Z3YRekYFefZGL5g7XxujZqkSEA1UAYLV0CD+sP1DwY\n\tpGkFB0x5ywMuoAqVlVd+O98yzTaaMF8ZbHh90JY8yh5mM9Lq6v278VhCceXX/mPDYw\n\tLebJZAXgLXrEngywkrKPr64Xbauv0smVsDLCivNY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QFhmT8pl\"; dkim-atps=neutral","Date":"Thu, 5 Jan 2023 09:11:19 +0200","To":"Matti =?utf-8?q?Lehtim=C3=A4ki?= ","Message-ID":"","References":"<20230104161501.100221-1-matti.lehtimaki@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20230104161501.100221-1-matti.lehtimaki@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Use C++17 [[fallthrough]]\n\teverywhere","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26182,"web_url":"https://patchwork.libcamera.org/comment/26182/","msgid":"<20230105090858.ifaiiwjlmwhglbly@uno.localdomain>","date":"2023-01-05T09:08:58","subject":"Re: [libcamera-devel] [PATCH] libcamera: Use C++17 [[fallthrough]]\n\teverywhere","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Matti\n\nOn Thu, Jan 05, 2023 at 09:11:19AM +0200, Laurent Pinchart via libcamera-devel wrote:\n> Hi Matti,\n>\n> On Wed, Jan 04, 2023 at 06:15:01PM +0200, Matti Lehtimäki via libcamera-devel wrote:\n> > Fixes build failure on some build environments.\n>\n> Would you be able to tell us what those build environments are ? We try\n> have a wide coverage of build targets and environments in our tests, and\n> the fact that we didn't catch this issue shows that an additional\n> environment should be added.\n>\n> > Signed-off-by: Matti Lehtimäki \n>\n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> > ---\n> > src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n> > src/libcamera/camera_sensor.cpp | 2 +-\n> > 2 files changed, 2 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> > index 16aac441..750ec351 100644\n> > --- a/src/gstreamer/gstlibcamera-utils.cpp\n> > +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> > @@ -154,7 +154,7 @@ colorspace_from_colorimetry(const GstVideoColorimetry &colorimetry)\n> > \tcase GST_VIDEO_TRANSFER_GAMMA22:\n> > \tcase GST_VIDEO_TRANSFER_GAMMA28:\n> > \t\tGST_WARNING(\"GAMMA 18, 20, 22, 28 transfer functions not supported\");\n> > -\t/* fallthrough */\n> > +\t\t[[fallthrough]];\n> > \tcase GST_VIDEO_TRANSFER_GAMMA10:\n> > \t\tcolorspace->transferFunction = ColorSpace::TransferFunction::Linear;\n> > \t\tbreak;\n> > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > index ae3127d6..a210aa4f 100644\n> > --- a/src/libcamera/camera_sensor.cpp\n> > +++ b/src/libcamera/camera_sensor.cpp\n> > @@ -427,7 +427,7 @@ int CameraSensor::initProperties()\n> > \t\t\tLOG(CameraSensor, Warning)\n> > \t\t\t\t<< \"Unsupported camera location \"\n> > \t\t\t\t<< v4l2Orientation << \", setting to External\";\n> > -\t\t\t/* Fall-through */\n> > +\t\t\t[[fallthrough]];\n> > \t\tcase V4L2_CAMERA_ORIENTATION_EXTERNAL:\n> > \t\t\tpropertyValue = properties::CameraLocationExternal;\n> > \t\t\tbreak;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB493C322E\n\tfor ;\n\tThu, 5 Jan 2023 09:09:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A1AA625CF;\n\tThu, 5 Jan 2023 10:09:03 +0100 (CET)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73667625CC\n\tfor ;\n\tThu, 5 Jan 2023 10:09:01 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id F11F61BF213;\n\tThu, 5 Jan 2023 09:08:59 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672909743;\n\tbh=agPTPQQCbuN5OyTOhQhdTX/IGAhMjMHe2oZOkG9U778=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=G1QYkzvMKP2pYwGOE3J7uo/Wa6bwDefxp4H4qaSnq6UyYJQjQLlKtxY2zFNVAH8qy\n\tp+6r20eJR2dmqp6KGF3Z2Y23dAEsIcAhcT4oRATqA6FrJDS9P7/9MPPd15x72MhKrO\n\tj/Uzhvuro0xRqGc5JvAAdSYpsL4tK1KnN6Rn0hquch1kbfirj3c04sutx87Ma6QsRE\n\tB8uUljkGsJWdWjnYFyjQd8HDdEjRZuAYT8GrT9Dw2CNPoAqQNm2C8GMalWs5IZSnl0\n\t6jdy/UYBoCYDph2ksNJ1/yjjOWjJoUi+DH0FOwCNUdS5HgrWnWMe71k50eLIN5QlXP\n\tf5ufFcXnkBuFg==","Date":"Thu, 5 Jan 2023 10:08:58 +0100","To":"Laurent Pinchart ","Message-ID":"<20230105090858.ifaiiwjlmwhglbly@uno.localdomain>","References":"<20230104161501.100221-1-matti.lehtimaki@gmail.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Use C++17 [[fallthrough]]\n\teverywhere","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Matti =?utf-8?q?Lehtim=C3=A4ki?= ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26183,"web_url":"https://patchwork.libcamera.org/comment/26183/","msgid":"<9251e212-ab62-04ab-a4b9-8d00c476a779@gmail.com>","date":"2023-01-05T09:11:10","subject":"Re: [libcamera-devel] [PATCH] libcamera: Use C++17 [[fallthrough]]\n\teverywhere","submitter":{"id":144,"url":"https://patchwork.libcamera.org/api/people/144/","name":"Matti Lehtimäki","email":"matti.lehtimaki@gmail.com"},"content":"Hi\n\nThe build failure happened when building libcamera in Sailfish OS \nPlatform SDK which has gcc 8.3.\n\n-Matti\n\nOn 5.1.2023 9.11, Laurent Pinchart wrote:\n> Hi Matti,\n> \n> On Wed, Jan 04, 2023 at 06:15:01PM +0200, Matti Lehtimäki via libcamera-devel wrote:\n>> Fixes build failure on some build environments.\n> \n> Would you be able to tell us what those build environments are ? We try\n> have a wide coverage of build targets and environments in our tests, and\n> the fact that we didn't catch this issue shows that an additional\n> environment should be added.\n> \n>> Signed-off-by: Matti Lehtimäki \n> \n> Reviewed-by: Laurent Pinchart \n> \n>> ---\n>> src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n>> src/libcamera/camera_sensor.cpp | 2 +-\n>> 2 files changed, 2 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n>> index 16aac441..750ec351 100644\n>> --- a/src/gstreamer/gstlibcamera-utils.cpp\n>> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n>> @@ -154,7 +154,7 @@ colorspace_from_colorimetry(const GstVideoColorimetry &colorimetry)\n>> \tcase GST_VIDEO_TRANSFER_GAMMA22:\n>> \tcase GST_VIDEO_TRANSFER_GAMMA28:\n>> \t\tGST_WARNING(\"GAMMA 18, 20, 22, 28 transfer functions not supported\");\n>> -\t/* fallthrough */\n>> +\t\t[[fallthrough]];\n>> \tcase GST_VIDEO_TRANSFER_GAMMA10:\n>> \t\tcolorspace->transferFunction = ColorSpace::TransferFunction::Linear;\n>> \t\tbreak;\n>> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n>> index ae3127d6..a210aa4f 100644\n>> --- a/src/libcamera/camera_sensor.cpp\n>> +++ b/src/libcamera/camera_sensor.cpp\n>> @@ -427,7 +427,7 @@ int CameraSensor::initProperties()\n>> \t\t\tLOG(CameraSensor, Warning)\n>> \t\t\t\t<< \"Unsupported camera location \"\n>> \t\t\t\t<< v4l2Orientation << \", setting to External\";\n>> -\t\t\t/* Fall-through */\n>> +\t\t\t[[fallthrough]];\n>> \t\tcase V4L2_CAMERA_ORIENTATION_EXTERNAL:\n>> \t\t\tpropertyValue = properties::CameraLocationExternal;\n>> \t\t\tbreak;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E7CDC322E\n\tfor ;\n\tThu, 5 Jan 2023 09:11:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D8421625CF;\n\tThu, 5 Jan 2023 10:11:14 +0100 (CET)","from mail-lf1-x133.google.com (mail-lf1-x133.google.com\n\t[IPv6:2a00:1450:4864:20::133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0436C625CC\n\tfor ;\n\tThu, 5 Jan 2023 10:11:12 +0100 (CET)","by mail-lf1-x133.google.com with SMTP id y25so54232261lfa.9\n\tfor ;\n\tThu, 05 Jan 2023 01:11:12 -0800 (PST)","from [192.168.0.251] (dsl-hkibng42-56733b-36.dhcp.inet.fi.\n\t[86.115.59.36]) by smtp.gmail.com with ESMTPSA id\n\ti19-20020a056512225300b004cc590975f7sm190262lfu.183.2023.01.05.01.11.11\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 05 Jan 2023 01:11:11 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672909874;\n\tbh=rrGu00YXcs/594B3OlbETzWDLEZaDw5I7mnv2LbOyqg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=nex7ofqveF0IP3dGLjyIhDLwGUYHzeJ5H7sqRO7p54MSdgj/FQ/fEtk6QMLGsUqDO\n\tjOk0E/5unm9SaSc033hb57rhCSBlCPUbFJ/Optn6Otww69aGM4GfP684IZG0s786rK\n\tLdp7+Ph0zZCqj9z72IQH1Dk2ZAtOAhXTmNJa3rp67NdvGPK2ydKdgPLiZstkx0SoU4\n\tM7q01rypBgZ9XVvnwzA6rHFcOyd5Gutr9n3F9H49fYTuXr4AN5fS8jIT2IXzBUqAhf\n\tkGl4XedjMeEogV9q1XuZGEdbJuIkpl+iyX2p2+1mOPK/27DoYyTbXeZZOuzByt0MlT\n\t72Kerm8QAS00A==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=aSPqOtZvb1r5DcP59fLBEBSYTarndelpunxuH2UDkYE=;\n\tb=R8f5HRL5jgyMxs+Ngod29B345fIGGrE0P1wyaOGvAPu54vELGp9LqmMW5SmFJ55QSE\n\tgpl0qtXcYSIVnZrui8h4E1psMSu4xcSLOlM5XmPBD5ZAdE4uEgK3D53Irxs0UP7YKmZV\n\tCQ/VX2kZumePbRAfU53/DqYOyTiQWM03lG1XBdaZiulyDpNXATc6zl5vT7UXbW46V0Yy\n\tkDru3pmB5b7o8s7An28FsOwnItPoCNuuPqy3GqfnKT0OBP/3A/4JxoI5pPJFyHE8zrob\n\tkQy4EbxfzdvWiR7aLNh0q5ZoQZeRB5LEnPtimhrgE5hCjjYFTnK2Q5kPLM44pcO4IpMi\n\tIY8w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"R8f5HRL5\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=aSPqOtZvb1r5DcP59fLBEBSYTarndelpunxuH2UDkYE=;\n\tb=y+k5LI10fIllqRZpemZCre/eb3ZGFBMBXnYEWcueKSHlYLyzPswAFN4lu5sq6QIZnU\n\tgZ86Qc5IhIiu9kK3WKH0tD4zVWWZ5+SzQwfdWEUnrnlsd3K8QTrp+PPxiS1WCoomQibb\n\tL4nuEYMxuA4fUh8YJ6txJNaOYlIsAlNCNaD6g9u/S9X34v3ivcj1KYY2m3u1bgG+05R5\n\tCtwzRpI19DsiSM1poPP39eoP2YilU/wGMDcGGp896oiUBeLpXsEimkLelF5niSYaBshV\n\tUfyp4528pwrpiVHvxoDvfq4BBjDwk8mhxxyDEw/qyGMRfbmMy3ehY1CzkqnK+eXFPgW9\n\tnLRA==","X-Gm-Message-State":"AFqh2koaSOPe2xY4UOaXVXxX6w2sbJ2bEZwjD/cK2IMKXpXKYxdGY2Uu\n\tcB3JytkGgo+oodt/IRYB3lwwmRksEAA=","X-Google-Smtp-Source":"AMrXdXv/bXKBgOHnUBCZUJC61WiKEBlUAILTb4MAgrCiHR8aJa4+IdrPtbbJoKJtWMvFWiLnpqHwpQ==","X-Received":"by 2002:ac2:431a:0:b0:4c8:ae6b:ea8d with SMTP id\n\tl26-20020ac2431a000000b004c8ae6bea8dmr13036324lfh.8.1672909872092; \n\tThu, 05 Jan 2023 01:11:12 -0800 (PST)","Message-ID":"<9251e212-ab62-04ab-a4b9-8d00c476a779@gmail.com>","Date":"Thu, 5 Jan 2023 11:11:10 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.4.2","To":"Laurent Pinchart ","References":"<20230104161501.100221-1-matti.lehtimaki@gmail.com>\n\t","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Use C++17 [[fallthrough]]\n\teverywhere","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"=?utf-8?q?Matti_Lehtim=C3=A4ki_via_libcamera-devel?=\n\t","Reply-To":"=?utf-8?q?Matti_Lehtim=C3=A4ki?= ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26185,"web_url":"https://patchwork.libcamera.org/comment/26185/","msgid":"","date":"2023-01-05T10:03:06","subject":"Re: [libcamera-devel] [PATCH] libcamera: Use C++17 [[fallthrough]]\n\teverywhere","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Matti,\n\nOn Thu, Jan 05, 2023 at 11:11:10AM +0200, Matti Lehtimäki wrote:\n> Hi\n> \n> The build failure happened when building libcamera in Sailfish OS \n> Platform SDK which has gcc 8.3.\n\nThank you. I build with gcc-8.3.0 already and don't see any error. There\nmust be some difference between our environments. I'm not sure I want to\nspend too much time investigating though :-)\n\nNice to hear you have an interest in libcamera for Sailfish OS. Please\nlet me know if we can be of any help to improve support for your\nplatforms.\n\n> On 5.1.2023 9.11, Laurent Pinchart wrote:\n> > On Wed, Jan 04, 2023 at 06:15:01PM +0200, Matti Lehtimäki via libcamera-devel wrote:\n> >> Fixes build failure on some build environments.\n> > \n> > Would you be able to tell us what those build environments are ? We try\n> > have a wide coverage of build targets and environments in our tests, and\n> > the fact that we didn't catch this issue shows that an additional\n> > environment should be added.\n> > \n> >> Signed-off-by: Matti Lehtimäki \n> > \n> > Reviewed-by: Laurent Pinchart \n> > \n> >> ---\n> >> src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n> >> src/libcamera/camera_sensor.cpp | 2 +-\n> >> 2 files changed, 2 insertions(+), 2 deletions(-)\n> >>\n> >> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> >> index 16aac441..750ec351 100644\n> >> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> >> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> >> @@ -154,7 +154,7 @@ colorspace_from_colorimetry(const GstVideoColorimetry &colorimetry)\n> >> \tcase GST_VIDEO_TRANSFER_GAMMA22:\n> >> \tcase GST_VIDEO_TRANSFER_GAMMA28:\n> >> \t\tGST_WARNING(\"GAMMA 18, 20, 22, 28 transfer functions not supported\");\n> >> -\t/* fallthrough */\n> >> +\t\t[[fallthrough]];\n> >> \tcase GST_VIDEO_TRANSFER_GAMMA10:\n> >> \t\tcolorspace->transferFunction = ColorSpace::TransferFunction::Linear;\n> >> \t\tbreak;\n> >> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> >> index ae3127d6..a210aa4f 100644\n> >> --- a/src/libcamera/camera_sensor.cpp\n> >> +++ b/src/libcamera/camera_sensor.cpp\n> >> @@ -427,7 +427,7 @@ int CameraSensor::initProperties()\n> >> \t\t\tLOG(CameraSensor, Warning)\n> >> \t\t\t\t<< \"Unsupported camera location \"\n> >> \t\t\t\t<< v4l2Orientation << \", setting to External\";\n> >> -\t\t\t/* Fall-through */\n> >> +\t\t\t[[fallthrough]];\n> >> \t\tcase V4L2_CAMERA_ORIENTATION_EXTERNAL:\n> >> \t\t\tpropertyValue = properties::CameraLocationExternal;\n> >> \t\t\tbreak;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35802C322E\n\tfor ;\n\tThu, 5 Jan 2023 10:03:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A81F625CC;\n\tThu, 5 Jan 2023 11:03:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 11D77625CC\n\tfor ;\n\tThu, 5 Jan 2023 11:03:11 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6F17D49C;\n\tThu, 5 Jan 2023 11:03:10 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672912992;\n\tbh=+AH4UF2UtpU2VU1aPv427F4gdYxNxmORE/7cn5Lr1RQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mXSN+Was5xBKHXnx8dLgbShOwSGmRRR4iSWtUPpKIS6gyZqkmsB8i4Wo0ULP5al5R\n\tOkDPskE+qkoODYCx93MiG51vEhSQO7oldXB4yj5zq9m8cqZPh9Ba7cytdOaVw+t1Sz\n\tVG+5wKEYqBQIUB1EGu+qLU6hTt6RQUIHyJZMvMstLLU/CbuqSTdxarMLE4lE0lPfT4\n\te7shsStKrjMf4qX2KzTC8Xgmc0eSPrlABVbOkVFkjUbrMO/zeOm1hrOmTtaEXe9UBo\n\tDI/qTK2dbM/h+LT/DysBUoQTnc0cjqLNOn3jts3UfXaUaKHpephksoL0sM1BoO2loL\n\tGKKHv9MfiLLag==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1672912990;\n\tbh=+AH4UF2UtpU2VU1aPv427F4gdYxNxmORE/7cn5Lr1RQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Zm04ZIxpWOYmK54BgNVhx271K5LUgbFGoh7iW7+OqLFd0T4RtGjJ4U7UtET8Md3Ds\n\tcYjDeaKpCXB07U84qE27UqjaA594iywzBLsgz4AneC/GczNNXwxNGI5GX2Xj+5ZAap\n\tbE8PBdI8ksL/eR6ROASM/KR1vKWNswaVDz0piUOI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Zm04ZIxp\"; dkim-atps=neutral","Date":"Thu, 5 Jan 2023 12:03:06 +0200","To":"Matti =?utf-8?q?Lehtim=C3=A4ki?= ","Message-ID":"","References":"<20230104161501.100221-1-matti.lehtimaki@gmail.com>\n\t\n\t<9251e212-ab62-04ab-a4b9-8d00c476a779@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<9251e212-ab62-04ab-a4b9-8d00c476a779@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Use C++17 [[fallthrough]]\n\teverywhere","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]