[{"id":26173,"web_url":"https://patchwork.libcamera.org/comment/26173/","msgid":"<167235994150.3944359.3770379794753430331@Monstersaurus>","date":"2022-12-30T00:25:41","subject":"Re: [libcamera-devel] [PATCH] qcam: Show string representation of\n\tpixel format","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Christian Rauch via libcamera-devel (2022-12-29 22:54:35)\n> The raw pixel format in form of the fourcc integer is not easily readable.\n> Use the string representation instead for easier debugging.\n> \n> Signed-off-by: Christian Rauch \n> ---\n> src/apps/qcam/viewfinder_qt.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/apps/qcam/viewfinder_qt.cpp b/src/apps/qcam/viewfinder_qt.cpp\n> index a7482bea..dcb7acdf 100644\n> --- a/src/apps/qcam/viewfinder_qt.cpp\n> +++ b/src/apps/qcam/viewfinder_qt.cpp\n> @@ -71,7 +71,7 @@ int ViewFinderQt::setFormat(const libcamera::PixelFormat &format, const QSize &s\n> \n> image_ = QImage(size, QImage::Format_RGB32);\n> \n> - qInfo() << \"Using software format conversion from\" << format;\n> + qInfo() << \"Using software format conversion from\" << format.toString().c_str();\n\nDoes the 'conversion from\" need a space after it? or does the\nformat.toString() provide that?\n\nIf that's all fine or resolved:\n\n\nReviewed-by: Kieran Bingham \n\n\n> } else {\n> qInfo() << \"Zero-copy enabled\";\n> }\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 848ABBD78E\n\tfor ;\n\tFri, 30 Dec 2022 00:25:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3EF9625CF;\n\tFri, 30 Dec 2022 01:25:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 142EC61F13\n\tfor ;\n\tFri, 30 Dec 2022 01:25:45 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 95DF16D0;\n\tFri, 30 Dec 2022 01:25:44 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672359946;\n\tbh=FDb/IGBaRm/fElUV8wjO7iyUq+j4TuiMw439dyJ26q0=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=j6+7vaJIKCqpqzP7DZfyJs+HOMvCTxrNf/brw2WZ35iKqa3DvGkQzYcjkUdVKR9oK\n\tXTb0mPiGjhfzeMtQi4uvwbXyFa+xirtNhKgPjlzAmLZTWDUCI03r+yEu1ZLhYNbbOg\n\t1sojaxasEdjehAFdtE/TWeMpqDXtqPQFscy4YwOus+nWpBek4CKeNBKVeN/bbZzOcZ\n\tr2RCHpgvWN19DDYUJpREZTvuJiOGVr1ISIo1LMo3pVb5Ry+98zJfBPYcG6abyHMWVE\n\tgIHwWn89n3inrnSePKeFhqZK+38s2SMepk15t28W4+xqTubrKT+hAnROW4nI6Q9deC\n\tjbx3Wx3wZEtVA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1672359944;\n\tbh=FDb/IGBaRm/fElUV8wjO7iyUq+j4TuiMw439dyJ26q0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=RvUvyeGWZuYwjcV764RNjVFvxAcWCDyZta8yTapvR/xkQ3lv6I9tlOCRSmX2FWtSV\n\tE2qsvxvPM+rr4/gdZyoqK6tsXT0UwkcVN19y1khiMVRS5FHqC55VXrYOsCrgqbJ5e6\n\t5tSsEYgPzFShqMSUkXMvK5RAGxUpu4AMEWEVa8Y0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"RvUvyeGW\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221229225435.36569-1-Rauch.Christian@gmx.de>","References":"<20221229225435.36569-1-Rauch.Christian@gmx.de>","To":"Christian Rauch ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 30 Dec 2022 00:25:41 +0000","Message-ID":"<167235994150.3944359.3770379794753430331@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] qcam: Show string representation of\n\tpixel format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26174,"web_url":"https://patchwork.libcamera.org/comment/26174/","msgid":"","date":"2022-12-30T00:44:57","subject":"Re: [libcamera-devel] [PATCH] qcam: Show string representation of\n\tpixel format","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"Hi Kieran,\n\nAm 30.12.22 um 01:25 schrieb Kieran Bingham:\n> Quoting Christian Rauch via libcamera-devel (2022-12-29 22:54:35)\n>> The raw pixel format in form of the fourcc integer is not easily readable.\n>> Use the string representation instead for easier debugging.\n>>\n>> Signed-off-by: Christian Rauch \n>> ---\n>> src/apps/qcam/viewfinder_qt.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/apps/qcam/viewfinder_qt.cpp b/src/apps/qcam/viewfinder_qt.cpp\n>> index a7482bea..dcb7acdf 100644\n>> --- a/src/apps/qcam/viewfinder_qt.cpp\n>> +++ b/src/apps/qcam/viewfinder_qt.cpp\n>> @@ -71,7 +71,7 @@ int ViewFinderQt::setFormat(const libcamera::PixelFormat &format, const QSize &s\n>>\n>> image_ = QImage(size, QImage::Format_RGB32);\n>>\n>> - qInfo() << \"Using software format conversion from\" << format;\n>> + qInfo() << \"Using software format conversion from\" << format.toString().c_str();\n>\n> Does the 'conversion from\" need a space after it? or does the\n> format.toString() provide that?\n\ntoString() does not provide the extra space. This seems to be some Qt\nmagic. Before this patch, the raw pixel format number was also printed\nwith a space between the static text and the integer format.\n\n> If that's all fine or resolved:\n>\n>\n> Reviewed-by: Kieran Bingham \n>\n>\n>> } else {\n>> qInfo() << \"Zero-copy enabled\";\n>> }\n>> --\n>> 2.34.1\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89735C3220\n\tfor ;\n\tFri, 30 Dec 2022 00:45:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E8A5961F13;\n\tFri, 30 Dec 2022 01:44:59 +0100 (CET)","from mout.gmx.net (mout.gmx.net [212.227.17.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 351B861F13\n\tfor ;\n\tFri, 30 Dec 2022 01:44:58 +0100 (CET)","from [192.168.0.158] ([88.152.184.103]) by mail.gmx.net (mrgmx105\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id\n\t1Mwfac-1ovJ3L2gDS-00yAj2; Fri, 30 Dec 2022 01:44:57 +0100"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672361099;\n\tbh=rJ8e2UeH4PdTxvwPDH6tHxmQXnxieuxOoIJiJ1glT3Q=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=xyEpT6BUXPegjo+4gogd3jfvQvIitgRBsSSvmaPt5xGYBNYckGfsZ5Fqoa0xKsEbO\n\tUJlxA1bR21g9Wp7bfHkQz5+54dN5gGgm2ay6gVw6KMhLxqnAJzgo5GEm+2FhnyTeNI\n\tzyqgsDVCs0K1e2zXSr9qmHmzQLnTeahBrlmMcMuXYcLQX0J2StlCSG4ubCAceYddcC\n\tNQZ0s4qsDbFimzxJ9Isb21qV5ajrwBOBaxzwkkID7N+wDhvk2Pva3JHHaUTxNUZMOV\n\tWqPm1eHKk0j6a8prQMZQWCox7mccVsQF4WYqJjgrnox6krXDgIWAauqt3dYxMOJ3QN\n\tFCurGdHi5YYWA==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; \n\tt=1672361097; bh=rJ8e2UeH4PdTxvwPDH6tHxmQXnxieuxOoIJiJ1glT3Q=;\n\th=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To;\n\tb=YaVqedU82IbMSasiN//MBSSbuFcfFKugkoJeNKI3npTwSahBtoUjAZ6ZfzhhXbQmv\n\t9vrBA+A0i2EXZ4+7yjTAm3uI7dcIWWjSVGWNeXaoMGYiOjAgB6+DZh1C7D32aI8kgh\n\tVDR3BC1n+42JnhcBSB2jBkbdWOaCV3ZbUtgPJUnUosa0xa1uG2QLVpxorVAwvI8KC6\n\tjiDQBQ2d+AQApVQXPfW+BzsVTLbMatk3nVlIdfDZAB1ju31zSDHtjgVLEdwiougLOa\n\tQNnkDLlm1HhdsyEtaX9CZ1l1/qWF64bOuCsQIMwieM+pD29TVj6wB4G/mAgHv5xrNi\n\twz3ZkEYZiYETA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmx.de header.i=@gmx.de\n\theader.b=\"YaVqedU8\"; dkim-atps=neutral","X-UI-Sender-Class":"724b4f7f-cbec-4199-ad4e-598c01a50d3a","Message-ID":"","Date":"Fri, 30 Dec 2022 01:44:57 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.4.2","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20221229225435.36569-1-Rauch.Christian@gmx.de>\n\t<167235994150.3944359.3770379794753430331@Monstersaurus>","Content-Language":"en-GB","In-Reply-To":"<167235994150.3944359.3770379794753430331@Monstersaurus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:HUo1zfA05Daph4J+gYXR8hdGd7sgc/1CIjLdLSEwVp4+0eG4y9d\n\tpCDhQRbLcW4PUkT5sI1z7IPuiZ+iCgozl0PgGk+j/vkcKgPaXvggJ9o05jdpLT+E2CiGT/4\n\tVBGqcT7LucJC6/mLJEuaLlSkRawcbix5iDA29LbCzvVYLxLkBTnjgRaATff9RY2Vv/X+G/V\n\t4hwWHRIZIKt7/Rq4ustCA==","X-Spam-Flag":"NO","UI-OutboundReport":"notjunk:1; M01:P0:F+W7Gc8kPE4=;\n\t5/DXm/DlG2cnmBHtkxsGtA6bqbl\n\tGlNU5HlC5KoxgijYDi5SmSGhNvZILU9UTD4mWzdnHNfa9hw8AFsMhccdFAgYQh7x281rRQ7RV\n\t2l2Z8pJBjGV4aS0Jd/sJEb1G8AXbBk02twYi00XKOjPNIz8LCTH2pI74j2JbfRQ1nfjIDbQ/T\n\tkJYmVyqVxCkrC00LGmHORpcLckQqrl/LI30H3EeMpoyWCq9q4ckLZvphOXAKiSxxDx14RalgI\n\t6LJoxYkLEK1yNr3h3vnpg10uQejuNWDkizRArlK+8eVNkDaNKA7SbGvwnZVObFmHq7VoVgTKG\n\tPyVrbbKjUDtOXY5b0GBwj1dkwDSQCo/+Xf0vzQbGzL1uSiV1NN+l06fv7SM/nWwwi2Bl0jlvR\n\teatnOTZ8Q6Y5nXOkqUz9/c6LGIPT3ZwmBPZutugiZdQJMGPVT0Ubt2MDerzggjRe+rdXloGkZ\n\tg6BUnYgA9i1O62Xh56cC95i3CEu0GvIb6edVVw1zzTwYAg+Y+TK0gxg8DvcMugee7NLEGCN2k\n\ttw7Fa0HW3RQ8haOI3/Fa579Vq+g5eBlJADKMCvTvoEyXvvmPvFcBPwWYEJcG/Kv+du02i8p+q\n\t2FflCTMCXws46HwZBjqkDz9l6bGszbbrxVKnlHKUphKH870mUfz8Inz6n3VJGLB5JbGzE6c8f\n\tnjRmxSzaOTgTX3qvdfExkamH/HFQrVhp2VOy7/JiZVDYTTlilnlGwejdUN+1HnNkrQpqxdK0f\n\tbKCbmnGIz9ELFgYb1shjFhFDQAsQyt6FVfH801P9nuUwmWm8z2qZkiUYHXQW0BqZY7a2A3KU9\n\tJYLSRkDcUoM4u9Vw/yQgbbALf4jgypfaYaD7locLnfd7jDJ2dfMBl1jX6zXavXNZLsEFr7UwW\n\tyed9+ZqPN394E5bGPiHkAMFaDTPx0ZYiqE2DG3sRTFi+s3YctIsWVUp8IjGiN/NshNqJw1i2x\n\tEjJ8A00Nszm2PivH/5WLB/XpG08=","Subject":"Re: [libcamera-devel] [PATCH] qcam: Show string representation of\n\tpixel format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26176,"web_url":"https://patchwork.libcamera.org/comment/26176/","msgid":"","date":"2022-12-30T20:16:06","subject":"Re: [libcamera-devel] [PATCH] qcam: Show string representation of\n\tpixel format","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Fri, Dec 30, 2022 at 01:44:57AM +0100, Christian Rauch wrote:\n> Am 30.12.22 um 01:25 schrieb Kieran Bingham:\n> > Quoting Christian Rauch via libcamera-devel (2022-12-29 22:54:35)\n> >> The raw pixel format in form of the fourcc integer is not easily readable.\n> >> Use the string representation instead for easier debugging.\n> >>\n> >> Signed-off-by: Christian Rauch \n> >> ---\n> >> src/apps/qcam/viewfinder_qt.cpp | 2 +-\n> >> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>\n> >> diff --git a/src/apps/qcam/viewfinder_qt.cpp b/src/apps/qcam/viewfinder_qt.cpp\n> >> index a7482bea..dcb7acdf 100644\n> >> --- a/src/apps/qcam/viewfinder_qt.cpp\n> >> +++ b/src/apps/qcam/viewfinder_qt.cpp\n> >> @@ -71,7 +71,7 @@ int ViewFinderQt::setFormat(const libcamera::PixelFormat &format, const QSize &s\n> >>\n> >> image_ = QImage(size, QImage::Format_RGB32);\n> >>\n> >> - qInfo() << \"Using software format conversion from\" << format;\n> >> + qInfo() << \"Using software format conversion from\" << format.toString().c_str();\n\nThis is getting long, let's write\n\n\t\tqInfo() << \"Using software format conversion from\"\n\t\t\t<< format.toString().c_str();\n\nSometimes I'm tempted to use the standard C++ library streams in qcam,\nas we would then benefit from libcamera's operator<<() implementation\nfor the PixelFormat class.\n\n> > Does the 'conversion from\" need a space after it? or does the\n> > format.toString() provide that?\n> \n> toString() does not provide the extra space. This seems to be some Qt\n> magic. Before this patch, the raw pixel format number was also printed\n> with a space between the static text and the integer format.\n\nQt inserts spaces automatically.\n\n> > If that's all fine or resolved:\n> >\n> > Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\nI'll address the line wrap when applying.\n\n> >> } else {\n> >> qInfo() << \"Zero-copy enabled\";\n> >> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2EDFBD78E\n\tfor ;\n\tFri, 30 Dec 2022 20:16:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AEDF625CF;\n\tFri, 30 Dec 2022 21:16:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24D4461F11\n\tfor ;\n\tFri, 30 Dec 2022 21:16:12 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F0F22F5;\n\tFri, 30 Dec 2022 21:16:11 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672431373;\n\tbh=vVQvbX77XDLO9luKQpEA7AGCrX+ApQu3e9FTyCI19RA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=q+BJIys9tAtt2izlDzJb8zKGt1O92BJ6G+vo80DYhcUyyfxlt6YtxuD2dW3qrL9h3\n\tvHDGC6nxEmLWQ51XHSpMzGzZpLg++Zxg23ZT8oS4pnuvvv/zmmQPX1ELl45DhZetie\n\tkqkWNSwF7gZ0cn7DehB79uv+R5k7E4bTqAA/Q+zPuHFl9aMqt6HMtutUv/znm0MAga\n\tGDpX+NsSxVp7loo4HaBsW/WIK/0q/bklt3djCQTtrl1kvEBUHVsbU/AgSAx3FhMNNZ\n\t1Z6r4zCJGU1ZTcYzxR4L5voNflGKTfLHsSlRqcI0T1AWzdT/zuS/afOv83HYhUF+3t\n\tUkDGxGTpQYgVg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1672431371;\n\tbh=vVQvbX77XDLO9luKQpEA7AGCrX+ApQu3e9FTyCI19RA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tEe6RvbgqhXRSy1t3fdo8WvF7z8w2odl3rXQsG9HO9S8h6PyhoNE7BPQIRhZgy0XK\n\tf3pXL78aAQnDS6aQovHdGdebYcjPEhQr0EM36p2dNP3fCscNv0TU6nPkc7fAcDZ4S+\n\t0q0aXkY1nKtklovw+4SWmSvA33tz0Yj1VhOw5SLc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tEe6Rvbg\"; dkim-atps=neutral","Date":"Fri, 30 Dec 2022 22:16:06 +0200","To":"Christian Rauch ","Message-ID":"","References":"<20221229225435.36569-1-Rauch.Christian@gmx.de>\n\t<167235994150.3944359.3770379794753430331@Monstersaurus>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] qcam: Show string representation of\n\tpixel format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]