[{"id":26177,"web_url":"https://patchwork.libcamera.org/comment/26177/","msgid":"","date":"2022-12-30T20:19:46","subject":"Re: [libcamera-devel] [PATCH v2] meson: Add 'all' choice to\n\tpipelines option","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nOn Thu, Dec 29, 2022 at 10:40:15AM -0600, Paul Elder wrote:\n> Add an 'all' choice to the pipelines option, for building all pipelines.\n> \n> Signed-off-by: Paul Elder \n> Conditionally-Reviewed-by: Laurent Pinchart \n> Conditionally-Reviewed-by: Umang Jain \n\nThe idea of Conditionally-Reviewed-by is that you can drop the\n\"Conditionally-\" prefix after applying the changes requested during\nreview :-)\n\n> ---\n> Changes in v2:\n> - specify what happens if both auto and all are selected\n> ---\n> meson.build | 12 ++++++++++++\n> meson_options.txt | 3 ++-\n> 2 files changed, 14 insertions(+), 1 deletion(-)\n> \n> diff --git a/meson.build b/meson.build\n> index df9099d0..24c31303 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -164,6 +164,18 @@ liblttng = dependency('lttng-ust', required : get_option('tracing'))\n> # are enabled.\n> pipelines = get_option('pipelines')\n> \n> +if pipelines.contains('all')\n> + pipelines = [\n> + 'imx8-isi',\n> + 'ipu3',\n> + 'raspberrypi',\n> + 'rkisp1',\n> + 'simple',\n> + 'uvcvideo',\n> + 'vimc'\n\nA trailing comma would be nice to minimize changes when adding new\npipeline handlers (not sure which platform would go after vimc though).\n\nFeel free to push this.\n\n> + ]\n> +endif\n> +\n> if pipelines.contains('auto')\n> host_cpu = host_machine.cpu_family()\n> pipelines = []\n> diff --git a/meson_options.txt b/meson_options.txt\n> index 793cda93..78a78b72 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -39,6 +39,7 @@ option('pipelines',\n> type : 'array',\n> value : ['auto'],\n> choices : [\n> + 'all',\n> 'auto',\n> 'imx8-isi',\n> 'ipu3',\n> @@ -48,7 +49,7 @@ option('pipelines',\n> 'uvcvideo',\n> 'vimc'\n> ],\n> - description : 'Select which pipeline handlers to build. If this is set to auto, all the pipelines applicable to the target architecture will be built.')\n> + description : 'Select which pipeline handlers to build. If this is set to \"auto\", all the pipelines applicable to the target architecture will be built. If this is set to \"all\", all the pipelines will be built. If both are selected then \"all\" will take precedence.')\n> \n> option('qcam',\n> type : 'feature',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4CFDBD78E\n\tfor ;\n\tFri, 30 Dec 2022 20:19:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 295A3625CB;\n\tFri, 30 Dec 2022 21:19:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10F6C61F11\n\tfor ;\n\tFri, 30 Dec 2022 21:19:52 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 687732F5;\n\tFri, 30 Dec 2022 21:19:51 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672431594;\n\tbh=qiHn2ecbpyxdSeWUd6SP1iMLu0bxeRB8LMlNlqtAGTM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=oiT+lmb/3rKTe9o3u9NSY0ekt4LOleLXP9M1RI84zHCp+G8a3rsUWKGeZZWfdpSp4\n\t4KcOoTbiscQkcxnXy8HO0tjG5Jrkyzq8inghBo6EsgQxAcIJfC4KtBis1EIjt2TZ9q\n\tK7mYoQGjGWp3kzrff5nFduh/8U/ITtOCEla/WiEWxnS1/RUi52Sgw9itc1feqXcXYt\n\teqGl0UydQdFMuEvJRjRt1hl5SXiDFoE8pd74kO+m2m8cpggyPYxfv2ThilK/M/Nig9\n\tl6QLtsu9KFui/oCgvzC2A3Pq8ApOC+DlcBxjiSLhnbfMlBuivDDa152+fYKaK/hllM\n\tpVbGEN3VQjhhw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1672431591;\n\tbh=qiHn2ecbpyxdSeWUd6SP1iMLu0bxeRB8LMlNlqtAGTM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GA0rtk2Y9JPfDTjoJn9jDMQMzV3+Gj4Fzu+NT2TyUJtSHbEa8w2KGk/rV4YRhDCP8\n\tBuSwW2KBS0BmtndRAZ9wCiuzxogeE0Yi/6aaez7lwdkd+byc4uQdUsdndAiG6gZtYL\n\tWX89aAywGLOM61OCRGGzAls4AaW014gwigzsFYpY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GA0rtk2Y\"; dkim-atps=neutral","Date":"Fri, 30 Dec 2022 22:19:46 +0200","To":"Paul Elder ","Message-ID":"","References":"<20221229164015.1650864-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221229164015.1650864-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] meson: Add 'all' choice to\n\tpipelines option","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]