[{"id":26170,"web_url":"https://patchwork.libcamera.org/comment/26170/","msgid":"","date":"2022-12-29T00:02:21","subject":"Re: [libcamera-devel] [PATCH] meson: Add 'all' choice to pipelines\n\toption","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Dec 28, 2022 at 04:57:10PM -0600, Paul Elder via libcamera-devel wrote:\n> Add an 'all' choice to the pipelines option, for building all pipelines.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> This patch depends on \"meson: options: Fix typo in pipelines\n> documentation\" [1]\n> \n> [1] https://patchwork.libcamera.org/patch/18076/\n> \n> This way we don't have to update buildbot scripts every time we add a\n> new pipeline handler (unless it doens't happen often enough that we\n> don't need this option).\n> \n> The pipelines need to be explicitly listed for meson to build them.\n> ---\n> meson.build | 12 ++++++++++++\n> meson_options.txt | 3 ++-\n> 2 files changed, 14 insertions(+), 1 deletion(-)\n> \n> diff --git a/meson.build b/meson.build\n> index df9099d0..4e5c417d 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -181,6 +181,18 @@ if pipelines.contains('auto')\n> pipelines += ['uvcvideo']\n> endif\n> \n> +if pipelines.contains('all')\n> + pipelines = [\n> + 'imx8-isi',\n> + 'ipu3',\n> + 'raspberrypi',\n> + 'rkisp1',\n> + 'simple',\n> + 'uvcvideo',\n> + 'vimc'\n> + ]\n> +endif\n> +\n> if get_option('test') and 'vimc' not in pipelines\n> message('Enabling vimc pipeline handler to support tests')\n> pipelines += ['vimc']\n> diff --git a/meson_options.txt b/meson_options.txt\n> index 793cda93..2443acf3 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -39,6 +39,7 @@ option('pipelines',\n> type : 'array',\n> value : ['auto'],\n> choices : [\n> + 'all',\n> 'auto',\n> 'imx8-isi',\n> 'ipu3',\n> @@ -48,7 +49,7 @@ option('pipelines',\n> 'uvcvideo',\n> 'vimc'\n> ],\n> - description : 'Select which pipeline handlers to build. If this is set to auto, all the pipelines applicable to the target architecture will be built.')\n> + description : 'Select which pipeline handlers to build. If this is set to auto, all the pipelines applicable to the target architecture will be built. If this is set to all, all the pipelines will be built. ')\n\nI'd write \"auto\" and \"all\" with quotes (I'll let you decide if single,\ndouble or back quotes are best).\n\nWhat if the user sets both \"all\" and \"auto\" ? I don't think that's a\nvalid use case, but I'd document whatever behaviour you think is best at\nleast in the commit message and possible here.\n\nConditionally-Reviewed-by: Laurent Pinchart \n\n> \n> option('qcam',\n> type : 'feature',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE1D2BD78E\n\tfor ;\n\tThu, 29 Dec 2022 00:02:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49A9E625C8;\n\tThu, 29 Dec 2022 01:02:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7F1F625C7\n\tfor ;\n\tThu, 29 Dec 2022 01:02:26 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 11BE0109;\n\tThu, 29 Dec 2022 01:02:25 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672272148;\n\tbh=aglr9GEE0+XVf04hLDjGbHyUvYCEu/jimeOeBuMbCcA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=TNMi+H3tWHGXg+ECa0p4F3CdpuW/h8DFfCRDRCi7RLgzCDU8crHpx1KVRBLQDty3s\n\t6NCgrZy/Aj0lKhhbjaTmp1cnkeOM2YQk/CyuyiGW1tJRhKdrk770dAR8/WJM4nqfeI\n\tYEx9wb7GvVSIAI+7EtD+qisdt/SLX1s3brF02iE0ZbQQ5vdjJ8Igw1k6XvhaLn+4x7\n\togpG44vjX8/fK2Dj1Rpk3Kl3xRGQjP5V3Ay4wdUB5lnTTxYdQDveJuRSPpZPkY44ew\n\tmigcxa2RPMhEobukD1b+Mz3OhfDU/yBQbek5t2mf1n84aQ677qiHCovnW0FcRGwJuY\n\t2/EBmih+//wXw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1672272146;\n\tbh=aglr9GEE0+XVf04hLDjGbHyUvYCEu/jimeOeBuMbCcA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=l+rULxqjbpVDHG2UEhwNLNXNsagL8nwJ1ImirujrH2r5oi6AqpkdNO/2Sl4KQhKmr\n\tAeuYmNi9Q0AHPY8lpHCXLSjoshejKHPoSh82R1yFQoKlS8zkafUddV2tbqzrq+CjuA\n\tJmzzqaL3cPE1kc45z8BEnFks1x2ukxH9gflr1G2w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"l+rULxqj\"; dkim-atps=neutral","Date":"Thu, 29 Dec 2022 02:02:21 +0200","To":"Paul Elder ","Message-ID":"","References":"<20221228225710.2357657-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221228225710.2357657-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] meson: Add 'all' choice to pipelines\n\toption","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26172,"web_url":"https://patchwork.libcamera.org/comment/26172/","msgid":"","date":"2022-12-29T16:08:02","subject":"Re: [libcamera-devel] [PATCH] meson: Add 'all' choice to pipelines\n\toption","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi,\n\nOn 12/29/22 5:32 AM, Laurent Pinchart via libcamera-devel wrote:\n> Hi Paul,\n>\n> Thank you for the patch.\n>\n> On Wed, Dec 28, 2022 at 04:57:10PM -0600, Paul Elder via libcamera-devel wrote:\n>> Add an 'all' choice to the pipelines option, for building all pipelines.\n>>\n>> Signed-off-by: Paul Elder \n>>\n>> ---\n>> This patch depends on \"meson: options: Fix typo in pipelines\n>> documentation\" [1]\n>>\n>> [1] https://patchwork.libcamera.org/patch/18076/\n>>\n>> This way we don't have to update buildbot scripts every time we add a\n>> new pipeline handler (unless it doens't happen often enough that we\n>> don't need this option).\n>>\n>> The pipelines need to be explicitly listed for meson to build them.\n>> ---\n>> meson.build | 12 ++++++++++++\n>> meson_options.txt | 3 ++-\n>> 2 files changed, 14 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/meson.build b/meson.build\n>> index df9099d0..4e5c417d 100644\n>> --- a/meson.build\n>> +++ b/meson.build\n>> @@ -181,6 +181,18 @@ if pipelines.contains('auto')\n>> pipelines += ['uvcvideo']\n>> endif\n>> \n>> +if pipelines.contains('all')\n>> + pipelines = [\n>> + 'imx8-isi',\n>> + 'ipu3',\n>> + 'raspberrypi',\n>> + 'rkisp1',\n>> + 'simple',\n>> + 'uvcvideo',\n>> + 'vimc'\n>> + ]\n>> +endif\n>> +\n>> if get_option('test') and 'vimc' not in pipelines\n>> message('Enabling vimc pipeline handler to support tests')\n>> pipelines += ['vimc']\n>> diff --git a/meson_options.txt b/meson_options.txt\n>> index 793cda93..2443acf3 100644\n>> --- a/meson_options.txt\n>> +++ b/meson_options.txt\n>> @@ -39,6 +39,7 @@ option('pipelines',\n>> type : 'array',\n>> value : ['auto'],\n>> choices : [\n>> + 'all',\n>> 'auto',\n>> 'imx8-isi',\n>> 'ipu3',\n>> @@ -48,7 +49,7 @@ option('pipelines',\n>> 'uvcvideo',\n>> 'vimc'\n>> ],\n>> - description : 'Select which pipeline handlers to build. If this is set to auto, all the pipelines applicable to the target architecture will be built.')\n>> + description : 'Select which pipeline handlers to build. If this is set to auto, all the pipelines applicable to the target architecture will be built. If this is set to all, all the pipelines will be built. ')\n> I'd write \"auto\" and \"all\" with quotes (I'll let you decide if single,\n> double or back quotes are best).\n>\n> What if the user sets both \"all\" and \"auto\" ? I don't think that's a\n> valid use case, but I'd document whatever behaviour you think is best at\n> least in the commit message and possible here.\n\nLikewise,\n>\n> Conditionally-Reviewed-by: Laurent Pinchart \n\nConditionally-Reviewed-by: Umang Jain \n\n>\n>> \n>> option('qcam',\n>> type : 'feature',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87D99BD78E\n\tfor ;\n\tThu, 29 Dec 2022 16:08:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3604B625CF;\n\tThu, 29 Dec 2022 17:08:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7FBE961F12\n\tfor ;\n\tThu, 29 Dec 2022 17:08:11 +0100 (CET)","from [IPV6:2409:4042:4e9a:4f4d:7592:6efc:57be:9268] (unknown\n\t[IPv6:2409:4042:4e9a:4f4d:7592:6efc:57be:9268])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 83B47283;\n\tThu, 29 Dec 2022 17:08:09 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1672330093;\n\tbh=ih4t3I8adIJPwiwgXaoPLYoX49zK1ynktN8cFVA9KDQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=GRhyhsvS3ViN7KfwiNK4xXS2kyR2B+l/ISxgNKT6W8P+LTkO0uvoShCqC7laR19TX\n\tgff1kphX9BFAGePV9X32YHorzdT2K0oHjzpUZCQEZiDnLwoy9PXIsyHuIfojF2XQTk\n\toGAvtgcT087fF4i2LgjJEZuF0e4XgRzPXPcF/EZA28qfOO+30f8JiDpltJtzlHfaoB\n\txJYBN3wVmozRU5kCDYLDK8Y/ZjYEb3n/CR8Z6nrzWnaJyzo52ivhHvJmGiOWu21+GA\n\tXQqDbvakmreYjvhx1ggj33+WwoBNzpQJH0MmXulooTqSoPnmpxuj6hwywhToaioJey\n\t1ExpaLVht+nqQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1672330091;\n\tbh=ih4t3I8adIJPwiwgXaoPLYoX49zK1ynktN8cFVA9KDQ=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=VUM5L6LI1T3GvoGljWqmTtzL+FM8NLi1ddMwJAQn/LhYIgrA3Wp5lDWeVGI3Q+xbn\n\tYiKb3V1nqWnikd+I9Qk5lDBKoMOrTGACjgvBv8VD7MEFZFdRQo9ZZO85mJOdNA3f3g\n\t7lO/qL+hiX7D9iLfJW/DXvB1TH+Z7JIktH4BOmeA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VUM5L6LI\"; dkim-atps=neutral","Message-ID":"","Date":"Thu, 29 Dec 2022 21:38:02 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.5.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tPaul Elder ","References":"<20221228225710.2357657-1-paul.elder@ideasonboard.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] meson: Add 'all' choice to pipelines\n\toption","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]