[{"id":26155,"web_url":"https://patchwork.libcamera.org/comment/26155/","msgid":"<7ee867fa-e7f4-8e6f-2316-35868dd42589@riseup.net>","date":"2022-12-24T10:12:21","subject":"Re: [libcamera-devel] [PATCHv2] gstreamer: Add bayer8 support to\n\tlibcamerasrc element","submitter":{"id":128,"url":"https://patchwork.libcamera.org/api/people/128/","name":"Rafael Diniz","email":"rafael@riseup.net"},"content":"Hi Pavel and all,\n\nDo you have a sample gst-lauch line which forces bayer format in order I \ncan test this also in the PinePhone 1?\n\nRafael\n\nOn 12/23/22 20:23, Pavel Machek via libcamera-devel wrote:\n> Bayer8 support is useful on hardware such as Librem 5, as GStreamer\n> provides easy solution for debayering and display of the camera\n> data. Add neccessary glue to libcamerasrc element.\n>      \n> Signed-off-by: Pavel Machek <pavel@ucw.cz>\n> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n> \n> --\n> \n> Thanks for the review!\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index 36b9564c..b2cc7661 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -20,6 +20,12 @@ static struct {\n>   \t/* Compressed */\n>   \t{ GST_VIDEO_FORMAT_ENCODED, formats::MJPEG },\n>   \n> +\t/* Bayer formats, gstreamer only supports 8-bit */\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SGRBG8 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SGBRG8 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SRGGB8 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SBGGR8 },\n> +\n>   \t/* RGB16 */\n>   \t{ GST_VIDEO_FORMAT_RGB16, formats::RGB565 },\n>   \n> @@ -228,6 +234,22 @@ gst_format_to_pixel_format(GstVideoFormat gst_format)\n>   \treturn PixelFormat{};\n>   }\n>   \n> +static const gchar *\n> +bayer_format_to_string(int format)\n> +{\n> +\tswitch (format) {\n> +\tcase formats::SGRBG8:\n> +\t\treturn \"grbg\";\n> +\tcase formats::SGBRG8:\n> +\t\treturn \"gbrg\";\n> +\tcase formats::SRGGB8:\n> +\t\treturn \"rggb\";\n> +\tcase formats::SBGGR8:\n> +\t\treturn \"bggr\";\n> +\t}\n> +\treturn NULL;\n> +}\n> +\n>   static GstStructure *\n>   bare_structure_from_format(const PixelFormat &format)\n>   {\n> @@ -243,6 +265,12 @@ bare_structure_from_format(const PixelFormat &format)\n>   \tswitch (format) {\n>   \tcase formats::MJPEG:\n>   \t\treturn gst_structure_new_empty(\"image/jpeg\");\n> +\tcase formats::SGRBG8:\n> +\tcase formats::SGBRG8:\n> +\tcase formats::SRGGB8:\n> +\tcase formats::SBGGR8:\n> +\t\treturn gst_structure_new(\"video/x-bayer\", \"format\", G_TYPE_STRING,\n> +\t\t\t\t\t bayer_format_to_string(format), nullptr);\n>   \tdefault:\n>   \t\treturn nullptr;\n>   \t}\n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 8d97d7c2..a10cbd4f 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -161,7 +161,7 @@ G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT,\n>   \t\t\tGST_DEBUG_CATEGORY_INIT(source_debug, \"libcamerasrc\", 0,\n>   \t\t\t\t\t\t\"libcamera Source\"))\n>   \n> -#define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw; image/jpeg\")\n> +#define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw; image/jpeg; video/x-bayer\")\n>   \n>   /* For the simple case, we have a src pad that is always present. */\n>   GstStaticPadTemplate src_template = {\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C18B1BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 24 Dec 2022 10:12:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22BC4625C8;\n\tSat, 24 Dec 2022 11:12:32 +0100 (CET)","from mx1.riseup.net (mx1.riseup.net [198.252.153.129])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84000625C8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 24 Dec 2022 11:12:29 +0100 (CET)","from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256\n\tclient-signature RSA-PSS (2048 bits) client-digest SHA256)\n\t(Client CN \"mail.riseup.net\", Issuer \"R3\" (not verified))\n\tby mx1.riseup.net (Postfix) with ESMTPS id 4NfKbv2GymzDqFw;\n\tSat, 24 Dec 2022 10:12:27 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1])\n\tby fews2.riseup.net (Postfix) with ESMTPSA id 4NfKbr4hZHz1yZp;\n\tSat, 24 Dec 2022 10:12:24 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671876752;\n\tbh=qlsKzjbwtLrhskq6vtmOULWdK1Xvb7KUna/g/voVSpA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=BOdj6cpNOaOxfunsKvpdFeOEtFCgkOEB+WAjc1jXnZNFDxpSnN6WmVHGcVsWeFB7A\n\t4TI9yboL4cMykQjpcCoovL2d8wsT6cp4iww00IncnjTefZvDjE9RiwIZZZxXcYzPOl\n\teBiupgA2102aR9aTBsghoR9AVYZPdnTlpMEA52jr/IBX20p1mVbc/7BU3zGm4A2yQq\n\t/VpBhMsAWkxwwDDjjiM+UIq816/UbSOQSJJ1rmPLX3QEHQsApSUND/MD2qAES9x4Ja\n\tOzwVsZTaCuyaPoVxS7wvA51GINwZKTHq+MehJh0IkWAweZ6jnQRP7qg3MbQL5BlhVT\n\tx8WA8F5jlRbbA==","v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; \n\tt=1671876747; bh=qlsKzjbwtLrhskq6vtmOULWdK1Xvb7KUna/g/voVSpA=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=pZmYjQNiYsU4yp0zTfDcNKEEkjA3tU/4SPzYogY63u2Y9lyrgaP56B+2jL1JKLoos\n\twYnKcEz3/VjvwsdvEqEdN9si3oO8qtOb9eI6EDY7Xm7ZrzWsV2laxGxgRyFPXYSHi4\n\tLG313Ajvh8yOeaD0miwmLUEdebAUZ3Najq0Qiphw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=riseup.net\n\theader.i=@riseup.net header.b=\"pZmYjQNi\"; \n\tdkim-atps=neutral","X-Riseup-User-ID":"FFCD7983FBF4F53ECDF2F84973F781E191BB20FDE51E1CAF3320DC25DE59F50E","Message-ID":"<7ee867fa-e7f4-8e6f-2316-35868dd42589@riseup.net>","Date":"Sat, 24 Dec 2022 13:12:21 +0300","MIME-Version":"1.0","To":"Pavel Machek <pavel@ucw.cz>, Nicolas Dufresne <nicolas@ndufresne.ca>","References":"<Y52jM6iQtzs0Vysm@duo.ucw.cz>\n\t<CAKQmDh9BDUWonGdnOqz4uNPwS+L6cQMh1A2O4Be3Z=z+JqbQTQ@mail.gmail.com>\n\t<Y545RJF0JMWIQUwe@duo.ucw.cz>\n\t<a060b121a53465d2118d8d6194cd866e32ccc238.camel@ndufresne.ca>\n\t<Y6IzhjY3XQZn2oci@duo.ucw.cz>\n\t<167162721688.3944359.738999548555516756@Monstersaurus>\n\t<Y6NFu/O6VDG+WYdN@duo.ucw.cz>\n\t<aeb18f80a76778f99db08d3600036e34257024cc.camel@ndufresne.ca>\n\t<Y6XkAEC7SOKsKMBk@duo.ucw.cz>","Content-Language":"en-US","In-Reply-To":"<Y6XkAEC7SOKsKMBk@duo.ucw.cz>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"------------ZFzMi0KTtFQzGpMOKDl3Ltwr\"","Subject":"Re: [libcamera-devel] [PATCHv2] gstreamer: Add bayer8 support to\n\tlibcamerasrc element","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Rafael Diniz via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Rafael Diniz <rafael@riseup.net>","Cc":"Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tPavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":26156,"web_url":"https://patchwork.libcamera.org/comment/26156/","msgid":"<CAKQmDh8RudSTZOkSioDCuu_4RapxtDzG5FSOAKeOG453iYQBbg@mail.gmail.com>","date":"2022-12-24T13:29:49","subject":"Re: [libcamera-devel] [PATCHv2] gstreamer: Add bayer8 support to\n\tlibcamerasrc element","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le sam. 24 déc. 2022, 05 h 12, Rafael Diniz <rafael@riseup.net> a écrit :\n\n> Hi Pavel and all,\n>\n> Do you have a sample gst-lauch line which forces bayer format in order I\n> can test this also in the PinePhone 1?\n>\n\nI can't test, but this should do:\n\ngst-launch-1.0 libcamerasrc ! bayer2rgb ! glimagesink\n\nThe bayer2rgb template caps will serve as a filter, like a jpeg decoder\nwould force jpeg. But if needed, video/x-bayer is the filter you need.\n\nbest wishes,\nNicolas\n\n\n> Rafael\n>\n> On 12/23/22 20:23, Pavel Machek via libcamera-devel wrote:\n> > Bayer8 support is useful on hardware such as Librem 5, as GStreamer\n> > provides easy solution for debayering and display of the camera\n> > data. Add neccessary glue to libcamerasrc element.\n> >\n> > Signed-off-by: Pavel Machek <pavel@ucw.cz>\n> > Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n> >\n> > --\n> >\n> > Thanks for the review!\n> >\n> > diff --git a/src/gstreamer/gstlibcamera-utils.cpp\n> b/src/gstreamer/gstlibcamera-utils.cpp\n> > index 36b9564c..b2cc7661 100644\n> > --- a/src/gstreamer/gstlibcamera-utils.cpp\n> > +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> > @@ -20,6 +20,12 @@ static struct {\n> >       /* Compressed */\n> >       { GST_VIDEO_FORMAT_ENCODED, formats::MJPEG },\n> >\n> > +     /* Bayer formats, gstreamer only supports 8-bit */\n> > +     { GST_VIDEO_FORMAT_ENCODED, formats::SGRBG8 },\n> > +     { GST_VIDEO_FORMAT_ENCODED, formats::SGBRG8 },\n> > +     { GST_VIDEO_FORMAT_ENCODED, formats::SRGGB8 },\n> > +     { GST_VIDEO_FORMAT_ENCODED, formats::SBGGR8 },\n> > +\n> >       /* RGB16 */\n> >       { GST_VIDEO_FORMAT_RGB16, formats::RGB565 },\n> >\n> > @@ -228,6 +234,22 @@ gst_format_to_pixel_format(GstVideoFormat\n> gst_format)\n> >       return PixelFormat{};\n> >   }\n> >\n> > +static const gchar *\n> > +bayer_format_to_string(int format)\n> > +{\n> > +     switch (format) {\n> > +     case formats::SGRBG8:\n> > +             return \"grbg\";\n> > +     case formats::SGBRG8:\n> > +             return \"gbrg\";\n> > +     case formats::SRGGB8:\n> > +             return \"rggb\";\n> > +     case formats::SBGGR8:\n> > +             return \"bggr\";\n> > +     }\n> > +     return NULL;\n> > +}\n> > +\n> >   static GstStructure *\n> >   bare_structure_from_format(const PixelFormat &format)\n> >   {\n> > @@ -243,6 +265,12 @@ bare_structure_from_format(const PixelFormat\n> &format)\n> >       switch (format) {\n> >       case formats::MJPEG:\n> >               return gst_structure_new_empty(\"image/jpeg\");\n> > +     case formats::SGRBG8:\n> > +     case formats::SGBRG8:\n> > +     case formats::SRGGB8:\n> > +     case formats::SBGGR8:\n> > +             return gst_structure_new(\"video/x-bayer\", \"format\",\n> G_TYPE_STRING,\n> > +                                      bayer_format_to_string(format),\n> nullptr);\n> >       default:\n> >               return nullptr;\n> >       }\n> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp\n> b/src/gstreamer/gstlibcamerasrc.cpp\n> > index 8d97d7c2..a10cbd4f 100644\n> > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > @@ -161,7 +161,7 @@ G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc,\n> gst_libcamera_src, GST_TYPE_ELEMENT,\n> >                       GST_DEBUG_CATEGORY_INIT(source_debug,\n> \"libcamerasrc\", 0,\n> >                                               \"libcamera Source\"))\n> >\n> > -#define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw; image/jpeg\")\n> > +#define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw; image/jpeg;\n> video/x-bayer\")\n> >\n> >   /* For the simple case, we have a src pad that is always present. */\n> >   GstStaticPadTemplate src_template = {\n> >\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8899C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 24 Dec 2022 13:30:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2807A625CF;\n\tSat, 24 Dec 2022 14:30:03 +0100 (CET)","from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com\n\t[IPv6:2607:f8b0:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A643361F17\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 24 Dec 2022 14:30:01 +0100 (CET)","by mail-pf1-x42f.google.com with SMTP id n3so4868286pfq.10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 24 Dec 2022 05:30:01 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671888603;\n\tbh=oB7Nj8E52rnnV0DkvKZP0KIamKRFfzTONhyATR1U5UM=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2k/AAvN/HSJOy73MIyj++H67oxm6wwaIOQ0PZqlgHv7uv6KP7dmKAjGoqaGIYop/b\n\to/pLbRfjUHNzzVA4uDdQ3L6DKIdZ7Uh/TiNM4jsLcbK7pj8dcgcULAlxRfOC2OQm6D\n\tibJqW/3EwCf8QGfZIf1GQPm3jCtWnYm8DD1TkJHwG9NTUSkrm27EJ57fhUnayUGlJ4\n\ty7ME3N8yGNRTPPFYKTjX0GLee+dCpL+wppYiTEvBe/IXEqEzNamMchmsLtJmENG1Jv\n\thmDPlMX+Tc1qXGMd2b3qwtTi8rnWsRwwnLLQ8u/BtoLVNM2Dt0Z1YRus6BxI0Ivc0c\n\tCRp5mzE9uuX3g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20210112.gappssmtp.com; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=0yyCupYPEAhXGhHWfl0HZMkYlwxQ9tFELXNADtiSulk=;\n\tb=7bwK2l/XY3odrhm4gPPFHmKzzaBmB6rR8Ws4FQ/xocioM7Dax92YyWj2T3IaOue9Dm\n\tDKdl/6xaYft03EavzzmmTfoQLV8ITuFzdBAcdC1FrQC/vJYvvboMGwZzorW+7IGsbsFF\n\tK2Q9iRqfhGdSuDmFoVgA9XhkQtCWy5dlos2lb46P73dLTinrHQHLuvsH13R6wwCxAuDn\n\ttII6vtH6g7clFGONVsv/MFIhRZJRoIH7Rh16zYXo0c5xNXejAF2dR3aQRiFA6tXhJqHm\n\tlgAUFD6dp7xEq5P0oL/qgxAlt3GaCz5HOu3OPIIGMmpG3Z1CqsDM0VKx8QVUaQl+WSaK\n\tJmOA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ndufresne-ca.20210112.gappssmtp.com\n\theader.i=@ndufresne-ca.20210112.gappssmtp.com header.b=\"7bwK2l/X\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=0yyCupYPEAhXGhHWfl0HZMkYlwxQ9tFELXNADtiSulk=;\n\tb=OVueF3E05IAPDyr0ULpieqTkC4Ig1lnk8Ru8HuemiNBxskg3P4Z2XQDlBnvWLwtvuM\n\tp0jjPZu9Pd64mt/8uND6f3fNp3qNjzlI0Dm5WNngbBeTr+o7gR2VHaDOToPOI8SRyhyh\n\tWl7h1tGC0/AZU7aWEiAWz82cBTk1p9NE270Yo9dmEKbOfA3U12OJn0IWbXIpnTv1FLxG\n\t990mPO11AU6Gn/9sqqWdUq1iNdYGobKLiCuZJ3F8l7HFHpVAAQveMROR9UT8hNNF0FDc\n\tP1KdZ+k2JLr0+mmNEynorADtFZNo4UIdgxxH5OAbGm98wstwnWIr1W1iSIgdvAs1aoYU\n\tZFlg==","X-Gm-Message-State":"AFqh2kqsGT7zVsaYmF3YjhvWIIaMnaLNqpQuLEfCwiJPhi+Zw0XZ6D/e\n\teW3JTml0poyGn4AX/qRkMOuuoJedyIPC12WCrirrKg==","X-Google-Smtp-Source":"AMrXdXtY3MVTvFOj7pQk5PFEUHUwR4Tj2yyCgYXKDdcH00zFvDSqniteNFrdW7fQ35u2JXcoSz+HY46V66Mj/pikl3U=","X-Received":"by 2002:aa7:9892:0:b0:57a:9cfb:3490 with SMTP id\n\tr18-20020aa79892000000b0057a9cfb3490mr805613pfl.86.1671888600025;\n\tSat, 24 Dec 2022 05:30:00 -0800 (PST)","MIME-Version":"1.0","References":"<Y52jM6iQtzs0Vysm@duo.ucw.cz>\n\t<CAKQmDh9BDUWonGdnOqz4uNPwS+L6cQMh1A2O4Be3Z=z+JqbQTQ@mail.gmail.com>\n\t<Y545RJF0JMWIQUwe@duo.ucw.cz>\n\t<a060b121a53465d2118d8d6194cd866e32ccc238.camel@ndufresne.ca>\n\t<Y6IzhjY3XQZn2oci@duo.ucw.cz>\n\t<167162721688.3944359.738999548555516756@Monstersaurus>\n\t<Y6NFu/O6VDG+WYdN@duo.ucw.cz>\n\t<aeb18f80a76778f99db08d3600036e34257024cc.camel@ndufresne.ca>\n\t<Y6XkAEC7SOKsKMBk@duo.ucw.cz>\n\t<7ee867fa-e7f4-8e6f-2316-35868dd42589@riseup.net>","In-Reply-To":"<7ee867fa-e7f4-8e6f-2316-35868dd42589@riseup.net>","Date":"Sat, 24 Dec 2022 08:29:49 -0500","Message-ID":"<CAKQmDh8RudSTZOkSioDCuu_4RapxtDzG5FSOAKeOG453iYQBbg@mail.gmail.com>","To":"Rafael Diniz <rafael@riseup.net>","Content-Type":"multipart/alternative; boundary=\"0000000000001bdf3005f092e60c\"","Subject":"Re: [libcamera-devel] [PATCHv2] gstreamer: Add bayer8 support to\n\tlibcamerasrc element","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Nicolas Dufresne via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Nicolas Dufresne <nicolas@ndufresne.ca>","Cc":"Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tPavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>, \n\tPavel Machek <pavel@ucw.cz>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":26157,"web_url":"https://patchwork.libcamera.org/comment/26157/","msgid":"<Y6cNM/EzaPy1ziES@duo.ucw.cz>","date":"2022-12-24T14:31:15","subject":"Re: [libcamera-devel] [PATCHv2] gstreamer: Add bayer8 support to\n\tlibcamerasrc element","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n> Do you have a sample gst-lauch line which forces bayer format in order I can\n> test this also in the PinePhone 1?\n\nI'm using:\n\ngst-launch-1.0 libcamerasrc camera-name=\"/base/soc@0/bus@30800000/i2c@30a50000/camera@2d\" !  bayer2rgb ! videoscale ! video/x-raw,width=640,height=480 ! videoflip method=clockwise ! ximagesink\n\nYou'll need to tweak at least the name.\n\nBR,\n\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39C3CBD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 24 Dec 2022 14:31:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7673E625CB;\n\tSat, 24 Dec 2022 15:31:18 +0100 (CET)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23D3761F17\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 24 Dec 2022 15:31:16 +0100 (CET)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid 723121C09F4; Sat, 24 Dec 2022 15:31:15 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671892278;\n\tbh=n6vh5pg1Gtgt0lU2vWQUvMiPOt/kH3puCD6wM7GNpMQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=e4vFl1949GcLojplHs5Ugrdp0ziV3hOzMhWiczguazlqNpwLloGoPCduFWu4wsuTj\n\tJPVEi3699mrDuDTL4QtyEy3oyi8R3SbBIec4CfgfA0evQO/ZOe2GD3BkRgs6/bRwir\n\tVw9ebUr0vH3q3o/4wqgSrnPcr2GRJG/3CcdxgO5OFykCs8mJVMFIW2iIqE+xMghTFK\n\tBpAXbUkabbGdIRPTvFyvNUpLOqxzoFIAUYqjIt9Tp1375d8xH1dgzpPukme2D2GaB0\n\tIPkCyfnoZn8OpZPw+DjIWmUo7UO27f6WWKV8X97GBYFHBIWzEXAeNyumSiHPLM29lB\n\t87m8Te4jIKc9A==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1671892275;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ZnmqJa1PHZFbBTQnYVcztUuhbepcfFIHqkxNqbHCiPA=;\n\tb=OTxI/mUUS8DWU0Ec5uIb6s8ZYjnFwLlHa0tymIlkuex9VIE9z06ZjBF500Ll1x8P6xXyqb\n\tsUuVyiAofSn9nKf/r2fJMyqa+wmvcAysu09fW/rPA26TO8CwMiqulfPKcQBATm9ZEDNq7J\n\tPehROBuT69bwgIHWpUfgOR9GIXUc/yo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"OTxI/mUU\"; dkim-atps=neutral","Date":"Sat, 24 Dec 2022 15:31:15 +0100","To":"Rafael Diniz <rafael@riseup.net>","Message-ID":"<Y6cNM/EzaPy1ziES@duo.ucw.cz>","References":"<Y52jM6iQtzs0Vysm@duo.ucw.cz>\n\t<CAKQmDh9BDUWonGdnOqz4uNPwS+L6cQMh1A2O4Be3Z=z+JqbQTQ@mail.gmail.com>\n\t<Y545RJF0JMWIQUwe@duo.ucw.cz>\n\t<a060b121a53465d2118d8d6194cd866e32ccc238.camel@ndufresne.ca>\n\t<Y6IzhjY3XQZn2oci@duo.ucw.cz>\n\t<167162721688.3944359.738999548555516756@Monstersaurus>\n\t<Y6NFu/O6VDG+WYdN@duo.ucw.cz>\n\t<aeb18f80a76778f99db08d3600036e34257024cc.camel@ndufresne.ca>\n\t<Y6XkAEC7SOKsKMBk@duo.ucw.cz>\n\t<7ee867fa-e7f4-8e6f-2316-35868dd42589@riseup.net>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"Tm5zZD7DZFYYvPyC\"","Content-Disposition":"inline","In-Reply-To":"<7ee867fa-e7f4-8e6f-2316-35868dd42589@riseup.net>","Subject":"Re: [libcamera-devel] [PATCHv2] gstreamer: Add bayer8 support to\n\tlibcamerasrc element","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Pavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Pavel Machek <pavel@ucw.cz>","Cc":"Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tPavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":26158,"web_url":"https://patchwork.libcamera.org/comment/26158/","msgid":"<41316602-acf3-39c7-0a3e-6c38c8af3d7e@riseup.net>","date":"2022-12-24T14:41:53","subject":"Re: [libcamera-devel] [PATCHv2] gstreamer: Add bayer8 support to\n\tlibcamerasrc element","submitter":{"id":128,"url":"https://patchwork.libcamera.org/api/people/128/","name":"Rafael Diniz","email":"rafael@riseup.net"},"content":"Tks all!\n: )\n\n\nOn 12/24/22 17:31, Pavel Machek wrote:\n> Hi!\n> \n>> Do you have a sample gst-lauch line which forces bayer format in order I can\n>> test this also in the PinePhone 1?\n> \n> I'm using:\n> \n> gst-launch-1.0 libcamerasrc camera-name=\"/base/soc@0/bus@30800000/i2c@30a50000/camera@2d\" !  bayer2rgb ! videoscale ! video/x-raw,width=640,height=480 ! videoflip method=clockwise ! ximagesink\n> \n> You'll need to tweak at least the name.\n> \n> BR,\n> \t\t\t\t\t\t\t\tPavel\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8679C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 24 Dec 2022 14:42:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1DC9C61F17;\n\tSat, 24 Dec 2022 15:42:00 +0100 (CET)","from mx1.riseup.net (mx1.riseup.net [198.252.153.129])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA32661F17\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 24 Dec 2022 15:41:57 +0100 (CET)","from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256\n\tclient-signature RSA-PSS (2048 bits) client-digest SHA256)\n\t(Client CN \"mail.riseup.net\", Issuer \"R3\" (not verified))\n\tby mx1.riseup.net (Postfix) with ESMTPS id 4NfRZq4f8mzDqWT;\n\tSat, 24 Dec 2022 14:41:55 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1])\n\tby fews1.riseup.net (Postfix) with ESMTPSA id 4NfRZp23FJz5vLV;\n\tSat, 24 Dec 2022 14:41:54 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671892920;\n\tbh=ydjqlnUVC1PDigoYIVNTtxj6bPJFitwYc7Fi1Naj5nw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=jD281s+7hdp5e0H5DgqAIvvq1k25paAhhkSI9ZyOJNTRx+Qq8LIokIxXqKK/nYxhL\n\tzjH4G+jtAkK81EtSFMxw8M20+UWmBcdIwreInRwf2K+S4zZxvK20mhQZFS2JYbkzZ+\n\tbmB7smr23SOi7uWk08l1fHkNO1EQpvfrBKdkM9fCv2yIlWWELys1ElIc4WL5mnp0Bl\n\thWtM2dtDnpqTFwYo1Lxsnb/AHn3oHC4tH+raUQ0JhSSYwjCHRt1ACAG13upQOUdwuh\n\tVYCKhN9i5OTpZ3ehKXgRjhaWy8cuJbRvVfQ6xwIQctBnidahc1/R9fHPoif6I7Qelu\n\t37fj1NALNIL4w==","v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; \n\tt=1671892915; bh=ydjqlnUVC1PDigoYIVNTtxj6bPJFitwYc7Fi1Naj5nw=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=GHntvfeLUAH0hjhM7OBVwa1BmKSv4qIUrILJCAzut9cKlqhLu2jhahcdKxiXq/65J\n\tM4YuFQOO7dt2ilFaA6XTW+w9vEpvLF8gHnwtHrMvabunLD9NOHc7Pg1tYd5tuYe3Qd\n\tJ+8I3mnDLpKYnrF0V7L4B5smbInfkZNrIQfONAn4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=riseup.net\n\theader.i=@riseup.net header.b=\"GHntvfeL\"; \n\tdkim-atps=neutral","X-Riseup-User-ID":"5DABDC57AD16A4E0EE880AB18D9A8F91975A020F4DC9E53DCF7815A53790A978","Message-ID":"<41316602-acf3-39c7-0a3e-6c38c8af3d7e@riseup.net>","Date":"Sat, 24 Dec 2022 17:41:53 +0300","MIME-Version":"1.0","Content-Language":"en-US","To":"Pavel Machek <pavel@ucw.cz>","References":"<Y52jM6iQtzs0Vysm@duo.ucw.cz>\n\t<CAKQmDh9BDUWonGdnOqz4uNPwS+L6cQMh1A2O4Be3Z=z+JqbQTQ@mail.gmail.com>\n\t<Y545RJF0JMWIQUwe@duo.ucw.cz>\n\t<a060b121a53465d2118d8d6194cd866e32ccc238.camel@ndufresne.ca>\n\t<Y6IzhjY3XQZn2oci@duo.ucw.cz>\n\t<167162721688.3944359.738999548555516756@Monstersaurus>\n\t<Y6NFu/O6VDG+WYdN@duo.ucw.cz>\n\t<aeb18f80a76778f99db08d3600036e34257024cc.camel@ndufresne.ca>\n\t<Y6XkAEC7SOKsKMBk@duo.ucw.cz>\n\t<7ee867fa-e7f4-8e6f-2316-35868dd42589@riseup.net>\n\t<Y6cNM/EzaPy1ziES@duo.ucw.cz>","In-Reply-To":"<Y6cNM/EzaPy1ziES@duo.ucw.cz>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"------------w0gy9rfGrDEvBUPP5lVo92CO\"","Subject":"Re: [libcamera-devel] [PATCHv2] gstreamer: Add bayer8 support to\n\tlibcamerasrc element","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Rafael Diniz via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Rafael Diniz <rafael@riseup.net>","Cc":"Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tPavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":26159,"web_url":"https://patchwork.libcamera.org/comment/26159/","msgid":"<Y6cYY6B3L3ZDXvM2@pendragon.ideasonboard.com>","date":"2022-12-24T15:18:59","subject":"Re: [libcamera-devel] [PATCHv2] gstreamer: Add bayer8 support to\n\tlibcamerasrc element","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Pavel,\n\nThank you for the patch.\n\nOn Fri, Dec 23, 2022 at 06:23:12PM +0100, Pavel Machek via libcamera-devel wrote:\n> Bayer8 support is useful on hardware such as Librem 5, as GStreamer\n> provides easy solution for debayering and display of the camera\n> data. Add neccessary glue to libcamerasrc element.\n\ns/neccessary/necessary/\n\n> Signed-off-by: Pavel Machek <pavel@ucw.cz>\n> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n> \n> --\n\nIf you want to add text that should be dropped by git-am, the correct\nmarker is ---, not --.\n\n> Thanks for the review!\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index 36b9564c..b2cc7661 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -20,6 +20,12 @@ static struct {\n>  \t/* Compressed */\n>  \t{ GST_VIDEO_FORMAT_ENCODED, formats::MJPEG },\n>  \n> +\t/* Bayer formats, gstreamer only supports 8-bit */\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SGRBG8 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SGBRG8 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SRGGB8 },\n> +\t{ GST_VIDEO_FORMAT_ENCODED, formats::SBGGR8 },\n\nIf you don't mind, I'd like to sort these alphabetically.\n\n> +\n>  \t/* RGB16 */\n>  \t{ GST_VIDEO_FORMAT_RGB16, formats::RGB565 },\n>  \n> @@ -228,6 +234,22 @@ gst_format_to_pixel_format(GstVideoFormat gst_format)\n>  \treturn PixelFormat{};\n>  }\n>  \n> +static const gchar *\n> +bayer_format_to_string(int format)\n> +{\n> +\tswitch (format) {\n> +\tcase formats::SGRBG8:\n> +\t\treturn \"grbg\";\n> +\tcase formats::SGBRG8:\n> +\t\treturn \"gbrg\";\n> +\tcase formats::SRGGB8:\n> +\t\treturn \"rggb\";\n> +\tcase formats::SBGGR8:\n> +\t\treturn \"bggr\";\n\nSame here.\n\n> +\t}\n> +\treturn NULL;\n> +}\n> +\n>  static GstStructure *\n>  bare_structure_from_format(const PixelFormat &format)\n>  {\n> @@ -243,6 +265,12 @@ bare_structure_from_format(const PixelFormat &format)\n>  \tswitch (format) {\n>  \tcase formats::MJPEG:\n>  \t\treturn gst_structure_new_empty(\"image/jpeg\");\n> +\tcase formats::SGRBG8:\n> +\tcase formats::SGBRG8:\n> +\tcase formats::SRGGB8:\n> +\tcase formats::SBGGR8:\n\nAnd here too.\n\nIf you're fine with these small changes, I can apply them locally,\nthere's no need to send a v3.\n\nConditionally-Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> +\t\treturn gst_structure_new(\"video/x-bayer\", \"format\", G_TYPE_STRING,\n> +\t\t\t\t\t bayer_format_to_string(format), nullptr);\n>  \tdefault:\n>  \t\treturn nullptr;\n>  \t}\n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 8d97d7c2..a10cbd4f 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -161,7 +161,7 @@ G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT,\n>  \t\t\tGST_DEBUG_CATEGORY_INIT(source_debug, \"libcamerasrc\", 0,\n>  \t\t\t\t\t\t\"libcamera Source\"))\n>  \n> -#define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw; image/jpeg\")\n> +#define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw; image/jpeg; video/x-bayer\")\n>  \n>  /* For the simple case, we have a src pad that is always present. */\n>  GstStaticPadTemplate src_template = {","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9F43BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 24 Dec 2022 15:19:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A835625CB;\n\tSat, 24 Dec 2022 16:19:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C78D61F17\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 24 Dec 2022 16:19:04 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC7EC2B3;\n\tSat, 24 Dec 2022 16:19:03 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671895145;\n\tbh=Xd1hUoDiF/YEKuZ47ajvpPRd5c1o3WJ17EKAYTzNoC8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=hqjPqXIHRIehUIThVjyTkbDBJtBxmt0KPhQi65tupADBkzx2FzYBzRCDuA/FW6RmE\n\tu7Wj5TPa+kKsUjAIBBdSW0wDQUjSHXea2cne6gTuca0dirXc0y65H+gEEzDk2gkVYR\n\tMOIE6HOUcE1MUpFEXCkHxCDjEDjRf4jQi+/M+LiXZaqrSt7RdHJB48Sq8NfuouZRnv\n\tviQfmp7/W1r9MKPrhqWyWa6ShZnFApN18xcwPZz2aonNRkEi6L8S/rmASB+00uMCA1\n\tfTiqlQs/Db0LhM1Qi0Cd1pn3OEwIMbJfBGLONLUqEg2sKECrPow2CSRqDysbpjgt3R\n\tnKAh2QVJ0jayA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671895144;\n\tbh=Xd1hUoDiF/YEKuZ47ajvpPRd5c1o3WJ17EKAYTzNoC8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DvwcHUl/qBW9DSOGs26EMXHkn0981+F+zjpN4gY7Eul5eT2PfsVcnAWEhrwdqeDR8\n\tO7hpTXEJgPKyXjWmL8ZJ0jYWWeB3Z4cV6hlQNb1hCZhSApKKVKDtRnqkSB3Cynqqo3\n\tcqb/vWrya982arYrEEnAJMvIOKwrTNwaeHIMrV48="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DvwcHUl/\"; dkim-atps=neutral","Date":"Sat, 24 Dec 2022 17:18:59 +0200","To":"Pavel Machek <pavel@ucw.cz>","Message-ID":"<Y6cYY6B3L3ZDXvM2@pendragon.ideasonboard.com>","References":"<Y52jM6iQtzs0Vysm@duo.ucw.cz>\n\t<CAKQmDh9BDUWonGdnOqz4uNPwS+L6cQMh1A2O4Be3Z=z+JqbQTQ@mail.gmail.com>\n\t<Y545RJF0JMWIQUwe@duo.ucw.cz>\n\t<a060b121a53465d2118d8d6194cd866e32ccc238.camel@ndufresne.ca>\n\t<Y6IzhjY3XQZn2oci@duo.ucw.cz>\n\t<167162721688.3944359.738999548555516756@Monstersaurus>\n\t<Y6NFu/O6VDG+WYdN@duo.ucw.cz>\n\t<aeb18f80a76778f99db08d3600036e34257024cc.camel@ndufresne.ca>\n\t<Y6XkAEC7SOKsKMBk@duo.ucw.cz>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<Y6XkAEC7SOKsKMBk@duo.ucw.cz>","Subject":"Re: [libcamera-devel] [PATCHv2] gstreamer: Add bayer8 support to\n\tlibcamerasrc element","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tPavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":26160,"web_url":"https://patchwork.libcamera.org/comment/26160/","msgid":"<Y6ceJ9DGvWtPQ9/g@duo.ucw.cz>","date":"2022-12-24T15:43:35","subject":"Re: [libcamera-devel] [PATCHv2] gstreamer: Add bayer8 support to\n\tlibcamerasrc element","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n> And here too.\n> \n> If you're fine with these small changes, I can apply them locally,\n> there's no need to send a v3.\n> \n> Conditionally-Reviewed-by: Laurent Pinchart\n> <laurent.pinchart@ideasonboard.com>\n\nFine with them, thank you!\n\nBest regards,\n\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 509E3C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 24 Dec 2022 15:43:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A6DD9625CB;\n\tSat, 24 Dec 2022 16:43:37 +0100 (CET)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 404A861F17\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 24 Dec 2022 16:43:36 +0100 (CET)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid BFC571C09F4; Sat, 24 Dec 2022 16:43:35 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671896617;\n\tbh=XMIEhHflGJF+RwwqowfsMe+IkC0LxUyhY579eBNfrpE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=aMZ/myAC0+tc8MCGMGqUfU2z/xfJM2ObR1VzXo//PqoXVpEjNB9NLMWJ8yHUIPrdM\n\twMN2jnDkO0ioQtkQuIUJv0DgHNCHveZN/uiZU3cSDE+seN6Vh8DfNvTnHrnAYRBlk6\n\tzw+M+VcwPbDqiSqhvmYq9ywwN6fBkAgfkS4u0F036McMyqvy/xTVZJo8lX4x/GS48a\n\t7PNbIW68GtV3C0KciaqbxEtMlZcfmjBLIIZRW6yMwpCXXB6xDBBd73NmvDZCa2CMNv\n\tGoHffAgvejFLenJ3hCtsIV/ss47l8hM/wv533yrrmlrm+n3+QJpSPakkvbc2QhEH/g\n\tr+6NBxMq6XqBQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1671896615;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Cv4SsLEafS4igz9DdbDLz5R6QDL3evr9pb0ZoHToBrM=;\n\tb=HseF/CICJp0X9QL1A9eWwgIo1JSsEAAYJZyXva/SuelN3HPSB8HkVHQ3zWVShn8lljwd98\n\tc0dnpf/CpJh/ciOLjMvG+dAp5oqWuu63glbDvH+xzqBf2uENyDPnWEa/yxoN1ndTLj1B1o\n\tCYB+daoLQpSvX64QNk77AacBWOBQmvs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"HseF/CIC\"; dkim-atps=neutral","Date":"Sat, 24 Dec 2022 16:43:35 +0100","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<Y6ceJ9DGvWtPQ9/g@duo.ucw.cz>","References":"<Y52jM6iQtzs0Vysm@duo.ucw.cz>\n\t<CAKQmDh9BDUWonGdnOqz4uNPwS+L6cQMh1A2O4Be3Z=z+JqbQTQ@mail.gmail.com>\n\t<Y545RJF0JMWIQUwe@duo.ucw.cz>\n\t<a060b121a53465d2118d8d6194cd866e32ccc238.camel@ndufresne.ca>\n\t<Y6IzhjY3XQZn2oci@duo.ucw.cz>\n\t<167162721688.3944359.738999548555516756@Monstersaurus>\n\t<Y6NFu/O6VDG+WYdN@duo.ucw.cz>\n\t<aeb18f80a76778f99db08d3600036e34257024cc.camel@ndufresne.ca>\n\t<Y6XkAEC7SOKsKMBk@duo.ucw.cz>\n\t<Y6cYY6B3L3ZDXvM2@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"s5wcNXQ7hzoKDFb9\"","Content-Disposition":"inline","In-Reply-To":"<Y6cYY6B3L3ZDXvM2@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCHv2] gstreamer: Add bayer8 support to\n\tlibcamerasrc element","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Pavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Pavel Machek <pavel@ucw.cz>","Cc":"Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tPavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]