[{"id":26138,"web_url":"https://patchwork.libcamera.org/comment/26138/","msgid":"","date":"2022-12-23T15:19:16","subject":"Re: [libcamera-devel] [PATCH v1 1/4] test: v4l2_compat: Reduce\n\tindentation","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn 12/22/22 6:31 AM, Laurent Pinchart via libcamera-devel wrote:\n> Return early with subdir_done() to reduce indentation in case the\n> v4l2_compat layer is not enabled. This matches our usual code patterns\n> in meson.build files, and prepares for enabling the v4l2_compat test\n> with ASan.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n> ---\n> test/v4l2_compat/meson.build | 16 +++++++++-------\n> 1 file changed, 9 insertions(+), 7 deletions(-)\n>\n> diff --git a/test/v4l2_compat/meson.build b/test/v4l2_compat/meson.build\n> index 878095892679..10c4675286b3 100644\n> --- a/test/v4l2_compat/meson.build\n> +++ b/test/v4l2_compat/meson.build\n> @@ -1,5 +1,9 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> +if not is_variable('v4l2_compat')\n> + subdir_done()\n> +endif\n> +\n> # If ASan is enabled, the link order runtime check will fail as v4l2-ctl and\n> # v4l2-compliance are not linked to ASan. Skip the test in that case.\n> #\n> @@ -10,11 +14,9 @@ if get_option('b_sanitize').contains('address')\n> subdir_done()\n> endif\n> \n> -if is_variable('v4l2_compat')\n> - v4l2_compat_test = files('v4l2_compat_test.py')\n> +v4l2_compat_test = files('v4l2_compat_test.py')\n> \n> - test('v4l2_compat_test', v4l2_compat_test,\n> - args : v4l2_compat,\n> - suite : 'v4l2_compat',\n> - timeout : 60)\n> -endif\n> +test('v4l2_compat_test', v4l2_compat_test,\n> + args : v4l2_compat,\n> + suite : 'v4l2_compat',\n> + timeout : 60)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 419FFBD78E\n\tfor ;\n\tFri, 23 Dec 2022 15:19:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7BEB3623B8;\n\tFri, 23 Dec 2022 16:19:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7FF762398\n\tfor ;\n\tFri, 23 Dec 2022 16:19:24 +0100 (CET)","from [IPV6:2401:4900:1f3f:cd5d:4e48:3b91:9262:9565] (unknown\n\t[IPv6:2401:4900:1f3f:cd5d:4e48:3b91:9262:9565])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 13C9E492;\n\tFri, 23 Dec 2022 16:19:22 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671808766;\n\tbh=s4uGYbAZ+zDY06fyoV/KoIEmbl37YardE+dw8gnwEbg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=dQHuE12ZowheaLfjJlxCj9GVqy8ICsuh7kHtWTEXrAlSjepih/nFyL06SSqrKA9ud\n\tDx7eWp28krHXyCLkbUjSzT/KJiR8dRp0w8ImN+k370CKkX0HLwte6X5YUCfgjKQJKC\n\thf/ikqBv+AfHwHK70UclPf1rm6P6AHVeyxREqVxY9jv5MFf9EzYJJ0s0K/8ytk7OSd\n\t26+9vZwfPIQnvAFI9OMPgmaMRoQUmy2jIsJyvkynCZ/lYh+eTjJC1hSNVgbHhbVs+Z\n\tIeADyOi42X39EdwLs7297JO5L//Zm5ewOzWYxXQwb24YRH27XvBToRKGhLbTGkwxKn\n\tvvacRpeMdf09w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671808764;\n\tbh=s4uGYbAZ+zDY06fyoV/KoIEmbl37YardE+dw8gnwEbg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=f+S1o7uBtbHnW2XwR962fQjFkc5Xtz/dAN1bHoK9sSRrpTGwiwAJBi1ByWOpaaPnD\n\tr331Sey+4hE4dtIaYS5P2uhvtpOlWMS+Y+8wE+YXfP4uMgTIinwgF5g7EimNsvQDFC\n\tn0uEicofwQBAruRgQjnkmx8WOvy355yBlUlOohbw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"f+S1o7uB\"; dkim-atps=neutral","Message-ID":"","Date":"Fri, 23 Dec 2022 20:49:16 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.5.1","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20221222010132.22177-1-laurent.pinchart@ideasonboard.com>\n\t<20221222010132.22177-2-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","In-Reply-To":"<20221222010132.22177-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v1 1/4] test: v4l2_compat: Reduce\n\tindentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26147,"web_url":"https://patchwork.libcamera.org/comment/26147/","msgid":"","date":"2022-12-24T00:10:05","subject":"Re: [libcamera-devel] [PATCH v1 1/4] test: v4l2_compat: Reduce\n\tindentation","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Dec 22, 2022 at 03:01:29AM +0200, Laurent Pinchart via libcamera-devel wrote:\n> Return early with subdir_done() to reduce indentation in case the\n> v4l2_compat layer is not enabled. This matches our usual code patterns\n> in meson.build files, and prepares for enabling the v4l2_compat test\n> with ASan.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> test/v4l2_compat/meson.build | 16 +++++++++-------\n> 1 file changed, 9 insertions(+), 7 deletions(-)\n> \n> diff --git a/test/v4l2_compat/meson.build b/test/v4l2_compat/meson.build\n> index 878095892679..10c4675286b3 100644\n> --- a/test/v4l2_compat/meson.build\n> +++ b/test/v4l2_compat/meson.build\n> @@ -1,5 +1,9 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> +if not is_variable('v4l2_compat')\n> + subdir_done()\n> +endif\n> +\n> # If ASan is enabled, the link order runtime check will fail as v4l2-ctl and\n> # v4l2-compliance are not linked to ASan. Skip the test in that case.\n> #\n> @@ -10,11 +14,9 @@ if get_option('b_sanitize').contains('address')\n> subdir_done()\n> endif\n> \n> -if is_variable('v4l2_compat')\n> - v4l2_compat_test = files('v4l2_compat_test.py')\n> +v4l2_compat_test = files('v4l2_compat_test.py')\n> \n> - test('v4l2_compat_test', v4l2_compat_test,\n> - args : v4l2_compat,\n> - suite : 'v4l2_compat',\n> - timeout : 60)\n> -endif\n> +test('v4l2_compat_test', v4l2_compat_test,\n> + args : v4l2_compat,\n> + suite : 'v4l2_compat',\n> + timeout : 60)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65EC2BD78E\n\tfor ;\n\tSat, 24 Dec 2022 00:10:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D29D0623B8;\n\tSat, 24 Dec 2022 01:10:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A918061507\n\tfor ;\n\tSat, 24 Dec 2022 01:10:12 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2604:2d80:ad8a:9000:1bf9:855b:22de:3645])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3301C4DD;\n\tSat, 24 Dec 2022 01:10:11 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671840613;\n\tbh=ih1kXSd6uIzmPqqsXRLdh/VCW/LuaJGl4FSMyMyffUQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MiC3IoFmgIGzrVDlmr7uelII+Y0WZQOjuqzMUUF6JWYwD5MjiYJjQ3o/A6CdZaJUA\n\t9KnD9B8aDcpiDKVkQpXTB0bRGnsZ3BWehEr9qL+EWDV4x//uYyKHEVA4fABNu5cNn4\n\t+ksyDXR2a9HFiVYq30FTT2In20uhhWlyG11gYpeU3MH5ErhPv9PtWLUhSB1RW/qNwE\n\tMyldEU3e7hSEB6RfX4btC5uU/TQmxvT5TikCLUEwqzSnDz9fkl/EfR6LLeX/UFWzeY\n\td38GRnclUCQq+BGJUborp8nPbNAECwuqPbZYsGTIMoIPirJhuqUuvd7khqO6TfUU9b\n\tDoXqInvSaq5PQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671840611;\n\tbh=ih1kXSd6uIzmPqqsXRLdh/VCW/LuaJGl4FSMyMyffUQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=p9HrWOB+5o0gR94JxvFKk5I+JxEq+5ifjKlFiKwjL4WlkfTrgO2BoCcWRl4toHht5\n\tEm6ETQkF6i30E3ub2uakzvb66BUhRO6dy2N/73jt8twzHkwxDCmbJ8UwtvqFFqvhzm\n\tJXtneo73Zoyxcw0a6qcGhT85p8XuEToTGgkzhSLw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"p9HrWOB+\"; dkim-atps=neutral","Date":"Fri, 23 Dec 2022 18:10:05 -0600","To":"Laurent Pinchart ","Message-ID":"","References":"<20221222010132.22177-1-laurent.pinchart@ideasonboard.com>\n\t<20221222010132.22177-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20221222010132.22177-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 1/4] test: v4l2_compat: Reduce\n\tindentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]