[{"id":26129,"web_url":"https://patchwork.libcamera.org/comment/26129/","msgid":"<167162782579.3944359.7932123802263547573@Monstersaurus>","date":"2022-12-21T13:03:45","subject":"Re: [libcamera-devel] [PATCHv2] Simple typo fixes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Pavel,\n\nHow are you sending the patch to the list? It's malformed so it isn't\nbeing picked up as a patch by the patchwork tools.\n\nhttps://patchwork.libcamera.org/patch/18041/\n\nAre you using git-send-email ? https://git-send-email.io/ helps with the\nconfiguration of that if you are not.\n\n--\nKieran\n\nQuoting Pavel Machek via libcamera-devel (2022-12-20 22:02:35)\n> Hi!\n> \n> During reading the code, I found some typos that could be fixed.\n> \n> Signed-off-by: Pavel Machek <pavel@ucw.cz>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> --\n> v2: rebased to today's tree.\n> \n> commit f214f8fe259b485af926bb6299d07fc17f1272fc\n> Author: Pavel Machek <pavel@ucw.cz>\n> Date:   Fri Dec 9 18:43:20 2022 +0000\n> \n>     cleanup: Fix typos.\n> \n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index 9256bbba..d5fabaf1 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -2,7 +2,7 @@\n>  /*\n>   * Copyright (C) 2019, Google Inc.\n>   *\n> - * ipa_vimc.cpp - Vimc Image Processing Algorithm module\n> + * vimc.cpp - Vimc Image Processing Algorithm module\n>   */\n>  #include <libcamera/ipa/vimc_ipa_interface.h>\n>  \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index eb9ad65c..c27b3ef9 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -220,7 +220,7 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req\n>                 }\n>  \n>                 if (pipe_->availableStatBuffers_.empty()) {\n> -                       LOG(RkISP1, Error) << \"Statisitc buffer underrun\";\n> +                       LOG(RkISP1, Error) << \"Statistic buffer underrun\";\n>                         return nullptr;\n>                 }\n>  \n> @@ -340,7 +340,7 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)\n>  \n>         /*\n>          * The API tuning file is made from the sensor name unless the\n> -        * environment variable overrides it. If\n> +        * environment variable overrides it.\n>          */\n>         std::string ipaTuningFile;\n>         char const *configFromEnv = utils::secure_getenv(\"LIBCAMERA_RKISP1_TUNING_FILE\");\n> \n> -- \n> People of Russia, stop Putin before his war on Ukraine escalates.","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9170BC3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Dec 2022 13:03:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E46DA633A3;\n\tWed, 21 Dec 2022 14:03:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB63861F15\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Dec 2022 14:03:48 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 60209FB;\n\tWed, 21 Dec 2022 14:03:48 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671627829;\n\tbh=ORLTi04iKt3IwAo2uu7FUFvcAf9D4GXybGUcSux/FE0=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=OA1cDypZYm4O5cPdUbqf08p8QpnXBIs1wXKuV+3QiNKS5kmtu/3YQAZ7Xmlj4YtxM\n\ts26Vb/nT7b/CTLk9g5GdbCmGOvpXK21nNP35nTC6Cb2BaSiH3oWm5qtTgDqkDDJIhz\n\t+wQ9ZFR94qacn2JzhWV0+MT4h6Q/qweiNqElJXjDFnoVhd02xAPsM4DK09iqtokJjx\n\tn/cM9hskVT/T6lS642RLGpBpt6wQylGfHDMbm3ytT3eOvhuXE0vksWTBYFahQhxFG+\n\tIoBFjLQKl47ptD4lW8CfLTOItuYz4DL/h03zveDJZhhHNtQi2WbZfRZa/MJQjfvFOv\n\tGjH6Yp0Bkxqow==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671627828;\n\tbh=ORLTi04iKt3IwAo2uu7FUFvcAf9D4GXybGUcSux/FE0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=nff+s2KKRufNC7yFgx2wsgKXP6tw1OEivFG50syATUrx9LDZvaiJGjNobWayHZVnU\n\t3qyeaigq2lq5zt2jSMhsHC4vENuc6rA9+RD9ICCtf9BHXqR/sjosvPfhVsG/FHly9I\n\t4hcEltJqu3hQdEwxd4V8UXGjri8ggw14rcg1WNuk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nff+s2KK\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<Y6Iw+5Brkzx5WFBf@duo.ucw.cz>","References":"<Y5TzDeXoEPerowXI@duo.ucw.cz>\n\t<Y5T0UBGDjn09BUDI@pendragon.ideasonboard.com>\n\t<Y5T5Npc745uMeFAK@pendragon.ideasonboard.com>\n\t<Y6Iw+5Brkzx5WFBf@duo.ucw.cz>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tPavel Machek <pavel@ucw.cz>, Pavel Machek via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Date":"Wed, 21 Dec 2022 13:03:45 +0000","Message-ID":"<167162782579.3944359.7932123802263547573@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCHv2] Simple typo fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":26130,"web_url":"https://patchwork.libcamera.org/comment/26130/","msgid":"<167162804926.3944359.15794744544414728439@Monstersaurus>","date":"2022-12-21T13:07:29","subject":"Re: [libcamera-devel] [PATCHv2] Simple typo fixes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2022-12-21 13:03:45)\n> Hi Pavel,\n> \n> How are you sending the patch to the list? It's malformed so it isn't\n> being picked up as a patch by the patchwork tools.\n\nOr rather - it isn't being correctly picked up as a patch - because it's\nmixed between E-Mail content and patch content.\n\nNote how when applied, it has this 'email' content in the patch that\nshouldn't be there.\n\n- https://git.uk.ideasonboard.com/kbingham/libcamera/commit/40bb9471e39362591f9e57318f5f7bb63d7fa37c\n\n--\nKieran\n\n\n> \n> https://patchwork.libcamera.org/patch/18041/\n> \n> Are you using git-send-email ? https://git-send-email.io/ helps with the\n> configuration of that if you are not.\n> \n> --\n> Kieran\n> \n> Quoting Pavel Machek via libcamera-devel (2022-12-20 22:02:35)\n> > Hi!\n> > \n> > During reading the code, I found some typos that could be fixed.\n> > \n> > Signed-off-by: Pavel Machek <pavel@ucw.cz>\n> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > \n> > --\n> > v2: rebased to today's tree.\n> > \n> > commit f214f8fe259b485af926bb6299d07fc17f1272fc\n> > Author: Pavel Machek <pavel@ucw.cz>\n> > Date:   Fri Dec 9 18:43:20 2022 +0000\n> > \n> >     cleanup: Fix typos.\n> > \n> > diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> > index 9256bbba..d5fabaf1 100644\n> > --- a/src/ipa/vimc/vimc.cpp\n> > +++ b/src/ipa/vimc/vimc.cpp\n> > @@ -2,7 +2,7 @@\n> >  /*\n> >   * Copyright (C) 2019, Google Inc.\n> >   *\n> > - * ipa_vimc.cpp - Vimc Image Processing Algorithm module\n> > + * vimc.cpp - Vimc Image Processing Algorithm module\n> >   */\n> >  #include <libcamera/ipa/vimc_ipa_interface.h>\n> >  \n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index eb9ad65c..c27b3ef9 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -220,7 +220,7 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req\n> >                 }\n> >  \n> >                 if (pipe_->availableStatBuffers_.empty()) {\n> > -                       LOG(RkISP1, Error) << \"Statisitc buffer underrun\";\n> > +                       LOG(RkISP1, Error) << \"Statistic buffer underrun\";\n> >                         return nullptr;\n> >                 }\n> >  \n> > @@ -340,7 +340,7 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)\n> >  \n> >         /*\n> >          * The API tuning file is made from the sensor name unless the\n> > -        * environment variable overrides it. If\n> > +        * environment variable overrides it.\n> >          */\n> >         std::string ipaTuningFile;\n> >         char const *configFromEnv = utils::secure_getenv(\"LIBCAMERA_RKISP1_TUNING_FILE\");\n> > \n> > -- \n> > People of Russia, stop Putin before his war on Ukraine escalates.","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60EDBC3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Dec 2022 13:07:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA9C8633A3;\n\tWed, 21 Dec 2022 14:07:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C99A661F15\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Dec 2022 14:07:31 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4EC80FB;\n\tWed, 21 Dec 2022 14:07:31 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671628053;\n\tbh=cON2wJmQxJ01XWoYwF7uy1zcylSRkbkvqya0CCtWbLI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Qy3WACwQaJsjh/AOuCE06U5hgGDvlQxcq1oVu6dzZ4/HYUYYlW3gcQWKpksCA3eEj\n\tln0NrJ8kIk98s56Wnp4XGls7CecSMW1EU6HyRvwsXscsib+7s9bMJpRckpF4II8cYk\n\t/3WCWxKSkL445Lg04DyOQXXdSSe1MMVeHzHZK4m5m8pqUVKqWD1w2PZOdzESDDJC/p\n\tmBKF1RgkNxDxG6ojAoIW+8x1js9iJtt6C3en+dqpuNgfL7TGXucKf0fIR/nwxYYs83\n\t0d9lFbCoKBFIPVvHT7U0O56QjFoQcYk3GkLVPJGSyTzt3JNqMQaTZyoLDQeYGrpxFt\n\t62mfUIQBsLL0w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671628051;\n\tbh=cON2wJmQxJ01XWoYwF7uy1zcylSRkbkvqya0CCtWbLI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=c1nZ42rlxaG84DGfQyCnDTPACjRzUkwtj8H1TfYMHsZQrqIy/hARFZwWsGecqk5+Q\n\tvJpSo2lYIlaHgHhqlAC7GC2rE6LLrlyll3s2h+0qp7BsvbBYcezsHLp+7oh+cALL1n\n\tpfJ2GzMrkxQNFhPCnGPayhQ/GWgoaoYLovayM/so="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"c1nZ42rl\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<167162782579.3944359.7932123802263547573@Monstersaurus>","References":"<Y5TzDeXoEPerowXI@duo.ucw.cz>\n\t<Y5T0UBGDjn09BUDI@pendragon.ideasonboard.com>\n\t<Y5T5Npc745uMeFAK@pendragon.ideasonboard.com>\n\t<Y6Iw+5Brkzx5WFBf@duo.ucw.cz>\n\t<167162782579.3944359.7932123802263547573@Monstersaurus>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tPavel Machek <pavel@ucw.cz>, Pavel Machek via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Date":"Wed, 21 Dec 2022 13:07:29 +0000","Message-ID":"<167162804926.3944359.15794744544414728439@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCHv2] Simple typo fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":26131,"web_url":"https://patchwork.libcamera.org/comment/26131/","msgid":"<Y6MJKqyFyLtvpMNz@duo.ucw.cz>","date":"2022-12-21T13:24:58","subject":"Re: [libcamera-devel] [PATCHv2] Simple typo fixes","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"On Wed 2022-12-21 13:07:29, Kieran Bingham wrote:\n> Quoting Kieran Bingham (2022-12-21 13:03:45)\n> > Hi Pavel,\n> > \n> > How are you sending the patch to the list? It's malformed so it isn't\n> > being picked up as a patch by the patchwork tools.\n> \n> Or rather - it isn't being correctly picked up as a patch - because it's\n> mixed between E-Mail content and patch content.\n> \n> Note how when applied, it has this 'email' content in the patch that\n> shouldn't be there.\n> \n> -\nhttps://git.uk.ideasonboard.com/kbingham/libcamera/commit/40bb9471e39362591f9e57318f5f7bb63d7fa37c\n\nCan you fix it with git commit --amend, please. And I'll try to do\nbetter next time.\n\nThanks,\n\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D3B8C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Dec 2022 13:25:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E8FDA633A3;\n\tWed, 21 Dec 2022 14:25:00 +0100 (CET)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC7FF61F15\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Dec 2022 14:24:59 +0100 (CET)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid 378E81C09F5; Wed, 21 Dec 2022 14:24:59 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671629101;\n\tbh=vNc0b/+kXeAvdGbhGCReJ30ctLgQ4DlxSQflrdGLI3E=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=lz5OnPRI0tOzQvFNuJPLGwG95Lm75lM9hPXJS3lnIR9K0CpcWatkbNWOYvPWAP/Sw\n\tLDx6ki1tQHeTID5fDkqB93KWJpkO6f8Q66IuBwh56qyIGEwD4BpY4LXgZqiHvMjArb\n\t6URWwQz7hiFBcm+qOryIk7r1NdtPPMC/x1PlOO6H9dm+sZ/H/kw8TWQCV3DwsqAWCx\n\tSmoaBaBh899udZGRcy5Kor5bzO5W2TH+2/8i8XJ/lbnmVnTLkUERmg2hAzybiBjqrz\n\tKpNoJLkaEArTHy88WP9Ea2YD+fvH781cmynK8PWfN11lo4dpQl2zfJhMzv1UBTtcCw\n\t8hppMXG3RXLTg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1671629099;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=b34Abm5iSpWEjrjbvONMM7U52vtjy2TqZEZU8r3Jac4=;\n\tb=IWwh2iPTlQxdl1ZDEF6DfKh+qGEPl41vkBTrSEbClQq7diIZglAR+xM3d5r6b8yJ9v1G1O\n\t52/NH6ycwXl5+t/t+rOR9IVINjdNUuYnZG7YExO8bXt+xIpbWuQWdicduXetfZs+tmS3/+\n\t2KVdsG5HtMQo7CPtIG6tvIw0dP+Tcdo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"IWwh2iPT\"; dkim-atps=neutral","Date":"Wed, 21 Dec 2022 14:24:58 +0100","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<Y6MJKqyFyLtvpMNz@duo.ucw.cz>","References":"<Y5TzDeXoEPerowXI@duo.ucw.cz>\n\t<Y5T0UBGDjn09BUDI@pendragon.ideasonboard.com>\n\t<Y5T5Npc745uMeFAK@pendragon.ideasonboard.com>\n\t<Y6Iw+5Brkzx5WFBf@duo.ucw.cz>\n\t<167162782579.3944359.7932123802263547573@Monstersaurus>\n\t<167162804926.3944359.15794744544414728439@Monstersaurus>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"SHXQAdWxsWW9Wp6U\"","Content-Disposition":"inline","In-Reply-To":"<167162804926.3944359.15794744544414728439@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCHv2] Simple typo fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Pavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Pavel Machek <pavel@ucw.cz>","Cc":"Pavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":26153,"web_url":"https://patchwork.libcamera.org/comment/26153/","msgid":"<Y6ZVxY5SUGW/4Lic@pendragon.ideasonboard.com>","date":"2022-12-24T01:28:37","subject":"Re: [libcamera-devel] [PATCHv2] Simple typo fixes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Pavel,\n\nOn Wed, Dec 21, 2022 at 02:24:58PM +0100, Pavel Machek wrote:\n> On Wed 2022-12-21 13:07:29, Kieran Bingham wrote:\n> > Quoting Kieran Bingham (2022-12-21 13:03:45)\n> > > Hi Pavel,\n> > > \n> > > How are you sending the patch to the list? It's malformed so it isn't\n> > > being picked up as a patch by the patchwork tools.\n> > \n> > Or rather - it isn't being correctly picked up as a patch - because it's\n> > mixed between E-Mail content and patch content.\n> > \n> > Note how when applied, it has this 'email' content in the patch that\n> > shouldn't be there.\n> > \n> > -\n> https://git.uk.ideasonboard.com/kbingham/libcamera/commit/40bb9471e39362591f9e57318f5f7bb63d7fa37c\n> \n> Can you fix it with git commit --amend, please. And I'll try to do\n> better next time.\n\nI've replaced the commit message with\n\n    libcamera: Simple typo fixes\n\n    Fix various typos in the code base.\n\n    Signed-off-by: Pavel Machek <pavel@ucw.cz>\n    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n    Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nI will push the patch.","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 217BEC3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 24 Dec 2022 01:28:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B0A7623AF;\n\tSat, 24 Dec 2022 02:28:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C974D61507\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 24 Dec 2022 02:28:43 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A80B32B3;\n\tSat, 24 Dec 2022 02:28:42 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671845325;\n\tbh=jfGZ3NdbNYC4IuXPNes4QIxCx95lC9nu7SQ8PK+HZWk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wrPtMnESxAsUwghcz6ODEknib5yk9M+Rx0rWNxG5DAGlJj1TxoWefRDBVQGheeok4\n\t0WYbA3a6cJNAZBugw+P8q8mp2pLeJJwetP43S0wo/DXWQje+06Z+8ozP39RqwXD7aq\n\tWpdga6OCjcuxiwEpYnhC1rd9kGJVXe1lQV6Q6GFSWetfsg1QRge/+E3XGg7F2N7cFu\n\twmIRX0BpLTbrHkvPVWQO3nBsm/aCFLlcJtO0mgRNCA7sZkotZqfkKOycCoej2/BYwj\n\tgehSKMRsnQFwL0nI3pSfQ2AhNgqfl+iSzjdn/eG5DgJ7XFb5tWfy7/7E2NE0Ig4cyA\n\tI/kUjtu/OGR7w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671845323;\n\tbh=jfGZ3NdbNYC4IuXPNes4QIxCx95lC9nu7SQ8PK+HZWk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=N5R4WYT7AoDKIRphttrTtbQ+Uu+F9fLA1vcNDH4vL0YPNLQamBU8yHd4itcd1/skM\n\tZ4lOK1nBVfiuea29AOqvQ0WyzO3wDcFM8pjom0so3bI0DKbP4ANVNWWH+8rJD7n3K+\n\targDvCRCYijYrMVX8Dqm/tRilX8M5/4XPFbjW3ZY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"N5R4WYT7\"; dkim-atps=neutral","Date":"Sat, 24 Dec 2022 03:28:37 +0200","To":"Pavel Machek <pavel@ucw.cz>","Message-ID":"<Y6ZVxY5SUGW/4Lic@pendragon.ideasonboard.com>","References":"<Y5TzDeXoEPerowXI@duo.ucw.cz>\n\t<Y5T0UBGDjn09BUDI@pendragon.ideasonboard.com>\n\t<Y5T5Npc745uMeFAK@pendragon.ideasonboard.com>\n\t<Y6Iw+5Brkzx5WFBf@duo.ucw.cz>\n\t<167162782579.3944359.7932123802263547573@Monstersaurus>\n\t<167162804926.3944359.15794744544414728439@Monstersaurus>\n\t<Y6MJKqyFyLtvpMNz@duo.ucw.cz>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<Y6MJKqyFyLtvpMNz@duo.ucw.cz>","Subject":"Re: [libcamera-devel] [PATCHv2] Simple typo fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"Pavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]