[{"id":2396,"web_url":"https://patchwork.libcamera.org/comment/2396/","msgid":"<20190813102054.yni7obajvyi3am6h@uno.localdomain>","date":"2019-08-13T10:20:54","subject":"Re: [libcamera-devel] [PATCH v3 5/6] test: v4l2_device: Remove\n\tunused function","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n  nice catch\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n   j\n\nOn Tue, Aug 13, 2019 at 10:40:19AM +0100, Kieran Bingham wrote:\n> The 'exists()' call is not used within the code base.\n> Remove it.\n>\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  test/v4l2_videodevice/v4l2_videodevice_test.cpp | 11 -----------\n>  1 file changed, 11 deletions(-)\n>\n> diff --git a/test/v4l2_videodevice/v4l2_videodevice_test.cpp b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> index a0d269fef7f4..096f9649bfc9 100644\n> --- a/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> +++ b/test/v4l2_videodevice/v4l2_videodevice_test.cpp\n> @@ -6,7 +6,6 @@\n>   */\n>\n>  #include <iostream>\n> -#include <sys/stat.h>\n>\n>  #include <linux/media-bus-format.h>\n>\n> @@ -18,16 +17,6 @@\n>  using namespace std;\n>  using namespace libcamera;\n>\n> -bool exists(const std::string &path)\n> -{\n> -\tstruct stat sb;\n> -\n> -\tif (stat(path.c_str(), &sb) == 0)\n> -\t\treturn true;\n> -\n> -\treturn false;\n> -}\n> -\n>  int V4L2VideoDeviceTest::init()\n>  {\n>  \tenumerator_ = DeviceEnumerator::create();\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77C8860C43\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Aug 2019 12:19:28 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id EB0D2240007;\n\tTue, 13 Aug 2019 10:19:27 +0000 (UTC)"],"Date":"Tue, 13 Aug 2019 12:20:54 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190813102054.yni7obajvyi3am6h@uno.localdomain>","References":"<20190813094020.10277-1-kieran.bingham@ideasonboard.com>\n\t<20190813094020.10277-6-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"wm34iu4hqxyxipja\"","Content-Disposition":"inline","In-Reply-To":"<20190813094020.10277-6-kieran.bingham@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v3 5/6] test: v4l2_device: Remove\n\tunused function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 13 Aug 2019 10:19:28 -0000"}}]