[{"id":26110,"web_url":"https://patchwork.libcamera.org/comment/26110/","msgid":"<4b54c916-d272-cabc-6577-521ccf96fd45@ideasonboard.com>","date":"2022-12-19T14:04:40","subject":"Re: [libcamera-devel] [PATCH v2] Expose the Request Sequence Number\n\tin Python Bindings","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"content":"On 19/12/2022 15:20, Kieran Bingham wrote:\n> From: Matthew Goodman \n> \n> The python bindings are missing the ability to read the sequence number\n> of the Request object from the public API.\n> \n> Expose the objects sequence number on the pybind11 surfaces to support\n> applications reading this value.\n> \n> Signed-off-by: Matthew Goodman \n> [Kieran: Revised commit message]\n> Reviewed-by: Kieran Bingham \n> Signed-off-by: Kieran Bingham \n> \n> ---\n> v2:\n> - Revised commit message.\n> \n> Signed-off-by: Kieran Bingham \n> \n> src/py/libcamera/py_main.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> index 75947889f7b1..d14e18e25f3f 100644\n> --- a/src/py/libcamera/py_main.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -335,6 +335,7 @@ PYBIND11_MODULE(_libcamera, m)\n> \t\t.def_property_readonly(\"status\", &Request::status)\n> \t\t.def_property_readonly(\"buffers\", &Request::buffers)\n> \t\t.def_property_readonly(\"cookie\", &Request::cookie)\n> +\t\t.def_property_readonly(\"sequence\", &Request::sequence)\n> \t\t.def_property_readonly(\"has_pending_buffers\", &Request::hasPendingBuffers)\n> \t\t.def(\"set_control\", [](Request &self, const ControlId &id, py::object value) {\n> \t\t\tself.controls().set(id.id(), pyToControlValue(value, id.type()));\n\nReviewed-by: Tomi Valkeinen \n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A879BC3200\n\tfor ;\n\tMon, 19 Dec 2022 14:04:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2118061508;\n\tMon, 19 Dec 2022 15:04:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 401D861508\n\tfor ;\n\tMon, 19 Dec 2022 15:04:44 +0100 (CET)","from [192.168.1.15] (91-154-32-225.elisa-laajakaista.fi\n\t[91.154.32.225])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 864DE825;\n\tMon, 19 Dec 2022 15:04:43 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671458686;\n\tbh=592P/14eBaNX0+L+5e8r03pb0w/P+C4VfSJvHctMM4s=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=bw37vqRhz575GvdPJyNhyFC+TIJWUJesS4HXVnqlDEwKZaWG7qrW2++AnisJ2UnN3\n\tvmkgK5X88pql0D57vK0ptHpqHbu4sKNbv5Q2y48VECCIHhXq8THzuJInHh6UHKNCna\n\tab+4B21w6wCbGGfgYJDvMMBxCeLXsqkQdK0W7gWCeGV4gr3E0fG3MfymsbfG6SFQmK\n\tQbPklbN0NUOH6LtKh8GWNbSUhSUq+VUbswnWFLpcXAHCEHOUnzXm20Tf7GDXLJkSE4\n\tRhEE6zJfkb/w4QP5O90ReUoZme9RVDQSaX0pv+GUKEPPygvERU26lGKxRv058o/9eC\n\tcC2w7oLPAXZSg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671458683;\n\tbh=592P/14eBaNX0+L+5e8r03pb0w/P+C4VfSJvHctMM4s=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=jjpqfdGsskVmClIkIxeUGkwpEv4T4ka5KYCcIwtudMpCftndW4orLdwyIjUtkGCHH\n\t5chU2xI6O53tU+ElbH0TN1bFJHfUR5V3yhM7hfbVbboD/c+oqfU81WPfvkDrOGSVxm\n\twn/hgecfxVXTLPFS0Dv5CJoqq+TZglnvc1z08kRk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jjpqfdGs\"; dkim-atps=neutral","Message-ID":"<4b54c916-d272-cabc-6577-521ccf96fd45@ideasonboard.com>","Date":"Mon, 19 Dec 2022 16:04:40 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.4.2","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20221219132029.2228553-1-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20221219132029.2228553-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2] Expose the Request Sequence Number\n\tin Python Bindings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]