[{"id":26127,"web_url":"https://patchwork.libcamera.org/comment/26127/","msgid":"","date":"2022-12-21T11:02:55","subject":"Re: [libcamera-devel] [PATCH v9 18/18] lc-compliance: Add test to\n\tensure MinimumRequests is valid","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi\n\nOn 12/16/22 5:59 PM, Paul Elder via libcamera-devel wrote:\n> From: Nícolas F. R. A. Prado \n>\n> Add a test in lc-compliance to check that the MinimumRequests property\n> is set and valid, that is, greater than 0.\n>\n> Signed-off-by: Nícolas F. R. A. Prado \n> Reviewed-by: Paul Elder \n> Signed-off-by: Paul Elder \n\nReviewed-by: Umang Jain \n\n>\n> ---\n> Changes in v9:\n> - rebased\n>\n> Changes in v8:\n> - Moved RequiredProperties test to property_test.cpp\n> - Moved CameraTests to new test_base.{cpp,h} files\n>\n> Changes in v7:\n> - New\n> ---\n> src/apps/lc-compliance/meson.build | 1 +\n> src/apps/lc-compliance/property_test.cpp | 24 ++++++++++++++++++++++++\n> src/apps/lc-compliance/test_base.cpp | 10 ++++++++++\n> src/apps/lc-compliance/test_base.h | 7 +++++++\n> 4 files changed, 42 insertions(+)\n> create mode 100644 src/apps/lc-compliance/property_test.cpp\n>\n> diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\n> index fae290bb..a10a3cc2 100644\n> --- a/src/apps/lc-compliance/meson.build\n> +++ b/src/apps/lc-compliance/meson.build\n> @@ -14,6 +14,7 @@ lc_compliance_sources = files([\n> 'capture_test.cpp',\n> 'environment.cpp',\n> 'main.cpp',\n> + 'property_test.cpp',\n> 'simple_capture.cpp',\n> 'test_base.cpp',\n> ])\n> diff --git a/src/apps/lc-compliance/property_test.cpp b/src/apps/lc-compliance/property_test.cpp\n> new file mode 100644\n> index 00000000..6a0951b2\n> --- /dev/null\n> +++ b/src/apps/lc-compliance/property_test.cpp\n> @@ -0,0 +1,24 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2021, Collabora Ltd.\n> + *\n> + * property_test.cpp - Test camera properties\n> + */\n> +\n> +#include \n> +\n> +#include \n> +\n> +#include \"test_base.h\"\n> +\n> +using namespace libcamera;\n> +\n> +TEST_F(CameraTests, RequiredProperties)\n> +{\n> +\tconst ControlList &properties = camera_->properties();\n> +\n> +\tusing namespace properties;\n> +\n> +\tEXPECT_GT(properties.get(MinimumRequests), 0)\n> +\t\t<< \"Camera should have a positive value for MinimumRequests property\";\n> +}\n> diff --git a/src/apps/lc-compliance/test_base.cpp b/src/apps/lc-compliance/test_base.cpp\n> index c9957b9e..a5e64c8b 100644\n> --- a/src/apps/lc-compliance/test_base.cpp\n> +++ b/src/apps/lc-compliance/test_base.cpp\n> @@ -26,3 +26,13 @@ void CameraHolder::releaseCamera()\n> \tcamera_->release();\n> \tcamera_.reset();\n> }\n> +\n> +void CameraTests::SetUp()\n> +{\n> +\tacquireCamera();\n> +}\n> +\n> +void CameraTests::TearDown()\n> +{\n> +\treleaseCamera();\n> +}\n> diff --git a/src/apps/lc-compliance/test_base.h b/src/apps/lc-compliance/test_base.h\n> index 52347749..8125e1c6 100644\n> --- a/src/apps/lc-compliance/test_base.h\n> +++ b/src/apps/lc-compliance/test_base.h\n> @@ -21,4 +21,11 @@ protected:\n> \tstd::shared_ptr camera_;\n> };\n> \n> +class CameraTests : public ::testing::Test, public CameraHolder\n> +{\n> +protected:\n> +\tvoid SetUp() override;\n> +\tvoid TearDown() override;\n> +};\n> +\n> #endif /* __LC_COMPLIANCE_TEST_BASE_H__ */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D197C3200\n\tfor ;\n\tWed, 21 Dec 2022 11:03:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78FD2633A3;\n\tWed, 21 Dec 2022 12:03:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6EB8461507\n\tfor ;\n\tWed, 21 Dec 2022 12:03:01 +0100 (CET)","from [IPV6:2401:4900:1f3f:d076:4da6:b729:f032:ed0a] (unknown\n\t[IPv6:2401:4900:1f3f:d076:4da6:b729:f032:ed0a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 182C0FB;\n\tWed, 21 Dec 2022 12:02:59 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671620582;\n\tbh=KlTSKQ6jbLPi2uGuYy6veCAknOPr7Xa2my6rgw0dYgg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=pVJfDIdYciJN+rreO7s7fVA16GRmQjTqILjspNAF4YA8m/QbSpPst+//4ErTH3+cB\n\tXEX8XSM8S1WjQwzc+DtBDoDjruRt3mM+/1Y2aeR9TyWoOz9T1v8EXx3DL0O9pZiHh/\n\tPY83DrkKdvF3PUhp9bEP7xb+qVRo2Qaw7lN/rdIkXYjDb0a/pbMEM3BqMcxGAlrluL\n\tp/zc3+3QqY6wFu6Jy08nqwWnXSEcTlaiR2xNAb8LUZdHB9uJcJpQzBc8f4qdrBtyOH\n\thtiocfvgAyOPbrWMwVd8AczgJp5yOI3sW+A8ZThimgNNCrhCdvVBMThF/HJw+g1F5k\n\tUfr8ariJTKtEQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671620581;\n\tbh=KlTSKQ6jbLPi2uGuYy6veCAknOPr7Xa2my6rgw0dYgg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=urUypl8Yswx1HjZSaE+qNx6j2et2nKGSwhJYTFIo7DQ95NT6a/voUx/Rf9ZDoaytT\n\tS94hn4XDnFwS+/G8eNNl+GhevzdAmuQbiw8m1HdNR7Y1Swj3EufLHlK7TQtlImJ7Or\n\tdaHdoXWeTluUjKzmpFjNeelcGp8hABT0eLOkikuc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"urUypl8Y\"; dkim-atps=neutral","Message-ID":"","Date":"Wed, 21 Dec 2022 16:32:55 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.5.1","Content-Language":"en-US","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20221216122939.256534-1-paul.elder@ideasonboard.com>\n\t<20221216122939.256534-19-paul.elder@ideasonboard.com>","In-Reply-To":"<20221216122939.256534-19-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v9 18/18] lc-compliance: Add test to\n\tensure MinimumRequests is valid","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]