[{"id":26126,"web_url":"https://patchwork.libcamera.org/comment/26126/","msgid":"<29d7cd70-3cc9-6e55-d849-a556834b6ff4@ideasonboard.com>","date":"2022-12-21T10:50:33","subject":"Re: [libcamera-devel] [PATCH v9 11/18] lc-compliance: Fix source\n\tfile ordering in meson.build","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch\n\nOn 12/16/22 5:59 PM, Paul Elder via libcamera-devel wrote:\n> From: Nícolas F. R. A. Prado <nfraprado@collabora.com>\n>\n> The capture_test.cpp file was added in the source list of meson in the\n> wrong place. Fix it so the list is alphabetically sorted.\n>\n> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>\n> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n\n>\n> ---\n> Changes in v9:\n> - rebased\n>\n> Changes in v8:\n> - New\n> ---\n>   src/apps/lc-compliance/meson.build | 2 +-\n>   1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\n> index 51d9075a..3b1927fd 100644\n> --- a/src/apps/lc-compliance/meson.build\n> +++ b/src/apps/lc-compliance/meson.build\n> @@ -11,10 +11,10 @@ endif\n>   lc_compliance_enabled = true\n>   \n>   lc_compliance_sources = files([\n> +    'capture_test.cpp',\n>       'environment.cpp',\n>       'main.cpp',\n>       'simple_capture.cpp',\n> -    'capture_test.cpp',\n>   ])\n>   \n>   lc_compliance  = executable('lc-compliance', lc_compliance_sources,","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0280CC3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Dec 2022 10:50:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5AB3A633A7;\n\tWed, 21 Dec 2022 11:50:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6796B61F1A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Dec 2022 11:50:39 +0100 (CET)","from [IPV6:2401:4900:1f3f:d076:4da6:b729:f032:ed0a] (unknown\n\t[IPv6:2401:4900:1f3f:d076:4da6:b729:f032:ed0a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F16D6FB;\n\tWed, 21 Dec 2022 11:50:37 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671619840;\n\tbh=nT7D3LopwTr7c85maS/Rlb+1o+NHbOeZdXhtIWphzUc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=e41SzJNlPdqMTbiKe6awS2H70tYk4Be8SpcmmLlo8gUotECi0tzPV4kklj7Sg0iRD\n\tKJl8AB8JsEoOMUb0Dc4JlBPuVRN6325SN9kW3BaLyp75akZxjLitKOx+DzSjPRa/xX\n\tcZEgdElu4o45GzidBTBO5lpvXzfNtENSHc/wgTPDiffFgtgrDcoHcPhcyV8WF+EXrf\n\tqrAaEtR3RFrcAGuQGXaV6d+ZgVbMGWW5f5szfb7Hmt5E+gpzKQl9fC1BXw6EClr0mP\n\tkNDUg35eq0FXgwcAm5DuJTqr7UOl37EdcI/O5g/QLXmIEkhVnrzTrC3IckHOPkmV9k\n\ttAPtYHZdbKojw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671619838;\n\tbh=nT7D3LopwTr7c85maS/Rlb+1o+NHbOeZdXhtIWphzUc=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=nMA/06s+9z3m2+6HxK6OuMPh6WgDMxW/lPKVaathWuZvLX6OP4FdCIc2Vs4xwW97l\n\tZeOYLI7a40v5q96us8RRtc146d9n4uyCYqTlNnw7pT9GcaPdh+iY3enE83VQkOYL05\n\tg/R+2ZojjRSfAdavKFHBbRVew7TKhEYd3tD3TwJY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nMA/06s+\"; dkim-atps=neutral","Message-ID":"<29d7cd70-3cc9-6e55-d849-a556834b6ff4@ideasonboard.com>","Date":"Wed, 21 Dec 2022 16:20:33 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.5.1","Content-Language":"en-US","To":"Paul Elder <paul.elder@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20221216122939.256534-1-paul.elder@ideasonboard.com>\n\t<20221216122939.256534-12-paul.elder@ideasonboard.com>","In-Reply-To":"<20221216122939.256534-12-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v9 11/18] lc-compliance: Fix source\n\tfile ordering in meson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Umang Jain <umang.jain@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]