[{"id":26093,"web_url":"https://patchwork.libcamera.org/comment/26093/","msgid":"<20221216134105.yqslfnhbwsc6dsri@uno.localdomain>","date":"2022-12-16T13:41:05","subject":"Re: [libcamera-devel] [PATCH v9 01/18] pipeline: rkisp1: Reorder\n\theaders to appease the linter","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul\n\nOn Fri, Dec 16, 2022 at 09:29:22PM +0900, Paul Elder via libcamera-devel wrote:\n> Re-order the header includes to appease the style-checker, so that when\n> we add headers later (specifically, property_ids.h), it won't complain.\n>\n\nIf it please the tool and avoid later conflicts..\n\n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index eb9ad65c..f658d75e 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -23,11 +23,11 @@\n> #include \n> #include \n> #include \n> +#include \n> +#include \n\nHowever I would have expected checkstyle to require an empty line here\n\nAnyway, glory glory to the holy tool\nReviewed-by: Jacopo Mondi \n\n> #include \n> #include \n> #include \n> -#include \n> -#include \n>\n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_sensor.h\"\n> --\n> 2.35.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ECC74C31E9\n\tfor ;\n\tFri, 16 Dec 2022 13:41:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B54DB603D0;\n\tFri, 16 Dec 2022 14:41:07 +0100 (CET)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5F69603D0\n\tfor ;\n\tFri, 16 Dec 2022 14:41:06 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 710151C0005;\n\tFri, 16 Dec 2022 13:41:06 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671198067;\n\tbh=twGQEDP+xkG3U1DpAjR29Nl6G6YHlCB3R0omaYv87BQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=06FjFyEz4uBPhzQVxtp+jm8cowkp2o3UX1I62Ng6ABySObunA1f9X02YWAfAqmRlL\n\txlqs8cdQwpEiSux9DwME+8Jo6jIplDX7Gd2IBsVGjoIdl6KcuiDSwZnRxdqxI04oIx\n\tJQ24XnKcG5xWhZ/OfTOP/zumKBxdOBB+twAmti2WUqvwANYXkyP2GgHj3zThIV7LkP\n\tTnEM4MMH6IfrB6PGC9GExStcKOoWAgHJoPRRuj7nq1tEszm4Iw3YmMJlc1/31X0WMF\n\tShQFlEyjX0mzT2kVzlCM97hjFArGjd820McgA2ZLHuQzoMv3JaII8Kdola4vKvcrUc\n\tt2dgERFLelLcg==","Date":"Fri, 16 Dec 2022 14:41:05 +0100","To":"Paul Elder ","Message-ID":"<20221216134105.yqslfnhbwsc6dsri@uno.localdomain>","References":"<20221216122939.256534-1-paul.elder@ideasonboard.com>\n\t<20221216122939.256534-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221216122939.256534-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v9 01/18] pipeline: rkisp1: Reorder\n\theaders to appease the linter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26122,"web_url":"https://patchwork.libcamera.org/comment/26122/","msgid":"","date":"2022-12-21T08:26:55","subject":"Re: [libcamera-devel] [PATCH v9 01/18] pipeline: rkisp1: Reorder\n\theaders to appease the linter","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn 12/16/22 5:59 PM, Paul Elder via libcamera-devel wrote:\n> Re-order the header includes to appease the style-checker, so that when\n> we add headers later (specifically, property_ids.h), it won't complain.\n>\n> Signed-off-by: Paul Elder \n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index eb9ad65c..f658d75e 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -23,11 +23,11 @@\n> #include \n> #include \n> #include \n> +#include \n> +#include \n> #include \n> #include \n> #include \n> -#include \n> -#include \n> \n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_sensor.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EBA0CC3213\n\tfor ;\n\tWed, 21 Dec 2022 08:27:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 27EFB633A7;\n\tWed, 21 Dec 2022 09:27:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C05E61F1A\n\tfor ;\n\tWed, 21 Dec 2022 09:27:03 +0100 (CET)","from [IPV6:2401:4900:1f3f:d076:4da6:b729:f032:ed0a] (unknown\n\t[IPv6:2401:4900:1f3f:d076:4da6:b729:f032:ed0a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C9BDFFB;\n\tWed, 21 Dec 2022 09:27:01 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671611224;\n\tbh=5tWqKuik8nvmmuXwp3izee8aZHFP/HVl6ZjOv26wK7Y=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=x3Mr+/irPqlb/LZQajOHl5U42QG12qt5gIUSxcalIOUtWCQGJOVNY+xNarwab9EKa\n\tkfi8fklOZxIkXXBtwVH7VqBhjaZiyHP4dyNB8FvzHK/Q8qdYbjDqctCM1cAVwZ3w3U\n\tjaI8UFp+2SqUCn5Ddz9k8ZKNxJ22cXn9jZPUn7v6c4rATvB6qvDDc9CIkadcblJNSx\n\tDQu7eONNIA9kwtXRGoIsMyFgqjCLca9NmRwAIv0+lJe5JJhtmKq+4OZEuAhQWRrFHt\n\tZAofTh4bDHO+wt6PPeQ+gSRQcTLaSiqV+pg4B4NVsvTV9RcuyUbjmrqXO6FflypXrY\n\tqaGa3DPkg3T3g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671611222;\n\tbh=5tWqKuik8nvmmuXwp3izee8aZHFP/HVl6ZjOv26wK7Y=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=VgMpDMr0v8YHddbTCd45rELBk6RZoIR7Z+vNBKJMSusrm6idQCFxZ/5qI4Q4+MZr+\n\tucYZT6jWW6kMyLk+xQjIWbBdElumX6al3GWPS1k7ogwxzB8dyO0jT2V9UDWgx9/tbR\n\taO0QKmKp4PTmd6Ek5OTR0KglNxMhRzZG/JWv1jCQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VgMpDMr0\"; dkim-atps=neutral","Message-ID":"","Date":"Wed, 21 Dec 2022 13:56:55 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.5.1","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20221216122939.256534-1-paul.elder@ideasonboard.com>\n\t<20221216122939.256534-2-paul.elder@ideasonboard.com>","Content-Language":"en-US","In-Reply-To":"<20221216122939.256534-2-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v9 01/18] pipeline: rkisp1: Reorder\n\theaders to appease the linter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]