[{"id":26081,"web_url":"https://patchwork.libcamera.org/comment/26081/","msgid":"<167103789259.9133.7864700035490536876@Monstersaurus>","date":"2022-12-14T17:11:32","subject":"Re: [libcamera-devel] [PATCH] utils: checkstyle.py: Check new\n\theader file on new and renamed meson.build files","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Xavier Roumegue via libcamera-devel (2022-12-14 16:16:56)\n> Declaration of new header file to the build system are only checked against\n> modified meson.build file. Therefore, this raises a false positive warning in\n> case the meson.build is added or renamed.\n> \n> Add the new and renamed meson.build files to the list of files to check header\n> file inclusion.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Xavier Roumegue \n> ---\n> utils/checkstyle.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index f0248d65..64dcf5ed 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -313,7 +313,7 @@ class HeaderAddChecker(CommitChecker):\n> def check(cls, commit, top_level):\n> issues = []\n> \n> - meson_files = [f for f in commit.files('M')\n> + meson_files = [f for f in commit.files('AMR')\n> if os.path.basename(f) == 'meson.build']\n> \n> for filename in commit.files('AR'):\n> -- \n> 2.38.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5435C31E9\n\tfor ;\n\tWed, 14 Dec 2022 17:11:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0031B63354;\n\tWed, 14 Dec 2022 18:11:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B8DA61F23\n\tfor ;\n\tWed, 14 Dec 2022 18:11:35 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0AC72499;\n\tWed, 14 Dec 2022 18:11:35 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671037897;\n\tbh=qQ8sq6aYTMudXMU/5hl05brc+n43mB0AJY5c+wD5Wy8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=pxCT6AMv73RRDll9shLgSVqI0tOh7WZCou/2SmgBrs9WhSpadqV6pnG08+1T+NjRk\n\tqbXKQrE9poxp2qz8PB7Bm1RiWHswa1dxUoYSr+YymKk0Le/UGrJ5Lbj2yIR/X8rFIy\n\tHYG6mbD6uajzEpMJfD4EiMJBN5D/s+mNPFWt9/vnphjRcyLvwTLjXsxU9EbaEII40C\n\tY4A0Jk2SEcLMdcFnclGtrUvobBlpsuIbOr/Khz93w+xOyqeJY2tmTtLbnusj3vjuVE\n\tBxwKc/7hNKmtvpmOXWrBmcV9Fvm8hFHAAX05vE1fjEZxmw2fzKPSN5hiEHqWzKekjw\n\tWMAFWsRypeDpw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671037895;\n\tbh=qQ8sq6aYTMudXMU/5hl05brc+n43mB0AJY5c+wD5Wy8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=EMyD/+biEPU0osZxV2yhbi0GRCYQJpUXxmdQXYVaQzlvf1oETBtW9eahQcMrC4zGV\n\tBIuITMiIRY6Bg1JklkYAvCmDQJtAfZaqp2GtltV+IFFUDeAY786+c3Zcy7oen2ZdRC\n\tKly/c/lNkzkOFiX4IGgLk/GqC+6kyhrFQeiqWRls="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EMyD/+bi\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221214161656.436083-1-xavier.roumegue@oss.nxp.com>","References":"<20221214161656.436083-1-xavier.roumegue@oss.nxp.com>","To":"Xavier Roumegue ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 14 Dec 2022 17:11:32 +0000","Message-ID":"<167103789259.9133.7864700035490536876@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] utils: checkstyle.py: Check new\n\theader file on new and renamed meson.build files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26087,"web_url":"https://patchwork.libcamera.org/comment/26087/","msgid":"","date":"2022-12-15T10:31:05","subject":"Re: [libcamera-devel] [PATCH] utils: checkstyle.py: Check new\n\theader file on new and renamed meson.build files","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Xavier,\n\nThank you for the patch.\n\nOn Wed, Dec 14, 2022 at 05:16:56PM +0100, Xavier Roumegue via libcamera-devel wrote:\n> Declaration of new header file to the build system are only checked against\n> modified meson.build file. Therefore, this raises a false positive warning in\n> case the meson.build is added or renamed.\n> \n> Add the new and renamed meson.build files to the list of files to check header\n> file inclusion.\n> \n> Signed-off-by: Xavier Roumegue \n> ---\n> utils/checkstyle.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index f0248d65..64dcf5ed 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -313,7 +313,7 @@ class HeaderAddChecker(CommitChecker):\n> def check(cls, commit, top_level):\n> issues = []\n> \n> - meson_files = [f for f in commit.files('M')\n> + meson_files = [f for f in commit.files('AMR')\n\n'AMR' is the default filter, so you can use\n\n meson_files = [f for f in commit.files()\n if os.path.basename(f) == 'meson.build']\n\nI'll change this when applying.\n\nReviewed-by: Laurent Pinchart \n\n> if os.path.basename(f) == 'meson.build']\n> \n> for filename in commit.files('AR'):","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20044C31E9\n\tfor ;\n\tThu, 15 Dec 2022 10:31:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8895E6339D;\n\tThu, 15 Dec 2022 11:31:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 955F260410\n\tfor ;\n\tThu, 15 Dec 2022 11:31:09 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 01F4D327;\n\tThu, 15 Dec 2022 11:31:08 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671100270;\n\tbh=cru2L49Cgbj7KEEPqCoiuz+rRTsgVsp3uVTSSVaa2M4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=fvIB2waPI0TOwB9lT/6wvVNcui1WUJOKQaLbL5gUu3VwxZvTGU2dZH8v7yjaayRt+\n\tk3Vp0Q7FqQV/xgYKz1wF5i6bWl8DbmfInvbCe0QdQJ/BcDqTN13d0QOkVj5Rem/CZ0\n\tNFdYCfopueoJFajpJT/e4qSkVDP0Lrz1bGkIj3FnaRU9Z9mXA5SVSArDKIV37hALJB\n\tMZ47EQaAoZ68Kkybc2zJZJ8RPfFM9ThBEXwJUPDIfpE4W1hw264g1+WGAYlMlSy7nb\n\t58mtY0Hi4AoWqPmYAzih6Y0xXaCmnVM+yuhid7XmCWq3f0wo9n8lUSzlT0aXpnGqu0\n\tGj5PbFqyIWUdw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1671100269;\n\tbh=cru2L49Cgbj7KEEPqCoiuz+rRTsgVsp3uVTSSVaa2M4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fOMnELBc6dwVkM/QO45BnV0g0LrotsG+hTsvEDX1PPD/alqqr0kr8N1LKJLq+J9BN\n\tS3Za2gshQaWvBXhSDTMYGqcpLwHi0cDnJEPtxI8FOqUWh7jKVe/D1cUJSbssM8pNeT\n\tTy6Wjsxw228WgmeFCI44nfIhSy3RluXDBx1fFqVM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fOMnELBc\"; dkim-atps=neutral","Date":"Thu, 15 Dec 2022 12:31:05 +0200","To":"Xavier Roumegue ","Message-ID":"","References":"<20221214161656.436083-1-xavier.roumegue@oss.nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221214161656.436083-1-xavier.roumegue@oss.nxp.com>","Subject":"Re: [libcamera-devel] [PATCH] utils: checkstyle.py: Check new\n\theader file on new and renamed meson.build files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]