{"id":17998,"url":"https://patchwork.libcamera.org/api/patches/17998/?format=json","web_url":"https://patchwork.libcamera.org/patch/17998/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221213114836.15473-4-naush@raspberrypi.com>","date":"2022-12-13T11:48:34","name":"[libcamera-devel,v3,3/5] ipa: raspberrypi: awb: Delay release of the statistics buffer","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bfeaf5625c13acb70d2cf68ebd0eaf6be7f73509","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17998/mbox/","series":[{"id":3670,"url":"https://patchwork.libcamera.org/api/series/3670/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3670","date":"2022-12-13T11:48:31","name":"Raspberry Pi: Generalise statistics","version":3,"mbox":"https://patchwork.libcamera.org/series/3670/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17998/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17998/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE3B3C328D\n\tfor ;\n\tTue, 13 Dec 2022 11:48:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 81D326336A;\n\tTue, 13 Dec 2022 12:48:53 +0100 (CET)","from mail-wr1-x431.google.com (mail-wr1-x431.google.com\n\t[IPv6:2a00:1450:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85ADE63364\n\tfor ;\n\tTue, 13 Dec 2022 12:48:50 +0100 (CET)","by mail-wr1-x431.google.com with SMTP id f18so15312831wrj.5\n\tfor ;\n\tTue, 13 Dec 2022 03:48:50 -0800 (PST)","from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tj8-20020a5d4528000000b0024287d9d4a8sm11574541wra.74.2022.12.13.03.48.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 13 Dec 2022 03:48:48 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670932133;\n\tbh=WGDI8twxcdHAKJzJ5im7ArFW9wvzj17s+nghLwrJXYo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=UsViOkovCQg4tNZ1oC0vifu5XdE6H0N+vpsOEdb3nq4q1ZViKiBH8sF+fdNEhZiEu\n\tmgoHx1drvXHW6Dzcv9i4XPHobeTzzBJrbbDzb3kM+4zFuNY/CIrsW5OoQctYaY9ACx\n\tQkkOG+6ZRrvqXD6nnbutLfYyWdhik3eHmTuiihMrzWDZTpI1Yezp/rtuADcEp14PVY\n\tfjjnmgBh/zxqfhITnsldrSKDvACgBq1RZdlad/jONF6ZWUjiz/n3SuwNYXs+S4t1kC\n\tjyF4r6gA1Emkk5cziLw1SYp03MGDyNM3FoEy1bSUJHiR6ISQDjWdBuA8WI+X332Eee\n\tN51+5cDFChVRw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=2xu9NvIf3FFVhTiDKKJMfUfn/nFLA9UTQHonQ3imTOM=;\n\tb=folMdn4E0rlqAYw4PoNyIB2dsKvyUxhU+q1XNE8Tid4IIY8/nwFtvVVgVis2IFoMll\n\tC+8ExS+KFT3IPqUFEC3BolN7LaHmOOaklJYG1Vkg5iTgjaBhswJ6UK8yJACzV7+2oZyS\n\t3KqculpCWNlJub3LvxhEuoT5HzSm5NpXvj4IviRqwXGjRZLPtqhoF34J3rmyPPJ9V1J/\n\tfFWg9SYwkGNMnGlfIpZFhxfFx5CQ4hPbGLM8OZoiIdTPiliuBhDsUK+y911cy3Jy3RQt\n\tGuvWdRUdI8I+EaZGRZCVZetA0N6B1D0HLxRZ6SRyB2Nbl8NpnmqzVr80ctEb+FbFEyBJ\n\tQsyg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"folMdn4E\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=2xu9NvIf3FFVhTiDKKJMfUfn/nFLA9UTQHonQ3imTOM=;\n\tb=SHK3O4m9zApSi4IA3OYinVIl3DdAGLYuw6ssIh2S9yNRGaYn74HNsxelnStT5SgVyw\n\tm9DcOuQM/uAfy25Sddm0o5uHzZOFU2+1y4WLeHsHIWPOxyaOSbFV5sRbZis2DeD8cXZ2\n\tlZTFlrK9ob3Y7vyePz035FpZqMUtNlmedTS97EZ3pngYaW+0iwFZBsF8BP5wvvnkYhPp\n\tkVLLBo6H6Dq/nbGX28Zxn8LVIgimmQ7MkDezEfNNtHLWuiBEQL01iCS27OPXHVyKSYE4\n\tNewnDrh0vmh0g+OIaxwNqcN45D18ek2TNUn6dXYpY9AsucfALNejdUE4MsVA4hLOkb7X\n\tD7rg==","X-Gm-Message-State":"ANoB5plukVHfBmCitt1Djd6owzfCUelybwL5QuWn+WsfmjCSrHpIDu4Z\n\tgnIKk/gmJYcjJpp6JWizxhCONGrLK13xN8kD","X-Google-Smtp-Source":"AA0mqf4NqdZGw3ZyMXJsvBQItsxB+ZtGNOTGSPmVa+iZy3DFd+dvZROsFbp/Pcxb0PsmlAFV1WLbiA==","X-Received":"by 2002:adf:f10f:0:b0:242:19b3:67 with SMTP id\n\tr15-20020adff10f000000b0024219b30067mr12059414wro.37.1670932129588; \n\tTue, 13 Dec 2022 03:48:49 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 13 Dec 2022 11:48:34 +0000","Message-Id":"<20221213114836.15473-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20221213114836.15473-1-naush@raspberrypi.com>","References":"<20221213114836.15473-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 3/5] ipa: raspberrypi: awb: Delay\n\trelease of the statistics buffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Release the statistics buffer after running the through the AWB calculations.\nOnly the \"counted\" statistics are copied out to a local structure, so keeping\nthe statistics buffer allows the algorithm to see the \"uncounted\" statistics as\nwell.\n\nThis is currently handled by hard-coding the total number of statistics regions\nregions based on the structure definition in the bcm2835_isp_stats structure.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \n---\n src/ipa/raspberrypi/controller/rpi/awb.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\nindex 4f6af4ba98dc..04d1c8783654 100644\n--- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n@@ -427,11 +427,6 @@ void Awb::prepareStats()\n \t */\n \tgenerateStats(zones_, statistics_->awb_stats, config_.minPixels,\n \t\t config_.minG);\n-\t/*\n-\t * we're done with these; we may as well relinquish our hold on the\n-\t * pointer.\n-\t */\n-\tstatistics_.reset();\n \t/*\n \t * apply sensitivities, so values appear to come from our \"canonical\"\n \t * sensor.\n@@ -728,6 +723,11 @@ void Awb::doAwb()\n \t\t\t<< \" with gains r \" << asyncResults_.gainR\n \t\t\t<< \" and b \" << asyncResults_.gainB;\n \t}\n+\t/*\n+\t * we're done with these; we may as well relinquish our hold on the\n+\t * pointer.\n+\t */\n+\tstatistics_.reset();\n }\n \n /* Register algorithm with the system. */\n","prefixes":["libcamera-devel","v3","3/5"]}