[{"id":26369,"web_url":"https://patchwork.libcamera.org/comment/26369/","msgid":"<167508485745.42371.2116459462274015902@Monstersaurus>","date":"2023-01-30T13:20:57","subject":"Re: [libcamera-devel] [PATCH v3 2/5] ipa: raspberrypi: histogram:\n\tAdd a constructor for an empty histogram","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2022-12-13 11:48:33)\n> Add a default constructor to the RPiController::Histogram class that creates\n> an empty histogram. Since this is a cumulative histogram, push a value of 0 into\n> the first (and only) bin to signify this.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/raspberrypi/controller/histogram.h | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/ipa/raspberrypi/controller/histogram.h b/src/ipa/raspberrypi/controller/histogram.h\n> index 66a68b087964..6b3e3a9e68e4 100644\n> --- a/src/ipa/raspberrypi/controller/histogram.h\n> +++ b/src/ipa/raspberrypi/controller/histogram.h\n> @@ -20,6 +20,11 @@ namespace RPiController {\n> class Histogram\n> {\n> public:\n> + Histogram()\n> + {\n> + cumulative_.push_back(0);\n> + }\n> +\n> template Histogram(T *histogram, int num)\n> {\n> assert(num);\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2083BEFBE\n\tfor ;\n\tMon, 30 Jan 2023 13:21:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24752625E4;\n\tMon, 30 Jan 2023 14:21:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F9A160482\n\tfor ;\n\tMon, 30 Jan 2023 14:21:00 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B8FDF8B8;\n\tMon, 30 Jan 2023 14:20:59 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675084861;\n\tbh=n99q8iGGlsapL/PlsKfZWsh/lt60pMB94UIxcw2P6b4=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ESka4pm67EzQ24XZ1k3Dnr0jMpZ3ud3bkTp16wLgYE+xSV3bINBKOk0M3OwyyyqEW\n\tZHJ1D8tZHlbFlQgZPOCk02eYnUXmgZru7MIlnJ1SnUTShSmPCvUWVUKjrhqGjvqCEI\n\toiiu/QYsW058lPz9P9Ukys7L6xRLHDAsSOKvTKuS6wDe7hsIZLCGULRBxhE2KhnAYy\n\tNq9xynvEC7fPVE9QDAfQq6LGx9BVUbdY/S9H9butRxxocfuV8AfxacTf/siNYgFTnH\n\tDwxc1SW9D2NG3ZDKC8aLRjz/Thf92GsL+TF7lZ0f8ybK2EK0CfiFUZrIo2N7scd/xO\n\tCRQsU0l9iFrqw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675084859;\n\tbh=n99q8iGGlsapL/PlsKfZWsh/lt60pMB94UIxcw2P6b4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=HqAB4FiFT7CXu0PsGAo+byNAn1U4+pPZ/hcMEBzMN8hTEtnR7mtR0/zR8jDsoK8hw\n\tABf20wA6ZkadmonMsEPrZy2hr8JlOekQe3kqtHfURzTGwJnBwIuXTbyYXSuiBzfCgP\n\tn1X6EG1yFSOfztvrHea8UDN7J2PJfv+NFW1N16zk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HqAB4FiF\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221213114836.15473-3-naush@raspberrypi.com>","References":"<20221213114836.15473-1-naush@raspberrypi.com>\n\t<20221213114836.15473-3-naush@raspberrypi.com>","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 30 Jan 2023 13:20:57 +0000","Message-ID":"<167508485745.42371.2116459462274015902@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 2/5] ipa: raspberrypi: histogram:\n\tAdd a constructor for an empty histogram","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]