{"id":17989,"url":"https://patchwork.libcamera.org/api/patches/17989/?format=json","web_url":"https://patchwork.libcamera.org/patch/17989/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221213091558.621950-7-paul.elder@ideasonboard.com>","date":"2022-12-13T09:15:57","name":"[libcamera-devel,v2,6/7] tracepoints: pipeline: Add tracepoint for pipe stop","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"30254fede35853f048bf32ed49eafa9258e371d6","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17989/mbox/","series":[{"id":3668,"url":"https://patchwork.libcamera.org/api/series/3668/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3668","date":"2022-12-13T09:15:51","name":"tracepoints: request: Improve request tracepoints","version":2,"mbox":"https://patchwork.libcamera.org/series/3668/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17989/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17989/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1E6CBDE6B\n\tfor ;\n\tTue, 13 Dec 2022 09:16:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78A6A63375;\n\tTue, 13 Dec 2022 10:16:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C38F06336B\n\tfor ;\n\tTue, 13 Dec 2022 10:16:20 +0100 (CET)","from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 83CA0AFC;\n\tTue, 13 Dec 2022 10:16:19 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670922982;\n\tbh=+ug6ktsSlZJThflSAuxfjlHlVZCshb4h7SeJHlbDvXg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=tPYfMCd80SIsZs8URC+Kh5xwKi7cnJ2ynGHRAlYzjf+P/r0XyWKagJZZKGs27De3U\n\ttobq+wZzT4zo69sfpzba43L4POyTVsfhVrnRYQ17Szp1w73ky+ntc1ruXB0g+9a/Dn\n\tevRALDG0lYLU0V0/xJF8EeBv6JLoQftKxXoWjA4wiMY8Uc8OmqMTZTUg4ogD6Z37nq\n\tWF5CpFGmnPPr6MgyyO5rHdhuslJ0GiUPGX+mwJ/nKruTpSE8cET8D+dQqpUAFPp1u6\n\tVBP5DsDoetr7Bd5CNHh2PDoqspwEAQ3HA3jOX+2uLiZREwk6H0Oa9wqfIDfoyUvVAn\n\tprSE1mU8mbcRg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670922980;\n\tbh=+ug6ktsSlZJThflSAuxfjlHlVZCshb4h7SeJHlbDvXg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ek29poWuFpi01wruJJhC+d3Y5nYhdIIGPUGA93ZWVh61MqWNXpMHuQq6gUdfriWj+\n\tucrsQNRUytl7jFzDw56cP7xtQ5CSwrJ4QlS+X0C/1q02a+VkigRIok0xpy1I6VSt/o\n\tRGNlp8pR4hcGjvUaa1enTRKnNmG5SZVrxfiXs9O8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ek29poWu\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 13 Dec 2022 18:15:57 +0900","Message-Id":"<20221213091558.621950-7-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20221213091558.621950-1-paul.elder@ideasonboard.com>","References":"<20221213091558.621950-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 6/7] tracepoints: pipeline: Add\n\ttracepoint for pipe stop","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a tracepoint for stopping the pipeline. This was used for debugging\nthe segfault caused at camera stop time, where buffers were turning into\nnullptrs.\n\nSigned-off-by: Paul Elder \n\n---\nNew in v2\n---\n include/libcamera/internal/tracepoints/pipeline.tp | 13 +++++++++++++\n src/libcamera/pipeline_handler.cpp | 2 ++\n 2 files changed, 15 insertions(+)","diff":"diff --git a/include/libcamera/internal/tracepoints/pipeline.tp b/include/libcamera/internal/tracepoints/pipeline.tp\nindex 950aa918..71694dd4 100644\n--- a/include/libcamera/internal/tracepoints/pipeline.tp\n+++ b/include/libcamera/internal/tracepoints/pipeline.tp\n@@ -5,6 +5,8 @@\n * pipeline.tp - Tracepoints for pipelines\n */\n \n+#include \"libcamera/internal/pipeline_handler.h\"\n+\n TRACEPOINT_EVENT(\n \tlibcamera,\n \tipa_call_begin,\n@@ -30,3 +32,14 @@ TRACEPOINT_EVENT(\n \t\tctf_string(function_name, func)\n \t)\n )\n+\n+TRACEPOINT_EVENT(\n+\tlibcamera,\n+\tpipe_stop,\n+\tTP_ARGS(\n+\t\tlibcamera::PipelineHandler *, pipe\n+\t),\n+\tTP_FIELDS(\n+\t\tctf_string(name, pipe->name())\n+\t)\n+)\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex cfade490..7adb7628 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -326,6 +326,8 @@ void PipelineHandler::unlockMediaDevices()\n */\n void PipelineHandler::stop(Camera *camera)\n {\n+\tLIBCAMERA_TRACEPOINT(pipe_stop, this);\n+\n \t/* Stop the pipeline handler and let the queued requests complete. */\n \tstopDevice(camera);\n \n","prefixes":["libcamera-devel","v2","6/7"]}