[{"id":26048,"web_url":"https://patchwork.libcamera.org/comment/26048/","msgid":"<167085229910.9133.12533752751590520191@Monstersaurus>","date":"2022-12-12T13:38:19","subject":"Re: [libcamera-devel] [PATCH] Documentation: contributing: Add\n\tcommit message guidelines","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-12-12 13:11:38)\n> All developers, whether junior or experienced, can benefit from\n> improving their commit message writing skills. Add a paragraph to the\n> contribution documentation to explain this, with a link to a good guide.\n> \n> Signed-off-by: Laurent Pinchart \n\nSounds good to me.\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> Documentation/contributing.rst | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/Documentation/contributing.rst b/Documentation/contributing.rst\n> index 6405c5fb8a1a..2f0b4921f7e6 100644\n> --- a/Documentation/contributing.rst\n> +++ b/Documentation/contributing.rst\n> @@ -68,6 +68,13 @@ code that is as easy to read, understand and maintain as possible. This is\n> made possible by a set of :ref:`coding-style-guidelines` that all submissions\n> are expected to follow.\n> \n> +We also care about the quality of commit messages. A good commit message not\n> +only describes what a commit does, but why it does so. By conveying clear\n> +information about the purpose of the commit, it helps speeding up reviews.\n> +Regardless of whether you're new to git or have years of experience,\n> +https://cbea.ms/git-commit/ is always a good guide to read to improve your\n> +commit message writing skills.\n> +\n> The patch submission process for libcamera is similar to the Linux kernel, and\n> goes through the `libcamera-devel`_ mailing list. If you have no previous\n> experience with ``git-send-email``, or just experience trouble configuring it\n> \n> base-commit: b026e4a6a0a620ce994938c3d1babd3f3df4a47e\n> prerequisite-patch-id: ef2a8b4c18a2688014681a8f75d7ceddaed07b99\n> prerequisite-patch-id: 7b397e1ed4feed4d64faf71370fc3df4a46bb2eb\n> prerequisite-patch-id: b7d57dd39a032a92e05d3d4e22bb821b085e2291\n> prerequisite-patch-id: 05daa092b096bd8385c1ca3587e344570724308d\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E613BDE6B\n\tfor ;\n\tMon, 12 Dec 2022 13:38:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7365C63362;\n\tMon, 12 Dec 2022 14:38:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5ABFE6333F\n\tfor ;\n\tMon, 12 Dec 2022 14:38:22 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC2796CF;\n\tMon, 12 Dec 2022 14:38:21 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670852303;\n\tbh=Kdl7/jaa3rYIYV49x1B4/Vl4E2BWRVk2RIXKP6yGuRg=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=FWmw+P+N5f+QRmbzAnyy4EpKMr8nCocRGYPdWnGMVhGpERodZRfiSK5DpoK+fZ00h\n\tUPqizsk4M8Ss9wnqQ0LHAg3EeQ9pldi0uVuiJHaEYjmCpGhAXk9WP42Zh0NSQ74rOc\n\tqqneUzjPM39YlCQQ97CDo+LXUYDNCLBOmsM2428C3pMEIyUGo9ao9QKHZFVhgkqMMx\n\t95uFAEiPtTANVzos+aYh4ejVxlFfXa7N2qCUWlUfYKgp3ZR/0609HhMONYlpxseLZ/\n\tnIVVpS8InIOAhTyoc8vyZwqeoonSq0QKQkOFX4CXsvfQRtD1++NGJ/QX2iskOxZiJm\n\tDRdjJarWG87pg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670852302;\n\tbh=Kdl7/jaa3rYIYV49x1B4/Vl4E2BWRVk2RIXKP6yGuRg=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=G6mHTQMKe/AZCt3N64XCDSK7IIk9hcnGyaC01z8osxfixL7zSrPCbFctnDzVmGZhE\n\tvLzmNwOJRETKBvsGuYOxjMo9DWbsyh8OBwbGrYaITKT3KyBAn+co34sPHUljRAv2Qe\n\tnlf3jZ7s41nj9Y2CD2SAegtTdgnHcwacojpZ5NUk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"G6mHTQMK\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221212131138.26544-1-laurent.pinchart@ideasonboard.com>","References":"<20221212131138.26544-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 12 Dec 2022 13:38:19 +0000","Message-ID":"<167085229910.9133.12533752751590520191@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] Documentation: contributing: Add\n\tcommit message guidelines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26049,"web_url":"https://patchwork.libcamera.org/comment/26049/","msgid":"<41586929-7939-0fd1-9e8a-b7de4197cbfd@ideasonboard.com>","date":"2022-12-12T13:39:34","subject":"Re: [libcamera-devel] [PATCH] Documentation: contributing: Add\n\tcommit message guidelines","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello,\n\nOn 12/12/22 7:08 PM, Kieran Bingham via libcamera-devel wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-12-12 13:11:38)\n>> All developers, whether junior or experienced, can benefit from\n>> improving their commit message writing skills. Add a paragraph to the\n>> contribution documentation to explain this, with a link to a good guide.\n>>\n>> Signed-off-by: Laurent Pinchart \n> Sounds good to me.\n>\n>\n> Reviewed-by: Kieran Bingham \n\nSeconded,\n\nReviewed-by: Umang Jain \n\n>\n>> ---\n>> Documentation/contributing.rst | 7 +++++++\n>> 1 file changed, 7 insertions(+)\n>>\n>> diff --git a/Documentation/contributing.rst b/Documentation/contributing.rst\n>> index 6405c5fb8a1a..2f0b4921f7e6 100644\n>> --- a/Documentation/contributing.rst\n>> +++ b/Documentation/contributing.rst\n>> @@ -68,6 +68,13 @@ code that is as easy to read, understand and maintain as possible. This is\n>> made possible by a set of :ref:`coding-style-guidelines` that all submissions\n>> are expected to follow.\n>> \n>> +We also care about the quality of commit messages. A good commit message not\n>> +only describes what a commit does, but why it does so. By conveying clear\n>> +information about the purpose of the commit, it helps speeding up reviews.\n>> +Regardless of whether you're new to git or have years of experience,\n>> +https://cbea.ms/git-commit/ is always a good guide to read to improve your\n>> +commit message writing skills.\n>> +\n>> The patch submission process for libcamera is similar to the Linux kernel, and\n>> goes through the `libcamera-devel`_ mailing list. If you have no previous\n>> experience with ``git-send-email``, or just experience trouble configuring it\n>>\n>> base-commit: b026e4a6a0a620ce994938c3d1babd3f3df4a47e\n>> prerequisite-patch-id: ef2a8b4c18a2688014681a8f75d7ceddaed07b99\n>> prerequisite-patch-id: 7b397e1ed4feed4d64faf71370fc3df4a46bb2eb\n>> prerequisite-patch-id: b7d57dd39a032a92e05d3d4e22bb821b085e2291\n>> prerequisite-patch-id: 05daa092b096bd8385c1ca3587e344570724308d\n>> -- \n>> Regards,\n>>\n>> Laurent Pinchart\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 610E2C31E9\n\tfor ;\n\tMon, 12 Dec 2022 13:39:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12C0363362;\n\tMon, 12 Dec 2022 14:39:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 01C446333F\n\tfor ;\n\tMon, 12 Dec 2022 14:39:42 +0100 (CET)","from [IPV6:2401:4900:1f3e:7d24:3f0:3e81:fb16:ab4d] (unknown\n\t[IPv6:2401:4900:1f3e:7d24:3f0:3e81:fb16:ab4d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 68F5B6CF;\n\tMon, 12 Dec 2022 14:39:40 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670852384;\n\tbh=E3TMrTH4i9tXxXW7k7tDJ12IWGpXm/4JCfuzRg3MhoQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=YVD8LWo0+ABdv3xDfR79/3W7LLjrh9RFjOMkzpHLACgL8cXPcjqpX7GI8pMhhzseZ\n\tCQPTMay1V4/h88ie39Zl2/omL5nD2b3zYc0t2XfkWXhAlGmQh5mXbiZ7mj//pyu8rF\n\t25Mze3Q87S6y/pGnbuA/B/snmQ4kTSMHodfafMQCmzijyjv13eHSV3dF+ZLelmMbeJ\n\t6MW3Ug5bqX1EWmuO+gxdVt+5K/4m9212R+CpHP3iCAbTM0K2l0Ti+6NtoV4fOxoq5g\n\tgQKdgfFrP39LQPQi+gily/erl/kwLfjmzewoNRIf65K7qXaCJdzRKIgI1bnevLv2B2\n\tSdma87bfgo0qw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670852381;\n\tbh=E3TMrTH4i9tXxXW7k7tDJ12IWGpXm/4JCfuzRg3MhoQ=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=OFC5lVutUXg1Jgei7YO1rtoz6lE5R4OBXC2UpjJWO5G24zb9Rgcibptvq1gGv+t1h\n\tYNhkzodjPekRFE8obTYzLmqwc0ZgcsIuBOw8mQLPJ6h40zdV132Mxg/3QMD0+SuIjR\n\t9W/Na3dFroJQHdWlpn7DPZtU5TOsGRwaLhH5H9Ao="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OFC5lVut\"; dkim-atps=neutral","Message-ID":"<41586929-7939-0fd1-9e8a-b7de4197cbfd@ideasonboard.com>","Date":"Mon, 12 Dec 2022 19:09:34 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.5.1","To":"Kieran Bingham ,\n\tLaurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20221212131138.26544-1-laurent.pinchart@ideasonboard.com>\n\t<167085229910.9133.12533752751590520191@Monstersaurus>","Content-Language":"en-US","In-Reply-To":"<167085229910.9133.12533752751590520191@Monstersaurus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] Documentation: contributing: Add\n\tcommit message guidelines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26051,"web_url":"https://patchwork.libcamera.org/comment/26051/","msgid":"","date":"2022-12-12T19:35:02","subject":"Re: [libcamera-devel] [PATCH] Documentation: contributing: Add\n\tcommit message guidelines","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"Dear Laurent,\n\nThe git history contains \"tags\" in the commit message header, e.g.:\n- libcamera: pipeline:\n- pipeline: rkisp1:\n- utils: tuning: libtuning:\n- utils: libtuning: modules: alsc:\n\nThe pattern behind those tags is not (yet) obvious to me, e.g. why is it\n\"pipeline: rkisp1:\" and not \"libcamera: pipeline: rkisp1:\". Could you\nalso add some documentation on how those tags should be selected?\n\nBest,\nChristian\n\n\nAm 12.12.22 um 14:11 schrieb Laurent Pinchart via libcamera-devel:\n> All developers, whether junior or experienced, can benefit from\n> improving their commit message writing skills. Add a paragraph to the\n> contribution documentation to explain this, with a link to a good guide.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> Documentation/contributing.rst | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/Documentation/contributing.rst b/Documentation/contributing.rst\n> index 6405c5fb8a1a..2f0b4921f7e6 100644\n> --- a/Documentation/contributing.rst\n> +++ b/Documentation/contributing.rst\n> @@ -68,6 +68,13 @@ code that is as easy to read, understand and maintain as possible. This is\n> made possible by a set of :ref:`coding-style-guidelines` that all submissions\n> are expected to follow.\n>\n> +We also care about the quality of commit messages. A good commit message not\n> +only describes what a commit does, but why it does so. By conveying clear\n> +information about the purpose of the commit, it helps speeding up reviews.\n> +Regardless of whether you're new to git or have years of experience,\n> +https://cbea.ms/git-commit/ is always a good guide to read to improve your\n> +commit message writing skills.\n> +\n> The patch submission process for libcamera is similar to the Linux kernel, and\n> goes through the `libcamera-devel`_ mailing list. If you have no previous\n> experience with ``git-send-email``, or just experience trouble configuring it\n>\n> base-commit: b026e4a6a0a620ce994938c3d1babd3f3df4a47e\n> prerequisite-patch-id: ef2a8b4c18a2688014681a8f75d7ceddaed07b99\n> prerequisite-patch-id: 7b397e1ed4feed4d64faf71370fc3df4a46bb2eb\n> prerequisite-patch-id: b7d57dd39a032a92e05d3d4e22bb821b085e2291\n> prerequisite-patch-id: 05daa092b096bd8385c1ca3587e344570724308d","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 02380C31E9\n\tfor ;\n\tMon, 12 Dec 2022 19:35:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7176D63354;\n\tMon, 12 Dec 2022 20:35:05 +0100 (CET)","from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 651D96333F\n\tfor ;\n\tMon, 12 Dec 2022 20:35:03 +0100 (CET)","from [192.168.0.158] ([88.152.184.103]) by mail.gmx.net (mrgmx104\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id\n\t1MIMbU-1p8Acc3bVs-00EOVL for\n\t; Mon, 12 Dec 2022 20:35:02 +0100"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670873705;\n\tbh=ag5mGVnMAKehddCo3j58bvhR/Oom7oHmRjbWJiqImzQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=f6L4GfskgDui1W3eA9tGiam//st2rT8A4cz9oYaF7RUpaHslNGfBncrT4HVjzLJx9\n\t4MixrTliBHedW4RNGqteCnTAepWkqcSGrbXGsy41s4vrCYXic9M+0boUAlQNOl4EIo\n\t2Ca+cNXHbZ0zqwSghnz65HJMzVSiTZMms6QJ2W4woawSa21Ru9jPlWgqh2IuSchZ8s\n\tp90nczoLxXSL/ZUZoJhxdPoKIShNpEvpyhOWMXqaNvv6/V9aJyP7O3Zbdtg0mB58om\n\tcMu8k7DotuS8yX08LC/mx5+N8IejZEXL6GkAI3H5RvwqhNjJ9LtxagmsRIQGjxHBJU\n\tr31d4qHToU9gA==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; \n\tt=1670873703; bh=ag5mGVnMAKehddCo3j58bvhR/Oom7oHmRjbWJiqImzQ=;\n\th=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To;\n\tb=peBps1t+6vfZoxjJp7FBNusSK5ov3DOyg3u6fGFPmldIHZGDHXIABYfS5gZzFkLMB\n\twjidRvQxT6TMLGAhT/ryrhw+9VVuns7fRsrVFjwzQCuysN2ijXdVBJ8XPlvyjOYYyn\n\tku9MW1FucvoT69aptaaTsCWiqE07jAgV+Tv+U6kborjft17Khv8vpu0KZP+Meu5ui5\n\tExSf2I7eAOQ6z8t7JH4q43BBhrykPCD/yAzitRuMQPtgAym+DvJtnGFySgj8A9NpvX\n\t1nXAusK9cJo5ZGLPEYszgfGRJJmMi3GaLOhfYna/ugMUBMjzOG8DvSXHuAkFAL74ce\n\tMR1Wkmx6t8CZw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmx.de header.i=@gmx.de\n\theader.b=\"peBps1t+\"; dkim-atps=neutral","X-UI-Sender-Class":"724b4f7f-cbec-4199-ad4e-598c01a50d3a","Message-ID":"","Date":"Mon, 12 Dec 2022 20:35:02 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.4.2","Content-Language":"en-GB","To":"libcamera-devel@lists.libcamera.org","References":"<20221212131138.26544-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20221212131138.26544-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:MKNgUjxPihoQbW34PUAOAa1ItJ3HE4n5wlmYI0lCzCn9P/aAut4\n\tYwR/I38mTo7KbUMPYkj3LEuqF4MJb3Vpsh6xl6w9rN9POOhRfbvdEMHmmWRyEXXCISWY4G3\n\tjnzxDH05wTA/1eJEDxlrekPQi1jI7/r/BnQtXhcE4o6C5BbzchZxZJE/q5bnEgCQFa/ddy0\n\tEbgEbn9+ZC9ke79u/Jjdw==","X-Spam-Flag":"NO","UI-OutboundReport":"notjunk:1; M01:P0:PRIebxpo5BA=;\n\tuLxjDqkacJJcKnxGKeTWPxTasdq\n\tpWbi6YGgCuaFaExUurK0uQKBDJbZTo+3M3un8DfbLZS1b2Oss4oq3JIj+YcL2QY8vFk9b8AbU\n\tXnDziaLYKNhDwoTV2va8tkL5tXIlJtyp/yGT8CP3MwfZqvnFcH7indtyA0wJSHvJHMGKv2sbv\n\tCvlie5x+xvEgrLwaQAWuAARF0fhXOiVhui9llH8dkeJILOdpA1G/xU2Ena63QFdxA7yAcHQkS\n\tPMaViAIfX9Gi6Esj7+xQjAXhlBsiZ/bO0P64e2o17a5+gIBmXQ3207zoRKNNrr+eZXgFBQI7+\n\tvsnQxE5ronJXW6y7K3pFUEMtUowoW8Xxe5jFgbVaJFoDgoI4cEmHygWEIUjzW1SbopK2txvNz\n\tEufpsIKemHlX2Os4b2fbl4Qp1PWcszZFQAmIH5EpwgIqxbv9bvwr5XztHHVBy4ap4va6JoTmo\n\tNrYDK82sd62K7im8iTBlC05fF1rVNrSSwPDO/+BuuhYQeGST/YFn+09h5O92BL48fgJPWzNzv\n\tSSmJe6Hr5Lgv9xzEKPEuHGhrO3CYxX/gUL7y6+sQWSx/4j52pwguWSbLa99LG0XC1TVjuDYIr\n\tA5RbA50Igj/0Z6RdXiGngEz4SLV7VZz0nbDMENZx3H2oxQpqXalzjctXhDX6lQ0J9edZ6obbC\n\tDroOKl1J6za9msKvx/KKuimYH1JgoybKHYlEM6XT4RcNsh8I5QTJG3oYlec1QPZvSaaFqi9FH\n\t4q+6ur3X8is4Bb7FIzMLV8X/byNpU/ThwigoiJjVx8xw8VP8wpGhqIWyjRQ8fMppPk8J0eWEm\n\tuViZT86/CETujLDZxr8TahlyYf2/aP/7DE5WZJR83m4DJ2S1teuLGbt2EN8GtqkT0JAzs0sx/\n\tybJ7stFkGSYRT582wqdWAFOuWd8s+LOe28EB+sdLl+VaVcRVmw1MfO20E4zLP/xmj9Ck5vIu9\n\tB28D423oqawVJxpukXnA1ahwxpU=","Subject":"Re: [libcamera-devel] [PATCH] Documentation: contributing: Add\n\tcommit message guidelines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26052,"web_url":"https://patchwork.libcamera.org/comment/26052/","msgid":"<167092634073.9133.7763715811176627395@Monstersaurus>","date":"2022-12-13T10:12:20","subject":"Re: [libcamera-devel] [PATCH] Documentation: contributing: Add\n\tcommit message guidelines","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Christian Rauch via libcamera-devel (2022-12-12 19:35:02)\n> Dear Laurent,\n> \n> The git history contains \"tags\" in the commit message header, e.g.:\n> - libcamera: pipeline:\n> - pipeline: rkisp1:\n> - utils: tuning: libtuning:\n> - utils: libtuning: modules: alsc:\n> \n> The pattern behind those tags is not (yet) obvious to me, e.g. why is it\n> \"pipeline: rkisp1:\" and not \"libcamera: pipeline: rkisp1:\". Could you\n> also add some documentation on how those tags should be selected?\n\nThere's no formal definition here I think. It's usually 'obvious' by\nlooking at the history of the files being changed. Sometimes it's\ndifficult if the patch covers multiple areas too.\n\nBut generally it's the 'component' name. Sometimes it makes sense to\nleave a tag out because otherwise the subject line would become too\nlong.\n\nThe 'libcamera:' prefix on pipeline: rkisp1: could be implicit, so it's\neasy to drop.\n\nAdding a phrase or two like this to the contributing.rst could indeed\nmake sense.\n\n--\nKieran\n\n\n> \n> Best,\n> Christian\n> \n> \n> Am 12.12.22 um 14:11 schrieb Laurent Pinchart via libcamera-devel:\n> > All developers, whether junior or experienced, can benefit from\n> > improving their commit message writing skills. Add a paragraph to the\n> > contribution documentation to explain this, with a link to a good guide.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > Documentation/contributing.rst | 7 +++++++\n> > 1 file changed, 7 insertions(+)\n> >\n> > diff --git a/Documentation/contributing.rst b/Documentation/contributing.rst\n> > index 6405c5fb8a1a..2f0b4921f7e6 100644\n> > --- a/Documentation/contributing.rst\n> > +++ b/Documentation/contributing.rst\n> > @@ -68,6 +68,13 @@ code that is as easy to read, understand and maintain as possible. This is\n> > made possible by a set of :ref:`coding-style-guidelines` that all submissions\n> > are expected to follow.\n> >\n> > +We also care about the quality of commit messages. A good commit message not\n> > +only describes what a commit does, but why it does so. By conveying clear\n> > +information about the purpose of the commit, it helps speeding up reviews.\n> > +Regardless of whether you're new to git or have years of experience,\n> > +https://cbea.ms/git-commit/ is always a good guide to read to improve your\n> > +commit message writing skills.\n> > +\n> > The patch submission process for libcamera is similar to the Linux kernel, and\n> > goes through the `libcamera-devel`_ mailing list. If you have no previous\n> > experience with ``git-send-email``, or just experience trouble configuring it\n> >\n> > base-commit: b026e4a6a0a620ce994938c3d1babd3f3df4a47e\n> > prerequisite-patch-id: ef2a8b4c18a2688014681a8f75d7ceddaed07b99\n> > prerequisite-patch-id: 7b397e1ed4feed4d64faf71370fc3df4a46bb2eb\n> > prerequisite-patch-id: b7d57dd39a032a92e05d3d4e22bb821b085e2291\n> > prerequisite-patch-id: 05daa092b096bd8385c1ca3587e344570724308d","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8800BBDE6B\n\tfor ;\n\tTue, 13 Dec 2022 10:12:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB30B63362;\n\tTue, 13 Dec 2022 11:12:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2DC16334D\n\tfor ;\n\tTue, 13 Dec 2022 11:12:23 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 42A0F4A7;\n\tTue, 13 Dec 2022 11:12:23 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670926345;\n\tbh=728bKdFI9wnxZWNyaVNsDgGP6rxsBaP1Ij4drqPyp2A=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=RNbMNbRsZbgdVPOpEvBeNLoQ9jt3irTQzAztEdcptQ0Apvq/uH0M8amcJEQK4qbSn\n\tTb62jCqVAiVO2v+ClDT9r6FtBq1poCy5yXV7xN57j9eyc6exOljs21Al8taQ4jqubW\n\tVqMDOXiv5MgE9zOcXGwphFVkwaRC2UauY5BClzsdl/nS+Bs0eQaA0sLsj22H2N0j30\n\tjxilu5CqGKStmyedXl5SidYFxNIdrRSyl2aYHsEV+k8sMhtp5DhNMc8MmX+JU04q66\n\tgO9haBwkt+UJQLm5kxu4RErlR6lpEi2m8pKw++coqn+GXJdOq7V9yAxY1GLlBfDFAJ\n\tCRKvXcHYRSnZg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670926343;\n\tbh=728bKdFI9wnxZWNyaVNsDgGP6rxsBaP1Ij4drqPyp2A=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=KoqAov+/q5DN35lUhr8sJUH9U1ZuGS58u3ggPY5sW2zjVeQaeBu4qUkd6S4GqtpH2\n\tuD316U3QXmxRsTPem/DNtH1IwcyceqZIkQMe3SbnyQMlAIorWpojNL3cn+XPqoL+wa\n\tuevHLL0DJQzfAel89sAdq5xkGHz49sdEhqUMw5p4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"KoqAov+/\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20221212131138.26544-1-laurent.pinchart@ideasonboard.com>\n\t","To":"Christian Rauch ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 13 Dec 2022 10:12:20 +0000","Message-ID":"<167092634073.9133.7763715811176627395@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] Documentation: contributing: Add\n\tcommit message guidelines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]