{"id":17979,"url":"https://patchwork.libcamera.org/api/patches/17979/?format=json","web_url":"https://patchwork.libcamera.org/patch/17979/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221212131138.26544-1-laurent.pinchart@ideasonboard.com>","date":"2022-12-12T13:11:38","name":"[libcamera-devel] Documentation: contributing: Add commit message guidelines","commit_ref":"e653f4c13e32225c2d1c304f3e6c44ff4efbdfe9","pull_url":null,"state":"accepted","archived":false,"hash":"81afafbab74e74b4ce1f9b20906b8f7a3e6887ed","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17979/mbox/","series":[{"id":3666,"url":"https://patchwork.libcamera.org/api/series/3666/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3666","date":"2022-12-12T13:11:38","name":"[libcamera-devel] Documentation: contributing: Add commit message guidelines","version":1,"mbox":"https://patchwork.libcamera.org/series/3666/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17979/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17979/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D83A7C31E9\n\tfor ;\n\tMon, 12 Dec 2022 13:11:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2020E63354;\n\tMon, 12 Dec 2022 14:11:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4981D6333F\n\tfor ;\n\tMon, 12 Dec 2022 14:11:41 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7A666CF\n\tfor ;\n\tMon, 12 Dec 2022 14:11:40 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670850703;\n\tbh=47MdW+W8msp/W2Ky+49mC0IPflRmfcvYZRkJthJgEcs=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=Wfh1Xa6bEOIHK91R4kQl+mmLA0YtX1XztfMp6qJ6JN+1zLwlx4/jpxH0/b9UG45AG\n\teRIWIak1Dly1XDtN2sh9zXdiZWvYUr2KVA+qeFQg3L7/69oKyjr1J9U89hlXqa58uJ\n\tOG6+CdB3KfJ5PHo2TSo46h4S8GbRrjuEisiL+fAmEP1w82mCOQ8GhRwZNPN8mceU+H\n\t0DprZ3YhMhg7HEREJ3K2LI4pxfXYNy1GwPzQPxBTibPuS3p5Kwgs5H1wT7LcxKjyo8\n\tpnrryvIR57BA0IvT4d2InHbkWVwi+WM7iqYyzzNDXJI4nbMnAo7gifakxa+QXzFSYR\n\tK8sFnSlgDDmvw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670850700;\n\tbh=47MdW+W8msp/W2Ky+49mC0IPflRmfcvYZRkJthJgEcs=;\n\th=From:To:Subject:Date:From;\n\tb=m8r1z+Qdriyvmnsb21BmkRo8m9M5HJZAwCjkCUGaGnT1OSIKvSzgOIWnLqFe54s7W\n\t7H6BpF/jP3e5s5rG7YUsEAFYi+PcBh8nfOWnYJgSQAaiRqvCCXHTeuDvvdYVvUU7OB\n\t3ivGH2/9cv7sm+EDu/jsu5IMAWux8hsZbe3yInL4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"m8r1z+Qd\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 12 Dec 2022 15:11:38 +0200","Message-Id":"<20221212131138.26544-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.37.4","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] Documentation: contributing: Add commit\n\tmessage guidelines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"All developers, whether junior or experienced, can benefit from\nimproving their commit message writing skills. Add a paragraph to the\ncontribution documentation to explain this, with a link to a good guide.\n\nSigned-off-by: Laurent Pinchart \n---\n Documentation/contributing.rst | 7 +++++++\n 1 file changed, 7 insertions(+)\n\n\nbase-commit: b026e4a6a0a620ce994938c3d1babd3f3df4a47e\nprerequisite-patch-id: ef2a8b4c18a2688014681a8f75d7ceddaed07b99\nprerequisite-patch-id: 7b397e1ed4feed4d64faf71370fc3df4a46bb2eb\nprerequisite-patch-id: b7d57dd39a032a92e05d3d4e22bb821b085e2291\nprerequisite-patch-id: 05daa092b096bd8385c1ca3587e344570724308d","diff":"diff --git a/Documentation/contributing.rst b/Documentation/contributing.rst\nindex 6405c5fb8a1a..2f0b4921f7e6 100644\n--- a/Documentation/contributing.rst\n+++ b/Documentation/contributing.rst\n@@ -68,6 +68,13 @@ code that is as easy to read, understand and maintain as possible. This is\n made possible by a set of :ref:`coding-style-guidelines` that all submissions\n are expected to follow.\n \n+We also care about the quality of commit messages. A good commit message not\n+only describes what a commit does, but why it does so. By conveying clear\n+information about the purpose of the commit, it helps speeding up reviews.\n+Regardless of whether you're new to git or have years of experience,\n+https://cbea.ms/git-commit/ is always a good guide to read to improve your\n+commit message writing skills.\n+\n The patch submission process for libcamera is similar to the Linux kernel, and\n goes through the `libcamera-devel`_ mailing list. If you have no previous\n experience with ``git-send-email``, or just experience trouble configuring it\n","prefixes":["libcamera-devel"]}