[{"id":26041,"web_url":"https://patchwork.libcamera.org/comment/26041/","msgid":"<167083679441.9133.1557537417057956556@Monstersaurus>","date":"2022-12-12T09:19:54","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Rectify\n\ttest patterns listed for IMX519","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain via libcamera-devel (2022-12-12 07:16:47)\n> The IMX519 driver reports ColorBars and ColorBarsFadeToGray but upon\n> inspecting the test pattern modes via v4l2-ctl utility, these test\n> patterns do not comply with MIPI CCS v1.1 (Section 10.1).\n> \n> Hence, omit from camera-sensor-properties database for now and add a\n> comment for the same.\n> \n> Fixes: e3b26b4c4eb2 (\"libcamera: camera_sensor: Add IMX519 sensor properties\")\n> Signed-off-by: Umang Jain \n\nSounds fine to me.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 04d80d6d..7f5e404e 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -106,10 +106,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> .unitCellSize = { 1220, 1220 },\n> .testPatternModes = {\n> { controls::draft::TestPatternModeOff, 0 },\n> - { controls::draft::TestPatternModeColorBars, 1 },\n> { controls::draft::TestPatternModeSolidColor, 2 },\n> - { controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n> { controls::draft::TestPatternModePn9, 4 },\n> + /*\n> + * The driver reports ColorBars and ColorBarsFadeToGray as well but\n> + * these two patterns do not comply with MIPI CCS v1.1 (Section 10.1).\n> + */\n> },\n> } },\n> { \"ov2740\", {\n> -- \n> 2.38.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E652BDE6B\n\tfor ;\n\tMon, 12 Dec 2022 09:19:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01D4F63354;\n\tMon, 12 Dec 2022 10:19:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D22161F23\n\tfor ;\n\tMon, 12 Dec 2022 10:19:57 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF706FB;\n\tMon, 12 Dec 2022 10:19:56 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670836799;\n\tbh=RalwhVGQ2ocnmMuWFEEKZUykfzh3bgPXpNIJjN+Yy28=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=kHNsN7bzTTggVEva+mX5bXr2/q47GCoDUd00Xzv34F1mgIMVjBuM6RS8wLHlcmYLV\n\tFOvqERhT7ruM7QLTeWs5m8rxyAc7C99UgSBOAykmRFCOEeSaC/JqZa+zGfMnFbYVoH\n\t4m6qIm58RJlR18Q+ENOkwezH7JFNweOE9z544za2JAAftKVFA0CfoVnMNocBWAt0sv\n\tGl76C4W3U2zCypHyoMOxWgvTvKlYYFTW5ZAwv+ZBqen3eD8bqp989GEb7HKcFdmWLD\n\thYEcsviJjwFQVMo73gD0wwIMh59uDONuHc3DIpX3rS4G/nmgktc/7QRKMLrJ2Sw4hM\n\tMUb2jhQ4zX9aw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670836796;\n\tbh=RalwhVGQ2ocnmMuWFEEKZUykfzh3bgPXpNIJjN+Yy28=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=PFMvU0WOd8i4UmLzd2lqzHCtrrTqN8UPGxi/049OYENbHeUGl4iiZqNobZZc6D7dX\n\tLy8Ldkl1tAXrYPnqwPWUitS4BDubQWfTozWQ/IfFVu9Jc940wsm7xXqzqqn24RJxse\n\taWfrAWYjoweqyB/ubqKEXJjG1F9NOtjfYMmz7jH8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PFMvU0WO\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221212071647.23803-1-umang.jain@ideasonboard.com>","References":"<20221212071647.23803-1-umang.jain@ideasonboard.com>","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 12 Dec 2022 09:19:54 +0000","Message-ID":"<167083679441.9133.1557537417057956556@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Rectify\n\ttest patterns listed for IMX519","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26042,"web_url":"https://patchwork.libcamera.org/comment/26042/","msgid":"","date":"2022-12-12T09:34:20","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Rectify\n\ttest patterns listed for IMX519","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Mon, Dec 12, 2022 at 12:46:47PM +0530, Umang Jain via libcamera-devel wrote:\n> The IMX519 driver reports ColorBars and ColorBarsFadeToGray but upon\n> inspecting the test pattern modes via v4l2-ctl utility, these test\n> patterns do not comply with MIPI CCS v1.1 (Section 10.1).\n> \n> Hence, omit from camera-sensor-properties database for now and add a\n> comment for the same.\n> \n> Fixes: e3b26b4c4eb2 (\"libcamera: camera_sensor: Add IMX519 sensor properties\")\n> Signed-off-by: Umang Jain \n\nI'm still puzzled by the blue-yellow colour bars pattern when selecting\ntest pattern 1. It could be a sensor misconfiguration, which would be\nnice to fix. Not something we need to look at though, for this patch,\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 04d80d6d..7f5e404e 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -106,10 +106,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t.unitCellSize = { 1220, 1220 },\n> \t\t\t.testPatternModes = {\n> \t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> -\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n> \t\t\t\t{ controls::draft::TestPatternModeSolidColor, 2 },\n> -\t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n> \t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n> +\t\t\t\t/*\n> +\t\t\t\t * The driver reports ColorBars and ColorBarsFadeToGray as well but\n> +\t\t\t\t * these two patterns do not comply with MIPI CCS v1.1 (Section 10.1).\n> +\t\t\t\t */\n> \t\t\t},\n> \t\t} },\n> \t\t{ \"ov2740\", {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36D82C31E9\n\tfor ;\n\tMon, 12 Dec 2022 09:34:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9765D63362;\n\tMon, 12 Dec 2022 10:34:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 53BEF61F23\n\tfor ;\n\tMon, 12 Dec 2022 10:34:23 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C393B8A9;\n\tMon, 12 Dec 2022 10:34:22 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670837664;\n\tbh=9/sC4FfJkSeFSixnrfCLS0bc+/fGm0u8TzQ1B4/QTlM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZiD7rbccZki3gwTZer1uk6hJkEFrygBwcTXWQpatW+YBNK2WEK6T1VFb68ZdSXUbl\n\tWqMJiR3H8sUf3jzP0TQpeKZwofOxR4JItlKU2pIMHtoEiHssDiPYW+oUdCoEejCq14\n\t5cJENHE8P8G6fYFKmbL7k22WJhckBXF0Ne88S6y6ghs43XiA0agxxQSxGTt942SXvE\n\teiHNOCidrfabOn+f2joG3WwR2MeH6cQPaiQZtLrYpAhIf9pnzySpHA5WTo0wfuAJIk\n\tKlSWM7zJ3qzVh4e7Ubcs5LoIXcW2y1Jm0nps8Ie5xxo/T1VsQRkVkKQApAlgwGrCl+\n\t0XpqyrwEYbotg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670837663;\n\tbh=9/sC4FfJkSeFSixnrfCLS0bc+/fGm0u8TzQ1B4/QTlM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Mxzt+rbFuT7JoUgtfFzBGvuhaxLMyvPNJogC07cccL/NtwMO7jsinozt4nOJ8JdDL\n\thti4OPFXqDWAZWgE9O2/spQzagOFdw0tfqVV7kvClqHgx2cYkcQDs7M2HnL57xRFG1\n\tC+RqKJOIG5fSxKl6Iv51D+dg61Gb28oIPfZwH+js="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Mxzt+rbF\"; dkim-atps=neutral","Date":"Mon, 12 Dec 2022 11:34:20 +0200","To":"Umang Jain ","Message-ID":"","References":"<20221212071647.23803-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221212071647.23803-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Rectify\n\ttest patterns listed for IMX519","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]