[{"id":26038,"web_url":"https://patchwork.libcamera.org/comment/26038/","msgid":"","date":"2022-12-10T21:04:16","subject":"Re: [libcamera-devel] [PATCH] Simple typo fixes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Pavel,\n\nThank you for the patch.\n\nOn Sat, Dec 10, 2022 at 09:58:53PM +0100, Pavel Machek via libcamera-devel wrote:\n> During reading the code, I found some typos that could be fixed.\n> \n> Signed-off-by: Pavel Machek \n\nReviewed-by: Laurent Pinchart \n\nIt would be nice to integrate a spellchecker into our checkstyle.py\nscript. Last time I have a look at it (that was a while ago) it wasn't\nexactly trivial, even if we could extra comments properly (requiring C++\nparsing), there would likely be lots of false positives.\n\n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index 9256bbba..d5fabaf1 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -2,7 +2,7 @@\n> /*\n> * Copyright (C) 2019, Google Inc.\n> *\n> - * ipa_vimc.cpp - Vimc Image Processing Algorithm module\n> + * vimc.cpp - Vimc Image Processing Algorithm module\n> */\n> #include \n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 231b16ec..d0a2d2c5 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -214,7 +214,7 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req\n> \tFrameBuffer *paramBuffer = pipe_->availableParamBuffers_.front();\n> \n> \tif (pipe_->availableStatBuffers_.empty()) {\n> -\t\tLOG(RkISP1, Error) << \"Statisitc buffer underrun\";\n> +\t\tLOG(RkISP1, Error) << \"Statistic buffer underrun\";\n> \t\treturn nullptr;\n> \t}\n> \tFrameBuffer *statBuffer = pipe_->availableStatBuffers_.front();\n> @@ -331,7 +331,7 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)\n> \n> \t/*\n> \t * The API tuning file is made from the sensor name unless the\n> -\t * environment variable overrides it. If\n> +\t * environment variable overrides it.\n> \t */\n> \tstd::string ipaTuningFile;\n> \tchar const *configFromEnv = utils::secure_getenv(\"LIBCAMERA_RKISP1_TUNING_FILE\");\n> @@ -507,7 +507,7 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n> \t\t\t}\n> \t\t}\n> \n> -\t\t/* All paths rejected configuraiton. */\n> +\t\t/* All paths rejected configuration. */\n> \t\tLOG(RkISP1, Debug) << \"Camera configuration not supported \"\n> \t\t\t\t << cfg.toString();\n> \t\treturn Invalid;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20833BE08B\n\tfor ;\n\tSat, 10 Dec 2022 21:04:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 76E506335E;\n\tSat, 10 Dec 2022 22:04:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F237A603CC\n\tfor ;\n\tSat, 10 Dec 2022 22:04:18 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 687A94AE;\n\tSat, 10 Dec 2022 22:04:18 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670706260;\n\tbh=eNfLgtn97iOcynkOklVaMgwhsmfssAF5rfpm3nWFJlQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=TtF6RLSRUsebEwEAhNdjR+cZV0NgB6CSIX9avi8p6cxXBvO1uSc5tNf+EqGVt1CyD\n\tjUhm2j/ZwCcVFM6zX+RIC0YCwmQX4SIeMOteeJ6DKW/0gEoPOzieR+0q1qPLuI1KyE\n\tSIB7e1Ofbm5HjVzb+zuoR2yax1mkW9J2XNAz2U1oYM2OHArdQYWUtCd6LecEUBoFLp\n\tzYkDfMejyaeSgw1HXYOXrpwzID2w+1gMVg68lWhlMeIMetotLRxtcd/WUKQv5XIfmX\n\tN8G12NJHwVOFb9wNpzko7+J7/Bzq5Hdgmjh32TkTYaGPo2qbizyWIgvWCamaUhAqfO\n\twHn0PlNSZtWSA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670706258;\n\tbh=eNfLgtn97iOcynkOklVaMgwhsmfssAF5rfpm3nWFJlQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=R4GuL0q0nv6gD6H0wYmogtHTVtCWXjs5RjzPb6Lqar4CDnj50A+S/ijZ/Cgw3c2He\n\t09awANeKwBeYIh4rQEQyTHI/HyTmKyjafy3aNTXVKNVuvNA+6Ehpm1t5wjjBaNIc1S\n\tOExs0KwAK+M/QmyaWAXessCJfZ+M/bdwJUoze+Vs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"R4GuL0q0\"; dkim-atps=neutral","Date":"Sat, 10 Dec 2022 23:04:16 +0200","To":"Pavel Machek ","Message-ID":"","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] Simple typo fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26039,"web_url":"https://patchwork.libcamera.org/comment/26039/","msgid":"","date":"2022-12-10T21:25:10","subject":"Re: [libcamera-devel] [PATCH] Simple typo fixes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sat, Dec 10, 2022 at 11:04:16PM +0200, Laurent Pinchart via libcamera-devel wrote:\n> Hi Pavel,\n> \n> Thank you for the patch.\n> \n> On Sat, Dec 10, 2022 at 09:58:53PM +0100, Pavel Machek via libcamera-devel wrote:\n> > During reading the code, I found some typos that could be fixed.\n> > \n> > Signed-off-by: Pavel Machek \n> \n> Reviewed-by: Laurent Pinchart \n\nActually, this doesn't apply on the master branch. Would you be able to\nrebase and send a v2 ?\n\n> It would be nice to integrate a spellchecker into our checkstyle.py\n> script. Last time I have a look at it (that was a while ago) it wasn't\n> exactly trivial, even if we could extra comments properly (requiring C++\n> parsing), there would likely be lots of false positives.\n> \n> > diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> > index 9256bbba..d5fabaf1 100644\n> > --- a/src/ipa/vimc/vimc.cpp\n> > +++ b/src/ipa/vimc/vimc.cpp\n> > @@ -2,7 +2,7 @@\n> > /*\n> > * Copyright (C) 2019, Google Inc.\n> > *\n> > - * ipa_vimc.cpp - Vimc Image Processing Algorithm module\n> > + * vimc.cpp - Vimc Image Processing Algorithm module\n> > */\n> > #include \n> > \n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index 231b16ec..d0a2d2c5 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -214,7 +214,7 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req\n> > \tFrameBuffer *paramBuffer = pipe_->availableParamBuffers_.front();\n> > \n> > \tif (pipe_->availableStatBuffers_.empty()) {\n> > -\t\tLOG(RkISP1, Error) << \"Statisitc buffer underrun\";\n> > +\t\tLOG(RkISP1, Error) << \"Statistic buffer underrun\";\n> > \t\treturn nullptr;\n> > \t}\n> > \tFrameBuffer *statBuffer = pipe_->availableStatBuffers_.front();\n> > @@ -331,7 +331,7 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)\n> > \n> > \t/*\n> > \t * The API tuning file is made from the sensor name unless the\n> > -\t * environment variable overrides it. If\n> > +\t * environment variable overrides it.\n> > \t */\n> > \tstd::string ipaTuningFile;\n> > \tchar const *configFromEnv = utils::secure_getenv(\"LIBCAMERA_RKISP1_TUNING_FILE\");\n> > @@ -507,7 +507,7 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n> > \t\t\t}\n> > \t\t}\n> > \n> > -\t\t/* All paths rejected configuraiton. */\n> > +\t\t/* All paths rejected configuration. */\n> > \t\tLOG(RkISP1, Debug) << \"Camera configuration not supported \"\n> > \t\t\t\t << cfg.toString();\n> > \t\treturn Invalid;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1977BDE6B\n\tfor ;\n\tSat, 10 Dec 2022 21:25:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B1066335E;\n\tSat, 10 Dec 2022 22:25:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B497603CC\n\tfor ;\n\tSat, 10 Dec 2022 22:25:13 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E47A4AE;\n\tSat, 10 Dec 2022 22:25:12 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670707514;\n\tbh=m8HvCIWizRdNNbIUbrzKaS2e+mO/1xSMHgl4aG9vNDs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=hxrqUGOGViUV0cGZ9SSApT3FFr/Z0V7HOb35IM56Ps5pqnbNRu5ADFFbN50Tm4lN7\n\tfuEI/J7kKwZHxsKa1qYU8pfymnmr20Yf/qGk9ivNh8weFJQpnx7MIXRy4tzMeWTVOp\n\tVpzsvFcpXeTUS9S61pTg0Z2YT2rDu4tudlUmrbVrZG7PySCiRnkx6wFR4/T180XmYP\n\tQq4SpGPiuCPT8gjzuuCbVpWZqN5FBjkTKLkyuB+6gjZWLCiiZO0sxAa4Pcy7P64F5p\n\tKGXdS0YBNavrntxsbSnSDHcqGM6mUdUAvQbLeWTJegqrTmjbJyjFA7JNEolodzrE5p\n\tg6nFHrsTXPtlQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670707512;\n\tbh=m8HvCIWizRdNNbIUbrzKaS2e+mO/1xSMHgl4aG9vNDs=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=IpOuz2NFXpDS45orYZoL5pPgSsbPx/+nvj3IoiY0WaUGwQa2ZEG2pVD+lsmOXvsR5\n\tSb09Xcpr0BTe/4v/UKXp2ke+tIyM+yFktXpfi5Ui5TH6w2B3+78meKjL+NVwF2Lg3K\n\tTcwrqvkj+PYZ5JS2Wk8ACUVxGfHOkwVxUoDigNfg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IpOuz2NF\"; dkim-atps=neutral","Date":"Sat, 10 Dec 2022 23:25:10 +0200","To":"Pavel Machek , libcamera-devel@lists.libcamera.org","Message-ID":"","References":"\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] Simple typo fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]