{"id":17963,"url":"https://patchwork.libcamera.org/api/patches/17963/?format=json","web_url":"https://patchwork.libcamera.org/patch/17963/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221209081937.598303-5-paul.elder@ideasonboard.com>","date":"2022-12-09T08:19:37","name":"[libcamera-devel,4/4] tracepoints: request: Add flags to request_reuse tracepoint","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2f76bcad64eb3547446b721bcdc8af783a1417b3","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17963/mbox/","series":[{"id":3662,"url":"https://patchwork.libcamera.org/api/series/3662/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3662","date":"2022-12-09T08:19:33","name":"tracepoints: request: Improve request tracepoints","version":1,"mbox":"https://patchwork.libcamera.org/series/3662/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17963/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17963/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37A0BBDE6B\n\tfor ;\n\tFri, 9 Dec 2022 08:20:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED0F36335D;\n\tFri, 9 Dec 2022 09:20:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 06BAA6334B\n\tfor ;\n\tFri, 9 Dec 2022 09:20:02 +0100 (CET)","from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9398F480;\n\tFri, 9 Dec 2022 09:20:01 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670574005;\n\tbh=EFJeSy6sbJJ2oXZhNmCoBfWGPim8lrt3pOCpN6iX5qU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=VWQz+S5GaEuUiU3afFK7li/shNRrqXlySmWhqJ9VBq8l8YL4a4pMPVeodHafFBNOV\n\t1kWX46o5pxQqsAS3EuQ9lZQHxq0loHjLiwjzhGURsJjRiNVUGA/h05IVYxfemEZvrL\n\t5WZLLmncRLL2MXhYQzluAPeTSKBYSGg6my9LUDF23VsJRtvFjeiCpWbcTKH3McsMfN\n\tkRAH0ki2f6rPi3ShK/Lvgjan9cOZ4N8hwYWGfC1XmfRMaTsQMhvDqZ2NIFI656TDgS\n\ttDbB2t7t6dfJZAMsmX+Hm2W4qIzwA50pmBxRMfOc5IJlObkldF5FVp6Ng5QffNwpvD\n\tWwZqYQoocn8NA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670574002;\n\tbh=EFJeSy6sbJJ2oXZhNmCoBfWGPim8lrt3pOCpN6iX5qU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TaV2dqrLE8FJlJm03Fm1wK+5flaevp0fdHV590yhgBIMQuRAljrqhB+0cZU6sGGYn\n\ta6gQSfUkU17E0ZTAL/cX2xBSzsd0YfIlvwbONT4fJWS+inHdGvstNcmuUMRVZOxz6R\n\tgrJq02WZ2+CkhYXAuwuFfguRjV97uOEV4YIDJtcU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"TaV2dqrL\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 9 Dec 2022 17:19:37 +0900","Message-Id":"<20221209081937.598303-5-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20221209081937.598303-1-paul.elder@ideasonboard.com>","References":"<20221209081937.598303-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 4/4] tracepoints: request: Add flags to\n\trequest_reuse tracepoint","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add flags to the fields of the tracepoint event request_reuse. This\ncauses it to be no longer able to use the event class, which is why it\nhas to list the fields again.\n\nSigned-off-by: Paul Elder \n---\n .../libcamera/internal/tracepoints/request.tp | 24 ++++++++++++-------\n src/libcamera/request.cpp | 2 +-\n 2 files changed, 16 insertions(+), 10 deletions(-)","diff":"diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp\nindex 29aa3745..e173929f 100644\n--- a/include/libcamera/internal/tracepoints/request.tp\n+++ b/include/libcamera/internal/tracepoints/request.tp\n@@ -63,15 +63,6 @@ TRACEPOINT_EVENT_INSTANCE(\n \t)\n )\n \n-TRACEPOINT_EVENT_INSTANCE(\n-\tlibcamera,\n-\trequest,\n-\trequest_reuse,\n-\tTP_ARGS(\n-\t\tlibcamera::Request *, req\n-\t)\n-)\n-\n TRACEPOINT_EVENT_INSTANCE(\n \tlibcamera,\n \trequest,\n@@ -127,3 +118,18 @@ TRACEPOINT_EVENT_INSTANCE(\n \t\tlibcamera::FrameBuffer *, buf\n \t)\n )\n+\n+TRACEPOINT_EVENT(\n+\tlibcamera,\n+\trequest_reuse,\n+\tTP_ARGS(\n+\t\tlibcamera::Request *, req,\n+\t\tenum libcamera::Request::ReuseFlag, flags\n+\t),\n+\tTP_FIELDS(\n+\t\tctf_integer_hex(uintptr_t, request, reinterpret_cast(req))\n+\t\tctf_integer(uint64_t, cookie, req->cookie())\n+\t\tctf_enum(libcamera, request_status, uint32_t, status, req->status())\n+\t\tctf_integer_hex(uint32_t, flags, static_cast(flags))\n+\t)\n+)\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex ecefba0b..04c0c45c 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -381,7 +381,7 @@ Request::~Request()\n */\n void Request::reuse(ReuseFlag flags)\n {\n-\tLIBCAMERA_TRACEPOINT(request_reuse, this);\n+\tLIBCAMERA_TRACEPOINT(request_reuse, this, flags);\n \n \t_d()->reset();\n \n","prefixes":["libcamera-devel","4/4"]}