{"id":17960,"url":"https://patchwork.libcamera.org/api/patches/17960/?format=json","web_url":"https://patchwork.libcamera.org/patch/17960/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221209081937.598303-2-paul.elder@ideasonboard.com>","date":"2022-12-09T08:19:34","name":"[libcamera-devel,1/4] tracepoints: request: Add private pointer to request_construct","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d9fd2bab2e5073827847a5e20eefc1f65d0f9055","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17960/mbox/","series":[{"id":3662,"url":"https://patchwork.libcamera.org/api/series/3662/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3662","date":"2022-12-09T08:19:33","name":"tracepoints: request: Improve request tracepoints","version":1,"mbox":"https://patchwork.libcamera.org/series/3662/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17960/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17960/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D89BBDE6B\n\tfor ;\n\tFri, 9 Dec 2022 08:20:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4765063351;\n\tFri, 9 Dec 2022 09:20:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA4626334A\n\tfor ;\n\tFri, 9 Dec 2022 09:19:57 +0100 (CET)","from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DD7C480;\n\tFri, 9 Dec 2022 09:19:56 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670574001;\n\tbh=6WIFo5utB76imWZ9s+f10d/k/eBUWdAREDOOFKKbTdU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=xHCm77YpYTRbwF4Wt/TNrjYF+sNipnrv/lhBgN37HhZrZWbLVMGP6JT4pGepksiTa\n\teSUGdkU6In73NiXgo/A4wABqQXrd3KPhDkoBTubOagKq75k67JSv+zB9J5urde88Ta\n\t0JClHluTWajZqv7V8blpuYY8FIFk82WZnm/inI5JF7dOpuFHiUKh7c2LCcNTRxHVaQ\n\tXp/Y8ZR/KWgNYH7Wsd2t0DXUEXydZzvOmbC338bVCjJ6SOOjBcjthwBXlxEz60uSDH\n\tKVkNXCiaVorftxPRMUaC4gc2lD08tHznycVKOHL1PdUxE11XVOQwdBR5TErn1yL5gT\n\t7GM1aVmN80Irg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670573997;\n\tbh=6WIFo5utB76imWZ9s+f10d/k/eBUWdAREDOOFKKbTdU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QvwC99zwFREZelk/bMZHD6NCG+aOhNH6NgyDyZJk4xM/TfB8tQQNDen20wJbDr8JF\n\tqJjMJyCZRB5BnqUcCpnKyjAMNnKomsRPtVILyOoTcyIWDzo0XGMI9czR2l6zXnDKYp\n\tLHBw4uyEeRHIVqPwlsKgJZqpCrxvzg4CTheOFyrM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QvwC99zw\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 9 Dec 2022 17:19:34 +0900","Message-Id":"<20221209081937.598303-2-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20221209081937.598303-1-paul.elder@ideasonboard.com>","References":"<20221209081937.598303-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/4] tracepoints: request: Add private\n\tpointer to request_construct","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"Paul Elder ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Since some Request tracepoints print the public pointer and some print\nthe private pointer, print both pointers in the constructor tracepoint\nso that they can be used to associate with the other request\ntracepoints.\n\nSigned-off-by: Paul Elder \n---\n include/libcamera/internal/tracepoints/request.tp | 13 ++++++++++---\n src/libcamera/request.cpp | 2 +-\n 2 files changed, 11 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp\nindex f1e54497..491c7705 100644\n--- a/include/libcamera/internal/tracepoints/request.tp\n+++ b/include/libcamera/internal/tracepoints/request.tp\n@@ -8,6 +8,7 @@\n #include \n \n #include \n+#include \n \n TRACEPOINT_EVENT_CLASS(\n \tlibcamera,\n@@ -22,12 +23,18 @@ TRACEPOINT_EVENT_CLASS(\n \t)\n )\n \n-TRACEPOINT_EVENT_INSTANCE(\n+TRACEPOINT_EVENT(\n \tlibcamera,\n-\trequest,\n \trequest_construct,\n \tTP_ARGS(\n-\t\tlibcamera::Request *, req\n+\t\tlibcamera::Request *, req,\n+\t\tlibcamera::Request::Private *, priv\n+\t),\n+\tTP_FIELDS(\n+\t\tctf_integer_hex(uintptr_t, request, reinterpret_cast(req))\n+\t\tctf_integer_hex(uintptr_t, priv, reinterpret_cast(priv))\n+\t\tctf_integer(uint64_t, cookie, req->cookie())\n+\t\tctf_enum(libcamera, request_status, uint32_t, status, req->status())\n \t)\n )\n \ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 949c556f..b9fb17d6 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -356,7 +356,7 @@ Request::Request(Camera *camera, uint64_t cookie)\n \t */\n \tmetadata_ = new ControlList(controls::controls);\n \n-\tLIBCAMERA_TRACEPOINT(request_construct, this);\n+\tLIBCAMERA_TRACEPOINT(request_construct, this, _d());\n \n \tLOG(Request, Debug) << \"Created request - cookie: \" << cookie_;\n }\n","prefixes":["libcamera-devel","1/4"]}