[{"id":26007,"web_url":"https://patchwork.libcamera.org/comment/26007/","msgid":"<167025961197.3691396.5793201875926055715@Monstersaurus>","date":"2022-12-05T17:00:11","subject":"Re: [libcamera-devel] [PATCH] android: Fix missing space in error\n\tmessage","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi via libcamera-devel (2022-12-05 16:51:17)\n> Add whitespace to correct the error message.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/android/camera_hal_manager.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> index b229e2d5067c..a86e23d443d3 100644\n> --- a/src/android/camera_hal_manager.cpp\n> +++ b/src/android/camera_hal_manager.cpp\n> @@ -141,7 +141,7 @@ void CameraHalManager::cameraAdded(std::shared_ptr cam)\n> if (!isCameraExternal && !halConfig_.exists()) {\n> LOG(HAL, Error)\n> << \"HAL configuration file is mandatory for internal cameras.\"\n> - << \" Camera \" << cam->id() << \"failed to load\";\n> + << \" Camera \" << cam->id() << \" failed to load\";\n> return;\n> }\n> \n> -- \n> 2.38.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7019EBE08B\n\tfor ;\n\tMon, 5 Dec 2022 17:00:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D55976333F;\n\tMon, 5 Dec 2022 18:00:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3DCD61F22\n\tfor ;\n\tMon, 5 Dec 2022 18:00:15 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 44F88589;\n\tMon, 5 Dec 2022 18:00:15 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670259616;\n\tbh=o18O5VBCwUyoadVcX4YmZC9ezGeNjZkhs5wt6JO0W9A=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=jOBkLwahf6KaARK/vtrpHhHJ3yvEWm5XPobpU+FEoQ54pwYlDewZ0IUGlkbBMwTzM\n\txcUuz9YZQQugIcwqm3E7+6DkYL433Koad/sgvbfA5QcSZ6mTMru5pp+spKr4/bEKqL\n\t2PJ7+U5nN/4/NFmaj2rSW+CSt3EHd/wJpfiMu8UDpmTQ3EVOeX9fSCOYNJ5oVad41y\n\toss6ZNvetS8gPtP0yU/JqZw000w34aROn1siRrSKMLsuZ99gbAH+/lxzbsZ46D541T\n\tQPBH2NlwcnbWMsLMnzPeWvEtwR5FyF1+NDF9ladhmuOTuUGPv9pAX0834tXEq4r0Ig\n\tErbhLE3q3z9eQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670259615;\n\tbh=o18O5VBCwUyoadVcX4YmZC9ezGeNjZkhs5wt6JO0W9A=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=LE8GEtUhzH3J5EOgKQKRUlXmgJhBf58UVEoe7ylESvFJ3V6p/vKSHyaOeN/10HBDB\n\tDCZ8TH3dDLEXlWEiWnMq8ynAckikECkxDwO59Ii70YvR47IXmX9K+6tpA3IXz1DcD6\n\tpSJDOY4onxaR4aoJmD2je4zUEf+oSjOk4ZEIbNSY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"LE8GEtUh\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221205165117.30277-1-jacopo@jmondi.org>","References":"<20221205165117.30277-1-jacopo@jmondi.org>","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","Date":"Mon, 05 Dec 2022 17:00:11 +0000","Message-ID":"<167025961197.3691396.5793201875926055715@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] android: Fix missing space in error\n\tmessage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26008,"web_url":"https://patchwork.libcamera.org/comment/26008/","msgid":"<1802e70a-24bd-d5ca-0812-53fbe01e5d0d@ideasonboard.com>","date":"2022-12-06T04:10:27","subject":"Re: [libcamera-devel] [PATCH] android: Fix missing space in error\n\tmessage","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 12/6/22 12:51 AM, Jacopo Mondi via libcamera-devel wrote:\n> Add whitespace to correct the error message.\n>\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Umang Jain \n\n> ---\n> src/android/camera_hal_manager.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> index b229e2d5067c..a86e23d443d3 100644\n> --- a/src/android/camera_hal_manager.cpp\n> +++ b/src/android/camera_hal_manager.cpp\n> @@ -141,7 +141,7 @@ void CameraHalManager::cameraAdded(std::shared_ptr cam)\n> \tif (!isCameraExternal && !halConfig_.exists()) {\n> \t\tLOG(HAL, Error)\n> \t\t\t<< \"HAL configuration file is mandatory for internal cameras.\"\n> -\t\t\t<< \" Camera \" << cam->id() << \"failed to load\";\n> +\t\t\t<< \" Camera \" << cam->id() << \" failed to load\";\n> \t\treturn;\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24A3DBDE6B\n\tfor ;\n\tTue, 6 Dec 2022 04:11:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 604F06333F;\n\tTue, 6 Dec 2022 05:11:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD29061F1D\n\tfor ;\n\tTue, 6 Dec 2022 05:11:28 +0100 (CET)","from [192.168.100.186] (unknown [210.186.188.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AE4DC480;\n\tTue, 6 Dec 2022 05:11:27 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670299890;\n\tbh=/6rrqDEPEsmv3dCgWTfqwVSLSIVpy1VLe0eXToj5LCU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=upYTs1Dth4XxhQvnHr+p3aoPOsWGff1/icQJ5+c+xzr/ICbROqV7t9PeEv8PdmW/m\n\tXmaul/W1XetECVZNOwbj6oUDm5gPqch1YVH8msSdOD4p4OIZu1T4d82EcQGSXbQxTM\n\tbFfO2XXKwyX/jhzfUpAkXMIDlv07ysFRmMJRLTqiGSabj1Lwtblg5UPXTxqcaBrj53\n\tZofIhHFuZUiwvnKW34zQZ4YUn1bl8/fRsC+pnvBX14n4KP+FtMjCb1SugXGEt7Wl+E\n\t7dEbmCfiKQHmd467iNDTOwxMGlUJKEQ0cC1nuvhkQ9c6MRRZ48tfcolDK5EQec6GID\n\tP4J1NOZnujTCw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670299888;\n\tbh=/6rrqDEPEsmv3dCgWTfqwVSLSIVpy1VLe0eXToj5LCU=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=uzG0FJqHGg44VUxojcy5nkmGvjIGcwZtb7iDwQ+Slg6I8qNOKFh0pT/EGjDyl3fRc\n\tNsdpjMLVdLFXfcfOod0FOSSfxlWQZMmF6gvQw3Xr7Y/gA/xPyNIgCxUCSZ/CAxHSpz\n\tfqkvx2VZZaWIamluRkZD/HbSY5xmuX8gxCaK9Khg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uzG0FJqH\"; dkim-atps=neutral","Message-ID":"<1802e70a-24bd-d5ca-0812-53fbe01e5d0d@ideasonboard.com>","Date":"Tue, 6 Dec 2022 12:10:27 +0800","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.5.0","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20221205165117.30277-1-jacopo@jmondi.org>","Content-Language":"en-US","In-Reply-To":"<20221205165117.30277-1-jacopo@jmondi.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] android: Fix missing space in error\n\tmessage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]