[{"id":26012,"web_url":"https://patchwork.libcamera.org/comment/26012/","msgid":"","date":"2022-12-07T03:27:24","subject":"Re: [libcamera-devel] [PATCH v7 3/6] Add meson.build in\n\tsrc/android/jpeg","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Harvey,\n\nThank you for the patch.\n\nOn Thu, Dec 01, 2022 at 09:27:30AM +0000, Harvey Yang via libcamera-devel wrote:\n> From: Harvey Yang \n> \n> To further control sources in jpeg to build based on the platform, this\n> patch adds meson.build in src/android/jpeg directory.\n> \n> Signed-off-by: Harvey Yang \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/jpeg/meson.build | 8 ++++++++\n> src/android/meson.build | 5 +----\n> 2 files changed, 9 insertions(+), 4 deletions(-)\n> create mode 100644 src/android/jpeg/meson.build\n> \n> diff --git a/src/android/jpeg/meson.build b/src/android/jpeg/meson.build\n> new file mode 100644\n> index 00000000..08397a87\n> --- /dev/null\n> +++ b/src/android/jpeg/meson.build\n> @@ -0,0 +1,8 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +\n> +android_hal_sources += files([\n> + 'encoder_libjpeg.cpp',\n> + 'exif.cpp',\n> + 'post_processor_jpeg.cpp',\n> + 'thumbnailer.cpp'\n> +])\n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index c2773f9e..b24e2e52 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -47,16 +47,13 @@ android_hal_sources = files([\n> 'camera_ops.cpp',\n> 'camera_request.cpp',\n> 'camera_stream.cpp',\n> - 'jpeg/encoder_libjpeg.cpp',\n> - 'jpeg/exif.cpp',\n> - 'jpeg/post_processor_jpeg.cpp',\n> - 'jpeg/thumbnailer.cpp',\n> 'yuv/post_processor_yuv.cpp'\n> ])\n> \n> android_cpp_args = []\n> \n> subdir('cros')\n> +subdir('jpeg')\n> subdir('mm')\n> \n> android_camera_metadata_sources = files([","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 015AABDE6B\n\tfor ;\n\tWed, 7 Dec 2022 03:27:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C46A36333F;\n\tWed, 7 Dec 2022 04:27:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E040061F22\n\tfor ;\n\tWed, 7 Dec 2022 04:27:26 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6844F3D7;\n\tWed, 7 Dec 2022 04:27:26 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670383647;\n\tbh=fsFzbIzkS1/A4YXyqc38pBrZE8MevOuFUhON27dqYhU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ghYE0zwXk9kgHMrkEVgxNjDv0nKhIFNpO3h7FCrffspEMDEJRi4HCeE4xhC5SfztX\n\tctElIBBF1NLjKOq3WCJ1Ddhc1HrTm6t7LuPzKJtx5kVsAX6UxB4QqsIcy4sRethXzI\n\tQ+cKQePOYsOZGww6ABaCTZhgbo0ldUkqxQaaB5U4gMNeddQ8URe+fArcaeD/IgNDzk\n\tBJGwyxt+6rZr4/vDbNoYjbGslMSqZXVqkkANRL+c/J+ISYMeno1z2OvCIzNTvOc/6i\n\tjBWOnRIPuftCvecxH/cq1m/GB/O5NH3V8xr6ERs2HTB+miGVTR4+xlFBTwYXzLKLnO\n\tzTBTIpc9TGzig==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670383646;\n\tbh=fsFzbIzkS1/A4YXyqc38pBrZE8MevOuFUhON27dqYhU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=l05qQdXhB6QynqiyxKtnCvtrPyyhzak5+wAg+VIiHY621yDbQ01IuJRFuiz8MPV3n\n\tbl3YWX98b08vrutBNeM8u6R6EzIJWUhDDkHIbdxOZMh8V3bH/qWLKhe1ROW7586X2+\n\t7xOM+isrTh0N1ePFwpk+VoWyjRS25PnGlqyFMTFw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"l05qQdXh\"; dkim-atps=neutral","Date":"Wed, 7 Dec 2022 05:27:24 +0200","To":"Harvey Yang ","Message-ID":"","References":"<20221201092733.2042078-1-chenghaoyang@google.com>\n\t<20221201092733.2042078-4-chenghaoyang@google.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221201092733.2042078-4-chenghaoyang@google.com>","Subject":"Re: [libcamera-devel] [PATCH v7 3/6] Add meson.build in\n\tsrc/android/jpeg","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]