[{"id":25912,"web_url":"https://patchwork.libcamera.org/comment/25912/","msgid":"<166939248869.1079859.2568346758919602988@Monstersaurus>","date":"2022-11-25T16:08:08","subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Add additional default\n\tvalues to controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Robert Mader via libcamera-devel (2022-11-25 15:48:43)\n> To make things easier for consumers.\n> \n> Related: https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1450\n> \n\nI think these controls should be managed by the algorithms themselves\n... but that's not for this patch, and I think this is reasonable.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Robert Mader \n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 52dffc09..6544c925 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -101,9 +101,9 @@ const ControlInfoMap::Map rkisp1Controls{\n> { &controls::AeEnable, ControlInfo(false, true) },\n> { &controls::AwbEnable, ControlInfo(false, true) },\n> { &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },\n> - { &controls::Brightness, ControlInfo(-1.0f, 0.993f) },\n> - { &controls::Contrast, ControlInfo(0.0f, 1.993f) },\n> - { &controls::Saturation, ControlInfo(0.0f, 1.993f) },\n> + { &controls::Brightness, ControlInfo(-1.0f, 0.993f, 0.0f) },\n> + { &controls::Contrast, ControlInfo(0.0f, 1.993f, 1.0f) },\n> + { &controls::Saturation, ControlInfo(0.0f, 1.993f, 1.0f) },\n> { &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n> { &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n> };\n> -- \n> 2.38.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54C93BE08B\n\tfor ;\n\tFri, 25 Nov 2022 16:08:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7AFB63326;\n\tFri, 25 Nov 2022 17:08:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA2A6632EA\n\tfor ;\n\tFri, 25 Nov 2022 17:08:10 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4EBFB496;\n\tFri, 25 Nov 2022 17:08:10 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669392491;\n\tbh=hdLNvbfHtMOTozBA89pu4grIVSJQGBOrDAU89YECWFk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=X7KhnUm16AzJnert8LVYMCo5vh2IfEmvyhQY5MTA9IZ0G0N/YA8hCQStFoQhv1TDk\n\tZ5dCPTYf8JaVmXyku3/PfE+AKCSD30IiLhq2N0lf0wHynTnr8TMIBivN5FMt6s/Pk3\n\tEfx2qaiglkdAygT1ucSabEJ3fvPOBH2PWLVvuaHOUSiAL/z+1OjWJnyxRGgtF4Ud9k\n\tFK6cTLC77Np7fS0MDtHPGBB9tzF03treNEUAVHuXsp1+PXag472cHX4GUL656rJWCC\n\tx7MCz0aVk0uiovnRzlgmmp+6yQJ6VhuTQOKFwE9QBQdHfJ/X+eHL8rlAsrhORilj4s\n\tOrh8/UVOuP6Mg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1669392490;\n\tbh=hdLNvbfHtMOTozBA89pu4grIVSJQGBOrDAU89YECWFk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=EuFISuRprNfS/hhV2TKh5H1LfR0CIJhuW6cYvX/NTB++sbbYPV2Wybjg1xzuvdKr2\n\tsFHIySFMglyfihMr87RZqKd7p7BRCmBoYuVntB4VheUbBbyrd4yKfnST8O5UGigQrA\n\ti82R5v0yyhEpxW/h2A1fgkhy6/xtLqoBNo0EifOk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EuFISuRp\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221125154843.23486-1-robert.mader@collabora.com>","References":"<20221125154843.23486-1-robert.mader@collabora.com>","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 25 Nov 2022 16:08:08 +0000","Message-ID":"<166939248869.1079859.2568346758919602988@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Add additional default\n\tvalues to controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Robert Mader ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26030,"web_url":"https://patchwork.libcamera.org/comment/26030/","msgid":"<20221208171826.hzg25wt4wcfqrtj4@uno.localdomain>","date":"2022-12-08T17:18:26","subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Add additional default\n\tvalues to controls","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello,\n\nOn Fri, Nov 25, 2022 at 04:08:08PM +0000, Kieran Bingham via libcamera-devel wrote:\n> Quoting Robert Mader via libcamera-devel (2022-11-25 15:48:43)\n> > To make things easier for consumers.\n> >\n> > Related: https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1450\n> >\n>\n> I think these controls should be managed by the algorithms themselves\n> ... but that's not for this patch, and I think this is reasonable.\n>\n\nLikewise\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> Reviewed-by: Kieran Bingham \n>\n> > Signed-off-by: Robert Mader \n> > ---\n> > src/ipa/rkisp1/rkisp1.cpp | 6 +++---\n> > 1 file changed, 3 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > index 52dffc09..6544c925 100644\n> > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > @@ -101,9 +101,9 @@ const ControlInfoMap::Map rkisp1Controls{\n> > { &controls::AeEnable, ControlInfo(false, true) },\n> > { &controls::AwbEnable, ControlInfo(false, true) },\n> > { &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },\n> > - { &controls::Brightness, ControlInfo(-1.0f, 0.993f) },\n> > - { &controls::Contrast, ControlInfo(0.0f, 1.993f) },\n> > - { &controls::Saturation, ControlInfo(0.0f, 1.993f) },\n> > + { &controls::Brightness, ControlInfo(-1.0f, 0.993f, 0.0f) },\n> > + { &controls::Contrast, ControlInfo(0.0f, 1.993f, 1.0f) },\n> > + { &controls::Saturation, ControlInfo(0.0f, 1.993f, 1.0f) },\n> > { &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n> > { &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n> > };\n> > --\n> > 2.38.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 931BEBDE6B\n\tfor ;\n\tThu, 8 Dec 2022 17:18:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C461763351;\n\tThu, 8 Dec 2022 18:18:30 +0100 (CET)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::224])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D6686333B\n\tfor ;\n\tThu, 8 Dec 2022 18:18:29 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 50F5FE000E;\n\tThu, 8 Dec 2022 17:18:28 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670519910;\n\tbh=yM0GxBx/EYWU+Y/T+cPr7+NHoWfurdklcXBAncY4L8I=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=K9hsP9ExHR1rcQ/BuWkoGfZODM68fIgSpJDPEvNEM4o46HMGxo0EP9pBsxhN+03z8\n\tEP2jNtEWMdpN8q5rDLnNbqKtJCnb/kR6OHVNGxXOkuiUjPusPSSPioUcyIUxLeLWPr\n\tqYoA5D7WsPPBuAtLumfkbA6aUshKtRy1rqMNjz5Xn3kvh0XuvFbr772GZiBvEX9F2n\n\tI1MbPIJSWccy6ScmHoAEOeM25E8RE1Oy8XMnGqLla9VjbWkrIfmSpvpGvImNTXXnYU\n\tDYORhAHDm6V/kXyMp0Qw1yLhqYPd6G0htjxpNMIPFI0qUHO02qCUtPE8B1iv1HEDIY\n\tTrmCr9cs0hPAw==","Date":"Thu, 8 Dec 2022 18:18:26 +0100","To":"Kieran Bingham ","Message-ID":"<20221208171826.hzg25wt4wcfqrtj4@uno.localdomain>","References":"<20221125154843.23486-1-robert.mader@collabora.com>\n\t<166939248869.1079859.2568346758919602988@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166939248869.1079859.2568346758919602988@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Add additional default\n\tvalues to controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]