{"id":17899,"url":"https://patchwork.libcamera.org/api/patches/17899/?format=json","web_url":"https://patchwork.libcamera.org/patch/17899/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221125154843.23486-1-robert.mader@collabora.com>","date":"2022-11-25T15:48:43","name":"[libcamera-devel] ipa: rkisp1: Add additional default values to controls","commit_ref":"d5fc282eff47446475aa730d05513684de2840e4","pull_url":null,"state":"accepted","archived":false,"hash":"6817d8c3e55c17ddcdb2264fe3ebf92902376dfd","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/?format=json","name":"Robert Mader","email":"robert.mader@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17899/mbox/","series":[{"id":3642,"url":"https://patchwork.libcamera.org/api/series/3642/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3642","date":"2022-11-25T15:48:43","name":"[libcamera-devel] ipa: rkisp1: Add additional default values to controls","version":1,"mbox":"https://patchwork.libcamera.org/series/3642/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17899/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17899/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4A56BDE6B\n\tfor ;\n\tFri, 25 Nov 2022 15:53:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1D5163326;\n\tFri, 25 Nov 2022 16:53:41 +0100 (CET)","from madras.collabora.co.uk (madras.collabora.co.uk\n\t[46.235.227.172])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6EC80632EA\n\tfor ;\n\tFri, 25 Nov 2022 16:49:51 +0100 (CET)","from thinkpad-t460p.lan (unknown [185.176.222.145])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256)\n\t(No client certificate requested) (Authenticated sender: rmader)\n\tby madras.collabora.co.uk (Postfix) with ESMTPSA id C6B7F6602B5C;\n\tFri, 25 Nov 2022 15:49:50 +0000 (GMT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669391622;\n\tbh=b9sSCSRCUzCV/Ec8E7iT2aWT4ZqTASG+3aEQT3CAAxI=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=FJztUREfD7Ivl1mqvRK/XzqCZmVrIX7T3odnPYO+nlQITdaU/DDKHwKBXi94RipLw\n\tq+OW9+2l7XMVGregA1VxEVIU28L4GHeRlsXIlIRjOLMPKV7bY/ZTe9I3iz8dQZjc07\n\tSKLLCRlH8KXMZ+psiyYsnuUAT9+7nl0JYIiO3IORTICw6CRDne5iSxQDHS3Rh3q111\n\tA0jrs23yu3jBDWKAElhgw/A2oOhm7ix6YFxORRVo8AM+qp8zeT+Z4LQA7X6aL04Lzk\n\tZbDVv29GE71b4HJzOIXD8YonbftagGLswIjYeTzWxjKIZgxSUYm8y1UXJyLoxtjInx\n\tnMw3S7lSzS+yA==","v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1669391391;\n\tbh=b9sSCSRCUzCV/Ec8E7iT2aWT4ZqTASG+3aEQT3CAAxI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=JHpQLW0XbkqD/SBk/6M3S7eHjdDuqbqJYcM8Va+jXhC6/IEnQUmG+JL/InKbstyBt\n\t+bqq5UD6Ge82jtzUwxrDgn1g9NYlB5Fkhgq3jbSZGVj37HwoHi1QHnrFf4voOtoeOy\n\tQhOlhXnW0WedOwz3sYPEmLL9GQ4maQ25oHqshVm6hnoTp85f668OBbFq8BpKuvKSaa\n\t4mtsl1PwBPpvktu/AtS2tRtbC151foe+FrBMf1R8DCD+xAjm0SfzAYnpHpZdcDpxOc\n\tYkB4RnBwUDBQ5h1WmC/TD7J1EqqieRowon7L+udKNLNaMFNc2tg0y20Y0u257E30ZT\n\t8eIhLsyd/GVkQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=collabora.com\n\theader.i=@collabora.com\n\theader.b=\"JHpQLW0X\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 25 Nov 2022 16:48:43 +0100","Message-Id":"<20221125154843.23486-1-robert.mader@collabora.com>","X-Mailer":"git-send-email 2.38.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Approved-At":"Fri, 25 Nov 2022 16:53:40 +0100","Subject":"[libcamera-devel] [PATCH] ipa: rkisp1: Add additional default\n\tvalues to controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Robert Mader via libcamera-devel ","Reply-To":"Robert Mader ","Cc":"Robert Mader ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"To make things easier for consumers.\n\nRelated: https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1450\n\nSigned-off-by: Robert Mader \n---\n src/ipa/rkisp1/rkisp1.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 52dffc09..6544c925 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -101,9 +101,9 @@ const ControlInfoMap::Map rkisp1Controls{\n \t{ &controls::AeEnable, ControlInfo(false, true) },\n \t{ &controls::AwbEnable, ControlInfo(false, true) },\n \t{ &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },\n-\t{ &controls::Brightness, ControlInfo(-1.0f, 0.993f) },\n-\t{ &controls::Contrast, ControlInfo(0.0f, 1.993f) },\n-\t{ &controls::Saturation, ControlInfo(0.0f, 1.993f) },\n+\t{ &controls::Brightness, ControlInfo(-1.0f, 0.993f, 0.0f) },\n+\t{ &controls::Contrast, ControlInfo(0.0f, 1.993f, 1.0f) },\n+\t{ &controls::Saturation, ControlInfo(0.0f, 1.993f, 1.0f) },\n \t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n };\n","prefixes":["libcamera-devel"]}