{"id":17895,"url":"https://patchwork.libcamera.org/api/patches/17895/?format=json","web_url":"https://patchwork.libcamera.org/patch/17895/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221124121220.47000-10-jacopo@jmondi.org>","date":"2022-11-24T12:12:20","name":"[libcamera-devel,9/9] documentation: sensor_drivers: Document H/V flip","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f4a394514680ef8340644812df20b0e552b2fcab","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17895/mbox/","series":[{"id":3638,"url":"https://patchwork.libcamera.org/api/series/3638/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3638","date":"2022-11-24T12:12:11","name":"libcamera: camera_sensor: Centralize flips handling","version":1,"mbox":"https://patchwork.libcamera.org/series/3638/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17895/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17895/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49E03BDE6B\n\tfor ;\n\tThu, 24 Nov 2022 12:12:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08CED6331E;\n\tThu, 24 Nov 2022 13:12:39 +0100 (CET)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B306D6331A\n\tfor ;\n\tThu, 24 Nov 2022 13:12:35 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id DECDC40002;\n\tThu, 24 Nov 2022 12:12:34 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669291959;\n\tbh=1Y9XURxrGeqSini5H73FcuTfYF7+giYbLY/41RfhXVs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=0WDXC+s+md/+5rzgDMmvuy2n0UvpHsg0kNCr3ubYEwoAziAE9FQnQJKmD/LjTa8Hg\n\tLOUPb/hQ3iQKFLqxlnhnHldoFnFBJoBRjBlEkBYDRDARo8R5QaLD1I1rRouUl/KCR4\n\tJitfGgIxwxpi11mMIVaNbmG7e72OY313HzzNFUpJXJ6hlNaOrHFUjP0NGeLzLk0WSQ\n\tDYHww7plVxTUYxDsL8xsG4OoFgNiNbQSNZRC9InUrVfMcpp0L9h0c86e97SckLxl7q\n\t87GsnDHK0GU9aOKycACBRJKgUx251E+P78bKnkU5WtXMEFPbBXDBnlmXh9nnEcTOxt\n\tLm3/NbV9IT9fQ==","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 24 Nov 2022 13:12:20 +0100","Message-Id":"<20221124121220.47000-10-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.38.1","In-Reply-To":"<20221124121220.47000-1-jacopo@jmondi.org>","References":"<20221124121220.47000-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 9/9] documentation: sensor_drivers:\n\tDocument H/V flip","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Briefly document the optional requirement support for H/V flip controls.\n\nSigned-off-by: Jacopo Mondi \n---\n Documentation/sensor_driver_requirements.rst | 13 +++++++++++++\n 1 file changed, 13 insertions(+)","diff":"diff --git a/Documentation/sensor_driver_requirements.rst b/Documentation/sensor_driver_requirements.rst\nindex b0854be3328a..e9f998ca8d31 100644\n--- a/Documentation/sensor_driver_requirements.rst\n+++ b/Documentation/sensor_driver_requirements.rst\n@@ -55,6 +55,19 @@ The sensor driver should support the following V4L2 controls:\n \n The controls are used to register the camera location and rotation.\n \n+In order to support rotating the image according to the above registered\n+properties the sensor driver should support\n+\n+* `V4L2_CID_HFLIP`_\n+* `V4L2_CID_VFLIP`_\n+\n+.. _V4L2_CID_HFLIP: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/control.html\n+.. _V4L2_CID_VFLIP: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/control.html\n+\n+and have them writable from userspace. In case of a RAW Bayer sensors, drivers\n+should correctly report if vertical/horizontal flips modify the Bayer pattern\n+ordering by reporting the `V4L2_CTRL_FLAG_MODIFY_LAYOUT` control flag.\n+\n The sensor driver should implement support for the V4L2 Selection API,\n specifically it should implement support for the\n `VIDIOC_SUBDEV_G_SELECTION`_ ioctl with support for the following selection\n","prefixes":["libcamera-devel","9/9"]}