[{"id":29427,"web_url":"https://patchwork.libcamera.org/comment/29427/","msgid":"<56e3e853-edf9-4e68-a1b0-4eb3ab84274c@ideasonboard.com>","date":"2024-05-04T21:24:53","subject":"Re: [libcamera-devel] [PATCH 6/6] utils: libtuning: Get debug\n\tparameters from cli arguments","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Paul\n\nOn 24/11/2022 11:38, Paul Elder wrote:\n> Get the debug parameters for enabling per-module debug from command line\n> arguments.\n>\n> Signed-off-by: Paul Elder \n> ---\n> utils/tuning/libtuning/libtuning.py | 40 ++++++++++++++++++++++++++---\n> 1 file changed, 36 insertions(+), 4 deletions(-)\n>\n> diff --git a/utils/tuning/libtuning/libtuning.py b/utils/tuning/libtuning/libtuning.py\n> index 469e6940..6d616ddb 100644\n> --- a/utils/tuning/libtuning/libtuning.py\n> +++ b/utils/tuning/libtuning/libtuning.py\n> @@ -5,6 +5,7 @@\n> # libtuning.py - An infrastructure for camera tuning tools\n> \n> import argparse\n> +from pathlib import Path\n> \n> import libtuning as lt\n> import libtuning.utils as utils\n> @@ -20,10 +21,6 @@ class Color(IntEnum):\n> B = 3\n> \n> \n> -class Debug(Enum):\n> - Plot = 1\n> -\n> -\n> # @brief What to do with the leftover pixels after dividing them into ALSC\n> # sectors, when the division gradient is uniform\n> # @var Float Force floating point division so all sectors divide equally\n> @@ -157,6 +154,23 @@ class Tuner(object):\n> # we want a better logging infrastructure with log levels\n> parser.add_argument('-l', '--log', type=str, default=None,\n> help='Output log file (optional)')\n> + parser.add_argument('-dd', '--debug_dir', type=str, default=None,\n> + help='''Debug output directory (optional).\n> + If the directory does not exist, it will be\n> + created (including parent directories). If\n> + the directory already exists, any existing\n> + contents will be overwritten.''')\n\nI don't think this will create parent directories at present, as when you call debug_dir.mkdir() the \ndefault behaviour [1] is not to create parent directories.\n\n\n[1] https://docs.python.org/3/library/pathlib.html#pathlib.Path.mkdir\n\n> + module_list = [module.type for module in self.modules]\n> + module_list.append('macbeth')\n\n\nIs this still relevant?\n\n> + module_list.sort()\n> + parser.add_argument('-do', '--debug_opt', type=str, default='',\n> + help=f'''Debug option string (optional).\n> + Comma-separated (without spaces) list of module names\n> + for which debug output should be enabled. If this\n> + option is not provided but --debug_dir is, then all\n> + modules will have debug output enabled. This option\n> + will not do anything if --debug_dir is not specified.\n> + Available modules: {module_list}''')\n> return parser.parse_args(argv[1:])\n> \n> def run(self, argv):\n> @@ -181,11 +195,29 @@ class Tuner(object):\n> if module in self.modules:\n> self.modules.remove(module)\n> \n> + # Prepare debug\n> + module_debug_list = args.debug_opt.split(',')\n> + if '' in module_debug_list:\n> + module_debug_list.remove('')\n> +\n> + if args.debug_dir is not None:\n> + debug_dir = Path(args.debug_dir)\n> + if not debug_dir.is_dir():\n> + debug_dir.mkdir()\n> +\n> + # Validate modules and set debug\n> for module in self.modules:\n> if not module.validate_config(self.config):\n> eprint(f'Config is invalid for module {module.type}')\n> return -1\n> \n> + if args.debug_dir is not None and \\\n> + (len(module_debug_list) == 0 or module.type in module_debug_list):\n> + module_debug_dir = debug_dir / module.type\n> + if not module_debug_dir.is_dir():\n> + module_debug_dir.mkdir()\n> + module.enable_debug(module_debug_dir)\n> +\n> has_lsc = any(isinstance(m, lt.modules.lsc.LSC) for m in self.modules)\n> # Only one LSC module allowed\n> has_only_lsc = has_lsc and len(self.modules) == 1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 462BDC3220\n\tfor ;\n\tSat, 4 May 2024 21:24:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4462562E1C;\n\tSat, 4 May 2024 23:24:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D8CE604D4\n\tfor ;\n\tSat, 4 May 2024 23:24:56 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DC4B733D\n\tfor ;\n\tSat, 4 May 2024 23:23:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Xo7niiHX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714857836;\n\tbh=K0Wa0WkU2SFtBfI+052cuQGrCdImzTf4j+8pAeYoDgg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Xo7niiHXw6sS8M5FsWA+NyxoHlJGGQ+Z3ulBT2KbRU6rTvQjV+TMcg01tfbUqCAty\n\tV30UGLtrXdUxJ5dS9r0SfWwHHU+9cc69/b8L8DMLhDvzEmb0BtJC/f5uL3qfRBovCD\n\t7zdTCWNhrm/WrTcuzLDB8cGni+7tVOE/RKVpYkI4=","Message-ID":"<56e3e853-edf9-4e68-a1b0-4eb3ab84274c@ideasonboard.com>","Date":"Sat, 4 May 2024 22:24:53 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [libcamera-devel] [PATCH 6/6] utils: libtuning: Get debug\n\tparameters from cli arguments","To":"libcamera-devel@lists.libcamera.org","References":"<20221124113849.2193579-1-paul.elder@ideasonboard.com>\n\t<20221124113849.2193579-7-paul.elder@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20221124113849.2193579-7-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]