[{"id":29428,"web_url":"https://patchwork.libcamera.org/comment/29428/","msgid":"<1f0a1e63-4aaa-4889-9eb3-d55c8d4eda48@ideasonboard.com>","date":"2024-05-04T21:26:12","subject":"Re: [libcamera-devel] [PATCH 1/6] utils: libtuning: module: Prepare\n\tper-module debugging infrastructure","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Paul\n\nOn 24/11/2022 11:38, Paul Elder wrote:\n> Prepare for per-module debugging infrastructure in the base Module\n> class. The debug parameter will be provided from a command line argument\n> as opposed to from the tuning script as was originally planned.\n>\n> Remove the debug parameter from the LSC constructor (it is the only\n> module that we have so far). As the debug parameter currently does not\n> do anything, no regression is introduced.\n>\n> Update the tuning scripts accordingly.\n>\n> Signed-off-by: Paul Elder \n\n\nReviewed-by: Daniel Scally \n\n> ---\n> utils/tuning/libtuning/modules/lsc/lsc.py | 3 ---\n> utils/tuning/libtuning/modules/module.py | 6 ++++++\n> utils/tuning/raspberrypi/alsc.py | 1 -\n> utils/tuning/rkisp1.py | 1 -\n> 4 files changed, 6 insertions(+), 5 deletions(-)\n>\n> diff --git a/utils/tuning/libtuning/modules/lsc/lsc.py b/utils/tuning/libtuning/modules/lsc/lsc.py\n> index 344a07a3..f54ca8be 100644\n> --- a/utils/tuning/libtuning/modules/lsc/lsc.py\n> +++ b/utils/tuning/libtuning/modules/lsc/lsc.py\n> @@ -17,7 +17,6 @@ class LSC(Module):\n> out_name = 'GenericLSC'\n> \n> def __init__(self, *,\n> - debug: list,\n> sector_shape: tuple,\n> sector_x_gradient: lt.Gradient,\n> sector_y_gradient: lt.Gradient,\n> @@ -25,8 +24,6 @@ class LSC(Module):\n> smoothing_function: lt.Smoothing):\n> super().__init__()\n> \n> - self.debug = debug\n> -\n> self.sector_shape = sector_shape\n> self.sector_x_gradient = sector_x_gradient\n> self.sector_y_gradient = sector_y_gradient\n> diff --git a/utils/tuning/libtuning/modules/module.py b/utils/tuning/libtuning/modules/module.py\n> index 12e2fc7c..b4ad0625 100644\n> --- a/utils/tuning/libtuning/modules/module.py\n> +++ b/utils/tuning/libtuning/modules/module.py\n> @@ -4,6 +4,8 @@\n> #\n> # module.py - Base class for algorithm-specific tuning modules\n> \n> +from pathlib import Path\n> +\n> \n> # @var type Type of the module. Defined in the base module.\n> # @var out_name The key that will be used for the algorithm in the algorithms\n> @@ -15,8 +17,12 @@ class Module(object):\n> out_name = 'GenericAlgorithm'\n> \n> def __init__(self):\n> + self.debug = None\n> pass\n> \n> + def enable_debug(self, output_dir: Path):\n> + self.debug = output_dir\n> +\n> def validate_config(self, config: dict) -> bool:\n> raise NotImplementedError\n> \n> diff --git a/utils/tuning/raspberrypi/alsc.py b/utils/tuning/raspberrypi/alsc.py\n> index 024eb5a3..4dc5f5ba 100644\n> --- a/utils/tuning/raspberrypi/alsc.py\n> +++ b/utils/tuning/raspberrypi/alsc.py\n> @@ -10,7 +10,6 @@ from libtuning.modules.lsc import ALSCRaspberryPi\n> ALSC = \\\n> ALSCRaspberryPi(do_color=lt.Param('do_alsc_colour', lt.Param.Mode.Optional, True),\n> luminance_strength=lt.Param('luminance_strength', lt.Param.Mode.Optional, 0.5),\n> - debug=[lt.Debug.Plot],\n> sector_shape=(16, 12),\n> sector_x_gradient=lt.gradient.Linear(lt.Remainder.DistributeFront),\n> sector_y_gradient=lt.gradient.Linear(lt.Remainder.DistributeFront),\n> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> index 1cea6ddb..43b4b190 100755\n> --- a/utils/tuning/rkisp1.py\n> +++ b/utils/tuning/rkisp1.py\n> @@ -14,7 +14,6 @@ from libtuning.modules.lsc import LSCRkISP1\n> \n> tuner = lt.Tuner('RkISP1')\n> tuner.add(LSCRkISP1(\n> - debug=[lt.Debug.Plot],\n> # This is for the actual LSC tuning, and is part of the base LSC\n> # module. rkisp1's table sector sizes (16x16 programmed as mirrored\n> # 8x8) are separate, and is hardcoded in its specific LSC tuning","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 70182C3220\n\tfor ;\n\tSat, 4 May 2024 21:26:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D71E604D4;\n\tSat, 4 May 2024 23:26:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4986C604D4\n\tfor ;\n\tSat, 4 May 2024 23:26:15 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3716833D\n\tfor ;\n\tSat, 4 May 2024 23:25:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WtjzFF4S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714857916;\n\tbh=U5iFdOUJbJC/7Q/+15yjdDNphYLdw1CZ0D9oQlw6O8w=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=WtjzFF4SvYSMJZiZz6rcmzVz1mSE8UE4EMk8dGWSwufuwj/k3Y+9AS8DhvGjMI0Uo\n\tTFi5aqO4QxnBx/fMMJySWF+hyrCwwi670x378R9l66gJbRiGx1tUePOQhPmiYITvCA\n\tl6g5v7vCJFYZCAg5uvgiurdi46IMD+cdr6yvV5mE=","Message-ID":"<1f0a1e63-4aaa-4889-9eb3-d55c8d4eda48@ideasonboard.com>","Date":"Sat, 4 May 2024 22:26:12 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [libcamera-devel] [PATCH 1/6] utils: libtuning: module: Prepare\n\tper-module debugging infrastructure","To":"libcamera-devel@lists.libcamera.org","References":"<20221124113849.2193579-1-paul.elder@ideasonboard.com>\n\t<20221124113849.2193579-2-paul.elder@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20221124113849.2193579-2-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]