[{"id":25888,"web_url":"https://patchwork.libcamera.org/comment/25888/","msgid":"<20221124121907.2anq4c6m54tm64vf@uno.localdomain>","date":"2022-11-24T12:19:07","subject":"Re: [libcamera-devel] [PATCH v4 1/9] libcamera: stream: Add\n\toperator<<() to print StreamRole as a string","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Thu, Nov 24, 2022 at 04:51:25AM +0200, Laurent Pinchart via libcamera-devel wrote:\n> libcamera prints stream role values in log messages. To be more\n> user-friendly, add a specialization of operator<<() to print the role\n> name as a string instead of a numerical value.\n>\n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Paul Elder \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/stream.h | 3 +++\n> src/libcamera/stream.cpp | 19 +++++++++++++++++++\n> 2 files changed, 22 insertions(+)\n>\n> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> index f0ae7e62e0a3..efec695ad317 100644\n> --- a/include/libcamera/stream.h\n> +++ b/include/libcamera/stream.h\n> @@ -9,6 +9,7 @@\n>\n> #include \n> #include \n> +#include \n> #include \n> #include \n>\n> @@ -70,6 +71,8 @@ enum StreamRole {\n>\n> using StreamRoles = std::vector;\n>\n> +std::ostream &operator<<(std::ostream &out, StreamRole role);\n> +\n> class Stream\n> {\n> public:\n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index 686e693bccba..67f308157fbf 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -417,6 +417,25 @@ std::string StreamConfiguration::toString() const\n> * acceptable.\n> */\n>\n> +/**\n> + * \\brief Insert a text representation of a StreamRole into an output stream\n> + * \\param[in] out The output stream\n> + * \\param[in] role The StreamRole\n> + * \\return The output stream \\a out\n> + */\n> +std::ostream &operator<<(std::ostream &out, StreamRole role)\n> +{\n> +\tstatic constexpr std::array names{\n> +\t\t\"Raw\",\n> +\t\t\"StillCapture\",\n> +\t\t\"VideoRecording\",\n> +\t\t\"Viewfinder\",\n> +\t};\n> +\n> +\tout << names[static_cast>(role)];\n> +\treturn out;\n> +}\n> +\n> /**\n> * \\typedef StreamRoles\n> * \\brief A vector of StreamRole\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A709BE08B\n\tfor ;\n\tThu, 24 Nov 2022 12:19:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7B0F63313;\n\tThu, 24 Nov 2022 13:19:09 +0100 (CET)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::221])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 896E0632EA\n\tfor ;\n\tThu, 24 Nov 2022 13:19:08 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 1D7CF24000D;\n\tThu, 24 Nov 2022 12:19:07 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669292349;\n\tbh=k9t1tP0Y4867mHq4eXE4kLxox7BOS/c8DTH/I+ojG1g=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=m2phyWpKV8+O8Nlo9edIVTwjhj20xKI9Qm3If8uftYMSlTS9PfRgadPYxFUmjq4Da\n\tdYvRPC5x3v0fHyWgrwXifxi1xdx9G8p4AGk+lWrBO90v/5IhHi9YsJKfQJwZSEMC3A\n\tkey1H+i5TEX1LAj4cFADFIw3PHQZD1vVjEkyZ4XmFFGRA64MsZEpdcReGjb7qTtPuD\n\tDpiyH2iEbvjssTgtPT6U24kp0oqDiAzOC71/3QBgCnNpECBcz0HHYmMBepRu8LwN0n\n\t9X64Hd2uMnqw50ZcQB7PFPO3HRV9A8uKckwVsBy9I1jblzvgZ89XGT2V+CDGcYyVnU\n\thmcIbdR9Vucow==","Date":"Thu, 24 Nov 2022 13:19:07 +0100","To":"Laurent Pinchart ","Message-ID":"<20221124121907.2anq4c6m54tm64vf@uno.localdomain>","References":"<20221124025133.17875-1-laurent.pinchart@ideasonboard.com>\n\t<20221124025133.17875-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221124025133.17875-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 1/9] libcamera: stream: Add\n\toperator<<() to print StreamRole as a string","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]