{"id":17841,"url":"https://patchwork.libcamera.org/api/patches/17841/?format=json","web_url":"https://patchwork.libcamera.org/patch/17841/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221122120343.4825-4-david.plowman@raspberrypi.com>","date":"2022-11-22T12:03:43","name":"[libcamera-devel,3/3] libcamera: pipeline: ipu3: Reset sensor HBLANK control","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0bf9bc4ef0d9ae5821df4c127facf371c910b5e1","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17841/mbox/","series":[{"id":3629,"url":"https://patchwork.libcamera.org/api/series/3629/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3629","date":"2022-11-22T12:03:40","name":"Resolve invalid attempt to set sensor HBLANK control","version":1,"mbox":"https://patchwork.libcamera.org/series/3629/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17841/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17841/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5EEA5BE08B\n\tfor ;\n\tTue, 22 Nov 2022 12:03:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22D9863314;\n\tTue, 22 Nov 2022 13:03:55 +0100 (CET)","from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5834C6331E\n\tfor ;\n\tTue, 22 Nov 2022 13:03:52 +0100 (CET)","by mail-wm1-x334.google.com with SMTP id\n\tj5-20020a05600c410500b003cfa9c0ea76so11115146wmi.3\n\tfor ;\n\tTue, 22 Nov 2022 04:03:52 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tp18-20020adfe612000000b002366a624bd4sm12119141wrm.28.2022.11.22.04.03.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Nov 2022 04:03:50 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669118635;\n\tbh=6FM3QFEdtWOjmGPVWwF1R7Y9blkyrWCuUZsR9VgGB5M=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=VIZds3PzYlPib7mF3qe/6HsOZ0vSJZeNlqjET/UA1pudppLLia/kEG8y4m56uiqxi\n\ta/hWZWfE0M6QWOAfXlDFSFbFzCwJEQ2e6LBmhnQof4xrB57Q6jSZszrK04nzVNxfsa\n\tzJbd0B0EY5H16WrU0WVhuJksLfeR0l4LJPe4e4MpM9NgtGaaJwteoYkSanGsWXHLA5\n\t/wzm+dhOx4qOYWZjydXFCzViPCv5yYtYp0cgbO1vify6oQTSYK9ZrP+ORhCzmacdS7\n\t7rniCOpCBHFS83X/oncn0jILnHQYaCMYhbf6Y79ZiXn21cyIbTekaHsuptqpy/Xehw\n\tWc77gN2xjUDkQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=QM3FI8MTL2nC87hq0DBBUKu5+wbe6JmvxrskIriyLVE=;\n\tb=OyxY1OuM+GOfLUlnq5hHrl8+gJJQUvQby8lHcTHchEB1BYWY7T2A7FDy3m6Q/iUFOi\n\ttrqHTrQCSAWqw9PQLAgD3zJzYFizJQghI5Ss1FpnoSUkbS16mON//FIyw/1OriKgkxrv\n\tOuI0C3/A7l+hp90QLcBmbAfEFahHDiJZo2V/ulbIm5ASAQIfAruF+24T48d49FbaktQ9\n\tPcKoyVr1TZgwXjnqHEKZ3PmrJm6rCpZuHuKmJc+ytK7L3qxVSJ4zlhzez4UBy6YdQh02\n\tvpg25zo7/XTi83NKYk/VAX0kRvYF/Dp9f+5qisWYAFj6mSrLU97e5iRGEQ1WDCdkeF5v\n\tGyCQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"OyxY1OuM\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=QM3FI8MTL2nC87hq0DBBUKu5+wbe6JmvxrskIriyLVE=;\n\tb=c0jYJcR8/Unrnu9qbb5LpC7FEPdwzB/NOPQ3uGe4Ks4Dy9MoRkJBo8/VjEXk5zz6EM\n\tAsKuPSpgbZYXRXpsyqEy+sxej2HyjPo272/6om7O/D5yIqy09zv282Of9rN8pmCA57k/\n\tm25lI09D+Zky4RRlXin6ihP8ik30eQoblYemQdfEOtw3lQG3QberghWN1DQl+poDREXb\n\thhdWISBU8o/KFxO9/HoYp/aTS1+jMlWhkCNUjl9aizagBkD/cKSvvQ60lA3jPsSten7F\n\tPx7g43UKrM63CAC5LPvRz5UxSJUWzmm4gT/aCz82ULj1NrhBjj7GsdCPvpCY46oLJIHS\n\t2zgQ==","X-Gm-Message-State":"ANoB5pk1m82nQitlDcEA4I1zmVpjO7RhNrzUikiO6dANlHSqtLI46y2V\n\tYZsGTCzKOdFnTbxwjme2mZPOEFF2hUMWfg==","X-Google-Smtp-Source":"AA0mqf5BTv7xfbT8F4+jqJBncuMMVbWQFQdfng8h17cHkU3K5/HUuqlEyzdj35L9orZq/NtYiCk0QQ==","X-Received":"by 2002:a05:600c:1e89:b0:3cf:774b:ce6f with SMTP id\n\tbe9-20020a05600c1e8900b003cf774bce6fmr2999915wmb.133.1669118631385; \n\tTue, 22 Nov 2022 04:03:51 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 22 Nov 2022 12:03:43 +0000","Message-Id":"<20221122120343.4825-4-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20221122120343.4825-1-david.plowman@raspberrypi.com>","References":"<20221122120343.4825-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/3] libcamera: pipeline: ipu3: Reset\n\tsensor HBLANK control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Resetting the sensor's HBLANK to its minimum value is no longer\nperformed for us, so the pipeline handler must call the helper method\nto do it.\n\nSigned-off-by: David Plowman \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex e4d79ea4..47ec6bd0 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -566,6 +566,9 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \tif (ret)\n \t\treturn ret;\n \n+\t/* Reset the horizontal blanking to minimum in case it has changed. */\n+\tcio2->sensor()->resetHblank();\n+\n \t/*\n \t * Pass the requested stream size to the CIO2 unit and get back the\n \t * adjusted format to be propagated to the ImgU output devices.\n","prefixes":["libcamera-devel","3/3"]}