[{"id":25877,"web_url":"https://patchwork.libcamera.org/comment/25877/","msgid":"","date":"2022-11-23T13:40:43","subject":"Re: [libcamera-devel] [PATCH v1 2/5] ipa: raspberrypi: histogram:\n\tAdd a constructor for an empty histogram","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"HI Naush\n\nThanks for the patch.\n\nOn Tue, 22 Nov 2022 at 11:22, Naushir Patuck via libcamera-devel\n wrote:\n>\n> Add a default constructor to the RPiController::Histogram class that creates\n> an empty histogram. Since this is a cumulative histogram, push a value of 0 into\n> the first (and only) bin to signify this.\n>\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: David Plowman \n\nThanks!\nDavid\n\n> ---\n> src/ipa/raspberrypi/controller/histogram.h | 5 +++++\n> 1 file changed, 5 insertions(+)\n>\n> diff --git a/src/ipa/raspberrypi/controller/histogram.h b/src/ipa/raspberrypi/controller/histogram.h\n> index 66a68b087964..6b3e3a9e68e4 100644\n> --- a/src/ipa/raspberrypi/controller/histogram.h\n> +++ b/src/ipa/raspberrypi/controller/histogram.h\n> @@ -20,6 +20,11 @@ namespace RPiController {\n> class Histogram\n> {\n> public:\n> + Histogram()\n> + {\n> + cumulative_.push_back(0);\n> + }\n> +\n> template Histogram(T *histogram, int num)\n> {\n> assert(num);\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C87CBDE6B\n\tfor ;\n\tWed, 23 Nov 2022 13:40:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CAFF563313;\n\tWed, 23 Nov 2022 14:40:57 +0100 (CET)","from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com\n\t[IPv6:2607:f8b0:4864:20::62b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 232EF63311\n\tfor ;\n\tWed, 23 Nov 2022 14:40:56 +0100 (CET)","by mail-pl1-x62b.google.com with SMTP id j12so16655836plj.5\n\tfor ;\n\tWed, 23 Nov 2022 05:40:56 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669210857;\n\tbh=bhHK635L/uZY0zxqaLM0p+3NgHVdgepNrGF7oOBGMrk=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=C+BOQc0LnizKOhZwQhsoc+u76uJxpWzcGwMyCJrGIAgvMv0kedXgpndnTX+dQEYRp\n\tw73dj/YOXURcRp4gQMgXzRJg+sWB41HShgXCHGkkE0crL4AdvsFYLf/Na1UoicecR1\n\tC71LJx9HO6lAYtISRaI5kDf7qbIhzzthejkXgkPK15+MFW+dtDdb3JLr9kJYZ/b6S8\n\t0bgpSX8kjawP2k4D2+se1LzG/3/SvT5uux5zvKL+rTgzWcNk7bsaJg9vPn6TSonEWK\n\tjsYeqLX6S387jqJ/liE/oMJQ11Oc3LSApf0pziKkUU2HJLIFRoyMLTWX3k0Ln290gh\n\tjkOjFfvUPjJCQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=6GN2KeAfKUFHYlhV6v05cAfIYYbRVsq3t7HBPFYft3Y=;\n\tb=p9ci5ivmn2mONtcDBJEB7SLDR1pPKs4rwAO+B1B6cBEFNtz+Xcq/dM4Sa0uqBv2qIX\n\toug9Yorc5iAU8cvMJUZj7VGCfO/9jLhCirmUnlL7xgCwmJBeRB+dotGVsNp/g8CinXqs\n\tGky2varRIce9QS1wXBL6e1ZGx1L+LBJp6uAGF3FaNwabma9o3JKwr7HdoDOVhEMOA8pB\n\tJK0vqBzhHG7jAVtEgdQzwjstzrmhY4/wu8w8G4XJ3Fo76OdJ9jsy3B3xXkSe2rMxZngF\n\tmRn766FavwuWMFPi+xfBnZkDtNO+cCKeFVKIzUQsOJlu6RRCt1EItVW8lmisuFeX/jNq\n\tvdnw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"p9ci5ivm\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=6GN2KeAfKUFHYlhV6v05cAfIYYbRVsq3t7HBPFYft3Y=;\n\tb=Cb/uvm+yOVrM7+lKTIa+/MwcQX9EvgZ34oZACAeuCIQkTJHsYEkhMv8xrEPxT+xy4b\n\tZ48GBo3HQXgPdLR80URrwqe4c+uJiA61xnYTULZFBz8GBuXuxv2/g8342DAsmh0GTfKv\n\tlnpoWfNxoGkT+OrzPUdbdSxc6UnkREJXIswRhZO/tEO8T7LaNXV2Le6KSWdAd3lN4esM\n\tDz3Wa6PR1ra5hHlWhY8cazAuHcaKNXSEdeEzKdh376esDK5fhA1zQjDHTCPQTVrb+7Pu\n\tY3Jf+/4PQDwJk31gHNRDx/dskGW/oqceRCx9YqXIs/8z7ShVOwTGB78I1O9y6MZ9uAzQ\n\tXumw==","X-Gm-Message-State":"ANoB5pl0bZOM8HKo/T4xDx8TKDWpfdbTybexc/FRmTcmRQ5ZB1IMsQOH\n\takEOgjccdyiqxQAzROERPcWb9fV0E+yOR7TkmsnTN1Rv6ms=","X-Google-Smtp-Source":"AA0mqf4E1DjrJ9Lb6EFOoz6+pZo9vK7m1Llp7cjrAGyGpybjZFy4yGdhdoEdzRCYQ57Q+rwX9c+5RMOu3F73WS27EuE=","X-Received":"by 2002:a17:90a:5d0e:b0:202:c5cc:15bd with SMTP id\n\ts14-20020a17090a5d0e00b00202c5cc15bdmr36606390pji.235.1669210854400;\n\tWed, 23 Nov 2022 05:40:54 -0800 (PST)","MIME-Version":"1.0","References":"<20221122112224.31691-1-naush@raspberrypi.com>\n\t<20221122112224.31691-3-naush@raspberrypi.com>","In-Reply-To":"<20221122112224.31691-3-naush@raspberrypi.com>","Date":"Wed, 23 Nov 2022 13:40:43 +0000","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v1 2/5] ipa: raspberrypi: histogram:\n\tAdd a constructor for an empty histogram","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]