{"id":17827,"url":"https://patchwork.libcamera.org/api/patches/17827/?format=json","web_url":"https://patchwork.libcamera.org/patch/17827/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221121154421.11732-6-david.plowman@raspberrypi.com>","date":"2022-11-21T15:44:21","name":"[libcamera-devel,v2,5/5] libcamera: pipeline: rkisp1: Set device's flip controls as previously","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a50d4a2e4db3acdf12e49940c2afeeb063735628","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17827/mbox/","series":[{"id":3625,"url":"https://patchwork.libcamera.org/api/series/3625/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3625","date":"2022-11-21T15:44:16","name":"Resolve invalid attempts to set sensor flip controls","version":2,"mbox":"https://patchwork.libcamera.org/series/3625/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17827/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17827/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22256BE08B\n\tfor ;\n\tMon, 21 Nov 2022 15:44:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D50096331F;\n\tMon, 21 Nov 2022 16:44:34 +0100 (CET)","from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 573236331D\n\tfor ;\n\tMon, 21 Nov 2022 16:44:31 +0100 (CET)","by mail-wr1-x436.google.com with SMTP id x17so7005145wrn.6\n\tfor ;\n\tMon, 21 Nov 2022 07:44:31 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tt11-20020adff60b000000b0022e035a4e93sm11742257wrp.87.2022.11.21.07.44.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 21 Nov 2022 07:44:30 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669045474;\n\tbh=bh9I5bRKF0w2MeqEa0N4v8iZ5H0zEkddiVq8N8dlwCM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=z607aPOfgUnzHc02tBm+PeifNhJgtfjTYVpWBOumsHnkbpm9+uHgI1EO/2wL/CXde\n\twFt5yUObdnbQnc3ug2WOzyfp/0EDYxuL6JdlVbwQnrgYK6ih8uh/qk3wCX5ou5gLF7\n\tVqz32h5Cdngl9xOlSJ8QrQgUwHmvgopIjx7sfXbO27pZW4PGGFukHjikOBdcjvAhtg\n\t9/YQR2H980VixMsaWane0ku0ex0fczTxohWI9+bB4AooCvEGSdljmoZiQc6FYFB6OL\n\tw6if4qcUbdr00sMq1uNbRpG+SLYJsWGTZD5J7T7YaCyTlA2DQoYAEyZc2l3WIa1GTn\n\tEBvNaG4UkZynw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=41Mcjs494HINUeN/gt5bpH1WI2znT1tO4uWTxfMQSOU=;\n\tb=WfgnXriR+ocVLgADu71vi804rwTPNipJW/FWp85EJV8jq3O+vhU8+XpQob5fs7rBBH\n\t54Up3Qa0TUco7uU5g59XwrzyyXiJmBtdoqRKb564eh6F4Mdd29O/I/9HY5b0/cCNswPS\n\tZIhGiO/OdlMTHmCF+uU3DKF3Aa+8E7ja0ZuSfWZVPhLDFeYz77h06fKmGfXUyWfwClRy\n\tKnxg0icDYmZDKAPwolDvZI6jKJDJxR+3xMrP0DWfouJdxmR1xxsC2Mbc9VuDdv0gq9A/\n\twdov/RXHLHb5Qbebu08DPuCBz5M6V9ZKz9Vf/riu49CAsnFf10nqcQXgW+0I7/nFzFba\n\tajYA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"WfgnXriR\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=41Mcjs494HINUeN/gt5bpH1WI2znT1tO4uWTxfMQSOU=;\n\tb=hDITbpCk7z1ELTxtLXPoVmXDVKhY1dYoe3UBPYus4RwYpMMHDEtNOXsR4xUeItePsh\n\t0u30e47LKNEJ4j83uTwPolXvRKVymlhXHnoHCqObiQEtH/UZdIOajaWTSGrBhnQtwEkx\n\tbJyFsBkQE7KF4aL9ThavXFmtNHqgK20o+79sivBGXF1GfW1YKZf3M+SD1gv66PoJBH5r\n\tACsGdyeYfDUmc75xB5yY2WJ+eds40KuUbztA51Gqgpozmuub14Eda9VPRb+cV9YL5eYn\n\t9qHNoJ9HfGpZOnRQ8URsSiHBneeVAGKcV3hJEenFWCRf+GtM77JGM/DnDzozY99LKJ4m\n\tUAKw==","X-Gm-Message-State":"ANoB5pk9mrhZvwEy9LGt/7QwLd9/zbZIyUtIIR5UpvH50B4c+RskBepH\n\tbnVR5/gz/bJuUP3DHA0JjcN8Egpw6lg8pA==","X-Google-Smtp-Source":"AA0mqf4Z+lSas8hDiclCmDBwClgyYZ1eBq2i2tgoUJvsylsb8hJ0yPRIV8Km2a7UnWmc7965y4qDww==","X-Received":"by 2002:adf:f38a:0:b0:236:5270:7347 with SMTP id\n\tm10-20020adff38a000000b0023652707347mr11828327wro.35.1669045470730; \n\tMon, 21 Nov 2022 07:44:30 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 21 Nov 2022 15:44:21 +0000","Message-Id":"<20221121154421.11732-6-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20221121154421.11732-1-david.plowman@raspberrypi.com>","References":"<20221121154421.11732-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 5/5] libcamera: pipeline: rkisp1: Set\n\tdevice's flip controls as previously","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Set the horizontal and vertical flip controls by calling the device's\nsetTransform method now that this no longer happens in\nCameraSensor::init(). The aim here is to preserve the previous\nbehaviour.\n\nSigned-off-by: David Plowman \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 3d3a7086..f144fabd 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -632,6 +632,9 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \tif (ret)\n \t\treturn ret;\n \n+\t/* Set up the device's horizontal and vertical flips. */\n+\tsensor->device()->setTransform(c->transform);\n+\n \t/*\n \t * Configure the format on the sensor output and propagate it through\n \t * the pipeline.\n","prefixes":["libcamera-devel","v2","5/5"]}