{"id":17826,"url":"https://patchwork.libcamera.org/api/patches/17826/?format=json","web_url":"https://patchwork.libcamera.org/patch/17826/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221121154421.11732-5-david.plowman@raspberrypi.com>","date":"2022-11-21T15:44:20","name":"[libcamera-devel,v2,4/5] libcamera: pipeline: simple: Set device's flip controls as previously","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2e4894768a2a96c65c49ef5e7c71f8a3cbd86bb7","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17826/mbox/","series":[{"id":3625,"url":"https://patchwork.libcamera.org/api/series/3625/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3625","date":"2022-11-21T15:44:16","name":"Resolve invalid attempts to set sensor flip controls","version":2,"mbox":"https://patchwork.libcamera.org/series/3625/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17826/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17826/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6AD6BBE08B\n\tfor ;\n\tMon, 21 Nov 2022 15:44:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 23EB46331D;\n\tMon, 21 Nov 2022 16:44:34 +0100 (CET)","from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5BF263321\n\tfor ;\n\tMon, 21 Nov 2022 16:44:30 +0100 (CET)","by mail-wm1-x32f.google.com with SMTP id\n\tm7-20020a05600c090700b003cf8a105d9eso9300877wmp.5\n\tfor ;\n\tMon, 21 Nov 2022 07:44:30 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tt11-20020adff60b000000b0022e035a4e93sm11742257wrp.87.2022.11.21.07.44.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 21 Nov 2022 07:44:29 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669045474;\n\tbh=wC/eouBOvKoHq7yHhH+rO6xXi0AvXprsYlXej4tsNSA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=PsfOga6tkH9R3v56uXpOYi8g1QTGWKBDi93dp6wPd9Lgs7VH6Oma6ZdXRkMVcmrtR\n\tMCeyQ1F2Zrvogs3JVOZ3z4yBKrG5WWJ8eeWY8pcj1/+zdoL3BQ1ZIkoXvb6gYSZCWk\n\tDg/koOB4kzEJxqNtD9D01mzx2hliXzQopcu1rMJulLSX2dz3UpaevK6wDTqyfc+tA0\n\tFkFAhK7dxqL5nJK259Insmjzf8lZJt87M3luewzFvn1WkZiB2QHDQ8atISPC4qbpld\n\tz6662x0cdhNsxHCpRKJCygvl5HAltpbNl3jDhach5IvUbwMaqTISs1oE69s6OJjVFY\n\teKj1ra/ge6AvA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=quSfxEw9Fkkx4YktgHt5yQsthxWzdQOrtAnA/xUQP+c=;\n\tb=ZT6ZAYtp9glbfNNZTNICrOkpInDgzxTRMxjuJM8C0wZAfnoYjUO1D1cKLRAaKlzOq8\n\tYJ/L31Vbve1VJ1wlfKimER9LjnPkKPWjnXCwgnFuIVgousXwNaQJrIDQHFT9QlbIPBz9\n\tMGesCvdkIE4d6xMvd1O4exDll0QEKMXWh7mpBFuz4U0K4rbgwuq4XxNfl9aMI9W1fXd5\n\tdqrWGP66xZ0L1c3d5cMieYXLKFqSFnb8NQ+Qo6LaOiMRq6Wr5lIW6llprNWcipqPpWS7\n\tU75zfKYhrbDsScqHV94V1U3AnPFbv6dcUPEe7asKUFoGF40LV+6MP0Jb3fKoTPsWITRW\n\tOWYA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"ZT6ZAYtp\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=quSfxEw9Fkkx4YktgHt5yQsthxWzdQOrtAnA/xUQP+c=;\n\tb=Zj3lNl8L+mfi5wPLChP77oJFIASl638EnFrzV1B9tLvFcLo7Tinrr8EpCAdTP7mhxz\n\tZMuZi7NIs9BGjmlqYLslHR9lH0bV6UOAnYUukqRxO46uz4EySkBaCXLbeLS88IcKU0j9\n\tGxCTQelWlQYIR32pKY44JrJTKABcm1o4PFrBXwAWZGPda2Z2MtJPUxgb8pj52YJoQtu8\n\tCUnpI9B1vhOqVruY+gxUTsackhHJAwBMKGt8GK5ISvndaFobRovfQjViF+8jz9Z2N+KG\n\tQI6SOGioyXQzn4Pdo4PZrCPov8zP0aAEoMA++36jFvKV7ti3doJrVtIpy4BvXpAhpNlr\n\tQeeQ==","X-Gm-Message-State":"ANoB5pl8fPt5VZ/c1ibmeijPF+zonSy0fnLqWz5S7p4kkSNvg3qnf4wO\n\t7AO4q3ulg1rQ1V4E9lDSVcWNWJaSKGiM+Q==","X-Google-Smtp-Source":"AA0mqf4c0jTGN+VOM4QDuEdhqyN+8yCLNLCCczIG1idMBgQUorO+mlPf0wwE0Gew3R1l8fHu3KoMlA==","X-Received":"by 2002:a05:600c:3d8f:b0:3cf:6a4c:af8b with SMTP id\n\tbi15-20020a05600c3d8f00b003cf6a4caf8bmr17364274wmb.115.1669045469956; \n\tMon, 21 Nov 2022 07:44:29 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 21 Nov 2022 15:44:20 +0000","Message-Id":"<20221121154421.11732-5-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20221121154421.11732-1-david.plowman@raspberrypi.com>","References":"<20221121154421.11732-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 4/5] libcamera: pipeline: simple: Set\n\tdevice's flip controls as previously","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Set the horizontal and vertical flip controls by calling the device's\nsetTransform method now that this no longer happens in\nCameraSensor::init(). The aim here is to preserve the previous\nbehaviour.\n\nSigned-off-by: David Plowman \n---\n src/libcamera/pipeline/simple/simple.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex a32de7f3..f25a8cc1 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1120,6 +1120,9 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \tif (ret < 0)\n \t\treturn ret;\n \n+\t/* Set up the video device's horizontal and vertical flips. */\n+\tvideo->setTransform(c->transform);\n+\n \t/* Configure the video node. */\n \tV4L2PixelFormat videoFormat = video->toV4L2PixelFormat(pipeConfig->captureFormat);\n \n","prefixes":["libcamera-devel","v2","4/5"]}