[{"id":25832,"web_url":"https://patchwork.libcamera.org/comment/25832/","msgid":"<20221121125558.rlnhck4iminscumi@uno.localdomain>","date":"2022-11-21T12:55:58","subject":"Re: [libcamera-devel] [PATCH] pipeline: imx8-isi: Set\n\tSensorTimestamp metadata","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sun, Nov 20, 2022 at 07:20:30PM +0200, Laurent Pinchart wrote:\n> Report the sensor timestamp in metadata. Use the timestamp from the\n> first buffer. Accuracy could be improved by using the frame start event\n> from the CSI-2 receiver, but the kernel driver doesn't support it yet.\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nAck, and I can confirm it fixes an issue with the gstreamer\n\"videorate\" element.\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n  j\n\n> ---\n>  src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 6 ++++++\n>  1 file changed, 6 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> index a3dfd3fc529c..e51457ebc345 100644\n> --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> @@ -994,6 +994,12 @@ void PipelineHandlerISI::bufferReady(FrameBuffer *buffer)\n>  {\n>  \tRequest *request = buffer->request();\n>\n> +\t/* Record the sensor's timestamp in the request metadata. */\n> +\tControlList &metadata = request->metadata();\n> +\tif (!metadata.contains(controls::SensorTimestamp.id()))\n> +\t\tmetadata.set(controls::SensorTimestamp,\n> +\t\t\t     buffer->metadata().timestamp);\n> +\n>  \tcompleteBuffer(request, buffer);\n>  \tif (request->hasPendingBuffers())\n>  \t\treturn;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1EDEBD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Nov 2022 12:56:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46F4563311;\n\tMon, 21 Nov 2022 13:56:01 +0100 (CET)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::221])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B978163097\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Nov 2022 13:55:59 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 0F002240008;\n\tMon, 21 Nov 2022 12:55:58 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669035361;\n\tbh=zEgGOxThlJ7VLSBQaXqHqiIuxZWBBzpgeawjfDxolSY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ByEDLiR7c8/skgOB989TQpkm0qftcOnL4SYLmY3zJLYipT7hOVBBZLqbt/1uy0gRa\n\tryrzY7TL2isuzQ98DFwJNH0op5Zs+r9WYCv6RBjUjCvfk0sQyYqFU/jXqV5+DMWqik\n\ts5kh448NMQa5cRLGZfFbVCLWVZIBtRe18W1L2ZDkHBm3vFLRFKxg92lVX/vqCasXNu\n\tkAD3pGPyPegTO8mZ8CjSC9CP1Y9XdcpC97Rk6ANhwZxsWPCnMrvpomBpGVW4CU542O\n\tFI5NXst+5XZ/0b9i11doy1ife+3+Low9AjWuNcp6B7Qk8EU2eOmQKHpGNIWM4XEUqZ\n\tdeLEbHNIgfwGQ==","Date":"Mon, 21 Nov 2022 13:55:58 +0100","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20221121125558.rlnhck4iminscumi@uno.localdomain>","References":"<20221120172030.21821-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221120172030.21821-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] pipeline: imx8-isi: Set\n\tSensorTimestamp metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Jacopo Mondi <jacopo@jmondi.org>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":25833,"web_url":"https://patchwork.libcamera.org/comment/25833/","msgid":"<166903623288.50677.9962935210487950362@Monstersaurus>","date":"2022-11-21T13:10:32","subject":"Re: [libcamera-devel] [PATCH] pipeline: imx8-isi: Set\n\tSensorTimestamp metadata","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-11-20 17:20:30)\n> Report the sensor timestamp in metadata. Use the timestamp from the\n> first buffer. Accuracy could be improved by using the frame start event\n> from the CSI-2 receiver, but the kernel driver doesn't support it yet.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 6 ++++++\n>  1 file changed, 6 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> index a3dfd3fc529c..e51457ebc345 100644\n> --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> @@ -994,6 +994,12 @@ void PipelineHandlerISI::bufferReady(FrameBuffer *buffer)\n>  {\n>         Request *request = buffer->request();\n>  \n> +       /* Record the sensor's timestamp in the request metadata. */\n> +       ControlList &metadata = request->metadata();\n> +       if (!metadata.contains(controls::SensorTimestamp.id()))\n> +               metadata.set(controls::SensorTimestamp,\n> +                            buffer->metadata().timestamp);\n> +\n>         completeBuffer(request, buffer);\n>         if (request->hasPendingBuffers())\n>                 return;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3AE22BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Nov 2022 13:10:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F10BE63311;\n\tMon, 21 Nov 2022 14:10:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10E3063097\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Nov 2022 14:10:36 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B3EAE74C;\n\tMon, 21 Nov 2022 14:10:35 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669036237;\n\tbh=jmIKbieVy645cXtVOFI60sr9lvrwtHCJ9M08ew+wuUE=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=jhPUYoGL67wXCbquH3c6hClGMKcJ6GrZ4Oky4GPi9UhEQlo3V/NGH/6CpXJ3CqwKr\n\tgVDkZf3rjluKbQEclXPglxZq//5DH1QKSHmpzwRUXTKD7fvGxr85yewcQ2xTz+mkBm\n\t2mXVKkW3TsE+SLcGI1F96l9CWH79TvlDMPeg+vs33dGnVsvl5Pv4weEqSOTpF5K9xM\n\t6jN2BOpS8zla1EFzIHISPJVbIHZuhJfZnOvWXO8GN6P5+n/xZdaISypBPEl1P2hs1K\n\tZslIdlXBOEGnN8AnX/hLyUwDHI4dLQaOPLmYXCnMRqGa+6jQx5snh+1FtOhCrmNbn7\n\tlEQCvKew+22zg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1669036235;\n\tbh=jmIKbieVy645cXtVOFI60sr9lvrwtHCJ9M08ew+wuUE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=chfyc9r/fZu9k+WNuJ71dnMnpXJq8Hy14ii2fmqzF0MNKzss+p6zZisv2PEeGoZ48\n\tSCaspC0uAM+md8cJid7KAQeR2xyZPrOvVOZRavc+/IlNwndRuyfIRNROhDD/eOi++Q\n\tWfsQumQ3KRlwIxwXDIl4shxpxVIBxJL7+gEnBt0s="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"chfyc9r/\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221120172030.21821-1-laurent.pinchart@ideasonboard.com>","References":"<20221120172030.21821-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 21 Nov 2022 13:10:32 +0000","Message-ID":"<166903623288.50677.9962935210487950362@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] pipeline: imx8-isi: Set\n\tSensorTimestamp metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":25834,"web_url":"https://patchwork.libcamera.org/comment/25834/","msgid":"<166903629153.50677.12125115226729843184@Monstersaurus>","date":"2022-11-21T13:11:31","subject":"Re: [libcamera-devel] [PATCH] pipeline: imx8-isi: Set\n\tSensorTimestamp metadata","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-11-20 17:20:30)\n> Report the sensor timestamp in metadata. Use the timestamp from the\n> first buffer. Accuracy could be improved by using the frame start event\n> from the CSI-2 receiver, but the kernel driver doesn't support it yet.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nThis makes me wonder if we should have mandated metadata ... which is\nalways expected to be reported in any successfully completed request.\n\nIf so - there's scope for some checks to be added to lc-compliance to\nhelp validate this during bringup of new platforms.\n-\nKieran\n\n\n> ---\n>  src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 6 ++++++\n>  1 file changed, 6 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> index a3dfd3fc529c..e51457ebc345 100644\n> --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> @@ -994,6 +994,12 @@ void PipelineHandlerISI::bufferReady(FrameBuffer *buffer)\n>  {\n>         Request *request = buffer->request();\n>  \n> +       /* Record the sensor's timestamp in the request metadata. */\n> +       ControlList &metadata = request->metadata();\n> +       if (!metadata.contains(controls::SensorTimestamp.id()))\n> +               metadata.set(controls::SensorTimestamp,\n> +                            buffer->metadata().timestamp);\n> +\n>         completeBuffer(request, buffer);\n>         if (request->hasPendingBuffers())\n>                 return;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C08C7BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Nov 2022 13:11:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8BBBE63311;\n\tMon, 21 Nov 2022 14:11:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D6AE63097\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Nov 2022 14:11:34 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B3F6374C;\n\tMon, 21 Nov 2022 14:11:33 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669036295;\n\tbh=2Vpw5lVqCdYYA1igBDQsCeWgT/vtFED1OH2Sa2cjufQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vmrkRhCKSwIr23XxNP2vuLdT8Qw39JMzvsBDcuqgtK3LFFk3zEisoqvUqYVJqlKzh\n\t8j8h6sJazgLSlizqnR2zXUeYd02S3FH3N5h8jhfYHf+XSnAtWjFbYo5mQFOMTmzeyc\n\tQU3NvBQGlptg4rr+PfumKY6WlgzgWMCyOZGD60KeK8PvtiuQ+Ppmr19WEtZG3uCJtf\n\tJ82t7UqEMlqExY6Kkt+XDROUa6BZsvVZlfYIk2O1BNMsBjO8jujzilWTIBV+qXaIrP\n\tPolrYjrAGy7djVxiqz8naUGypWxnfDQf6fXEiDeLUKb8nnmTh8yf5YljtyC9Fkhk3Z\n\tMFZvByfPYNglA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1669036293;\n\tbh=2Vpw5lVqCdYYA1igBDQsCeWgT/vtFED1OH2Sa2cjufQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=CqaxEsmjQ3N8r6sffw5/5t7NCa5irmUjMAtmJRN7pgd10kEYYpCb9AZzGHWvJKpG8\n\tx9py7qYVUZTKgToL4BYKWSzICiZ5Ha9S2pYb6e7ANPN29SOjE5kze+M0xNkB7FnkL2\n\t7L1JUl0YdKhmn2ISc0pvOI/BAyT0EAA5xfmdM8Wo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CqaxEsmj\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20221120172030.21821-1-laurent.pinchart@ideasonboard.com>","References":"<20221120172030.21821-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 21 Nov 2022 13:11:31 +0000","Message-ID":"<166903629153.50677.12125115226729843184@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] pipeline: imx8-isi: Set\n\tSensorTimestamp metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":25835,"web_url":"https://patchwork.libcamera.org/comment/25835/","msgid":"<Y3t82y9yk4KrYtaK@pendragon.ideasonboard.com>","date":"2022-11-21T13:27:55","subject":"Re: [libcamera-devel] [PATCH] pipeline: imx8-isi: Set\n\tSensorTimestamp metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Nov 21, 2022 at 01:11:31PM +0000, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-11-20 17:20:30)\n> > Report the sensor timestamp in metadata. Use the timestamp from the\n> > first buffer. Accuracy could be improved by using the frame start event\n> > from the CSI-2 receiver, but the kernel driver doesn't support it yet.\n> > \n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> This makes me wonder if we should have mandated metadata ... which is\n> always expected to be reported in any successfully completed request.\n> \n> If so - there's scope for some checks to be added to lc-compliance to\n> help validate this during bringup of new platforms.\n\nAbsolutely, we should do so.\n\n> > ---\n> >  src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 6 ++++++\n> >  1 file changed, 6 insertions(+)\n> > \n> > diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> > index a3dfd3fc529c..e51457ebc345 100644\n> > --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> > +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n> > @@ -994,6 +994,12 @@ void PipelineHandlerISI::bufferReady(FrameBuffer *buffer)\n> >  {\n> >         Request *request = buffer->request();\n> >  \n> > +       /* Record the sensor's timestamp in the request metadata. */\n> > +       ControlList &metadata = request->metadata();\n> > +       if (!metadata.contains(controls::SensorTimestamp.id()))\n> > +               metadata.set(controls::SensorTimestamp,\n> > +                            buffer->metadata().timestamp);\n> > +\n> >         completeBuffer(request, buffer);\n> >         if (request->hasPendingBuffers())\n> >                 return;","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31701BD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Nov 2022 13:28:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7BBE26331A;\n\tMon, 21 Nov 2022 14:28:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 12F8163097\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Nov 2022 14:28:12 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1448D74C;\n\tMon, 21 Nov 2022 14:28:10 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669037293;\n\tbh=fuBg6Y3hpOSi8K1sczDxR403EDdTU1lSrz1dkKeRMRg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2bcRZGxTC48LJfLEh40ttF8UydDB1mpLrsuGQuGoPMdxEHsoS+51xmmBS5hDyf3st\n\tl8n8IoMGV/WV507lZMIZyLEp4gnB/cj/B6aJ40LmVFCbYpNLLGLtRNt7pZLMNixLFu\n\t0qSgEkIoHjbW3hSqW8Y/wf0uvoRe83YMFhO1N8v+sYW/VzhcyWh3xAwWFr+AZbvMtz\n\tuUg1p+2gLtvkJhO1NHUzN+aaQkx+W9MelUBd1WpvEqtYvmS/HRTqCeynk7VQIY+1OZ\n\t+wcIkhU6Q56q4se8grC4a6XLkHmloCOdCqWpQWw7ca8VNQzwVUXtd4bv9BfYEN5ad3\n\tSiZVpoVXz9qiw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1669037291;\n\tbh=fuBg6Y3hpOSi8K1sczDxR403EDdTU1lSrz1dkKeRMRg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CLdq14ev0VGlzHU9w77BRYdMQqshbfghZUUETPZFAd0exo9J0QzFPP81JPp80JxUp\n\tDE4U2HM5VmFAhHS7rli1ZFEFfWzYQKadppXF6KQkwl/mn+y8li61/WJwgrofNoZZj8\n\tbuRGLMY+V+9ppRWArcppJJyFTMJ4Q2ZK+zddcBI8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CLdq14ev\"; dkim-atps=neutral","Date":"Mon, 21 Nov 2022 15:27:55 +0200","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<Y3t82y9yk4KrYtaK@pendragon.ideasonboard.com>","References":"<20221120172030.21821-1-laurent.pinchart@ideasonboard.com>\n\t<166903629153.50677.12125115226729843184@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166903629153.50677.12125115226729843184@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] pipeline: imx8-isi: Set\n\tSensorTimestamp metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]