[{"id":25826,"web_url":"https://patchwork.libcamera.org/comment/25826/","msgid":"<Y3gi8HoMap/xa9yY@pendragon.ideasonboard.com>","date":"2022-11-19T00:27:28","subject":"Re: [libcamera-devel] [PATCH v2] kms: flag 'request' as\n\t'maybe_unused' to avoid 'unused-parameter' warnings","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Christian,\n\nThank you for the patch.\n\nOn Fri, Nov 18, 2022 at 09:39:51PM +0100, Christian Rauch via libcamera-devel wrote:\n> The parameter 'request' is only used in an assert. assert is only defined\n> for debug builds and release builds will not use the parameter, resulting\n> in warnings messages only for non-debug builds.\n> Fix this by flagging the parameter as 'maybe_unused'.\n> \n> Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/apps/cam/kms_sink.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp\n> index 754b061e..353209cd 100644\n> --- a/src/apps/cam/kms_sink.cpp\n> +++ b/src/apps/cam/kms_sink.cpp\n> @@ -517,7 +517,7 @@ bool KMSSink::processRequest(libcamera::Request *camRequest)\n>  \treturn false;\n>  }\n> \n> -void KMSSink::requestComplete(DRM::AtomicRequest *request)\n> +void KMSSink::requestComplete([[maybe_unused]] DRM::AtomicRequest *request)\n>  {\n>  \tstd::lock_guard<std::mutex> lock(lock_);\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6DAB3BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 19 Nov 2022 00:27:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A5BB6308F;\n\tSat, 19 Nov 2022 01:27:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 232EB61F31\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 19 Nov 2022 01:27:44 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A69D2749;\n\tSat, 19 Nov 2022 01:27:43 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668817665;\n\tbh=7rn+HMzEsbAfV5v6QX3QblGDsiQLlOvQThHDY2Uzfj0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=O9EWz1wMGFkaW4FxA1aqxCcTZQfEf9Hc6V5h4qDgRQk80HebhHIGIJ4rgnrvZ9Tb5\n\tPm+GVSBvl5qtpipriSoiRCHi6kzjmOrUO/sR75q2JN7HCJ45+6QiAkcZtNbwtaUwUi\n\tY9fJZjCQIiA3vCQcRJyUuGLI1KYX2NQ3IUG0/LQ14pHZTFhB9cJYsZS9teOtI680yC\n\tMod3ykUZFuUqroDgnHD9fYIPA2fhIWhS0zUDtyR0P7F0ff0xmB76Q1O0qycUyQWkF+\n\tF/qtpmblZmqAbQRylAkosHoGmWdhDY1z+SwZeGe0u+/260mxqEkzgz3xK+HjCUhaKI\n\tMHY5gFHmHhwRg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1668817663;\n\tbh=7rn+HMzEsbAfV5v6QX3QblGDsiQLlOvQThHDY2Uzfj0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GW5oBSn6U9W4gd0qMTOkTaLuSeOHDmL2UKPGDWD8OrWqUIAPqPKXqVht/dj+Dts6L\n\tNAF4WWKIAGOLhkN8VdybhN6YL62+XEKl0Oaz666zByES5IMbICKJ2iIHfgAsBjzDzW\n\tEPfiTBjGP9lumVqeO+VO56yBpC1eakW56SN4fbBQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GW5oBSn6\"; dkim-atps=neutral","Date":"Sat, 19 Nov 2022 02:27:28 +0200","To":"Christian Rauch <Rauch.Christian@gmx.de>","Message-ID":"<Y3gi8HoMap/xa9yY@pendragon.ideasonboard.com>","References":"<20221118203951.89812-1-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20221118203951.89812-1-Rauch.Christian@gmx.de>","Subject":"Re: [libcamera-devel] [PATCH v2] kms: flag 'request' as\n\t'maybe_unused' to avoid 'unused-parameter' warnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":25827,"web_url":"https://patchwork.libcamera.org/comment/25827/","msgid":"<Y3gjeMMstMIBZTTC@pendragon.ideasonboard.com>","date":"2022-11-19T00:29:44","subject":"Re: [libcamera-devel] [PATCH v2] kms: flag 'request' as\n\t'maybe_unused' to avoid 'unused-parameter' warnings","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sat, Nov 19, 2022 at 02:27:30AM +0200, Laurent Pinchart wrote:\n> Hi Christian,\n> \n> Thank you for the patch.\n> \n> On Fri, Nov 18, 2022 at 09:39:51PM +0100, Christian Rauch via libcamera-devel wrote:\n> > The parameter 'request' is only used in an assert. assert is only defined\n> > for debug builds and release builds will not use the parameter, resulting\n> > in warnings messages only for non-debug builds.\n> > Fix this by flagging the parameter as 'maybe_unused'.\n> > \n> > Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nI forgot to mention, the subject line should start with \"apps: cam:\". It\nthen gets a bit long, so I propose\n\napps: cam: kms: Avoid 'unused-parameter' warnings\n\nIf you're fine with that I'll change it when applying.\n\n> > ---\n> >  src/apps/cam/kms_sink.cpp | 2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp\n> > index 754b061e..353209cd 100644\n> > --- a/src/apps/cam/kms_sink.cpp\n> > +++ b/src/apps/cam/kms_sink.cpp\n> > @@ -517,7 +517,7 @@ bool KMSSink::processRequest(libcamera::Request *camRequest)\n> >  \treturn false;\n> >  }\n> > \n> > -void KMSSink::requestComplete(DRM::AtomicRequest *request)\n> > +void KMSSink::requestComplete([[maybe_unused]] DRM::AtomicRequest *request)\n> >  {\n> >  \tstd::lock_guard<std::mutex> lock(lock_);\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63EB5BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 19 Nov 2022 00:30:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C36906308F;\n\tSat, 19 Nov 2022 01:30:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4724661F31\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 19 Nov 2022 01:30:00 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B57AC749;\n\tSat, 19 Nov 2022 01:29:59 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668817801;\n\tbh=szYST3EjWdQpFZk7vXgse5dheYOChah0EFZvyGJPIAw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MVXO9Pgn8Mw72b/ZJRptlmU27ZDtbMssvFQco6PipQSaYQO5Sk/ngGXcAAlFHGmlp\n\t7+bvMYiiCNPl/CIviif9vL9Vthg8sxLEvxYxGYas3WWi27oUdmt3HNjEBUp8uynnwL\n\t24HvNGj0h6dUcFTj6W0RNL+Ox7jXursBSOmf2gkLI6fYmLBMa2K0eN41q9GW1kF5ua\n\tPxrwubPE+BEcg4aptmiL6uAsQLyGiDIqNrhfeC292BisTAgwlHN22axf1KGLylCWMS\n\ty6grDDw6rCLsoS/YvP/3jDiZs+OsrF+B/VbYX+CGkd6xyzD7wnpLuubgmBHNv1Np67\n\t+qMOujq1dLHfg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1668817799;\n\tbh=szYST3EjWdQpFZk7vXgse5dheYOChah0EFZvyGJPIAw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NuQ3PUAovbt9vecVpwDcI7/jEPB6oT/Rm2b8zgggSqYzQrQQKRaqZYhi/xckLUU0r\n\tuomg/80ObdkRlhGmUJxkRFP/g8+tdEBrmZGaDVz98UDd3Z9jNN4XINEgaF9PTrbelT\n\tMLY4qZAjDz1EcWaKa7ZMjfgowwXv4xzkArTLb5TQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NuQ3PUAo\"; dkim-atps=neutral","Date":"Sat, 19 Nov 2022 02:29:44 +0200","To":"Christian Rauch <Rauch.Christian@gmx.de>","Message-ID":"<Y3gjeMMstMIBZTTC@pendragon.ideasonboard.com>","References":"<20221118203951.89812-1-Rauch.Christian@gmx.de>\n\t<Y3gi8HoMap/xa9yY@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<Y3gi8HoMap/xa9yY@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] kms: flag 'request' as\n\t'maybe_unused' to avoid 'unused-parameter' warnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":25829,"web_url":"https://patchwork.libcamera.org/comment/25829/","msgid":"<b0cac718-9316-0f7d-bbda-d6ed9d6c6d62@ideasonboard.com>","date":"2022-11-19T05:22:46","subject":"Re: [libcamera-devel] [PATCH v2] kms: flag 'request' as\n\t'maybe_unused' to avoid 'unused-parameter' warnings","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello,\n\nOn 11/19/22 5:59 AM, Laurent Pinchart via libcamera-devel wrote:\n> On Sat, Nov 19, 2022 at 02:27:30AM +0200, Laurent Pinchart wrote:\n>> Hi Christian,\n>>\n>> Thank you for the patch.\n>>\n>> On Fri, Nov 18, 2022 at 09:39:51PM +0100, Christian Rauch via libcamera-devel wrote:\n>>> The parameter 'request' is only used in an assert. assert is only defined\n>>> for debug builds and release builds will not use the parameter, resulting\n>>> in warnings messages only for non-debug builds.\n>>> Fix this by flagging the parameter as 'maybe_unused'.\n>>>\n>>> Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> I forgot to mention, the subject line should start with \"apps: cam:\". It\n> then gets a bit long, so I propose\n>\n> apps: cam: kms: Avoid 'unused-parameter' warnings\n>\n> If you're fine with that I'll change it when applying.\n\nLGTM,\n\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n\n>\n>>> ---\n>>>   src/apps/cam/kms_sink.cpp | 2 +-\n>>>   1 file changed, 1 insertion(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp\n>>> index 754b061e..353209cd 100644\n>>> --- a/src/apps/cam/kms_sink.cpp\n>>> +++ b/src/apps/cam/kms_sink.cpp\n>>> @@ -517,7 +517,7 @@ bool KMSSink::processRequest(libcamera::Request *camRequest)\n>>>   \treturn false;\n>>>   }\n>>>\n>>> -void KMSSink::requestComplete(DRM::AtomicRequest *request)\n>>> +void KMSSink::requestComplete([[maybe_unused]] DRM::AtomicRequest *request)\n>>>   {\n>>>   \tstd::lock_guard<std::mutex> lock(lock_);\n>>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73DDFBE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 19 Nov 2022 05:23:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3E616308F;\n\tSat, 19 Nov 2022 06:23:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF4D5603CE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 19 Nov 2022 06:23:40 +0100 (CET)","from [192.168.1.104] (unknown [103.251.226.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 709A7749;\n\tSat, 19 Nov 2022 06:23:39 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668835422;\n\tbh=e7aVPjNXHfNX4PoGXLlCVvarHmJpTwgZAsT+0ksRkY4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MYO77j+jxROmybIyTn64WxU+jIGEgq37rUemeo84pl8CaJi+fvlZZ8VnUIO99q8VS\n\tWW6pvWZJo67b6J4Y8FfFPqo2oHnYaO7/ODMWZFxgnLrZW41lX+xgKnX38RKauZzPHj\n\t4rXHtVU2x3sT4HGlkwoiU8tDzDXNEjWrzUK+vlIuC8LX0d47KqH7HPrVK33J0Sd9Xi\n\tbCP/NC1g045gloqb9pCAwS0INdy9r6gyrUUCKMvTmbkDO5AO9vTgJvAuSGcbr9Jzde\n\tjq6t1wR22+AIA/XH3fGEvBxkn9mJ/ZanBBWYuwF9pbAgtgWvl80KA8eH7IUF2am0kL\n\tXuSkPtwPk7ZMg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1668835420;\n\tbh=e7aVPjNXHfNX4PoGXLlCVvarHmJpTwgZAsT+0ksRkY4=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=kFG+OGlXPhffIVimyRp/9d+fS/5186M9xBkuMjxeQkPACKeOQDn/32G1tCkzt2k0d\n\t3YLrI+Odn42ojsG5AqtJonoyRuGBP9tsOaqK4liNQ9S9L8pKA0ZkmTSvV/5+7Lw4zD\n\tizsncuKetZ2886ECxxiPByj3WLY58ReoqT5SUubo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kFG+OGlX\"; dkim-atps=neutral","Message-ID":"<b0cac718-9316-0f7d-bbda-d6ed9d6c6d62@ideasonboard.com>","Date":"Sat, 19 Nov 2022 10:52:46 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.4.1","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tChristian Rauch <Rauch.Christian@gmx.de>","References":"<20221118203951.89812-1-Rauch.Christian@gmx.de>\n\t<Y3gi8HoMap/xa9yY@pendragon.ideasonboard.com>\n\t<Y3gjeMMstMIBZTTC@pendragon.ideasonboard.com>","Content-Language":"en-US","In-Reply-To":"<Y3gjeMMstMIBZTTC@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2] kms: flag 'request' as\n\t'maybe_unused' to avoid 'unused-parameter' warnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Umang Jain <umang.jain@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":25830,"web_url":"https://patchwork.libcamera.org/comment/25830/","msgid":"<34c1f389-ea09-3737-7c04-3f6c3e1105aa@gmx.de>","date":"2022-11-20T13:39:33","subject":"Re: [libcamera-devel] [PATCH v2] kms: flag 'request' as\n\t'maybe_unused' to avoid 'unused-parameter' warnings","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"Hi Laurent,\n\nAm 19.11.22 um 01:29 schrieb Laurent Pinchart:\n> On Sat, Nov 19, 2022 at 02:27:30AM +0200, Laurent Pinchart wrote:\n>> Hi Christian,\n>>\n>> Thank you for the patch.\n>>\n>> On Fri, Nov 18, 2022 at 09:39:51PM +0100, Christian Rauch via libcamera-devel wrote:\n>>> The parameter 'request' is only used in an assert. assert is only defined\n>>> for debug builds and release builds will not use the parameter, resulting\n>>> in warnings messages only for non-debug builds.\n>>> Fix this by flagging the parameter as 'maybe_unused'.\n>>>\n>>> Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n>>\n>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>\n> I forgot to mention, the subject line should start with \"apps: cam:\". It\n> then gets a bit long, so I propose\n>\n> apps: cam: kms: Avoid 'unused-parameter' warnings\n>\n> If you're fine with that I'll change it when applying.\n\nYes, I am fine with you changing the commit message.\n\nThanks,\nChristian\n\n>\n>>> ---\n>>>   src/apps/cam/kms_sink.cpp | 2 +-\n>>>   1 file changed, 1 insertion(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp\n>>> index 754b061e..353209cd 100644\n>>> --- a/src/apps/cam/kms_sink.cpp\n>>> +++ b/src/apps/cam/kms_sink.cpp\n>>> @@ -517,7 +517,7 @@ bool KMSSink::processRequest(libcamera::Request *camRequest)\n>>>   \treturn false;\n>>>   }\n>>>\n>>> -void KMSSink::requestComplete(DRM::AtomicRequest *request)\n>>> +void KMSSink::requestComplete([[maybe_unused]] DRM::AtomicRequest *request)\n>>>   {\n>>>   \tstd::lock_guard<std::mutex> lock(lock_);\n>>>\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25792BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 20 Nov 2022 13:39:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9CCA2632ED;\n\tSun, 20 Nov 2022 14:39:55 +0100 (CET)","from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C325603CE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 20 Nov 2022 14:39:54 +0100 (CET)","from [IPV6:2a01:598:b1ad:ba79:4f28:93b1:1b1b:82f7]\n\t([80.187.116.105]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with\n\tESMTPSA (Nemesis) id 1MXXuB-1oQcAZ2mBb-00Z3Go for\n\t<libcamera-devel@lists.libcamera.org>; Sun, 20 Nov 2022 14:39:53 +0100"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668951595;\n\tbh=znhcoEtgjF7aT+SBr8/9sy3nb9i0kZ5jC2l2B5J1xi0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=pIFoIsHFj7C16LjfkDJqz7Fv9TDkTDFyIXOH+1vrTftRIYqxc4/nfoADos9md4mr1\n\tPYU6giRoTlgxwZbH6iSUCCyXnaET+u/STWOiQMKzRUK8HQJY/k0+WsnD3KuFv5mrDt\n\t9T66YK7oRjz20ec8pa2qcKZhcwTkNLCjEp7FLkX108QkGSfj33vDKBfw7rwh6RdA1j\n\twtrp2JhmV7qDynvRATqHPNlw+if9x36ReqpoHc1kMLYH2STDr4xyG8qJQ1wL3BRX3s\n\tZiXrrla6c3P5hAh23E9bHR8H/42IgS8HFQgU8g0ytYareZGDc9f4M+dcR5FSsOjtfe\n\t7yJbmadpHmbjg==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; \n\tt=1668951594; bh=znhcoEtgjF7aT+SBr8/9sy3nb9i0kZ5jC2l2B5J1xi0=;\n\th=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To;\n\tb=DVBIl8Sm8o57LiRlHrUtCvg1gVeZBsdfxukFdNSpRgy0H+BGy4p+VxSZ5oPvAfZj8\n\tsU/RpwOHJhHhMRqrLMF0BRtcgbQYgxVso6Udv4TjCZXnqwzFZK/bqpDdQlEkyHpbtB\n\tvrqFh1MQe39cRZiS5oFLp2c7ncEXSXaeLv4z2lH6pc4gtuZwBdgEzcL3o2E4L1Ptyk\n\tiU/b1n3/qUQIxWix3Fmw0iXfLxk/xyrPyT5eTlBaFsSy6XJD0lcxb30MeX3qIrYH5q\n\tpOphqNt0xDf/WPkRSIhyGGB/JDuxnBTzHRT/86ft9I1ZFAgubxNEzV+qJmt217obXV\n\tcvElA4ew6XB5A=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmx.de header.i=@gmx.de\n\theader.b=\"DVBIl8Sm\"; dkim-atps=neutral","X-UI-Sender-Class":"724b4f7f-cbec-4199-ad4e-598c01a50d3a","Message-ID":"<34c1f389-ea09-3737-7c04-3f6c3e1105aa@gmx.de>","Date":"Sun, 20 Nov 2022 14:39:33 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.4.2","To":"libcamera-devel@lists.libcamera.org","References":"<20221118203951.89812-1-Rauch.Christian@gmx.de>\n\t<Y3gi8HoMap/xa9yY@pendragon.ideasonboard.com>\n\t<Y3gjeMMstMIBZTTC@pendragon.ideasonboard.com>","Content-Language":"en-GB","In-Reply-To":"<Y3gjeMMstMIBZTTC@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:Tro5mXKQUYfTKVcZjNuI1d+BRAyr7Z8EcQM7/cbM18rqZ2IxMEQ\n\tB5vfpImn2P4LP7mV6/xbp7B09x+X81KtUT+pA8SCYXEZU9y1N33P4wdjvVUDonS4UbIZBhL\n\tG8pzfioOm3B+EMHJwPfP3igheNMqq5JDGiVISHkW9PXLbIysSjSWv9XV2ts6tVVSBCY5deE\n\tSaADKHazPgmOvCCu8VTzw==","X-Spam-Flag":"NO","UI-OutboundReport":"notjunk:1; M01:P0:hrqvvH/9MPc=;\n\t1FQW6CMKTAkaS1xKuq8i+IgmFCe\n\tAKEjeaWuntro1LUaXTFF2bxwHpWZgaYkUaRdkti3ZqWpCxP7jceCLlOUr/C2Vixh2hUS4d/Sx\n\t9T2fnus2HeShMH6RjCGwNRVbS+p/9k5UY0/s0Pai/8gQWxDKnaqrEnvdUDjNFpaJYnxt3tbdK\n\tT12hX5Uiq+f6tqCmLtyHBhqc+aVAgHVCk1MeIk0845APbh0dVqjGbuW5nXXlt4atwBnreAnf0\n\tmOe91797jdEvkEXzggS54xc4e2L0CLmK176ghXsY5IeLZ290Rp15wKcq5jUzQ0OJK0+hXbnUV\n\t1f0QQCrgLUudAJ+aEf7JGie8rzs8zDEqD8f+2g+z4nbRcRksZd3ViZX3ygzvotn9j7Jje5b4v\n\t2+YpRy6lQlCK5+JTmd3dGyF9oSp7GEpciUd/jOvShy96P5TGFObYGRO4y7n3e4aL6f9WcIfXF\n\tfv76nJRCEXfwNdetvmPejsrpXDnmXSB7pGis6+ZYpMM/k8Q7i0tIW53rtGHK18HiEJt1rYP3x\n\thAUCq4Vwdds/lIVnNlAtMwI3MHyoG9j2nDGXlPk9+DrAsotwP8gCbvtaqbqQyr61Vsay8v+VH\n\tZ4IyZT4HJjnphNep7q8XKF425GpEHBrh/rF81XSmVgMRpL6gsREjxp490BoXo0UjiDzAMQy0i\n\t37n8/Xaq+nHvhzP6qmLdFVUfeWgQPDlsZXEBo75QlyvxSaYx3SZe6u6KHQ/RIwC7eL7PmzeTi\n\tO0+5bsno1KZJEkl4v64re5DfrHdQVy3YVwS98xtJ7+8yIuceIlxLLMolofrLgP3jIVolgzHd1\n\tOdaDbmLZdij43wysCZxV84JiAxnukW0aCi0KyySWo7RCaD/1PpAq03z35yneCnk+6rAL7Rwmt\n\tqFXACJ+ZTbluzR2eAAX8ERgD5zghxTA7qox6v6d/h4/d8p5VHmz++SpopXSyHfpO+INs8eTs2\n\tI4uCmEqDjIEJ06gE+NoxMF9TbhE=","Subject":"Re: [libcamera-devel] [PATCH v2] kms: flag 'request' as\n\t'maybe_unused' to avoid 'unused-parameter' warnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Christian Rauch <Rauch.Christian@gmx.de>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]